diff mbox series

[PULL,11/32] hw/riscv/virt.c: imsics DT: add '#msi-cells'

Message ID	20240627100053.150937-12-alistair.francis@wdc.com
State	New
Headers	show Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> From: Alistair Francis <alistair23@gmail.com> To: qemu-devel@nongnu.org Cc: alistair23@gmail.com, Daniel Henrique Barboza <dbarboza@ventanamicro.com>, Conor Dooley <conor@kernel.org>, Alistair Francis <alistair.francis@wdc.com> Subject: [PULL 11/32] hw/riscv/virt.c: imsics DT: add '#msi-cells' Date: Thu, 27 Jun 2024 20:00:32 +1000 Message-ID: <20240627100053.150937-12-alistair.francis@wdc.com> In-Reply-To: <20240627100053.150937-1-alistair.francis@wdc.com> References: <20240627100053.150937-1-alistair.francis@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2001:4860:4864:20::2b; envelope-from=alistair23@gmail.com; helo=mail-oa1-x2b.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org
Series	[PULL,01/32] target/riscv: Extend virtual irq csrs masks to be 64 bit wide. \| expand [PULL,01/32] target/riscv: Extend virtual irq csrs masks to be 64 bit wide. [PULL,02/32] target/riscv: Move Guest irqs out of the core local irqs range. [PULL,03/32] target/riscv: zvbb implies zvkb [PULL,04/32] hw/riscv/virt.c: add address-cells in create_fdt_one_aplic() [PULL,05/32] hw/riscv/virt.c: add aplic nodename helper [PULL,06/32] hw/riscv/virt.c: rename aplic nodename to 'interrupt-controller' [PULL,07/32] hw/riscv/virt.c: aplic DT: add 'qemu, aplic' to 'compatible' [PULL,08/32] hw/riscv/virt.c: aplic DT: rename prop to 'riscv, delegation' [PULL,09/32] hw/riscv/virt.c: change imsic nodename to 'interrupt-controller' [PULL,10/32] hw/riscv/virt.c: imsics DT: add 'qemu, imsics' to 'compatible' [PULL,11/32] hw/riscv/virt.c: imsics DT: add '#msi-cells' [PULL,12/32] target/riscv/kvm: add software breakpoints support [PULL,13/32] target/riscv/kvm: handle the exit with debug reason [PULL,14/32] target/riscv/kvm: define TARGET_KVM_HAVE_GUEST_DEBUG [PULL,15/32] target/riscv: Reuse the conversion function of priv_spec [PULL,16/32] target/riscv: Define macros and variables for ss1p13 [PULL,17/32] target/riscv: Add 'P1P13' bit in SMSTATEEN0 [PULL,18/32] target/riscv: Add MEDELEGH, HEDELEGH csrs for RV32 [PULL,19/32] target/riscv: Reserve exception codes for sw-check and hw-err [PULL,20/32] target/riscv: Support the version for ss1p13 [PULL,21/32] hw/riscv/virt.c: Make block devices default to virtio [PULL,22/32] target/riscv: Fix froundnx.h nanbox check [PULL,23/32] target/riscv: fix instructions count handling in icount mode [PULL,24/32] target/riscv: Introduce extension implied rules definition [PULL,25/32] target/riscv: Introduce extension implied rule helpers [PULL,26/32] target/riscv: Add MISA extension implied rules [PULL,27/32] target/riscv: Add multi extension implied rules [PULL,28/32] target/riscv: Add Zc extension implied rule [PULL,29/32] target/riscv: Remove extension auto-update check statements [PULL,30/32] target/riscv: Add functions for common matching conditions of trigger [PULL,31/32] target/riscv: Apply modularized matching conditions for watchpoint [PULL,32/32] target/riscv: Apply modularized matching conditions for icount trigger

Commit Message

Alistair Francis June 27, 2024, 10 a.m. UTC

From: Daniel Henrique Barboza <dbarboza@ventanamicro.com>

The DT docs for riscv,imsics [1] requires a 'msi-cell' property. Add one
and set it zero.

[1] Documentation/devicetree/bindings/interrupt-controller/riscv,imsics.yaml

Reported-by: Conor Dooley <conor@kernel.org>
Fixes: 28d8c281200f ("hw/riscv: virt: Add optional AIA IMSIC support to virt machine")
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Message-ID: <20240531202759.911601-9-dbarboza@ventanamicro.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
 hw/riscv/virt.c | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

Patch

diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index e1ecf79551..9b648540e6 100644
--- a/hw/riscv/virt.c
+++ b/hw/riscv/virt.c
@@ -552,6 +552,7 @@  static void create_fdt_one_imsic(RISCVVirtState *s, hwaddr base_addr,
                           FDT_IMSIC_INT_CELLS);
     qemu_fdt_setprop(ms->fdt, imsic_name, "interrupt-controller", NULL, 0);
     qemu_fdt_setprop(ms->fdt, imsic_name, "msi-controller", NULL, 0);
+    qemu_fdt_setprop_cell(ms->fdt, imsic_name, "#msi-cells", 0);
     qemu_fdt_setprop(ms->fdt, imsic_name, "interrupts-extended",
                      imsic_cells, ms->smp.cpus * sizeof(uint32_t) * 2);
     qemu_fdt_setprop(ms->fdt, imsic_name, "reg", imsic_regs,