| Message ID | 20230811055438.1945-1-zhiwei_liu@linux.alibaba.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] linux-user/riscv: Use abi type for target_ucontext | expand |
On 11/8/23 07:54, LIU Zhiwei wrote: > We should not use types dependend on host arch for target_ucontext. > This bug is found when run rv32 applications. > > Signed-off-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> > --- > v2: > - Use abi_ptr instead of abi_ulong for uc_link. (Suggest by Philippe Mathieu-Daudé) > --- > linux-user/riscv/signal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Fri, Aug 11, 2023 at 1:57 AM LIU Zhiwei <zhiwei_liu@linux.alibaba.com> wrote: > > We should not use types dependend on host arch for target_ucontext. > This bug is found when run rv32 applications. > > Signed-off-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> Thanks! Applied to riscv-to-apply.next Alistair > --- > v2: > - Use abi_ptr instead of abi_ulong for uc_link. (Suggest by Philippe Mathieu-Daudé) > --- > linux-user/riscv/signal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/linux-user/riscv/signal.c b/linux-user/riscv/signal.c > index eaa168199a..f989f7f51f 100644 > --- a/linux-user/riscv/signal.c > +++ b/linux-user/riscv/signal.c > @@ -38,8 +38,8 @@ struct target_sigcontext { > }; /* cf. riscv-linux:arch/riscv/include/uapi/asm/ptrace.h */ > > struct target_ucontext { > - unsigned long uc_flags; > - struct target_ucontext *uc_link; > + abi_ulong uc_flags; > + abi_ptr uc_link; > target_stack_t uc_stack; > target_sigset_t uc_sigmask; > uint8_t __unused[1024 / 8 - sizeof(target_sigset_t)]; > -- > 2.17.1 > >
diff --git a/linux-user/riscv/signal.c b/linux-user/riscv/signal.c index eaa168199a..f989f7f51f 100644 --- a/linux-user/riscv/signal.c +++ b/linux-user/riscv/signal.c @@ -38,8 +38,8 @@ struct target_sigcontext { }; /* cf. riscv-linux:arch/riscv/include/uapi/asm/ptrace.h */ struct target_ucontext { - unsigned long uc_flags; - struct target_ucontext *uc_link; + abi_ulong uc_flags; + abi_ptr uc_link; target_stack_t uc_stack; target_sigset_t uc_sigmask; uint8_t __unused[1024 / 8 - sizeof(target_sigset_t)];