mbox series

[for-8.1,0/1] hw/riscv/virt.c: fix 'aclint' prop regression

Message ID 20230811160224.440697-1-dbarboza@ventanamicro.com
Headers show
Series hw/riscv/virt.c: fix 'aclint' prop regression | expand

Message

Daniel Henrique Barboza Aug. 11, 2023, 4:02 p.m. UTC 
Richard, Alistair,

I came across this gitlab bug earlier today. The bug itself was opened
yesterday:

https://gitlab.com/qemu-project/qemu/-/issues/1823

And turns out that this is a regression in the 'aclint' option that was
introduced in 8.1.

I'm aware that we're already in rc3 and kind of late, but even so I
marked this patch as 8.1 to let you decide whether it's worth spinning
rc4 or not.

Daniel Henrique Barboza (1):
  hw/riscv/virt.c: change 'aclint' TCG check

 hw/riscv/virt.c | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

Comments

Alistair Francis Aug. 11, 2023, 6:12 p.m. UTC | #1 
On Fri, Aug 11, 2023 at 12:03 PM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> Richard, Alistair,
>
> I came across this gitlab bug earlier today. The bug itself was opened
> yesterday:
>
> https://gitlab.com/qemu-project/qemu/-/issues/1823
>
> And turns out that this is a regression in the 'aclint' option that was
> introduced in 8.1.
>
> I'm aware that we're already in rc3 and kind of late, but even so I
> marked this patch as 8.1 to let you decide whether it's worth spinning
> rc4 or not.

Urgh! What a pain!

I'll fire off a PR now as this is worth fixing

Alistair

>
> Daniel Henrique Barboza (1):
>   hw/riscv/virt.c: change 'aclint' TCG check
>
>  hw/riscv/virt.c | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)
>
> --
> 2.41.0
>
>