| Message ID | 20231020074501.283063-1-dbarboza@ventanamicro.com |
|---|---|
| State | New |
| Headers | show |
| Series | linux-user/riscv: change default cpu to 'max' | expand |
On 20/10/23 09:45, Daniel Henrique Barboza wrote: > Commit f57d5f8004 deprecated the 'any' CPU type but failed to change the > default CPU for linux-user. The result is that all linux-users > invocations that doesn't specify a different CPU started to show a > deprecation warning: > > $ ./build/qemu-riscv64 ./foo-novect.out > qemu-riscv64: warning: The 'any' CPU is deprecated and will be removed in the future. > > Change the default CPU for RISC-V linux-user from 'any' to 'max'. > > Reported-by: Richard Henderson <richard.henderson@linaro.org> > Fixes: f57d5f8004 ("target/riscv: deprecate the 'any' CPU type") > Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> > --- > linux-user/riscv/target_elf.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On 10/20/23 00:45, Daniel Henrique Barboza wrote: > Commit f57d5f8004 deprecated the 'any' CPU type but failed to change the > default CPU for linux-user. The result is that all linux-users > invocations that doesn't specify a different CPU started to show a > deprecation warning: > > $ ./build/qemu-riscv64 ./foo-novect.out > qemu-riscv64: warning: The 'any' CPU is deprecated and will be removed in the future. > > Change the default CPU for RISC-V linux-user from 'any' to 'max'. > > Reported-by: Richard Henderson <richard.henderson@linaro.org> > Fixes: f57d5f8004 ("target/riscv: deprecate the 'any' CPU type") > Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On Fri, Oct 20, 2023 at 5:46 PM Daniel Henrique Barboza <dbarboza@ventanamicro.com> wrote: > > Commit f57d5f8004 deprecated the 'any' CPU type but failed to change the > default CPU for linux-user. The result is that all linux-users > invocations that doesn't specify a different CPU started to show a > deprecation warning: > > $ ./build/qemu-riscv64 ./foo-novect.out > qemu-riscv64: warning: The 'any' CPU is deprecated and will be removed in the future. > > Change the default CPU for RISC-V linux-user from 'any' to 'max'. > > Reported-by: Richard Henderson <richard.henderson@linaro.org> > Fixes: f57d5f8004 ("target/riscv: deprecate the 'any' CPU type") > Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > linux-user/riscv/target_elf.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/linux-user/riscv/target_elf.h b/linux-user/riscv/target_elf.h > index 9dd65652ee..dedd5956f3 100644 > --- a/linux-user/riscv/target_elf.h > +++ b/linux-user/riscv/target_elf.h > @@ -9,7 +9,6 @@ > #define RISCV_TARGET_ELF_H > static inline const char *cpu_get_model(uint32_t eflags) > { > - /* TYPE_RISCV_CPU_ANY */ > - return "any"; > + return "max"; > } > #endif > -- > 2.41.0 > >
On Fri, Oct 20, 2023 at 5:46 PM Daniel Henrique Barboza <dbarboza@ventanamicro.com> wrote: > > Commit f57d5f8004 deprecated the 'any' CPU type but failed to change the > default CPU for linux-user. The result is that all linux-users > invocations that doesn't specify a different CPU started to show a > deprecation warning: > > $ ./build/qemu-riscv64 ./foo-novect.out > qemu-riscv64: warning: The 'any' CPU is deprecated and will be removed in the future. > > Change the default CPU for RISC-V linux-user from 'any' to 'max'. > > Reported-by: Richard Henderson <richard.henderson@linaro.org> > Fixes: f57d5f8004 ("target/riscv: deprecate the 'any' CPU type") > Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> Thanks! Applied to riscv-to-apply.next Alistair > --- > linux-user/riscv/target_elf.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/linux-user/riscv/target_elf.h b/linux-user/riscv/target_elf.h > index 9dd65652ee..dedd5956f3 100644 > --- a/linux-user/riscv/target_elf.h > +++ b/linux-user/riscv/target_elf.h > @@ -9,7 +9,6 @@ > #define RISCV_TARGET_ELF_H > static inline const char *cpu_get_model(uint32_t eflags) > { > - /* TYPE_RISCV_CPU_ANY */ > - return "any"; > + return "max"; > } > #endif > -- > 2.41.0 > >
On Mon, 23 Oct 2023 at 02:15, Alistair Francis <alistair23@gmail.com> wrote: > > On Fri, Oct 20, 2023 at 5:46 PM Daniel Henrique Barboza > <dbarboza@ventanamicro.com> wrote: > > > > Commit f57d5f8004 deprecated the 'any' CPU type but failed to change the > > default CPU for linux-user. The result is that all linux-users > > invocations that doesn't specify a different CPU started to show a > > deprecation warning: > > > > $ ./build/qemu-riscv64 ./foo-novect.out > > qemu-riscv64: warning: The 'any' CPU is deprecated and will be removed in the future. > > > > Change the default CPU for RISC-V linux-user from 'any' to 'max'. > > > > Reported-by: Richard Henderson <richard.henderson@linaro.org> > > Fixes: f57d5f8004 ("target/riscv: deprecate the 'any' CPU type") > > Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> > > Thanks! > > Applied to riscv-to-apply.next Hi -- did this patch get lost along the way? It doesn't seem to be upstream yet. thanks -- PMM
On Fri, Nov 3, 2023 at 11:43 PM Peter Maydell <peter.maydell@linaro.org> wrote: > > On Mon, 23 Oct 2023 at 02:15, Alistair Francis <alistair23@gmail.com> wrote: > > > > On Fri, Oct 20, 2023 at 5:46 PM Daniel Henrique Barboza > > <dbarboza@ventanamicro.com> wrote: > > > > > > Commit f57d5f8004 deprecated the 'any' CPU type but failed to change the > > > default CPU for linux-user. The result is that all linux-users > > > invocations that doesn't specify a different CPU started to show a > > > deprecation warning: > > > > > > $ ./build/qemu-riscv64 ./foo-novect.out > > > qemu-riscv64: warning: The 'any' CPU is deprecated and will be removed in the future. > > > > > > Change the default CPU for RISC-V linux-user from 'any' to 'max'. > > > > > > Reported-by: Richard Henderson <richard.henderson@linaro.org> > > > Fixes: f57d5f8004 ("target/riscv: deprecate the 'any' CPU type") > > > Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> > > > > Thanks! > > > > Applied to riscv-to-apply.next > > Hi -- did this patch get lost along the way? It doesn't seem to > be upstream yet. It's in my tree. I expect to send a PR any day now Alistair > > thanks > -- PMM
diff --git a/linux-user/riscv/target_elf.h b/linux-user/riscv/target_elf.h index 9dd65652ee..dedd5956f3 100644 --- a/linux-user/riscv/target_elf.h +++ b/linux-user/riscv/target_elf.h @@ -9,7 +9,6 @@ #define RISCV_TARGET_ELF_H static inline const char *cpu_get_model(uint32_t eflags) { - /* TYPE_RISCV_CPU_ANY */ - return "any"; + return "max"; } #endif
Commit f57d5f8004 deprecated the 'any' CPU type but failed to change the default CPU for linux-user. The result is that all linux-users invocations that doesn't specify a different CPU started to show a deprecation warning: $ ./build/qemu-riscv64 ./foo-novect.out qemu-riscv64: warning: The 'any' CPU is deprecated and will be removed in the future. Change the default CPU for RISC-V linux-user from 'any' to 'max'. Reported-by: Richard Henderson <richard.henderson@linaro.org> Fixes: f57d5f8004 ("target/riscv: deprecate the 'any' CPU type") Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> --- linux-user/riscv/target_elf.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)