| Message ID | 20221201140811.142123-14-bmeng@tinylab.org |
|---|---|
| State | New |
| Headers | show |
| Series | [01/15] hw/riscv: Select MSI_NONBROKEN in SIFIVE_PLIC | expand |
On Thu, 2022-12-01 at 22:08 +0800, Bin Meng wrote: > "hartid-base" and "priority-base" are zero by default. There is no > need to initialize them to zero again. > > Signed-off-by: Bin Meng <bmeng@tinylab.org> > --- > > hw/riscv/opentitan.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com> > > diff --git a/hw/riscv/opentitan.c b/hw/riscv/opentitan.c > index be7ff1eea0..da73aa51f5 100644 > --- a/hw/riscv/opentitan.c > +++ b/hw/riscv/opentitan.c > @@ -165,10 +165,8 @@ static void lowrisc_ibex_soc_realize(DeviceState > *dev_soc, Error **errp) > > /* PLIC */ > qdev_prop_set_string(DEVICE(&s->plic), "hart-config", "M"); > - qdev_prop_set_uint32(DEVICE(&s->plic), "hartid-base", 0); > qdev_prop_set_uint32(DEVICE(&s->plic), "num-sources", 180); > qdev_prop_set_uint32(DEVICE(&s->plic), "num-priorities", 3); > - qdev_prop_set_uint32(DEVICE(&s->plic), "priority-base", 0x00); > qdev_prop_set_uint32(DEVICE(&s->plic), "pending-base", 0x1000); > qdev_prop_set_uint32(DEVICE(&s->plic), "enable-base", 0x2000); > qdev_prop_set_uint32(DEVICE(&s->plic), "enable-stride", 32);
On Fri, Dec 2, 2022 at 12:09 AM Bin Meng <bmeng@tinylab.org> wrote: > > "hartid-base" and "priority-base" are zero by default. There is no > need to initialize them to zero again. What is the defaults change though? I feel like these are worth leaving in Alistair > > Signed-off-by: Bin Meng <bmeng@tinylab.org> > --- > > hw/riscv/opentitan.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/riscv/opentitan.c b/hw/riscv/opentitan.c > index be7ff1eea0..da73aa51f5 100644 > --- a/hw/riscv/opentitan.c > +++ b/hw/riscv/opentitan.c > @@ -165,10 +165,8 @@ static void lowrisc_ibex_soc_realize(DeviceState *dev_soc, Error **errp) > > /* PLIC */ > qdev_prop_set_string(DEVICE(&s->plic), "hart-config", "M"); > - qdev_prop_set_uint32(DEVICE(&s->plic), "hartid-base", 0); > qdev_prop_set_uint32(DEVICE(&s->plic), "num-sources", 180); > qdev_prop_set_uint32(DEVICE(&s->plic), "num-priorities", 3); > - qdev_prop_set_uint32(DEVICE(&s->plic), "priority-base", 0x00); > qdev_prop_set_uint32(DEVICE(&s->plic), "pending-base", 0x1000); > qdev_prop_set_uint32(DEVICE(&s->plic), "enable-base", 0x2000); > qdev_prop_set_uint32(DEVICE(&s->plic), "enable-stride", 32); > -- > 2.34.1 > >
Hi Alistair, On Wed, Dec 7, 2022 at 12:38 PM Alistair Francis <alistair23@gmail.com> wrote: > > On Fri, Dec 2, 2022 at 12:09 AM Bin Meng <bmeng@tinylab.org> wrote: > > > > "hartid-base" and "priority-base" are zero by default. There is no > > need to initialize them to zero again. > > What is the defaults change though? I feel like these are worth leaving in > If the defaults change we should review all codes that use this model and do necessary change accordingly. I just see no need to re-initialize them to the default value, that's why we have a default one assigned. But I am fine to keep these codes if you think it's worth it. Regards, Bin
diff --git a/hw/riscv/opentitan.c b/hw/riscv/opentitan.c index be7ff1eea0..da73aa51f5 100644 --- a/hw/riscv/opentitan.c +++ b/hw/riscv/opentitan.c @@ -165,10 +165,8 @@ static void lowrisc_ibex_soc_realize(DeviceState *dev_soc, Error **errp) /* PLIC */ qdev_prop_set_string(DEVICE(&s->plic), "hart-config", "M"); - qdev_prop_set_uint32(DEVICE(&s->plic), "hartid-base", 0); qdev_prop_set_uint32(DEVICE(&s->plic), "num-sources", 180); qdev_prop_set_uint32(DEVICE(&s->plic), "num-priorities", 3); - qdev_prop_set_uint32(DEVICE(&s->plic), "priority-base", 0x00); qdev_prop_set_uint32(DEVICE(&s->plic), "pending-base", 0x1000); qdev_prop_set_uint32(DEVICE(&s->plic), "enable-base", 0x2000); qdev_prop_set_uint32(DEVICE(&s->plic), "enable-stride", 32);
"hartid-base" and "priority-base" are zero by default. There is no need to initialize them to zero again. Signed-off-by: Bin Meng <bmeng@tinylab.org> --- hw/riscv/opentitan.c | 2 -- 1 file changed, 2 deletions(-)