| Message ID | 20240330133452.2473222-1-pan2.li@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | RISC-V: Fix one unused varable in riscv_subset_list::parse | expand |
LGTM On Sat, Mar 30, 2024 at 9:35 PM <pan2.li@intel.com> wrote: > > From: Pan Li <pan2.li@intel.com> > > This patch would like to fix one unused variable as below: > > ../../gcc/common/config/riscv/riscv-common.cc: In static member function > 'static riscv_subset_list* riscv_subset_list::parse(const char*, location_t)': > ../../gcc/common/config/riscv/riscv-common.cc:1501:19: error: unused variable 'itr' > [-Werror=unused-variable] > 1501 | riscv_subset_t *itr; > > The variable consume code was removed but missed the var itself in > previous. Thus, we have unused variable here. > > gcc/ChangeLog: > > * common/config/riscv/riscv-common.cc (riscv_subset_list::parse): > Remove unused var decl. > > Signed-off-by: Pan Li <pan2.li@intel.com> > --- > gcc/common/config/riscv/riscv-common.cc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/riscv/riscv-common.cc > index 7095f303cbb..43b7549e3ec 100644 > --- a/gcc/common/config/riscv/riscv-common.cc > +++ b/gcc/common/config/riscv/riscv-common.cc > @@ -1498,7 +1498,6 @@ riscv_subset_list::parse (const char *arch, location_t loc) > return NULL; > > riscv_subset_list *subset_list = new riscv_subset_list (arch, loc); > - riscv_subset_t *itr; > const char *p = arch; > p = subset_list->parse_base_ext (p); > if (p == NULL) > -- > 2.34.1 >
Committed, thanks Kito. Pan -----Original Message----- From: Kito Cheng <kito.cheng@gmail.com> Sent: Sunday, March 31, 2024 8:54 AM To: Li, Pan2 <pan2.li@intel.com> Cc: gcc-patches@gcc.gnu.org; juzhe.zhong@rivai.ai; Wang, Yanzhang <yanzhang.wang@intel.com> Subject: Re: [PATCH] RISC-V: Fix one unused varable in riscv_subset_list::parse LGTM On Sat, Mar 30, 2024 at 9:35 PM <pan2.li@intel.com> wrote: > > From: Pan Li <pan2.li@intel.com> > > This patch would like to fix one unused variable as below: > > ../../gcc/common/config/riscv/riscv-common.cc: In static member function > 'static riscv_subset_list* riscv_subset_list::parse(const char*, location_t)': > ../../gcc/common/config/riscv/riscv-common.cc:1501:19: error: unused variable 'itr' > [-Werror=unused-variable] > 1501 | riscv_subset_t *itr; > > The variable consume code was removed but missed the var itself in > previous. Thus, we have unused variable here. > > gcc/ChangeLog: > > * common/config/riscv/riscv-common.cc (riscv_subset_list::parse): > Remove unused var decl. > > Signed-off-by: Pan Li <pan2.li@intel.com> > --- > gcc/common/config/riscv/riscv-common.cc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/riscv/riscv-common.cc > index 7095f303cbb..43b7549e3ec 100644 > --- a/gcc/common/config/riscv/riscv-common.cc > +++ b/gcc/common/config/riscv/riscv-common.cc > @@ -1498,7 +1498,6 @@ riscv_subset_list::parse (const char *arch, location_t loc) > return NULL; > > riscv_subset_list *subset_list = new riscv_subset_list (arch, loc); > - riscv_subset_t *itr; > const char *p = arch; > p = subset_list->parse_base_ext (p); > if (p == NULL) > -- > 2.34.1 >
diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/riscv/riscv-common.cc index 7095f303cbb..43b7549e3ec 100644 --- a/gcc/common/config/riscv/riscv-common.cc +++ b/gcc/common/config/riscv/riscv-common.cc @@ -1498,7 +1498,6 @@ riscv_subset_list::parse (const char *arch, location_t loc) return NULL; riscv_subset_list *subset_list = new riscv_subset_list (arch, loc); - riscv_subset_t *itr; const char *p = arch; p = subset_list->parse_base_ext (p); if (p == NULL)