| Message ID | 20230923010645.325310-1-pan2.li@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] RISC-V: Remove FP run test for ceil. | expand |
Ok juzhe.zhong@rivai.ai From: pan2.li Date: 2023-09-23 09:06 To: gcc-patches CC: juzhe.zhong; pan2.li; yanzhang.wang; kito.cheng Subject: [PATCH v1] RISC-V: Remove FP run test for ceil. From: Pan Li <pan2.li@intel.com> FP16 is not well reconciled when linking. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c: Remove. Signed-off-by: Pan Li <pan2.li@intel.com> --- .../riscv/rvv/autovec/unop/math-ceil-run-0.c | 39 ------------------- 1 file changed, 39 deletions(-) delete mode 100644 gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c b/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c deleted file mode 100644 index 600c161159d..00000000000 --- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c +++ /dev/null @@ -1,39 +0,0 @@ -/* { dg-do run { target { riscv_vector } } } */ -/* { dg-additional-options "-std=c2x -O3 -ftree-vectorize -fno-vect-cost-model -ffast-math" } */ - -#include "test-math.h" - -#define ARRAY_SIZE 128 - -_Float16 in[ARRAY_SIZE]; -_Float16 out[ARRAY_SIZE]; -_Float16 ref[ARRAY_SIZE]; - -TEST_UNARY_CALL (_Float16, __builtin_ceilf16) -TEST_ASSERT (_Float16) - -TEST_INIT (_Float16, 1.2, 2.0, 1) -TEST_INIT (_Float16, -1.2, -1.0, 2) -TEST_INIT (_Float16, 3.0, 3.0, 3) -TEST_INIT (_Float16, 1023.5, 1024.0, 4) -TEST_INIT (_Float16, 1025.0, 1025.0, 5) -TEST_INIT (_Float16, 0.0, 0.0, 6) -TEST_INIT (_Float16, -0.0, -0.0, 7) -TEST_INIT (_Float16, -1023.5, -1023.0, 8) -TEST_INIT (_Float16, -1024.0, -1024.0, 9) - -int -main () -{ - RUN_TEST (_Float16, 1, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - RUN_TEST (_Float16, 2, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - RUN_TEST (_Float16, 3, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - RUN_TEST (_Float16, 4, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - RUN_TEST (_Float16, 5, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - RUN_TEST (_Float16, 6, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - RUN_TEST (_Float16, 7, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - RUN_TEST (_Float16, 8, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - RUN_TEST (_Float16, 9, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - - return 0; -}
Committed, thanks Juzhe.
Pan
From: 钟居哲 <juzhe.zhong@rivai.ai>
Sent: Saturday, September 23, 2023 9:07 AM
To: Li, Pan2 <pan2.li@intel.com>; gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Li, Pan2 <pan2.li@intel.com>; Wang, Yanzhang <yanzhang.wang@intel.com>; kito.cheng <kito.cheng@gmail.com>
Subject: Re: [PATCH v1] RISC-V: Remove FP run test for ceil.
Ok
I guess it just needs more checks than `target { riscv_vector }`,
maybe something like `target { riscv_vector_zvfh }`, but anyway I am
fine to drop this for now.
On Sat, Sep 23, 2023 at 2:11 AM Li, Pan2 <pan2.li@intel.com> wrote:
>
> Committed, thanks Juzhe.
>
>
>
> Pan
>
>
>
> From: 钟居哲 <juzhe.zhong@rivai.ai>
> Sent: Saturday, September 23, 2023 9:07 AM
> To: Li, Pan2 <pan2.li@intel.com>; gcc-patches <gcc-patches@gcc.gnu.org>
> Cc: Li, Pan2 <pan2.li@intel.com>; Wang, Yanzhang <yanzhang.wang@intel.com>; kito.cheng <kito.cheng@gmail.com>
> Subject: Re: [PATCH v1] RISC-V: Remove FP run test for ceil.
>
>
>
> Ok
>
>
>
> ________________________________
>
> juzhe.zhong@rivai.ai
>
>
>
> From: pan2.li
>
> Date: 2023-09-23 09:06
>
> To: gcc-patches
>
> CC: juzhe.zhong; pan2.li; yanzhang.wang; kito.cheng
>
> Subject: [PATCH v1] RISC-V: Remove FP run test for ceil.
>
> From: Pan Li <pan2.li@intel.com>
>
>
>
> FP16 is not well reconciled when linking.
>
>
>
> gcc/testsuite/ChangeLog:
>
>
>
> * gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c: Remove.
>
>
>
> Signed-off-by: Pan Li <pan2.li@intel.com>
>
> ---
>
> .../riscv/rvv/autovec/unop/math-ceil-run-0.c | 39 -------------------
>
> 1 file changed, 39 deletions(-)
>
> delete mode 100644 gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c
>
>
>
> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c b/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c
>
> deleted file mode 100644
>
> index 600c161159d..00000000000
>
> --- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c
>
> +++ /dev/null
>
> @@ -1,39 +0,0 @@
>
> -/* { dg-do run { target { riscv_vector } } } */
>
> -/* { dg-additional-options "-std=c2x -O3 -ftree-vectorize -fno-vect-cost-model -ffast-math" } */
>
> -
>
> -#include "test-math.h"
>
> -
>
> -#define ARRAY_SIZE 128
>
> -
>
> -_Float16 in[ARRAY_SIZE];
>
> -_Float16 out[ARRAY_SIZE];
>
> -_Float16 ref[ARRAY_SIZE];
>
> -
>
> -TEST_UNARY_CALL (_Float16, __builtin_ceilf16)
>
> -TEST_ASSERT (_Float16)
>
> -
>
> -TEST_INIT (_Float16, 1.2, 2.0, 1)
>
> -TEST_INIT (_Float16, -1.2, -1.0, 2)
>
> -TEST_INIT (_Float16, 3.0, 3.0, 3)
>
> -TEST_INIT (_Float16, 1023.5, 1024.0, 4)
>
> -TEST_INIT (_Float16, 1025.0, 1025.0, 5)
>
> -TEST_INIT (_Float16, 0.0, 0.0, 6)
>
> -TEST_INIT (_Float16, -0.0, -0.0, 7)
>
> -TEST_INIT (_Float16, -1023.5, -1023.0, 8)
>
> -TEST_INIT (_Float16, -1024.0, -1024.0, 9)
>
> -
>
> -int
>
> -main ()
>
> -{
>
> - RUN_TEST (_Float16, 1, __builtin_ceilf16, in, out, ref, ARRAY_SIZE);
>
> - RUN_TEST (_Float16, 2, __builtin_ceilf16, in, out, ref, ARRAY_SIZE);
>
> - RUN_TEST (_Float16, 3, __builtin_ceilf16, in, out, ref, ARRAY_SIZE);
>
> - RUN_TEST (_Float16, 4, __builtin_ceilf16, in, out, ref, ARRAY_SIZE);
>
> - RUN_TEST (_Float16, 5, __builtin_ceilf16, in, out, ref, ARRAY_SIZE);
>
> - RUN_TEST (_Float16, 6, __builtin_ceilf16, in, out, ref, ARRAY_SIZE);
>
> - RUN_TEST (_Float16, 7, __builtin_ceilf16, in, out, ref, ARRAY_SIZE);
>
> - RUN_TEST (_Float16, 8, __builtin_ceilf16, in, out, ref, ARRAY_SIZE);
>
> - RUN_TEST (_Float16, 9, __builtin_ceilf16, in, out, ref, ARRAY_SIZE);
>
> -
>
> - return 0;
>
> -}
>
> --
>
> 2.34.1
>
>
>
>
Sure, will re-visit this part later. Pan -----Original Message----- From: Kito Cheng <kito.cheng@gmail.com> Sent: Saturday, September 23, 2023 3:47 PM To: Li, Pan2 <pan2.li@intel.com> Cc: 钟居哲 <juzhe.zhong@rivai.ai>; gcc-patches <gcc-patches@gcc.gnu.org>; Wang, Yanzhang <yanzhang.wang@intel.com> Subject: Re: [PATCH v1] RISC-V: Remove FP run test for ceil. I guess it just needs more checks than `target { riscv_vector }`, maybe something like `target { riscv_vector_zvfh }`, but anyway I am fine to drop this for now. On Sat, Sep 23, 2023 at 2:11 AM Li, Pan2 <pan2.li@intel.com> wrote: > > Committed, thanks Juzhe. > > > > Pan > > > > From: 钟居哲 <juzhe.zhong@rivai.ai> > Sent: Saturday, September 23, 2023 9:07 AM > To: Li, Pan2 <pan2.li@intel.com>; gcc-patches <gcc-patches@gcc.gnu.org> > Cc: Li, Pan2 <pan2.li@intel.com>; Wang, Yanzhang <yanzhang.wang@intel.com>; kito.cheng <kito.cheng@gmail.com> > Subject: Re: [PATCH v1] RISC-V: Remove FP run test for ceil. > > > > Ok > > > > ________________________________ > > juzhe.zhong@rivai.ai > > > > From: pan2.li > > Date: 2023-09-23 09:06 > > To: gcc-patches > > CC: juzhe.zhong; pan2.li; yanzhang.wang; kito.cheng > > Subject: [PATCH v1] RISC-V: Remove FP run test for ceil. > > From: Pan Li <pan2.li@intel.com> > > > > FP16 is not well reconciled when linking. > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c: Remove. > > > > Signed-off-by: Pan Li <pan2.li@intel.com> > > --- > > .../riscv/rvv/autovec/unop/math-ceil-run-0.c | 39 ------------------- > > 1 file changed, 39 deletions(-) > > delete mode 100644 gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c > > > > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c b/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c > > deleted file mode 100644 > > index 600c161159d..00000000000 > > --- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c > > +++ /dev/null > > @@ -1,39 +0,0 @@ > > -/* { dg-do run { target { riscv_vector } } } */ > > -/* { dg-additional-options "-std=c2x -O3 -ftree-vectorize -fno-vect-cost-model -ffast-math" } */ > > - > > -#include "test-math.h" > > - > > -#define ARRAY_SIZE 128 > > - > > -_Float16 in[ARRAY_SIZE]; > > -_Float16 out[ARRAY_SIZE]; > > -_Float16 ref[ARRAY_SIZE]; > > - > > -TEST_UNARY_CALL (_Float16, __builtin_ceilf16) > > -TEST_ASSERT (_Float16) > > - > > -TEST_INIT (_Float16, 1.2, 2.0, 1) > > -TEST_INIT (_Float16, -1.2, -1.0, 2) > > -TEST_INIT (_Float16, 3.0, 3.0, 3) > > -TEST_INIT (_Float16, 1023.5, 1024.0, 4) > > -TEST_INIT (_Float16, 1025.0, 1025.0, 5) > > -TEST_INIT (_Float16, 0.0, 0.0, 6) > > -TEST_INIT (_Float16, -0.0, -0.0, 7) > > -TEST_INIT (_Float16, -1023.5, -1023.0, 8) > > -TEST_INIT (_Float16, -1024.0, -1024.0, 9) > > - > > -int > > -main () > > -{ > > - RUN_TEST (_Float16, 1, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); > > - RUN_TEST (_Float16, 2, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); > > - RUN_TEST (_Float16, 3, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); > > - RUN_TEST (_Float16, 4, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); > > - RUN_TEST (_Float16, 5, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); > > - RUN_TEST (_Float16, 6, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); > > - RUN_TEST (_Float16, 7, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); > > - RUN_TEST (_Float16, 8, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); > > - RUN_TEST (_Float16, 9, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); > > - > > - return 0; > > -} > > -- > > 2.34.1 > > > >
diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c b/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c deleted file mode 100644 index 600c161159d..00000000000 --- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/math-ceil-run-0.c +++ /dev/null @@ -1,39 +0,0 @@ -/* { dg-do run { target { riscv_vector } } } */ -/* { dg-additional-options "-std=c2x -O3 -ftree-vectorize -fno-vect-cost-model -ffast-math" } */ - -#include "test-math.h" - -#define ARRAY_SIZE 128 - -_Float16 in[ARRAY_SIZE]; -_Float16 out[ARRAY_SIZE]; -_Float16 ref[ARRAY_SIZE]; - -TEST_UNARY_CALL (_Float16, __builtin_ceilf16) -TEST_ASSERT (_Float16) - -TEST_INIT (_Float16, 1.2, 2.0, 1) -TEST_INIT (_Float16, -1.2, -1.0, 2) -TEST_INIT (_Float16, 3.0, 3.0, 3) -TEST_INIT (_Float16, 1023.5, 1024.0, 4) -TEST_INIT (_Float16, 1025.0, 1025.0, 5) -TEST_INIT (_Float16, 0.0, 0.0, 6) -TEST_INIT (_Float16, -0.0, -0.0, 7) -TEST_INIT (_Float16, -1023.5, -1023.0, 8) -TEST_INIT (_Float16, -1024.0, -1024.0, 9) - -int -main () -{ - RUN_TEST (_Float16, 1, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - RUN_TEST (_Float16, 2, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - RUN_TEST (_Float16, 3, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - RUN_TEST (_Float16, 4, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - RUN_TEST (_Float16, 5, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - RUN_TEST (_Float16, 6, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - RUN_TEST (_Float16, 7, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - RUN_TEST (_Float16, 8, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - RUN_TEST (_Float16, 9, __builtin_ceilf16, in, out, ref, ARRAY_SIZE); - - return 0; -}