| Message ID | 20230906175025.935887-6-ewlu@rivosinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | RISC-V: Add Types to Untyped Instructions | expand |
On 9/6/23 11:50, Edwin Lu wrote: > This patch turns on the assert which ensures every instruction has type > that is not TYPE_UNKNOWN. > > gcc/ChangeLog: > > * config/riscv/riscv.cc (riscv_sched_variable_issue): Remove assert And this is fine. But hold off committing until all the dependencies are also committed. I think there's still one earlier patch that I wanted to look at again. jeff
On 9/7/2023 6:19 AM, Jeff Law wrote: > > > On 9/6/23 11:50, Edwin Lu wrote: >> This patch turns on the assert which ensures every instruction has type >> that is not TYPE_UNKNOWN. >> >> gcc/ChangeLog: >> >> * config/riscv/riscv.cc (riscv_sched_variable_issue): Remove assert > And this is fine. But hold off committing until all the dependencies > are also committed. I think there's still one earlier patch that I > wanted to look at again. > > jeff Sounds good to me. The thead instructions were the ones that haven't been checked in yet. Edwin
diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index ef63079de8e..f0576351cda 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -7330,11 +7330,9 @@ riscv_sched_variable_issue (FILE *, int, rtx_insn *insn, int more) if (get_attr_type (insn) == TYPE_GHOST) return 0; -#if 0 /* If we ever encounter an insn with an unknown type, trip an assert so we can find and fix this problem. */ gcc_assert (get_attr_type (insn) != TYPE_UNKNOWN); -#endif return more - 1; }
This patch turns on the assert which ensures every instruction has type that is not TYPE_UNKNOWN. gcc/ChangeLog: * config/riscv/riscv.cc (riscv_sched_variable_issue): Remove assert Signed-off-by: Edwin Lu <ewlu@rivosinc.com> --- gcc/config/riscv/riscv.cc | 2 -- 1 file changed, 2 deletions(-)