| Message ID | 20230420165523.281157-1-vineetg@rivosinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | MAINTAINERS: add Vineet Gupta to write after approval | expand |
On Thu, 20 Apr 2023 09:55:23 PDT (-0700), Vineet Gupta wrote: > ChangeLog: > > * MAINTAINERS (Write After Approval): Add myself. > > (Ref: <680c7bbe-5d6e-07cd-8468-247afc65e1dd@gmail.com>) > > Signed-off-by: Vineet Gupta <vineetg@rivosinc.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index cebf45d49e56..5f25617212a5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -434,6 +434,7 @@ Haochen Gui <guihaoc@gcc.gnu.org> > Jiufu Guo <guojiufu@linux.ibm.com> > Xuepeng Guo <terry.xpguo@gmail.com> > Wei Guozhi <carrot@google.com> > +Vineet Gupta <vineetg@rivosinc.com> > Naveen H.S <naveenh@marvell.com> > Mostafa Hagog <hagog@gcc.gnu.org> > Andrew Haley <aph@redhat.com> Acked-by: Palmer Dabbelt <palmer@rivosinc.com> Though not sure if I can do that, maybe we need a global reviewer?
Palmer Dabbelt <palmer@rivosinc.com> writes: > On Thu, 20 Apr 2023 09:55:23 PDT (-0700), Vineet Gupta wrote: >> ChangeLog: >> >> * MAINTAINERS (Write After Approval): Add myself. >> >> (Ref: <680c7bbe-5d6e-07cd-8468-247afc65e1dd@gmail.com>) >> >> Signed-off-by: Vineet Gupta <vineetg@rivosinc.com> >> --- >> MAINTAINERS | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index cebf45d49e56..5f25617212a5 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -434,6 +434,7 @@ Haochen Gui <guihaoc@gcc.gnu.org> >> Jiufu Guo <guojiufu@linux.ibm.com> >> Xuepeng Guo <terry.xpguo@gmail.com> >> Wei Guozhi <carrot@google.com> >> +Vineet Gupta <vineetg@rivosinc.com> >> Naveen H.S <naveenh@marvell.com> >> Mostafa Hagog <hagog@gcc.gnu.org> >> Andrew Haley <aph@redhat.com> > > Acked-by: Palmer Dabbelt <palmer@rivosinc.com> > > Though not sure if I can do that, maybe we need a global reviewer? No approval is needed when adding oneself to write-after-approval. The fact that one's able to make the change is proof enough. Richard
On 4/21/23 02:30, Richard Sandiford wrote: > No approval is needed when adding oneself to write-after-approval. > The fact that one's able to make the change is proof enough. Thx Richard. Noob question: I tried to commit/push but failed. | $ git remote show upstream | * remote upstream | Fetch URL: git://gcc.gnu.org/git/gcc.git | | $ git push upstream upstream-exp:master | fatal: remote error: service not enabled: /git/gcc.git Reading thru [1] it seems commit on trunk is only possible via git svn. Is that true ? Thx, -Vineet [1] https://gcc.gnu.org/wiki/GitMirror
You need use git+ssh protocol, I use this way to manage that: git remote add upstream-write git+ssh://<username>@gcc.gnu.org/git/gcc.git git push upstream-write master On Sat, Apr 22, 2023 at 12:00 AM Vineet Gupta <vineetg@rivosinc.com> wrote: > > > On 4/21/23 02:30, Richard Sandiford wrote: > > No approval is needed when adding oneself to write-after-approval. > > The fact that one's able to make the change is proof enough. > > Thx Richard. > > Noob question: I tried to commit/push but failed. > > | $ git remote show upstream > | * remote upstream > | Fetch URL: git://gcc.gnu.org/git/gcc.git > | > | $ git push upstream upstream-exp:master > | fatal: remote error: service not enabled: /git/gcc.git > > Reading thru [1] it seems commit on trunk is only possible via git svn. > Is that true ? > > Thx, > -Vineet > > [1] https://gcc.gnu.org/wiki/GitMirror
On 4/21/23 09:03, Kito Cheng wrote: > You need use git+ssh protocol, I use this way to manage that: > > git remote add upstream-write git+ssh://<username>@gcc.gnu.org/git/gcc.git > git push upstream-write master Thx Kito. That worked. I'll try to update the wiki. -Vineet > On Sat, Apr 22, 2023 at 12:00 AM Vineet Gupta <vineetg@rivosinc.com> wrote: >> >> On 4/21/23 02:30, Richard Sandiford wrote: >>> No approval is needed when adding oneself to write-after-approval. >>> The fact that one's able to make the change is proof enough. >> Thx Richard. >> >> Noob question: I tried to commit/push but failed. >> >> | $ git remote show upstream >> | * remote upstream >> | Fetch URL: git://gcc.gnu.org/git/gcc.git >> | >> | $ git push upstream upstream-exp:master >> | fatal: remote error: service not enabled: /git/gcc.git >> >> Reading thru [1] it seems commit on trunk is only possible via git svn. >> Is that true ? >> >> Thx, >> -Vineet >> >> [1] https://gcc.gnu.org/wiki/GitMirror
diff --git a/MAINTAINERS b/MAINTAINERS index cebf45d49e56..5f25617212a5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -434,6 +434,7 @@ Haochen Gui <guihaoc@gcc.gnu.org> Jiufu Guo <guojiufu@linux.ibm.com> Xuepeng Guo <terry.xpguo@gmail.com> Wei Guozhi <carrot@google.com> +Vineet Gupta <vineetg@rivosinc.com> Naveen H.S <naveenh@marvell.com> Mostafa Hagog <hagog@gcc.gnu.org> Andrew Haley <aph@redhat.com>
ChangeLog: * MAINTAINERS (Write After Approval): Add myself. (Ref: <680c7bbe-5d6e-07cd-8468-247afc65e1dd@gmail.com>) Signed-off-by: Vineet Gupta <vineetg@rivosinc.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)