From patchwork Tue Dec 18 14:28:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1015408 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43K1RK193hz9s3q for ; Wed, 19 Dec 2018 02:00:29 +1100 (AEDT) Received: from localhost ([::1]:54193 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZGrC-0002eH-Fa for incoming@patchwork.ozlabs.org; Tue, 18 Dec 2018 10:00:26 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZGNE-0000ud-JE for qemu-devel@nongnu.org; Tue, 18 Dec 2018 09:29:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZGNA-0000zm-U0 for qemu-devel@nongnu.org; Tue, 18 Dec 2018 09:29:28 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:40763) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZGN2-0000th-V8; Tue, 18 Dec 2018 09:29:17 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N9MlI-1hVoUx3v0e-015Gt3; Tue, 18 Dec 2018 15:29:00 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Tue, 18 Dec 2018 15:28:48 +0100 Message-Id: <20181218142851.9477-2-laurent@vivier.eu> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181218142851.9477-1-laurent@vivier.eu> References: <20181218142851.9477-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:zyTwx9I95ECyY3vLXCCHFRjIPjvJ6M4+GhOr9BUJjsY4Xr/N5yr GnFUdS3DsHfuvjwTWtF768Wj5QT5CEKqxJkjdRWsqCHfb0k1ou/h8cho+E9y+DbIeXPo4k0 LxOj5YyCimwfMux8Ywus6rrp9x/okXkeifc25jAIFcp7Uu3eWAic5NdjJiqDBWVSOLxWNPj vdTDfqODlE63hiBB7g/QA== X-UI-Out-Filterresults: notjunk:1; V03:K0:VZB82eZAQ0A=:BfQ1Rx/QMXxIXFzpkoq74e qP7gtPTGQbH9aKCgL2hdsg03ExKaqRyep2PXK0EE7RvZfPh/QEvEUoz1zld6ba83O8RFZCFQS ieQCuugtJzN+tGu/hFfE430TozSsk6Pa0pAFvOe2ybST6qQwt+1sbNbaA/M8RqllCChOam1wo lvSw/kV9vt6OQevBtjFzQVJFlWxILwHmRJMigqGkNALXg8JYGljoUxqtV1+8wVxqSBCi8WlLF R0OdhuA/+sfEY9TEN5sB3VzoyQgsp+EVTF/DIqbCGebCVvEyY/J9HPPaJnSQFUUSKD1KLsqYS bSpDi+usZT1DmhA6G1RY/evQwTgEcEuDg7rDiBhaxEwvaiYhZhd6HRCDEVb76xE09akPKqMF9 2mrzShArl9eJ1Fb1/klYHnkX/SUgIfuTfxNSwcAluTOI2zUpcCUe8HGi8kNKfoPF0BmGToEXz rDXOZZs859nMbe47F0zmgqdPmuwPdtexY2J6voy258VAKiKRi6N2WHDAOD4TijDTokTfSxieC EbPdmJW0yDGdQLZDh5m0wQ6GptOh2LTAEoXbFbrK3IPF203Uu1jHkWqACWJ/ey1ZAEYtVRNJr zJO7MbE/xiEVQ/okCIiIigtj+Vc/ENlWjLmc5xFL/Yh/On0ffZD0pCgaTzTBA4ClaVF+GV7jn ZGZEgL5bj0gO+C1JKbW/H5jjyqf0OlSyVUamQXjTgKzjkNddcWtS5CjqVQ7Njgt/r9SRQr2rc cI7kzCD4Cwk6OnbXNB19vifw5O9yEjovT5E8iZs5j27i/9P2Y3gag2J9SXU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.133 Subject: [Qemu-devel] [PULL 1/4] docs/devel/build-system: fix 'softmu' typo X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Collin Walling , Eduardo Habkost , qemu-block@nongnu.org, David Hildenbrand , qemu-trivial@nongnu.org, Markus Armbruster , Cornelia Huck , Michael Tokarev , Laurent Vivier , Michael Roth , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, "Emilio G. Cota" , Paolo Bonzini , Max Reitz , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181128153423.11916-1-cota@braap.org> Signed-off-by: Laurent Vivier --- docs/devel/build-system.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/build-system.txt b/docs/devel/build-system.txt index 52501f2ad9..f9fd27fab0 100644 --- a/docs/devel/build-system.txt +++ b/docs/devel/build-system.txt @@ -393,7 +393,7 @@ all use $(obj) as a prefix to the target, e.g. This file provides the entry point used to build each individual system or userspace emulator target. Each enabled target has its own subdirectory. For example if configure is run with the argument -'--target-list=x86_64-softmmu', then a sub-directory 'x86_64-softmu' +'--target-list=x86_64-softmmu', then a sub-directory 'x86_64-softmmu' will be created, containing a 'Makefile' which symlinks back to Makefile.target From patchwork Tue Dec 18 14:28:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1015404 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43K1KP11YNz9s3Z for ; Wed, 19 Dec 2018 01:55:21 +1100 (AEDT) Received: from localhost ([::1]:54149 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZGmD-00067t-Uo for incoming@patchwork.ozlabs.org; Tue, 18 Dec 2018 09:55:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZGNE-0000uc-Ht for qemu-devel@nongnu.org; Tue, 18 Dec 2018 09:29:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZGN8-0000yF-28 for qemu-devel@nongnu.org; Tue, 18 Dec 2018 09:29:26 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:54937) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZGMz-0000sB-K4; Tue, 18 Dec 2018 09:29:13 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MJm8H-1goSvs1WeX-00K6Hg; Tue, 18 Dec 2018 15:29:01 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Tue, 18 Dec 2018 15:28:49 +0100 Message-Id: <20181218142851.9477-3-laurent@vivier.eu> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181218142851.9477-1-laurent@vivier.eu> References: <20181218142851.9477-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:UY57jcpLeXyZhLzCOjp8UlR5puYrJhbzXT6lmqfhxXg5RnslyHc Fr6jLa8PH3g4+4NOiI6W8rkVExMKbJ3E1vL8zGlMMUVGqHKPqmReyXod3KRjZgxWsll2FBA CP+6A9ctJkslEpTbgbiPqbDgNcwUSub6I+1NlPe8nKE8HEN8ZkmUEaIQ/EgQhLi4sCt7H5/ CxtWj0wmiUNSbcbEDleaQ== X-UI-Out-Filterresults: notjunk:1; V03:K0:lqqYrYZAU74=:RdmYonMLtWwZSaw6llySDE i/7Cap2ogaw98h8X5iADrgDW2zPGWCT8DHPx9uEzxnkDyuVpL7abXYCtmHnlFVNP6l7mxryju BKYt7HRnO8QYtAOJxMiV0pKDhYHpO9dQfRTnQT+pz7pDPGThPUziBs4AiO3dWlaiaw7ispfb5 iCOISv0Uash8XTNCf3WpPTvgh+Bj6/2WsbLZd6w6Tjr/mhOonoGU13K4o7U2lfWWKK93y90eS apEsMaPBAetTdX1mR1kvxcyVbLi8KGHrtxu90uJ2UevNHfZP4PRuZ10Ytu51dwgmlR4GCpeFk 01Npf8p0eMtRXN8copCuy/xifQb9txr1s1Al0LxjisTUTLD493F3uSmpvGHhG0imh86GJcUof zY/UWL+Ra1JKD9yBMzMwYfuoGRi6gejNHJ8fnSppxYOlTY4Mq1oLt3x5gIhhc5CSTfjMKWWTV j3IRIwCGpS6iu2IJ04VWHqPe7Sf2y/gM3TVoY+uKkfpd9ncHStIf4Vl29vXegtQLVQCkqO3h8 zRMzt3VgRLrC8EM9S0rDzaFDaGH53+bdReCyiFg1C6Pex8Cy8WAWtB8lY+aXVXZ2pNGlMmT3M Gp1/956qq1eyvBF6qI/32aO5X5dynGj0ZJLTM0FX8kBZIxoJAF2KpFDIT0vxEtDS3nu1tLca7 t68mCYZjYkvL4uC0AwQQvhKHD38qdpbcPS8hjKH/v2/Xds72ZpvbEJytmb2DqGSIZSWNdxEPC DQgJATf4V9iNv5dLsBWup2nokp/TEu/pe922Tg== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.130 Subject: [Qemu-devel] [PULL 2/4] i386: hvf: drop debug printf in decode_sldtgroup X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Collin Walling , Eduardo Habkost , qemu-block@nongnu.org, David Hildenbrand , qemu-trivial@nongnu.org, Markus Armbruster , Cornelia Huck , Michael Tokarev , Laurent Vivier , Michael Roth , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Roman Bolshakov , Paolo Bonzini , Max Reitz , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Roman Bolshakov It's going to clutter QEMU logs if 0x0f00 is trapped. Signed-off-by: Roman Bolshakov Message-Id: <20181203100415.53027-2-r.bolshakov@yadro.com> Signed-off-by: Laurent Vivier --- target/i386/hvf/x86_decode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/i386/hvf/x86_decode.c b/target/i386/hvf/x86_decode.c index d125a6ef83..5f513c5563 100644 --- a/target/i386/hvf/x86_decode.c +++ b/target/i386/hvf/x86_decode.c @@ -525,8 +525,6 @@ static void decode_sldtgroup(CPUX86State *env, struct x86_decode *decode) X86_DECODE_CMD_INVL }; decode->cmd = group[decode->modrm.reg]; - printf("%llx: decode_sldtgroup: %d\n", env->hvf_emul->fetch_rip, - decode->modrm.reg); } static void decode_lidtgroup(CPUX86State *env, struct x86_decode *decode) From patchwork Tue Dec 18 14:28:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1015390 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43K0wj33BGz9sCr for ; Wed, 19 Dec 2018 01:37:25 +1100 (AEDT) Received: from localhost ([::1]:54016 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZGUs-0006cg-Fh for incoming@patchwork.ozlabs.org; Tue, 18 Dec 2018 09:37:22 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZGNJ-0000yv-Bj for qemu-devel@nongnu.org; Tue, 18 Dec 2018 09:29:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZGNE-00011e-J6 for qemu-devel@nongnu.org; Tue, 18 Dec 2018 09:29:33 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:46383) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZGMy-0000r8-6D; Tue, 18 Dec 2018 09:29:12 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N7Qp3-1hTLed30nt-017kvM; Tue, 18 Dec 2018 15:29:02 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Tue, 18 Dec 2018 15:28:50 +0100 Message-Id: <20181218142851.9477-4-laurent@vivier.eu> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181218142851.9477-1-laurent@vivier.eu> References: <20181218142851.9477-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:XcvVyTRNcuVoO7w926JgzxmXRp1FGKKZbPZfW3sMI8lTgZO0CMc gNaPQ5v3qC2fuF7iN1mzsAWCLaU8Hq0CKvko2PFy2IwlD86Ue3E6tRhEl5YuQ26VVWb8qbU QuoyaWVxXZj6cmoHVOga67LrLS900ycHGBaKq089dUJT3ISzLyggovUTECaYeFoCGYNVlyC glbsReoORZ/JDkwhb3MAg== X-UI-Out-Filterresults: notjunk:1; V03:K0:dPeCUy9F6kg=:IRNDK1QmnzHVY1nVXSaj8d bYoDo0GicW6OIW2PYzZg2LgE4obR4a7ZDzBn02LuQiLQ5nhpvPyaiFPz0z4JM0+1ojNsoTqXD 33EEI+KMi3QiZUcZLZ0N3ND5zIhAsmx3p0lo4vfHAwjv2a/wmDDACT0rRTk0gXCqdTPvZLO50 5/PXTfskpSpkQLdQ3Ckw9rAnjIPV7eDgV/EngF/7rYekt4irxWTyXqKPZiUBWx87Rc9+8ssxA MRrilMGPLJdFVIdNexS/355zZsbR9LtBbB0XiB3yptfaMfl5QHMQDjZneuwL2lt88O/HQ9ME9 eH2YRSZE+rlKSqJSjakaMPh6xNYnc9nY2Pc0DxUuV4i7o9hRbWH/1SJR/MgPoAj3ZIunqvkL/ r2GFZTH+15j7RmCJllMBewr3nstNGcN+k19rJjL6tvXnG1ZuxSrqpJ6nP6Dovsd55BcTnEh1z mzWyHyVYE4NkzOGMEWWZe9khM/ueVC5KwU0I/0/YxHZUuhaHVp7IKyuqczQv9hILQXmKn6fog HHkBxGsdDRqaFr4vxtonAsq8EjzR6wK+d4lemh+REYVZGLOe5wPUJnqwsa/sBszY9NcYgES1d THV5Vh/DmcLYnswR2VZDwlBLKAnv8koM2JLTMdk97thcKVaOKqn8inEck2UnuKJInv1y+1Awj Z4CI9KclF3s21aYL/8whmQ+BURHq90/8Mgll+7r3SF8lVcB3khA6fd18mEkxPaGzPmzHt9qtV +g/VIG3rZBlWAeMyVR5F8hKwrPIKDb5p0TWzKnBot3XSu4WdegavlYEuC1w= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.130 Subject: [Qemu-devel] [PULL 3/4] vl: Use error_fatal to simplify obvious fatal errors (again) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Collin Walling , Eduardo Habkost , qemu-block@nongnu.org, David Hildenbrand , qemu-trivial@nongnu.org, Markus Armbruster , Cornelia Huck , Michael Tokarev , Laurent Vivier , Michael Roth , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Paolo Bonzini , Max Reitz , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Markus Armbruster Patch created mechanically by rerunning: $ spatch --in-place --sp-file scripts/coccinelle/use-error_fatal.cocci \ --macro-file scripts/cocci-macro-file.h vl.c Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181213175807.12039-1-armbru@redhat.com> Signed-off-by: Laurent Vivier --- vl.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index 2a8b2ee16d..530fad6a71 100644 --- a/vl.c +++ b/vl.c @@ -3133,11 +3133,8 @@ int main(int argc, char **argv, char **envp) Visitor *v; BlockdevOptions_queue *bdo; - v = qobject_input_visitor_new_str(optarg, "driver", &err); - if (!v) { - error_report_err(err); - exit(1); - } + v = qobject_input_visitor_new_str(optarg, "driver", + &error_fatal); bdo = g_new(BlockdevOptions_queue, 1); visit_type_BlockdevOptions(v, NULL, &bdo->bdo, From patchwork Tue Dec 18 14:28:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1015407 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43K1QR4KDrz9rxp for ; Wed, 19 Dec 2018 01:59:43 +1100 (AEDT) Received: from localhost ([::1]:54186 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZGqT-00022F-22 for incoming@patchwork.ozlabs.org; Tue, 18 Dec 2018 09:59:41 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZGNT-0001Ak-Pq for qemu-devel@nongnu.org; Tue, 18 Dec 2018 09:29:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZGNO-00018b-WF for qemu-devel@nongnu.org; Tue, 18 Dec 2018 09:29:43 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:46705) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZGN2-0000tL-4b; Tue, 18 Dec 2018 09:29:16 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MMXYN-1gsIxL0LKR-00JY3a; Tue, 18 Dec 2018 15:29:04 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Tue, 18 Dec 2018 15:28:51 +0100 Message-Id: <20181218142851.9477-5-laurent@vivier.eu> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181218142851.9477-1-laurent@vivier.eu> References: <20181218142851.9477-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:vWgRSiuAdicdIsVonsksGCVB9bBEgulCYydaPpv2yQm6LEcSb2A mVBdDJfogi9Ow4fphflifx+pEb6Kpc/5bFx+wwcck/5s3tIlHsUhTL/jjiniMK4wxfFr+j3 Iem+BDEhhAD55Z+0rU/omO+uMeva20yVKWEtTzniidErVcZQuLlW+iyco0bSLts/U5tFo6T sr4wqribvT2/I2qsB1UIg== X-UI-Out-Filterresults: notjunk:1; V03:K0:K8/xurr9AlQ=:KWh3A7Z47p4u61OQj4nv+h Iy9X4rj7Ab7SHj5XT13nNkBl2odL1WdETSRu8hqGVsx5RUuDaQvqDHnpaF4Wgw6kG7AUWctVt LIF18w9JspjwVbwIplDFsroFzTHtJkt8rlSYixPI6zxwNqsojkNko0Ld91SUQm0/YlE5fbycc PYHzm1qKIuBlQBC6OFd/J0e72OiyXSMZEnZCjl8QYG5gfRGMJELLR3X+YGJlK9xli2fxhJhpz FPnXq5afRnQmidErkA4RC+2M0JhgZ2fEliL0yK2lB5+MwMnwGVjnuaPn4vIQnPGKbgCpGXoA/ tEdinUnnQIuomqOpzM3VhtfM34wXSi1ez5dyg7SV8Sb9XSdrIiPVBVCY7J5aSn3oE/G7Z1sU8 cLt6a8iE/gdhFGpu7l7ZGCW+a3Q/MgfYGvQR/sGTcru+UhWTCaA87ux9jfur6orMlcrQ32PaN y1GUpMHphP5E48iqli8ev8xdwqdf9XeYPePgw7VVw6PV1vBHQ2zKkuzfpAly2jvGFPYE9K6C+ QOwzz3qqjqG0EN0peMTRF5nCLWatMSLTU5R25t8egc+nEq7SiQIY61BUK3Xd6eKn93nFqO+fq ihGGAyRmq3EewcfBpiajRo8qD1nzu2qmSgEFNVsM5fA/tRNgX8mlMRJMbrFwNO5/SuJziVMCL sSImA2RuC5o+TTVfjuqpVDBcgw7LCFSfNSs1inelA2c2YiAUT4fJ44883Up72z5pXZw0yqaZJ H3N7mJpgPWFUdwRHFGwlXJx1O75NHPpRMZN0JR6wnXH6auqNeN1LwVbYED4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.135 Subject: [Qemu-devel] [PULL 4/4] error: Remove NULL checks on error_propagate() calls X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Collin Walling , Eduardo Habkost , qemu-block@nongnu.org, David Hildenbrand , qemu-trivial@nongnu.org, Markus Armbruster , Cornelia Huck , Michael Tokarev , Laurent Vivier , Michael Roth , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Paolo Bonzini , Max Reitz , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Markus Armbruster Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/error_propagate_null.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Whitespace tidied up manually. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181213173113.11211-1-armbru@redhat.com> Signed-off-by: Laurent Vivier --- blockdev.c | 4 +--- hw/s390x/s390-pci-bus.c | 4 +--- qga/commands-posix.c | 7 ++----- 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/blockdev.c b/blockdev.c index e6c8349409..a6f71f9d83 100644 --- a/blockdev.c +++ b/blockdev.c @@ -992,9 +992,7 @@ DriveInfo *drive_new(QemuOpts *all_opts, BlockInterfaceType block_default_type, blk = blockdev_init(filename, bs_opts, &local_err); bs_opts = NULL; if (!blk) { - if (local_err) { - error_propagate(errp, local_err); - } + error_propagate(errp, local_err); goto fail; } else { assert(!local_err); diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 99d0368868..f7458445c0 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -731,9 +731,7 @@ static void s390_pcihost_realize(DeviceState *dev, Error **errp) css_register_io_adapters(CSS_IO_ADAPTER_PCI, true, false, S390_ADAPTER_SUPPRESSIBLE, &local_err); - if (local_err) { - error_propagate(errp, local_err); - } + error_propagate(errp, local_err); } static int s390_pci_msix_init(S390PCIBusDevice *pbdev) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 1877976522..2e719d9b6b 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -1573,10 +1573,7 @@ static bool systemd_supports_mode(SuspendMode mode, Error **errp) return true; } - if (local_err) { - error_propagate(errp, local_err); - } - + error_propagate(errp, local_err); return false; } @@ -1782,7 +1779,7 @@ static void guest_suspend(SuspendMode mode, Error **errp) if (!mode_supported) { error_setg(errp, "the requested suspend mode is not supported by the guest"); - } else if (local_err) { + } else { error_propagate(errp, local_err); } }