From patchwork Thu Oct 18 20:13:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 986256 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="RtKuv+nG"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42bgv961Dsz9s8F for ; Fri, 19 Oct 2018 07:41:41 +1100 (AEDT) Received: from localhost ([::1]:44530 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDF6x-00061S-CS for incoming@patchwork.ozlabs.org; Thu, 18 Oct 2018 16:41:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDEgD-0007xy-3p for qemu-devel@nongnu.org; Thu, 18 Oct 2018 16:14:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDEg8-0006Oo-7X for qemu-devel@nongnu.org; Thu, 18 Oct 2018 16:14:01 -0400 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:37093) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gDEg7-0006NE-WB for qemu-devel@nongnu.org; Thu, 18 Oct 2018 16:13:56 -0400 Received: by mail-pf1-x444.google.com with SMTP id j23-v6so15384422pfi.4 for ; Thu, 18 Oct 2018 13:13:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=IkGT7UMDlUaSJugdviZ1od5cdEdjSocnyRPjRgr0kNA=; b=RtKuv+nGJIoZnJhYbc/qDkN45gN4YGguKX36k4lDh/Z8qFh/9m6N7WRKcPnaj+mpH1 r0Ovq/qsLTx7DuObnX1PF9Fm0YxX2phZrORAz/12UyKsM4JZyhjjOqIxAEf2SqpqHmKI deazFYromlCKQI7tycW/nqgh/eGYrXBS39eAE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=IkGT7UMDlUaSJugdviZ1od5cdEdjSocnyRPjRgr0kNA=; b=RLrdyIiOaN08k7hvr0ESnG3r3cO6aUQDnXJkEibF8utx9XVPN0T1r0TXjo+pMYQ54Q F/lxC6jslGnUoUwLOCemI/xiIxE1q8pUTjKQv0ylHEM0gy98JMGIiLBRL21m/WPKXSJr gm7L9d03qw9wSvLPuiLx9em6ewzSY2sp2dWEQ2app/1TZltC4bnXWWfYhchUA+MvJjPJ 98MBNqhNYmfZveU/wgiuHFE++EOpAQ1drh0i7WtJx0wXr/eNha/9Nxb0f3kh/7wFpOM+ ax+L5zbAPmDUlo0WwMjwx51SOW1QXx4Et17uEMD+7aUwn5sHEsQI18EH8IqzJ1n37SlH 10HA== X-Gm-Message-State: ABuFfojYC/fwp9Hnl2NlIXUi+8mdvDlCMrvX65H/OhphEIXSVewRVSlo btLvQqdefrg5tevqKfJvoV6dRA== X-Google-Smtp-Source: ACcGV60qkKA8BT1zFrW00FGcBSXXDEhaymkZTqgvrbrxJXjpGm3m+Xq9mPDWRT23iPXJvMPM+qHZJw== X-Received: by 2002:a63:8f09:: with SMTP id n9-v6mr29402162pgd.222.1539893634667; Thu, 18 Oct 2018 13:13:54 -0700 (PDT) Received: from www.outflux.net (173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133]) by smtp.gmail.com with ESMTPSA id l10-v6sm30759513pgs.45.2018.10.18.13.13.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Oct 2018 13:13:53 -0700 (PDT) Date: Thu, 18 Oct 2018 13:13:51 -0700 From: Kees Cook To: "Michael S. Tsirkin" Message-ID: <20181018201351.GA25286@beast> MIME-Version: 1.0 Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::444 Subject: [Qemu-devel] [PATCH] nvdimm: Add docs hint for Linux driver name X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haozhong Zhang , Ross Zwisler , Eduardo Habkost , Stefan Hajnoczi , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" I spent way too much time trying to figure out why the emulated NVDIMM was missing under Linux. In an effort to help others who might be looking for these kinds of things in the future, include a hint. Signed-off-by: Kees Cook --- docs/nvdimm.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt index 5f158a61708e..7231c2d78f65 100644 --- a/docs/nvdimm.txt +++ b/docs/nvdimm.txt @@ -49,8 +49,9 @@ Multiple vNVDIMM devices can be created if multiple pairs of "-object" and "-device" are provided. For above command line options, if the guest OS has the proper NVDIMM -driver, it should be able to detect a NVDIMM device which is in the -persistent memory mode and whose size is $NVDIMM_SIZE. +driver (e.g. "CONFIG_ACPI_NFIT=y" under Linux), it should be able to +detect a NVDIMM device which is in the persistent memory mode and whose +size is $NVDIMM_SIZE. Note: