From patchwork Tue Oct 3 14:26:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 823050 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3y9Q2s4CDWz9t5g for ; Mon, 9 Oct 2017 14:00:05 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=sent.com header.i=@sent.com header.b="aFE/BBDa"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="XF8esH4V"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3y9Q2s32hlzDr4W for ; Mon, 9 Oct 2017 14:00:05 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=sent.com header.i=@sent.com header.b="aFE/BBDa"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="XF8esH4V"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sent.com (client-ip=66.111.4.25; helo=out1-smtp.messagingengine.com; envelope-from=zi.yan@sent.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=sent.com header.i=@sent.com header.b="aFE/BBDa"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="XF8esH4V"; dkim-atps=neutral Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3y61YH2zg5zDqNm for ; Wed, 4 Oct 2017 01:26:10 +1100 (AEDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 9E1342117E; Tue, 3 Oct 2017 10:26:07 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute3.internal (MEProxy); Tue, 03 Oct 2017 10:26:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=cc :date:from:message-id:subject:to:x-me-sender:x-me-sender :x-sasl-enc:x-sasl-enc; s=fm1; bh=zbx6amYacmCi6+dKBAKACEMxcx/Al3 CbjsMijemCGR4=; b=aFE/BBDa6Y5BfYTgFtEvsyz0TR5ipaD/FIWDtKyRgGMmjg dUH+sxq6S9aH7wwlaG56UH6SF1RCTh/FjooYDBFMxusuj4W5Vds9WMGDL+rqe/MB +Q6EMVOerzjw68f+0MSCUSc4iRtnXZeF2m0Js6oqAernpvtsX2ACCs/RbXP3JBlx LvuyLNEahZ7tQsYuJpXGipSV8QwJPWEeTQi6tFo9KPIuJN+MDyZOCm050vI1AFL3 capNWAbDE2P4KJPB6PRXL4R07hctLBll3TykwLamNbLWBxUum6ZwlpJdzcwAa5gf 06bnRREvt2GWDojYwXG7HkUYm62b7B5saV7kvj4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=zbx6am YacmCi6+dKBAKACEMxcx/Al3CbjsMijemCGR4=; b=XF8esH4VJ/xtFgUcl3gKDw rvISPoVfDT0ueJyKxC4z9+JdStU8wP0OtntCKvvWid5H2R6M1HH5ezUwKm1WYtwI +Ml3PAFAhNmSi+A2bKbSmgN9jDJF70vq3eQ6uWUaE7YhAgehsTQsDvCIBNt4ynHl UifSAXVIBy9Tp4Z1LtMuLHHLw6FDUNvAOm5M/Nai8ayTGtpF2hiMh93OEw7EYSJg QvgBQJqSih51gbBbcMNqOG6Hs/gQmQxWG+5aHJEnFa5b8pKBRS+J+Ac8oa5qppuy cbMdKrtIb9lE50SBsftZkUAnIUl7N0+8k4lOQspjAQav9i6aAb2b5nzIIxLKW1zg == X-ME-Sender: X-Sasl-enc: ABJAvGp3I+El1/nDTCWjz9FfjFfRlGiq5JmOvRsZZknn 1507040767 Received: from tenansix.rutgers.edu (pool-165-230-225-59.nat.rutgers.edu [165.230.225.59]) by mail.messagingengine.com (Postfix) with ESMTPA id 3C9E1240F4; Tue, 3 Oct 2017 10:26:07 -0400 (EDT) From: Zi Yan To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: remove unnecessary WARN_ONCE in page_vma_mapped_walk(). Date: Tue, 3 Oct 2017 10:26:06 -0400 Message-Id: <20171003142606.12324-1-zi.yan@sent.com> X-Mailer: git-send-email 2.14.1 X-Mailman-Approved-At: Mon, 09 Oct 2017 13:58:11 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, Abdul Haleem , Andrew Morton , Zi Yan , "Kirill A . Shutemov" , Anshuman Khandual Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Zi Yan A non present pmd entry can appear after pmd_lock is taken in page_vma_mapped_walk(), even if THP migration is not enabled. The WARN_ONCE is unnecessary. Fixes: 616b8371539a ("mm: thp: enable thp migration in generic path") Reported-and-tested-by: Abdul Haleem Signed-off-by: Zi Yan Cc: "Kirill A. Shutemov" Cc: Anshuman Khandual Cc: Andrew Morton --- mm/page_vma_mapped.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/page_vma_mapped.c b/mm/page_vma_mapped.c index 6a03946469a9..eb462e7db0a9 100644 --- a/mm/page_vma_mapped.c +++ b/mm/page_vma_mapped.c @@ -167,8 +167,7 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw) return not_found(pvmw); return true; } - } else - WARN_ONCE(1, "Non present huge pmd without pmd migration enabled!"); + } return not_found(pvmw); } else { /* THP pmd was split under us: handle on pte level */