From patchwork Thu Oct 11 12:14:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Li Qiang X-Patchwork-Id: 982449 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="f59z0hai"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42W8zj5Qsyz9s8F for ; Thu, 11 Oct 2018 23:14:56 +1100 (AEDT) Received: from localhost ([::1]:34067 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAZrg-0007nG-SM for incoming@patchwork.ozlabs.org; Thu, 11 Oct 2018 08:14:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAZrG-0007n9-Mk for qemu-devel@nongnu.org; Thu, 11 Oct 2018 08:14:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gAZrB-0004n4-Lg for qemu-devel@nongnu.org; Thu, 11 Oct 2018 08:14:26 -0400 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]:44282) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gAZr8-0004lm-6r; Thu, 11 Oct 2018 08:14:19 -0400 Received: by mail-pg1-x542.google.com with SMTP id g2-v6so4086044pgu.11; Thu, 11 Oct 2018 05:14:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=oJPUw9eGc+c4/HJRXmrY6G+YLqLvGXQU1VtpKbbv9Ws=; b=f59z0haiqB8ykio+6dC0Bra2PCsXg7GRZhatxPyDW3+vJP4WOgWS6k/77DaOjcxiEc zWf6CzMlr8qLpTwciSD+axNg9crrsiXIbxsBRiRbW+h0DdV9slNHHOM1vPa6wBBxVmpP fWPX+NHpmEk128+wB7YeS+1SY7ay8i1rfd2BcSA7XawvUbaWlVXMaXLv5SCY1LM7eWI4 1w66qZK73RIggRywb0tM/kGpfSAfONwOdDkoWsaIurJAfFRI+wCkRAn8++9ZvVRAF6T+ IMseYFYB2y5Yf+q7AX0QCX5587VeQkIBYnAX3jM1HEv6xA8xO2aIJprcf4Tu0wpw0YEU G2rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=oJPUw9eGc+c4/HJRXmrY6G+YLqLvGXQU1VtpKbbv9Ws=; b=j4fe/0I5YtLMcZ2OuWSBUD+wis/TBJJBVowucjCu404TSGSxcupfWXwVSPsB7AhnPX 3wFh/IvW/erXffy519yfxBZwFJBb9iWPjbXTtoUrWPn5qqqlivin7346pQSX4MODNzsl QdWTNMDhx1+LOaYuVgMTDP7X7TYcbT5cdwbBDGSQft0muN2m7iPQY7Kq57gme6WKgPnE 9bVD4xH/lOjlmAm92+sCe+dboFd/kle95tLwZSSSMmMqcNMoztmnEi1b9JU95RxBG8nZ cmCGcgFV1JZx4ESuQjgVQBwESTagTPelWLk6qnYRtGsowgv5Vw6e00bLL889TRcrhEMD hIdg== X-Gm-Message-State: ABuFfogLwW4ez+UoJrSTktbNei3s2IBJnFsQ1d5Zy3tAawhk+1rVp6JX D9dHsbD9yubEnIjT84iYWVw= X-Google-Smtp-Source: ACcGV63ayl9P5HIMosd5C2xXbU+VBMEx7RVFjj7H58Lj4Rk8TiDiS8UBP6NMfR2Ori4EfteFkso/gg== X-Received: by 2002:a65:5083:: with SMTP id r3-v6mr1165286pgp.355.1539260056690; Thu, 11 Oct 2018 05:14:16 -0700 (PDT) Received: from localhost.localdomain.localdomain ([103.65.40.65]) by smtp.gmail.com with ESMTPSA id x186-v6sm39410691pfx.152.2018.10.11.05.14.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Oct 2018 05:14:16 -0700 (PDT) From: Li Qiang To: mst@redhat.com, marcel.apfelbaum@gmail.com Date: Thu, 11 Oct 2018 05:14:03 -0700 Message-Id: <1539260043-4264-1-git-send-email-liq3ea@gmail.com> X-Mailer: git-send-email 1.8.3.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::542 Subject: [Qemu-devel] [PATCH] i440fx: use ARRAY_SIZE for pam_regions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Li Qiang , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Cc: qemu-trivial@nongnu.org Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daudé --- hw/pci-host/piix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 0e608347c1..230d5d2ea3 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -142,7 +142,7 @@ static void i440fx_update_memory_mappings(PCII440FXState *d) PCIDevice *pd = PCI_DEVICE(d); memory_region_transaction_begin(); - for (i = 0; i < 13; i++) { + for (i = 0; i < ARRAY_SIZE(d->pam_regions); i++) { pam_update(&d->pam_regions[i], i, pd->config[I440FX_PAM + (DIV_ROUND_UP(i, 2))]); } @@ -401,7 +401,7 @@ PCIBus *i440fx_init(const char *host_type, const char *pci_type, init_pam(dev, f->ram_memory, f->system_memory, f->pci_address_space, &f->pam_regions[0], PAM_BIOS_BASE, PAM_BIOS_SIZE); - for (i = 0; i < 12; ++i) { + for (i = 0; i < ARRAY_SIZE(f->pam_regions) - 1; ++i) { init_pam(dev, f->ram_memory, f->system_memory, f->pci_address_space, &f->pam_regions[i+1], PAM_EXPAN_BASE + i * PAM_EXPAN_SIZE, PAM_EXPAN_SIZE);