From patchwork Thu Oct 5 20:51:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 822066 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3y7Q3C1htgz9s7p for ; Fri, 6 Oct 2017 07:53:27 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3y7Q3B6JrBzDr6N for ; Fri, 6 Oct 2017 07:53:26 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=217.72.192.78; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [217.72.192.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3y7Q0x5cQHzDqpD for ; Fri, 6 Oct 2017 07:51:29 +1100 (AEDT) Received: from [192.168.1.2] ([77.181.51.69]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LzKIP-1dE2Jn0snx-014Tkp; Thu, 05 Oct 2017 22:51:14 +0200 Subject: [PATCH 1/2] powermac: Delete an error message for a failed memory allocation in kw_i2c_host_init() From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras References: <5188c0b3-476a-6a14-bab5-052ad0f4dae0@users.sourceforge.net> Message-ID: <5dc8fe2f-0459-faff-585f-a92137115895@users.sourceforge.net> Date: Thu, 5 Oct 2017 22:51:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <5188c0b3-476a-6a14-bab5-052ad0f4dae0@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:u2ew0EXdCdtBPETkmvm/h1+JMFqTyElBjTeBUhqO3WRuk3L3sN2 rb69rGOs/BzvpBdDNuTzQwJhjp5J9ea+OqJ6nqYsFiZIzeZ0yPYNgNROo5jvbuaae3cF5Ql 1T+2ThWB38IUrHbomTIqsvB34g6B9JAuga6BVv0AfuaXGO7jZ+aDELjk4CJf4VpmL7oYqbo WBZJHBFBo2HYsjMYFSu+A== X-UI-Out-Filterresults: notjunk:1; V01:K0:sU2KmK2PZtk=:/10q04rX/5cuxDJDPZgJhI csLW2SI/g1UXIvj/KcZMFGjRyOJlmmrEkczOsnHfmg/STedbq138vNTsqVnL6IDABamjkZNjl k2rZSjyJoLv/hrGgD10wXSVjyIOmQpH673nqIJDezUO9mbZadQQSWsTxcgaTpqhgvKRWzidN/ BsokXZRx+ttP9zpbzUJN5QVOZXELSExgEPt5oEujqDtJwWoHyIlsAC9h6lNNTWF2fujhJmc1h DjX3h4q0ex8eIJl1xKcyulO9zO+dIrU4yDEoJ6NQKXSGCp+MWyUJaH5JIfAbyjw6GK3hQ7lA6 pPmA8GDDYOaRY3TmQGDwUlIKzlOqXr93GmCnThYy4S26P/8qMOofhXdxckHm7+Ii3Yj3isIsQ Puqhhx+P/AStusPmpLBs9V+E9hN+AuUWwjtEkBV3kx5Pj5bfhaHBqFBVx2VzLZoN2CjzEN+By I8Q4VhY3ALLo8JIz7I4UyKIPaQCst/nU0cSebyWFVgqMH9hPwXoPtvevRydAZD8J9QnlE0qCb QOYlREx2xRqHVFnnilCGJDD7AMNJRpL6vZ2fB9HSI/HMpYQ0db1o72k+QGeqgW2bEsvTzJSmL wEYjsdGtvOgWNDhIQeoLAkxzAXrRHB14VpCx6gS9rjRinZA7VjmtX4TPU8op7P36div2HdVnp JV5CLU/g928v4WfmH8ZshocaOX/guGvMFyqTHphhAWePQCjqrnYQ3viIufY5GTLv506WM3sP3 TGFXL7oth0Pytd/dFyH4BMeUjsE6R61H9b3Bzy++I0s9ABvl0xj764NmBLrGQYWNLJLy0FcuM OWO7XT9ckKKv1BorBiSTTLNR9t6UqL7oIT9sPSxxDNYzstOY9c= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Thu, 5 Oct 2017 22:30:29 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/powermac/low_i2c.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/powerpc/platforms/powermac/low_i2c.c b/arch/powerpc/platforms/powermac/low_i2c.c index 70183eb3d5c8..ecd166b5549b 100644 --- a/arch/powerpc/platforms/powermac/low_i2c.c +++ b/arch/powerpc/platforms/powermac/low_i2c.c @@ -493,11 +493,8 @@ static struct pmac_i2c_host_kw *__init kw_i2c_host_init(struct device_node *np) u32 steps; host = kzalloc(sizeof(struct pmac_i2c_host_kw), GFP_KERNEL); - if (host == NULL) { - printk(KERN_ERR "low_i2c: Can't allocate host for %pOF\n", - np); + if (!host) return NULL; - } /* Apple is kind enough to provide a valid AAPL,address property * on all i2c keywest nodes so far ... we would have to fallback From patchwork Thu Oct 5 20:52:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 822070 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3y7Q4r12hhz9t2h for ; Fri, 6 Oct 2017 07:54:52 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3y7Q4r043szDrLB for ; Fri, 6 Oct 2017 07:54:52 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.17.12; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3y7Q1v05G8zDqqP for ; Fri, 6 Oct 2017 07:52:18 +1100 (AEDT) Received: from [192.168.1.2] ([77.181.51.69]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M8iLA-1eA8k535Tg-00C8Fn; Thu, 05 Oct 2017 22:52:05 +0200 Subject: [PATCH 2/2] powermac: Improve a size determination in five functions From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras References: <5188c0b3-476a-6a14-bab5-052ad0f4dae0@users.sourceforge.net> Message-ID: <97bf4b4e-811e-58c4-214e-7d60c014a3d0@users.sourceforge.net> Date: Thu, 5 Oct 2017 22:52:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <5188c0b3-476a-6a14-bab5-052ad0f4dae0@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:WzwRl3uowq2FXEbBQ0Go1tZepF5/mJC3uvm6uIaztkloRyYVVzU rUJ6pwB663S/ZanzAf0U7Kt/qmyWMzVLPRs4usSU00s03iBsVNRVBzJBDokwm4w6eAnobg7 djWidHBJSxf0O28VN4TBbfaisr1v+L059KWAK40mxT+oOHSVjr8ERxMSMHb7XiXOWnebfvK Pmgsy7/AZZLp6qny6gr8A== X-UI-Out-Filterresults: notjunk:1; V01:K0:eHHNufSw08k=:+OJ/dmKEUqiJNztbItaXvL k6Mw4vyhQEw9+3nVXfaAJ1iBCp9zx6DsKVztv9DQCC/4qIHTUNuBekAG9TPuMGeqDf36rPMPz RVHC/1g6DbdCtcPSYDoeDvEw4A8k1UkqyUZm5XDBjjwlcvYC2IkKdjMNsr/6JGiV4PFgo6H6i Lkt0RelkQEzdxKIyVemLg/FOmU+y8nt2/W8SPaWe0FQBSaygMDt9QIK7PiVj7QvTJX0KF/PTI fl5vPvysOIg4Nu5xzIjxc3QMB6i+AmxOqMB+tj66YpxBe/boJMkvVLKub34oGQX2xDvoz8AgL N/ttricpBy5rDupulaXzRP/u6lclVZb8X848gtH6fs9dsXaXNhzibVAuw7QTMdfbg+NLk4Qcy qECU+3t5nt7Ca2cxgy77/pGEn1l1/G3Y2qdI3Jqs8IMI+B1+5o6pv5cuvOBgMhO2wYr9NuBY2 luoMDsILfjQhCxhGEo89u5HKWvxGsAxRrj5zON26/eukgtjy1d30bz24OYyVOWQaOT9a+yXq5 wtS+gMKHWAsyOkDi9mbHfW5XIXRZcc0edYCihSmSdXl/LDWJGf7VZahMz12dn3FXW5cvvOgNV ONBWeIOKVkXSKMUEEi6ivJEQR4Q0ziseiJTjOh/hXLe2mynsOScKm5LlnS6tBQUW4v4bmvQ4h 6ySGzkPQpBqu7ZmVDm0qssjU+vpu1lFFV8GrMGtSEA0s0MfTpIHA7xQ/4/khxCOY0hFxczRzt 1MLF5jMxN9BTFlUSHkMRhxxKpu19BDzU/jxnV5IcK1tUWEgywIJiJiAB60pnJHrfpbKjzmzn9 6FRgexB0oZkW+efNkW5CfHH4zwUfSbkL8aAYgw2j/DKeYHwHCo= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Thu, 5 Oct 2017 22:40:39 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/powermac/low_i2c.c | 6 +++--- arch/powerpc/platforms/powermac/pfunc_core.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/platforms/powermac/low_i2c.c b/arch/powerpc/platforms/powermac/low_i2c.c index ecd166b5549b..46b7eb1a0f5f 100644 --- a/arch/powerpc/platforms/powermac/low_i2c.c +++ b/arch/powerpc/platforms/powermac/low_i2c.c @@ -492,7 +492,7 @@ static struct pmac_i2c_host_kw *__init kw_i2c_host_init(struct device_node *np) const u32 *psteps, *prate, *addrp; u32 steps; - host = kzalloc(sizeof(struct pmac_i2c_host_kw), GFP_KERNEL); + host = kzalloc(sizeof(*host), GFP_KERNEL); if (!host) return NULL; @@ -571,7 +571,7 @@ static void __init kw_i2c_add(struct pmac_i2c_host_kw *host, { struct pmac_i2c_bus *bus; - bus = kzalloc(sizeof(struct pmac_i2c_bus), GFP_KERNEL); + bus = kzalloc(sizeof(*bus), GFP_KERNEL); if (bus == NULL) return; @@ -1253,7 +1253,7 @@ static void* pmac_i2c_do_begin(struct pmf_function *func, struct pmf_args *args) * near OOM that need to be resolved, the allocator itself should * probably make GFP_NOIO implicit during suspend */ - inst = kzalloc(sizeof(struct pmac_i2c_pf_inst), GFP_KERNEL); + inst = kzalloc(sizeof(*inst), GFP_KERNEL); if (inst == NULL) { pmac_i2c_close(bus); return NULL; diff --git a/arch/powerpc/platforms/powermac/pfunc_core.c b/arch/powerpc/platforms/powermac/pfunc_core.c index df3c93bef228..e0462fedcdb8 100644 --- a/arch/powerpc/platforms/powermac/pfunc_core.c +++ b/arch/powerpc/platforms/powermac/pfunc_core.c @@ -643,7 +643,7 @@ static int pmf_add_function_prop(struct pmf_device *dev, void *driverdata, while (length >= 12) { /* Allocate a structure */ - func = kzalloc(sizeof(struct pmf_function), GFP_KERNEL); + func = kzalloc(sizeof(*func), GFP_KERNEL); if (func == NULL) goto bail; kref_init(&func->ref); @@ -719,7 +719,7 @@ int pmf_register_driver(struct device_node *np, return -EBUSY; } - dev = kzalloc(sizeof(struct pmf_device), GFP_KERNEL); + dev = kzalloc(sizeof(*dev), GFP_KERNEL); if (dev == NULL) { DBG("pmf: no memory !\n"); return -ENOMEM;