From patchwork Sun Aug 27 20:10:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 806303 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xgR5c0fFXz9s8V for ; Mon, 28 Aug 2017 06:17:24 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3xgR5b6w29zDr34 for ; Mon, 28 Aug 2017 06:17:23 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xgR4M5z5QzDqgq for ; Mon, 28 Aug 2017 06:16:19 +1000 (AEST) Received: from [192.168.1.2] ([78.49.107.235]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LnB9V-1dKRlx3H5x-00hRYA; Sun, 27 Aug 2017 22:10:13 +0200 To: linux-leds@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Jacek Anaszewski , Michael Ellerman , Paul Mackerras , Pavel Machek , Richard Purdie From: SF Markus Elfring Subject: [PATCH] leds-PowerNV: Delete an error message for a failed memory allocation in powernv_led_create() Message-ID: <019499e0-68d8-b89d-f5d6-6aefd9cbaf04@users.sourceforge.net> Date: Sun, 27 Aug 2017 22:10:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Language: en-GB X-Provags-ID: V03:K0:YhRBFjl+M200bpeh8dagQrpz5DJqQi1AtpTdR1UzuxBygS5jZ4j nYAh8NjkUHazD35eLDDwynJQT4laKUXdpeOC1EKsG4N65TKbe5QXCYs8fB5TfJdWhngW7eP AOjMk350gpXZRXhzGkHUVybLHClYW00lEqvUCPX22+/yboohut9/GajZJushZvP4hxwUXkC dmiGwCs/eCK042rqzP3dw== X-UI-Out-Filterresults: notjunk:1; V01:K0:sKQzpXnFgn0=:TZUJTCp+Ok7yL5ShKX9oAw +pwrQ6xIvJ7xjC4TH5mU4dRLjmTYX2Qa1M2QpgGbOnhhs36pm13XUCi78sysTiaLtwrNC/5gk lLlmRXfefNDM85kIQzJbw7IOlN6fm9KBeTGXQ8ylk/7vU4zYDkMvhFEhaxRR6LSPSNQHzxr/g Se1J7EMbekw/Bj1a6yad8dMxQPipBj0LU3H/LncQT27V0qwEVOUc4L8lJrsayVb4oPCf/XkXN jUblZjSA4bM7+Q6jKtBm/6bVSlQ4ZAoFg0hzvQxooe9MXCGgeh1r9ICEjCN8p4YiJoHNDlz58 O21KK6OTIUP33HjUSn96JfoDIBoKmZgp9o2PnRMwwBZfrZBwQSv6GPY2xZ4zE03ro5mEbY/+u zbBSdIvq2nrh0qc5XjaUTEyJz7Q+0MAZDEo9p4Rq3DRxFcfwT4Y44x/VQUXLVhBLB6e5Bwszk g44ioMHwK2iMETqJG55UXgcn8Db2AF0gMp0ZEWTWByLFHvJPGvhJtyhRi34IJ4Kx1uCzrq7Ig M9w7tOmGsmHRqAMgimaaTlPjIWrNo4C02zUbzs24W+PXtcB2gubpIyHSHlpFVlPB7gBLOMP1C hs2ABkKeORjkvwcZ4qsPcv+luMzBrgDGkKXdqh4ETNlpwnY/kN6DNmWtwN51r3R6C1T66F3Up IoPtxif6EMC7DgVlmXqZZfUybeTEY3ciDuOtXXBh8ac5rm64/SoRyu+E8w4lRuPSvTl4iydcg t0UDNQYxTgGRLgn5calmU/LWxVLovVu/JsnVqpBryfUU+hGVf8WLRl3E2RbUc9pBwdG5EvLKq BVfRme0Olh4oEeZ7VAOmpiLlWIXY0avJY/ozjhjmJotcR5BkmI= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Sun, 27 Aug 2017 22:00:22 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Acked-by: Pavel Machek --- drivers/leds/leds-powernv.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/leds/leds-powernv.c b/drivers/leds/leds-powernv.c index b2a98c7b521b..b1adbd70ce2e 100644 --- a/drivers/leds/leds-powernv.c +++ b/drivers/leds/leds-powernv.c @@ -224,12 +224,8 @@ static int powernv_led_create(struct device *dev, powernv_led->cdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s:%s", powernv_led->loc_code, led_type_desc); - if (!powernv_led->cdev.name) { - dev_err(dev, - "%s: Memory allocation failed for classdev name\n", - __func__); + if (!powernv_led->cdev.name) return -ENOMEM; - } powernv_led->cdev.brightness_set_blocking = powernv_brightness_set; powernv_led->cdev.brightness_get = powernv_brightness_get;