From patchwork Wed Dec 11 23:03:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 2021735 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=A7ymYIDO; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Y7rnC186vz1yRC for ; Thu, 12 Dec 2024 10:06:07 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLVkY-0002pe-Md; Wed, 11 Dec 2024 18:04:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLVkW-0002oH-Ho for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:08 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLVkU-0001rL-Jr for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:08 -0500 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-38633b5dbcfso4471825f8f.2 for ; Wed, 11 Dec 2024 15:04:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733958245; x=1734563045; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q84BF+ePAefMMrHK1zEl0KjUdaMQRdy3zhrx62Em4cY=; b=A7ymYIDO5fap9DrW/EBuzh7/yEydEefzdDuEfKHedx5RcI4wSuCV5V55XUhPcIkajG JiUJbLRJR41PR+DwSgdBi047I+zg9ZylSlnR4CtmC8gGmdQjuTKZYKVM8pSEc1qasYmm 5ztNXDuzPcP5k+lkHCmku3wgrOz4gLiKrSrX1PSBNvGsQBrnbjFy7qmreAyPj0qnTOYm yFErLFM7CXFctn9La0dFsOMtiNWKCzrinER09og6FJEoqLDKrI1ZaAMtj8De9WcehdO3 L/M4Xx+iX8xuwNwQDvL2HP0Wt5Wzd+8lKOk31114f2cMJ//cpuwfANBFzIqDdC8zVXnB VL6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733958245; x=1734563045; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q84BF+ePAefMMrHK1zEl0KjUdaMQRdy3zhrx62Em4cY=; b=BMngpP2pVX6XXTYYKg4W8lYboHuivvDKCy4+sqxeXLnOsCxqdRELkDEE0/uSlHZ2Yk ToClJqxfO2XP0OmhdzBU4aQnYqP/vp0pRW3CqmRN45Fd91Nn8PV+zPJqgad0Xe3T29be FMqMPVpP26GztkEpRBcBRJIHcD7bls1TI4lMGtVA8OvU/xx6dBk4Ewf+IQwS6Uj7V8K+ 9/zuFyNZUSSdWI96N8xbS3BwudWMAd+iMFzH+w45v10OWTVeEaSfbg1L6+Dv4bRUqOiU agMudpxBUU813egB7pBzpMYBx0Q/1OqMXjy/5UVpXcc6tsY+Zpk/R+BcSgvWCSKMUM3a f6gg== X-Forwarded-Encrypted: i=1; AJvYcCX6cpguU3c4AgH7caQP5LewBmhD7iL819wzWCoI5mf5zIHQJ3a81K5ca+k2BISAS84YlCTo2QHWzw==@nongnu.org X-Gm-Message-State: AOJu0YxIImz9m2B3CYePbN2wDieJAiu+2O6SnSVAvhjEhgwiaTWmSZH0 ycGghobtM+iqqsNa8p+4ZA3KULjKLrYvR7M8ej/T0DN/MNRwF6Bfy5KTfx25mhY= X-Gm-Gg: ASbGncsw070BDSxds1zCCKjS9W/unbM6c8PPvsWTWri/X7W3Z8B8ETdGMdBBQd2xsix Sql3QNS6x2h4Doio5quVNdRws7xfbmq6L0Eo1ElPvtvhKP/SZGFkiE+EJEeUDInEodVMLH8L9eW vHa2PIntZpVa6iMeG8DK5o51Oe3ylWEc6qmZIOVOVfLxpM81OCd/bOs8ASVjUXtQgW/7dY7CoP8 nFmIS9ELDHvGd5RkgNR7CgYKN8pzeIDNb70XFhRTpYlbQgNWxMVRZIwEpXca2xi4Cd2h9t/FhJK xfIEcSbVFNmnSSmLtZgu1HvJP0+2KFaOtQ== X-Google-Smtp-Source: AGHT+IFj4wDYdVTeVwuYH2TKwtEA6LG+06PYKJPO47q/hi6nNnWcScJdwe5EV5X9ap37AMBzXiD+XQ== X-Received: by 2002:a5d:5983:0:b0:386:3903:86eb with SMTP id ffacd0b85a97d-3864ce97148mr3804619f8f.23.1733958245097; Wed, 11 Dec 2024 15:04:05 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38782514dc3sm2279838f8f.67.2024.12.11.15.04.03 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 11 Dec 2024 15:04:04 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-ppc@nongnu.org, qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Maydell Subject: [PATCH v2 1/9] target/xtensa: Remove tswap() calls in semihosting simcall() helper Date: Thu, 12 Dec 2024 00:03:49 +0100 Message-ID: <20241211230357.97036-2-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241211230357.97036-1-philmd@linaro.org> References: <20241211230357.97036-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=philmd@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-ppc@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org In preparation of heterogeneous emulation where cores with different endianness can run concurrently, we need to remove the tswap() calls -- which use a fixed per-binary endianness. Get the endianness of the CPU accessed using the libisa xtensa_isa_is_big_endian() call and replace the tswap() calls by bswap() ones when necessary. Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/xtensa/xtensa-semi.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/target/xtensa/xtensa-semi.c b/target/xtensa/xtensa-semi.c index fa21b7e11fc..2ded8e5634e 100644 --- a/target/xtensa/xtensa-semi.c +++ b/target/xtensa/xtensa-semi.c @@ -30,6 +30,7 @@ #include "chardev/char-fe.h" #include "exec/helper-proto.h" #include "semihosting/semihost.h" +#include "semihosting/uaccess.h" #include "qapi/error.h" #include "qemu/log.h" @@ -323,15 +324,12 @@ void HELPER(simcall)(CPUXtensaState *env) uint32_t fd = regs[3]; uint32_t rq = regs[4]; uint32_t target_tv = regs[5]; - uint32_t target_tvv[2]; struct timeval tv = {0}; if (target_tv) { - cpu_memory_rw_debug(cs, target_tv, - (uint8_t *)target_tvv, sizeof(target_tvv), 0); - tv.tv_sec = (int32_t)tswap32(target_tvv[0]); - tv.tv_usec = (int32_t)tswap32(target_tvv[1]); + get_user_u32(tv.tv_sec, target_tv); + get_user_u32(tv.tv_sec, target_tv + 4); } if (fd < 3 && sim_console) { if ((fd == 1 || fd == 2) && rq == SELECT_ONE_WRITE) { @@ -387,11 +385,8 @@ void HELPER(simcall)(CPUXtensaState *env) const char *str = semihosting_get_arg(i); int str_size = strlen(str) + 1; - argptr = tswap32(regs[3] + str_offset); - - cpu_memory_rw_debug(cs, - regs[3] + i * sizeof(uint32_t), - (uint8_t *)&argptr, sizeof(argptr), 1); + put_user_u32(regs[3] + str_offset, + regs[3] + i * sizeof(uint32_t)); cpu_memory_rw_debug(cs, regs[3] + str_offset, (uint8_t *)str, str_size, 1); From patchwork Wed Dec 11 23:03:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 2021722 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ehh76pDG; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Y7rld5NzFz1yRL for ; Thu, 12 Dec 2024 10:04:45 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLVkc-0002rB-Gj; Wed, 11 Dec 2024 18:04:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLVkb-0002qH-3v for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:13 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLVkZ-0001uT-E0 for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:12 -0500 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4361f65ca01so9490555e9.1 for ; Wed, 11 Dec 2024 15:04:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733958249; x=1734563049; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KujEMlgf4sTtMREgvgm8kU4qI7hcBzQ7iBZYjiigW3U=; b=ehh76pDGgXM8krjWCraj4aZE3l+G3tJjdHms0Krkpg4Z2AmG2w1Euu3jAIHJfyio7Y H6x6XcItkMMWOkE4njc6fWdMXR6APW7YmCDLO1lAPQacUKy0/xqnvm8nEmU1t9xh8X0O nPsy6XCqimhDT68/bIpNDKw3kAIXIGITs8SFLdCEp28/Cen/OFQkJfKlhZzjT7iTogkS VkAodSjoK87YCo5TVoMgB8X4poR8jlX4Y7ipDTWt1QEZfqjk4fqWy1KaR6gLrcycnvC/ 52BRulV/gpxdDv2TL+9Hfv2uYDf42E7YXVfTe/xHCVe8AkA3uydKMpl5E2FP/QyvXUJv 9HIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733958249; x=1734563049; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KujEMlgf4sTtMREgvgm8kU4qI7hcBzQ7iBZYjiigW3U=; b=EEalEyhU+cYM2261HJrGeWVXJk+lnnnLr63JcZRyl4/zyAz7pwnZPXh2UuZTS+hVhG +pT2gr8zdktTi766GUSpqs7CZwNQgt203I1La1dq+iBQ5uHeujTKsD9zb3L4zqEuQLCQ BBT0UX3zmGFv2Lg0QT0C2Suwzh5GRqtf1jAZ91l/gcbMEy9si4Vm77ZdIV3IWwkgb4Ko nLG1gPOBG9p+BTDeskBrPkzKxSxhRB7mEVLq942b/ibbJU2Tqobex6+Za3qJbAWCdjUN OGDL4uC3MjiFy8LczO56wual4lwNJF2UqB388c7Muv6nOH1+laEW9ynYH+3yjxmZGGmd EZOQ== X-Forwarded-Encrypted: i=1; AJvYcCWGOhusr/+zNu8hpsKytNeEWOYpP2qjEhHytDidamdZuDW0gFQrVKCwK7BCvFIXcxuuLFl0xeM4NQ==@nongnu.org X-Gm-Message-State: AOJu0Yzh0B2rLnbE35h0rzYe0NG3kusVNB4qtvGxABKZrzPreArES73J L5gYl+8RQSvd7Apnd0RayMP27q1Td5UUpELL8d6YgvHU5jIGzKMSLGB5BPn1qMU= X-Gm-Gg: ASbGncuxxQdHVuI1bHJOhiyjtA39hFcTXocVJfh2n8rKQF0XyhuPVchCDosBrZGOnrB p9tggMm7aPfl5y1muB2kjJExpJg5gozi3YZDmeUQSJLkmtspxrriWsXWL2xSg+ZzC9B70QSrCY1 YmrI+9UBgAQzVIJOCRApLaEZ9GX4umNADxb9uGNj1we8icdwM21VmPtf3Yq6Sy8K8EKecfV7y2t ZK+NWzfmJFmMWe3dy+edcVTFIIbyMr5gBOAGu/stMp38A7w/OL0fBP6QiSQ5S8K03km4y3r43jM XnhgEsl5q+DhHFwiTIR1xPXhtDVy3f9c3Q== X-Google-Smtp-Source: AGHT+IGpwgPFHStTPt9kR8GQ8LspXiu9RplHxeBHemwtjTDX9Po+JLjAVa+bSKV6l4RW6UhjLeW7Jg== X-Received: by 2002:a05:600c:5104:b0:42c:c28c:e477 with SMTP id 5b1f17b1804b1-4362286383amr10729675e9.23.1733958249569; Wed, 11 Dec 2024 15:04:09 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4361ec75410sm22742245e9.1.2024.12.11.15.04.08 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 11 Dec 2024 15:04:09 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-ppc@nongnu.org, qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 2/9] target/mips: Remove tswap() calls in semihosting uhi_fstat_cb() Date: Thu, 12 Dec 2024 00:03:50 +0100 Message-ID: <20241211230357.97036-3-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241211230357.97036-1-philmd@linaro.org> References: <20241211230357.97036-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-ppc@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org In preparation of heterogeneous emulation where cores with different endianness can run concurrently, we need to remove the tswap() calls -- which use a fixed per-binary endianness. Get the endianness of the UHI CPU accessed using mips_env_is_bigendian() and replace the tswap() calls by bswap() ones when necessary. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/sysemu/mips-semi.c | 43 +++++++++++++++++++++--------- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/target/mips/tcg/sysemu/mips-semi.c b/target/mips/tcg/sysemu/mips-semi.c index 5ba06e95734..df0c3256d9e 100644 --- a/target/mips/tcg/sysemu/mips-semi.c +++ b/target/mips/tcg/sysemu/mips-semi.c @@ -168,6 +168,7 @@ static void uhi_fstat_cb(CPUState *cs, uint64_t ret, int err) if (!err) { CPUMIPSState *env = cpu_env(cs); + bool swap_needed = HOST_BIG_ENDIAN != mips_env_is_bigendian(env); target_ulong addr = env->active_tc.gpr[5]; UHIStat *dst = lock_user(VERIFY_WRITE, addr, sizeof(UHIStat), 1); struct gdb_stat s; @@ -179,19 +180,35 @@ static void uhi_fstat_cb(CPUState *cs, uint64_t ret, int err) memcpy(&s, dst, sizeof(struct gdb_stat)); memset(dst, 0, sizeof(UHIStat)); - dst->uhi_st_dev = tswap16(be32_to_cpu(s.gdb_st_dev)); - dst->uhi_st_ino = tswap16(be32_to_cpu(s.gdb_st_ino)); - dst->uhi_st_mode = tswap32(be32_to_cpu(s.gdb_st_mode)); - dst->uhi_st_nlink = tswap16(be32_to_cpu(s.gdb_st_nlink)); - dst->uhi_st_uid = tswap16(be32_to_cpu(s.gdb_st_uid)); - dst->uhi_st_gid = tswap16(be32_to_cpu(s.gdb_st_gid)); - dst->uhi_st_rdev = tswap16(be32_to_cpu(s.gdb_st_rdev)); - dst->uhi_st_size = tswap64(be64_to_cpu(s.gdb_st_size)); - dst->uhi_st_atime = tswap64(be32_to_cpu(s.gdb_st_atime)); - dst->uhi_st_mtime = tswap64(be32_to_cpu(s.gdb_st_mtime)); - dst->uhi_st_ctime = tswap64(be32_to_cpu(s.gdb_st_ctime)); - dst->uhi_st_blksize = tswap64(be64_to_cpu(s.gdb_st_blksize)); - dst->uhi_st_blocks = tswap64(be64_to_cpu(s.gdb_st_blocks)); + dst->uhi_st_dev = be32_to_cpu(s.gdb_st_dev); + dst->uhi_st_ino = be32_to_cpu(s.gdb_st_ino); + dst->uhi_st_mode = be32_to_cpu(s.gdb_st_mode); + dst->uhi_st_nlink = be32_to_cpu(s.gdb_st_nlink); + dst->uhi_st_uid = be32_to_cpu(s.gdb_st_uid); + dst->uhi_st_gid = be32_to_cpu(s.gdb_st_gid); + dst->uhi_st_rdev = be32_to_cpu(s.gdb_st_rdev); + dst->uhi_st_size = be64_to_cpu(s.gdb_st_size); + dst->uhi_st_atime = be32_to_cpu(s.gdb_st_atime); + dst->uhi_st_mtime = be32_to_cpu(s.gdb_st_mtime); + dst->uhi_st_ctime = be32_to_cpu(s.gdb_st_ctime); + dst->uhi_st_blksize = be64_to_cpu(s.gdb_st_blksize); + dst->uhi_st_blocks = be64_to_cpu(s.gdb_st_blocks); + + if (swap_needed) { + dst->uhi_st_dev = bswap16(dst->uhi_st_dev); + dst->uhi_st_ino = bswap16(dst->uhi_st_ino); + dst->uhi_st_mode = bswap32(dst->uhi_st_mode); + dst->uhi_st_nlink = bswap16(dst->uhi_st_nlink); + dst->uhi_st_uid = bswap16(dst->uhi_st_uid); + dst->uhi_st_gid = bswap16(dst->uhi_st_gid); + dst->uhi_st_rdev = bswap16(dst->uhi_st_rdev); + dst->uhi_st_size = bswap64(dst->uhi_st_size); + dst->uhi_st_atime = bswap64(dst->uhi_st_atime); + dst->uhi_st_mtime = bswap64(dst->uhi_st_mtime); + dst->uhi_st_ctime = bswap64(dst->uhi_st_ctime); + dst->uhi_st_blksize = bswap64(dst->uhi_st_blksize); + dst->uhi_st_blocks = bswap64(dst->uhi_st_blocks); + } unlock_user(dst, addr, sizeof(UHIStat)); } From patchwork Wed Dec 11 23:03:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 2021721 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=YywzPHbW; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Y7rlD1SsMz1yRL for ; Thu, 12 Dec 2024 10:04:22 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLVkf-0002tG-SB; Wed, 11 Dec 2024 18:04:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLVke-0002sv-So for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:16 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLVkd-0001xm-Fa for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:16 -0500 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-385e2880606so5953595f8f.3 for ; Wed, 11 Dec 2024 15:04:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733958254; x=1734563054; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VCHSGNyFv8LSm9JlTuEHKD53SXdp1uauhC0W87/H+/o=; b=YywzPHbWUWQp+LriOA1CcyVn2HTyfr2hPLLOv8gtwPo1GCVfVn15ZM0fjBtpQsl4Rf CFVhPETVF5/EJHfjaHmlmx6IxJO2QqTUXj+AChr8oscMXJCLV2UHthyvL2ifbSOmaZrH qK1OsWkF+3mTocxJQpLBoZ0QF/UYZJsEwg5alQA6/msC9EPFS/zpm7vvZilPhjJPmS3i LEOYYTLT2GiI7htjI7Ab0SBgzBHNUDBIECHFf3z9p6vZt1nMEYEZ17BYng7HSaXvsB33 HdMUio5oAKzcU+TF3EAGvJMF84c33J1yFTDiM9j/7IZJ4kSuxrHbWMbvUEWZY4gxnbFP vqjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733958254; x=1734563054; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VCHSGNyFv8LSm9JlTuEHKD53SXdp1uauhC0W87/H+/o=; b=naNKk5UTZX1xDHMhIj7rtmW5J1cVfQiCBq1qlS6em5fSneKBmIislCkjOluoRlDXST aDSTnob5b+a2ZJzaP193qILGW2KGiFQ2o1BjEAMbzF8ZUuNvVjC/LuChLmAPtBfgxi7o Zcxe4jko1una5l8xwHNGnjCIqMZM5s7vAasoiLPIXR/9w9EzWyW6s82oQhcBpD0JTRQX Ay46kzcnjsQHgXYyutlz+7CP0TAYbdm3bG5KoyS41Qtw2ycJIE1HWhdzFPRUVWeubvmH QHE6Ct5cwiVJnOGDBtU2acKY77bI3RjdMZh1hKBnBqpNQ02T9UuavVIuUb1mrFUZvQZW tdBw== X-Forwarded-Encrypted: i=1; AJvYcCWgJ1HU2Po/K3xRQLPO6po7KktirnyKbIv0TbVCCpbSX5CPb55Va8v/jyMkZV8l4jw6KofOsOL1KA==@nongnu.org X-Gm-Message-State: AOJu0Yx7bWE54l59EpYD8DhUp4glR6eLR1LYjbHAKin4/TnmXSN+J9o1 VLPyMl/Yc61BuSgCj2DudhwEkeOymOTdqy2OS336booXfqPQTEAGJMt7C1ISwio= X-Gm-Gg: ASbGncuGQSKrB0xIb/eua6SO/JnUWQn3ER+hTJxlwgVh6Ckh6cKJDm+OHFCNwLepgMf p3DxCVbsEjIXtQc4lz9Of0c7dZTK0KB93aMkosScy0qWw+lxKuxv3DPALNvWQ/ll+18oll84Aqt /XPe2KphCt6ynzXvnfcTL2b5m7eC2/H9Oaj/31hgK+HLh0ElZaGp4rZg4LWMRodnEbVT1GWW5MF n2zyOrCvkWHpawZH+XH4WenFt7+ny+MK/79J10PQ8JV2kMGZqC4QRudMBoC2stpwgJliHNLOhdJ kbCXA3PUYUroOq8ol90Y4w8nv+EwPYqo3w== X-Google-Smtp-Source: AGHT+IGc3/AWzOOAriMV+IbB28ThDUkQnPPwa4fCXVt4koxt2DxrUannj4gUNc61UUYJBiBPXKTxTw== X-Received: by 2002:a5d:598c:0:b0:385:ebaf:3824 with SMTP id ffacd0b85a97d-3864cea38edmr4351410f8f.27.1733958254128; Wed, 11 Dec 2024 15:04:14 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-435aab63baesm62036735e9.38.2024.12.11.15.04.13 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 11 Dec 2024 15:04:13 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-ppc@nongnu.org, qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 3/9] accel/tcg: Include missing 'exec/tswap.h' header in translator.c Date: Thu, 12 Dec 2024 00:03:51 +0100 Message-ID: <20241211230357.97036-4-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241211230357.97036-1-philmd@linaro.org> References: <20241211230357.97036-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-ppc@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org translator.c indirectly gets "exec/tswap.h" declarations via "exec/cpu-all.h". Include it directly to be able to remove the former from the latter, otherwise we get: accel/tcg/translator.c:433:15: error: call to undeclared function 'tswap16'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 433 | tgt = tswap16(raw); | ^ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- accel/tcg/translator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c index cbad00a5172..ff5dabc9014 100644 --- a/accel/tcg/translator.c +++ b/accel/tcg/translator.c @@ -15,6 +15,7 @@ #include "exec/cpu_ldst.h" #include "exec/plugin-gen.h" #include "exec/cpu_ldst.h" +#include "exec/tswap.h" #include "tcg/tcg-op-common.h" #include "internal-target.h" #include "disas/disas.h" From patchwork Wed Dec 11 23:03:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 2021731 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=UQAyced1; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Y7rmn6StQz1yRC for ; Thu, 12 Dec 2024 10:05:45 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLVkm-0002yk-3d; Wed, 11 Dec 2024 18:04:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLVkk-0002wU-Kn for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:22 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLVkj-00020o-4v for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:22 -0500 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3862b364538so4186f8f.1 for ; Wed, 11 Dec 2024 15:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733958259; x=1734563059; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2CyImSr/vh1Hw5UwjATJ/bss7/ONFU9Y4xODnyBojcs=; b=UQAyced1MDSkY9dJpr7ZzoiGcU6leSsIWzdg+uN+OfiI4vs3y8qqf2cVbV2r+xVjXA l46bzLnmzu+HTV/6h6elTVgNo/c5QQo+J6k8Y0v7gMPepHx1zfOwYx4+C+LVJlFjYe5/ SnfqQTEG2Qnx/TeIiu9c7mXxHHwGvcZeG1pXVvlUufm6oHncsPMhNk6PwWcIv01YRVPV /Y3jkA3FFyO8edFyRICdRUh3DZzee0eJmW8CnmZqz+Gee+5RDV1vjR+J1wSibIlbboeF 4/2Y3AdvykHsmxufl72bKuZItzYJC0JyxBFFtqpX2K21yZrgrB/WOElfyhCyuePIn9sY xEAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733958259; x=1734563059; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2CyImSr/vh1Hw5UwjATJ/bss7/ONFU9Y4xODnyBojcs=; b=EHtQeNOkFpILJM7f4uaB9D/xuR3aW0f5Gc4WNwfezUL32HQqjhvYXhVoKwSZWtre56 mhKjl4fr2oQjHDoDjargKLP2RBENj4d8RFShkSssdKS3oOss+JJxrhsbCCW54wWYo/KM CIFOmIjSxXu8RLy2ZanTayOmQApTAdPMBkYrxannDGjH2KcPy7bwcRK+NoseqvKEGG9d lL0+KZVKMIMhq4ymgQ1YNcrJAgPOXIZoqj5RCzTn8hvnNjFrUmhbof+9dl3DjHOn/2ab umiaB5QUryddm0U9FQmRT3rWRj9CevXic+Wtt/V2gUmbZ1c6yt8txuqhAOajCgJ0YtWt 5njA== X-Forwarded-Encrypted: i=1; AJvYcCVabKLM4kE9f3fFk/0X6/W9SsPMqwuU37QkVp4qQk8hcZ5cJsZNEtdp/qOqORscHA26J1WlEyYYXg==@nongnu.org X-Gm-Message-State: AOJu0YzVRamvsbqfgCun1jS4vY0m0EErHCig1TLyGpOTlsYz1FtR4FPj 0wxq7nOE7hPLWr6Na0V3tFL+P5N47o32u/wo61w7YTU6kcER2HvR9Rf+wvxAhqI= X-Gm-Gg: ASbGncvsXKzdFcZdjWrD3fPruoVTgiyUM0hgZSlaTuLMnW4Vm+bhI98UjQXR4g5rHuh jU5IZ8UEiGhAoLIMmhuFMSaqMinjuuU+02hF1xnD0wQmWRLp4tXjVPoVoUVhm3G+8dfOrvCKbGp bRAubEemXUj6SYjHASZS6HCy0+IWECYcdUGRvIhn+SEcXZJThe22MZdesKophqd74+vT5w7YOel b4AxSJSkGOKgMknsMxcEHbIX35VSw9ktn1nsdCJemTNEFDFBAwmtv6FBTJ/0bru1Gpx2nliYPyv NPold4YGtUi2ZnbjholCXDU8VUm4s6MUIQ== X-Google-Smtp-Source: AGHT+IHqHQT7Cea2Wnc1ed4/tVD7++I0hUY9dC1tLd1/pRYYVNW7km+DEaIbfVAJ6hA0okp2xjfubQ== X-Received: by 2002:a05:6000:2cf:b0:386:32ca:7b5e with SMTP id ffacd0b85a97d-38788807815mr629903f8f.16.1733958259604; Wed, 11 Dec 2024 15:04:19 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-387824bd8b9sm2332636f8f.47.2024.12.11.15.04.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 11 Dec 2024 15:04:19 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-ppc@nongnu.org, qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 4/9] hw/arm: Include missing 'exec/tswap.h' header Date: Thu, 12 Dec 2024 00:03:52 +0100 Message-ID: <20241211230357.97036-5-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241211230357.97036-1-philmd@linaro.org> References: <20241211230357.97036-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=philmd@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-ppc@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Some files indirectly get "exec/tswap.h" declarations via "exec/cpu-all.h". Include it directly to be able to remove the former from the latter, otherwise we get: hw/arm/boot.c:175:19: error: call to undeclared function 'tswap32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 175 | code[i] = tswap32(insn); | ^ hw/arm/npcm7xx.c:326:26: error: call to undeclared function 'tswap32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 326 | board_setup[i] = tswap32(board_setup[i]); | ^ Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/boot.c | 1 + hw/arm/npcm7xx.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index 5301d8d318c..30ba98d52fb 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -26,6 +26,7 @@ #include "qemu/config-file.h" #include "qemu/option.h" #include "qemu/units.h" +#include "exec/tswap.h" /* Kernel boot protocol is specified in the kernel docs * Documentation/arm/Booting and Documentation/arm64/booting.txt diff --git a/hw/arm/npcm7xx.c b/hw/arm/npcm7xx.c index af04c4b7ec4..3a5ef26f689 100644 --- a/hw/arm/npcm7xx.c +++ b/hw/arm/npcm7xx.c @@ -28,6 +28,7 @@ #include "qemu/units.h" #include "sysemu/sysemu.h" #include "target/arm/cpu-qom.h" +#include "exec/tswap.h" /* * This covers the whole MMIO space. We'll use this to catch any MMIO accesses From patchwork Wed Dec 11 23:03:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 2021724 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=R/eBWH5z; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Y7rlw26gcz1yRL for ; Thu, 12 Dec 2024 10:05:00 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLVks-00032l-Rr; Wed, 11 Dec 2024 18:04:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLVkq-00031A-R3 for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:28 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLVkp-00023P-CG for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:28 -0500 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-434b3e32e9dso77005045e9.2 for ; Wed, 11 Dec 2024 15:04:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733958266; x=1734563066; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e1gkSU7M75EFdbW95JvRzZevk5diVkYdExWvAc1of60=; b=R/eBWH5z2dx6cjzsEN6u3+idu3vFuwzErwO8oX11xXUX49xg7u3+co4bLtb8Lwtojd 5NHmmaixLvtSXFqWCc2Jgbd40xh+tbLlPsc251PbFJ9YmL8Q2NXnPExaZcudXcqXOu/j 3HOJ5ZQeVfiblEkwyYcKRDfEEduHeHlE9GFVeQ4VeMTyHH/XoCh8GIx3eDq4QLBAcagv zAxyQs58tKFEF1Zf1vJ+6Z6uU9+1pMMeT9e3DP0+KHzEiflCuXTUtTyO4dDnkAnGt8Wi jTd6vixOeaHcpuPvX0SG2FSGxAGhAa4Anwj4I9VDP4et61vZCi0Emut8HYBzWO7qlTzY 0syw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733958266; x=1734563066; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e1gkSU7M75EFdbW95JvRzZevk5diVkYdExWvAc1of60=; b=AgyhEpVkxnt5u+wZbyPWer1blJgWjBdg7VExK4Hg9szYSjvyzAmFuo+XyDQHgpNyAQ FghROrSb6qyEXUxxxZR3npY5tnKm3WQlST88l+ttGss9TjF5UbiTzoy4Lro+KVqSYPqL gnFOQ36IVPivyaz/83/xipU7d7Z0ddun67JgSDWjXoJYzrzdJa8J6PBG38a0RE0dZ3C8 hyIT0flN+hrH4+LCQ7kx7ti1/2bFhX5KQl0QC15bGvOKPyeWhGPl9E4ITlmY6fsb0EXg ChIA9V6BVqlUZD4tisgtMz6mnQtseFIt+YXqnUYT56wKF1gZjmsvzfVn/xZhm0yIYU6G Va9w== X-Forwarded-Encrypted: i=1; AJvYcCXqDgeobnCmPpTmpJnD5D5x0Khf2mT2TV5PX3X461KyC8aqQq7cXH47ILe54lMQ8zY3sSp9QTYRAw==@nongnu.org X-Gm-Message-State: AOJu0YwZwmKtlh80/458lNPbeGuZP5ZsklLmUleaLElF5VlmzsepduFp 9dNpF9MZ/Bby88w9BsjkEabHTeN1XY5LteTiFxeK9lklCL9XcUQMh5TK9gkIAhQ= X-Gm-Gg: ASbGncudRLYJ5JUzWrCk+Ch1ETDPYGqon1qjW92vPf9vphj//Cxmktwu+aWkLH4Wx9o Io3XcpiOmnE89OEoev5LfvSbcwI4nBpL+SiVqvx/YJGl3ZmHYwNv2k5jQoI5z/xHrLqxg7wZXb6 Yz3b3YDf3y4wZyfy/vDeUT7y8yOIhkNetteP6YbS4Rr2vb5iSJhAhVCpNAv55ACL4AE4MeKdeg5 byzytaGgyQwZF8HeqK9sCHyngwi+qohbM5rvYLD/3l4tynKgSuX4ku8iU4kDzfPA2Z2BKFEqAjA GrFs++9bPyGNyyQF9tY1D+Ihi961EwjIAA== X-Google-Smtp-Source: AGHT+IH13sBDrrNq1YNP2KE3qw+IE73kK1J9viuwif4RhVJDSJvBV6NWIotfSC1dDfDCvcGxhZZv6Q== X-Received: by 2002:a05:600c:46c6:b0:434:f9c4:a850 with SMTP id 5b1f17b1804b1-43622833224mr13851425e9.10.1733958265695; Wed, 11 Dec 2024 15:04:25 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434f981880csm117938685e9.44.2024.12.11.15.04.23 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 11 Dec 2024 15:04:24 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-ppc@nongnu.org, qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 5/9] hw/ppc: Include missing 'exec/tswap.h' header Date: Thu, 12 Dec 2024 00:03:53 +0100 Message-ID: <20241211230357.97036-6-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241211230357.97036-1-philmd@linaro.org> References: <20241211230357.97036-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-ppc@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Some files indirectly get "exec/tswap.h" declarations via "exec/cpu-all.h". Include it directly to be able to remove the former from the latter, otherwise we get: hw/ppc/virtex_ml507.c:123:19: error: call to undeclared function 'tswap32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 123 | env->gpr[6] = tswap32(EPAPR_MAGIC); | ^ hw/ppc/sam460ex.c:238:23: error: call to undeclared function 'tswap32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 238 | env->gpr[6] = tswap32(EPAPR_MAGIC); | ^ hw/ppc/spapr.c:1617:13: error: call to undeclared function 'tswap64'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 1617 | DIRTY_HPTE(HPTE(spapr->htab, i)); | ^ hw/ppc/spapr.c:1406:55: note: expanded from macro 'DIRTY_HPTE' 1406 | #define DIRTY_HPTE(_hpte) ((*(uint64_t *)(_hpte)) |= tswap64(HPTE64_V_HPTE_DIRTY)) | ^ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/ppc/sam460ex.c | 1 + hw/ppc/spapr.c | 1 + hw/ppc/virtex_ml507.c | 1 + 3 files changed, 3 insertions(+) diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c index 78e2a46e753..3bbab263ae8 100644 --- a/hw/ppc/sam460ex.c +++ b/hw/ppc/sam460ex.c @@ -22,6 +22,7 @@ #include "sysemu/device_tree.h" #include "sysemu/block-backend.h" #include "exec/page-protection.h" +#include "exec/tswap.h" #include "hw/loader.h" #include "elf.h" #include "exec/memory.h" diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 0d4efaa0c09..02136b3295a 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -90,6 +90,7 @@ #include "hw/ppc/spapr_numa.h" #include +#include "exec/tswap.h" /* SLOF memory layout: * diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c index f378e5c4a90..0e9a2469599 100644 --- a/hw/ppc/virtex_ml507.c +++ b/hw/ppc/virtex_ml507.c @@ -26,6 +26,7 @@ #include "qemu/datadir.h" #include "qemu/units.h" #include "exec/page-protection.h" +#include "exec/tswap.h" #include "cpu.h" #include "hw/sysbus.h" #include "hw/char/serial-mm.h" From patchwork Wed Dec 11 23:03:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 2021727 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=fKgJrvMZ; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Y7rmF6NYhz1yRC for ; Thu, 12 Dec 2024 10:05:17 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLVkx-00039J-UM; Wed, 11 Dec 2024 18:04:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLVkw-00036O-8S for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:34 -0500 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLVku-000268-E3 for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:33 -0500 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-385f06d0c8eso3399482f8f.0 for ; Wed, 11 Dec 2024 15:04:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733958271; x=1734563071; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J+4/L4+9GPQca3Ynp9H2GzuGT1XQzOn/jP/hpV92NZU=; b=fKgJrvMZpvXa1FAvrauWPhM35j3CnjBlytfeLBMADbmhyWdAJIARj1IG27+Y/ZA4uW sfz/D3i6vB+znRddS7qVBOlIqhlQGIHeGQ5olL3U8EWn3sX3yMWdPaPbN0Q+YJsZ5bMY 5zDFyRjmYn4RtqvoAFgFj2Duj1Mg60n/I/znmuNGoyx1hiaxTxGmMLC2Da1n4XFVDyfC Qpx9FsK44Qczmm2Q04GxrM7LjPXP/I7jLSnpnVprl9mgmjsbCL7yibr55ZgaMcQabI6b 3sUJjrHraOdla7jK/LHjtdHsWkLuel19hD4wBLV39Uk5l6G0+9l6gOPDxZuQUlEvJjJA +pJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733958271; x=1734563071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J+4/L4+9GPQca3Ynp9H2GzuGT1XQzOn/jP/hpV92NZU=; b=PKscIPfYPq5eo36agMjhZfjvLWfkVfmNGFhecsUJmxgKOl4QI4CcDa+BNb+IcNoUnW UM29jPEg8Z2IzUgAgZlVkJo+iq1WIS2DpR76KjfnuuP0MQuMPSADVfURfbsXbgiS9tUp y8SUSCWKHv/PH0uGPQcA6LLSh3jLmIGzjFXrtxUEWn0WVoWTL7TaxkEuviE9Xu8/imJ9 8PO+5rGrlJCPim57uhKkQ7gSrnbwZoNwtmhBgCn/95CQq+UxJWTyz4866CDqhwnaNe+H iVzN6O/FNV0gS4ur+iIdgJtoiJsjPgwqQcQmVuh13AaOpzWSNAaBA4gCRAFJlI1cDFi7 vq/A== X-Forwarded-Encrypted: i=1; AJvYcCUO4GONJ6ayRo79O8Yl1ESkImZYDVG/3zsmEh2kTJnzazO/tOZOT+wXptNdqGsvbvDKYodDC54tCg==@nongnu.org X-Gm-Message-State: AOJu0Yy8TkJIEbZ8uS9uiSq4oui8TbTJESNYUrdxB+fy7SYtiv1nTzsD AkWzA4i4dyl8j4IPEpw61S6bD193+jne9fRSPmdt0jmq1+IldKuhzF30HjlycXE= X-Gm-Gg: ASbGncvVlliH3Bj0zs/uOVRZRmZ7vdTQZfiQrcGMC0qHG3EwjWHMKhF+sDZ88WFHY8A e/lq9ezmnfoWKcvogts9XQuR+IFLYO0VYO3hUspa3lB0L5432pnUXyE3QrLzcJk0mQtTil45n39 GPx2HH1asFi4UIBDi5PCRt6PhblJJ+llOxB7mK0oA/EFx1ZoLTALBYv5JMJ0xOLHxLPjw20ApGP FLZFW7ybMoPogQ0buxJRUD3yrgFnAXr59RPLnyp33RlVQCioTbbD5l0MPG5rkEKSjLJpUHOUkF2 m9Xxp51oIoFU5C9kUF5PfDbEXzE4EQWj0w== X-Google-Smtp-Source: AGHT+IF3qMRbCL0VgNH7+bQrXp6oZOW0PcG2/8u/3GJ1CWD6wsbyUQMFe6AQCr1M7K48q8hVuUm1Lg== X-Received: by 2002:a05:6000:2ab:b0:382:450c:2607 with SMTP id ffacd0b85a97d-3864ce495a8mr3829234f8f.4.1733958270738; Wed, 11 Dec 2024 15:04:30 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38782514db8sm2347116f8f.84.2024.12.11.15.04.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 11 Dec 2024 15:04:30 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-ppc@nongnu.org, qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 6/9] hw/mips: Include missing 'exec/tswap.h' header Date: Thu, 12 Dec 2024 00:03:54 +0100 Message-ID: <20241211230357.97036-7-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241211230357.97036-1-philmd@linaro.org> References: <20241211230357.97036-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-ppc@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Some files indirectly get "exec/tswap.h" declarations via "exec/cpu-all.h". Include it directly to be able to remove the former from the latter, otherwise we get: hw/mips/malta.c:674:22: error: call to undeclared function 'tswap32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 674 | tswap32((1 << 31) /* ConfigEn */ | ^ hw/mips/fuloong2e.c:89:23: error: call to undeclared function 'tswap32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 89 | prom_buf[index] = tswap32(ENVP_VADDR + table_addr); | ^ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/mips/fuloong2e.c | 1 + hw/mips/malta.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c index 7fd8296ccb6..904c10b90e3 100644 --- a/hw/mips/fuloong2e.c +++ b/hw/mips/fuloong2e.c @@ -40,6 +40,7 @@ #include "sysemu/reset.h" #include "sysemu/sysemu.h" #include "qemu/error-report.h" +#include "exec/tswap.h" #define ENVP_PADDR 0x2000 #define ENVP_VADDR cpu_mips_phys_to_kseg0(NULL, ENVP_PADDR) diff --git a/hw/mips/malta.c b/hw/mips/malta.c index 198da5ba3d4..834636dae59 100644 --- a/hw/mips/malta.c +++ b/hw/mips/malta.c @@ -28,6 +28,7 @@ #include "qemu/datadir.h" #include "qemu/cutils.h" #include "qemu/guest-random.h" +#include "exec/tswap.h" #include "hw/clock.h" #include "hw/southbridge/piix.h" #include "hw/isa/superio.h" From patchwork Wed Dec 11 23:03:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 2021730 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Ub7ilO+7; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Y7rmc3Fjqz1yS4 for ; Thu, 12 Dec 2024 10:05:36 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLVlK-0003Wc-T0; Wed, 11 Dec 2024 18:04:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLVl3-0003I1-1k for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:42 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLVl0-0002A0-G8 for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:40 -0500 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4361a50e337so13218925e9.0 for ; Wed, 11 Dec 2024 15:04:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733958277; x=1734563077; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i5TDVgq/CwukR+NJEtHbkNKroUN70sGumVux+smwBCQ=; b=Ub7ilO+7J0750n7OF58vshIkm3AV+78t9nLKtlDukYpRCpPARfq/Wl3LqXEL8h7zQL Z+7b57wnVSRjPIj55Zo6aJjCYjDTFoTCmUR2flLDU6NTOd09KmRzPLgc0+D1cSvy0YGC lbrz0ihNzV+wYN32slUeDPyoYLmMWSKX7JzTSHG3X56LyEM0c1g3GnxIoywT34Rhj2Cy aDgQpNa3PZbLfNuCDNOCsJpCN8br+R6d1NHxgXrGueCzBjLQtQApSgosGOXkY41e45xm LnxTedqgzFjlOSnW2GVWlH3rWWJm0eefKNULxpeoqzADWhLUybTrLFtjrrOyoPdJHPcl PHgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733958277; x=1734563077; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i5TDVgq/CwukR+NJEtHbkNKroUN70sGumVux+smwBCQ=; b=QkRRUebaqitv8s0ajb4gK80xKxPmSrF9XXfZ8u+CF84O+7thb8k3Wu5UhTBXN9gEqN BZcVZ4f9xlwfLCzYqi/8t4wSiaBvw+4oX+zYOCL+bidvQs+UzS49oNslnuwaJ2vFXLG1 yx+h8CNJNnZnvnBkuH5/B3YllCkektEDyEB7s58T3c+3DBBuf3VAbGk3bY/cGY9QIaMw sK7VeUCX0Do8xF1mOYPVF+YVTgHt5Pd/t9jp4fdSehB9BZKJgZ+8DQB/cdGhYUbs7Mb5 nHZqFMHfgWI3efHUQdRJ4quRk9N9G4865CsFMfMdTg71lSmhvvfRrCoeHY0T/UHIoWBV Md4w== X-Forwarded-Encrypted: i=1; AJvYcCWFQ+TF5ge6pEKILNztG3w0Mm+K9O9HookmuwW5a3nGmwEpaR1haSJWB3cMBcoLAdItKp8N0E04mg==@nongnu.org X-Gm-Message-State: AOJu0YzKbCKjs8OsuYxP1wKKkeeqgH+iBO4KCW70VQ0NsL7uBagdZSk9 4Bvz2aKVxZSbqB0FCgFFeAhxcPkO2U20JleR9S9e/wqzexdOJTIsQcXWXw4G/BY= X-Gm-Gg: ASbGncuuaIliI4erihH9OF+9yW7RgvK4R8pKmV4k0ICiRsMlZ6Zkx7KiAxuZUt9cSQx 9k3NHg5SfYOCW8cZTvbOKhli8dgJ9QdH3PbGSfBQHyt6ssPF5KxhBwdZn9VpDoeLJfUPO1LMy+j lbrb9/aauOfFCh5onm3CxRdehYX/rWvp42+dJOjHUKv9IyupEiOb1XimLR8GC29wHuKZtekmgRK l+x6BiEaUlyhhYT9wnSFhmNzNVSJgxsdjBC+YbtQJEjFdhNdQnAkP3OMZTMLYuVfhYTh8HlQfA6 AdZUK/WHQhkwOFfId7bZjg+k+KVJjKDYXQ== X-Google-Smtp-Source: AGHT+IEhm6oddSIUhSNEWiz9LFRT/gvZfGHNmjndFdBk7CFLy2+kvYb3ZuIpawuLW7nNHrcK5WzsAg== X-Received: by 2002:a05:600c:1f0d:b0:434:a923:9310 with SMTP id 5b1f17b1804b1-4361c3c5015mr37873435e9.15.1733958276747; Wed, 11 Dec 2024 15:04:36 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38782514c06sm2341763f8f.73.2024.12.11.15.04.34 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 11 Dec 2024 15:04:35 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-ppc@nongnu.org, qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 7/9] hw/sh4/r2d: Include missing 'exec/tswap.h' header Date: Thu, 12 Dec 2024 00:03:55 +0100 Message-ID: <20241211230357.97036-8-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241211230357.97036-1-philmd@linaro.org> References: <20241211230357.97036-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-ppc@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org r2d.c indirectly get "exec/tswap.h" declarations via "exec/cpu-all.h". Include it directly to be able to remove the former from the latter, otherwise we get: hw/sh4/r2d.c:357:35: error: call to undeclared function 'tswap32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 357 | boot_params.loader_type = tswap32(1); | ^ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/sh4/r2d.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c index 7eecd79fcc1..e6cc156c238 100644 --- a/hw/sh4/r2d.c +++ b/hw/sh4/r2d.c @@ -43,6 +43,7 @@ #include "hw/loader.h" #include "hw/usb.h" #include "hw/block/flash.h" +#include "exec/tswap.h" #define FLASH_BASE 0x00000000 #define FLASH_SIZE (16 * MiB) From patchwork Wed Dec 11 23:03:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 2021728 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=p1ZWY7xk; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Y7rmT5cHGz1yRC for ; Thu, 12 Dec 2024 10:05:29 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLVlK-0003Uv-6A; Wed, 11 Dec 2024 18:04:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLVl8-0003Kv-EW for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:47 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLVl6-0002FZ-Vt for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:46 -0500 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3862b364538so4324f8f.1 for ; Wed, 11 Dec 2024 15:04:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733958283; x=1734563083; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+71ZOpdVAG9B9l+7/FqsTNfCtOJJsIHhAT40qDCr+hM=; b=p1ZWY7xkla3DXjQ2g68P2igLCFqO3MLeBEFavRFoJGRHqyWYrJyNvdjO/8aVleAlt6 /APUezHJ9mtF+7vQLRK0Evvo22DlLjJ0wISNzi9ED7CUQDfXN96VQO28GwkZGIKKD4Zg f7CDEw2Ing6WhvdpFj5kEkYKXgGOOdAJnSjKbGC7evsOyMl1qY2eX9CGuFlx2JleLN6I P9TNAhP1o1BtbuaSfm5tIg1buvkSsys5/IQNle8L+WKkATnqtFXVI8nJ12vCjlomp8Ez EHKZd8Z2tDxTM1+ryjVUIXSJsAmeAfpU9KblT0XTzDPjIUtiPYe8hRhx0jFrN2DT1hGt MBvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733958283; x=1734563083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+71ZOpdVAG9B9l+7/FqsTNfCtOJJsIHhAT40qDCr+hM=; b=iMEJe+IUgav7qXFTmSe4oLN6L/kB6n25XMp3vVedFdwCr5pMoPEXPW4sIYrlKBnv5Y zYjljt6ItYuchtJuDe72lj/lHGWkPjQtzDSUZRqtpnEoJTb6u5wlw6XLcZSJSwQ3DK8Y 62jk6SGNkuwY0HkiHzmX6ESvs12GMjSinLSGYgWPxUvf5cBwHTkyAxkInce8r/7FYgVm xQ2yZnYryj7LP8/4JNPi/jHYxm9/cwf0SMO2azjuZzXKvd1r7OlQpZe1whCoKXXkUAdc /Q0tSOP7dnVn9jJxl4DZs+t/ALZpGT5/ZWpJlvgHLohtqm44E5E4+wL5rVO80WgqLnag OQUw== X-Forwarded-Encrypted: i=1; AJvYcCXnhzf3fPow/EII+DdCFyqxkjD7D2WvosVcVv7lOCtutYtfdEAG2oPuAMy/NnOLeKsTSSkoCXs5pQ==@nongnu.org X-Gm-Message-State: AOJu0Yz2dcmW7K5Dc7GaOfmzWLjTt78Rz6YWToYEKQ56F0uF5AAtugz3 CVQTzYmXFBuQuOOgr5epWmsDVFjsrKuSKaD39mOsOcq3pHCciZ+WuLEM6/Mk5Rk= X-Gm-Gg: ASbGncvxSH58ks0WBoQxIDRSzF/slO1IC9RkX54Y9HR1MbXkKcpozaoGgTgbYxG9bee yFrXj4o1aRPHvAELK13XIWClyDU8X4bo0tOc0OPuMCKyH9cREpmxSHi3qYEq0mi4dXM5gq/d/yT QqGwXVYPWItW6f3DYEmHhD9t0kwpGQnxiGnNurUeRSAtjfL06vALm5l/UvIxzIZYOTKGIiWMhC4 HJGhK3JZvUs7g+a1Lz3CT63mkBPoSA2PDzKbhWNZ/6mvJfWLY6hWaZhsTlg7uLx44lxOrgo7LK3 FYbcZruvwvv6blcFQ2+bysVNWDYbbFhHfw== X-Google-Smtp-Source: AGHT+IEe6dwlE3rKQ3ehwUu/JJmDhcTIUXRgm4CPz2wR2Px26X3yPZt8sxZ/CCCrwsGPC7Xrs/pwyg== X-Received: by 2002:a05:6000:a07:b0:385:e10a:4d97 with SMTP id ffacd0b85a97d-38788825765mr681479f8f.21.1733958282175; Wed, 11 Dec 2024 15:04:42 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-387824a4a25sm2330451f8f.27.2024.12.11.15.04.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 11 Dec 2024 15:04:41 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-ppc@nongnu.org, qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 8/9] hw/xtensa: Include missing 'exec/tswap.h' header Date: Thu, 12 Dec 2024 00:03:56 +0100 Message-ID: <20241211230357.97036-9-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241211230357.97036-1-philmd@linaro.org> References: <20241211230357.97036-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-ppc@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Some files indirectly get "exec/tswap.h" declarations via "exec/cpu-all.h". Include it directly to be able to remove the former from the latter, otherwise we get: hw/xtensa/bootparam.h:40:16: error: call to undeclared function 'tswap16'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 40 | .tag = tswap16(tag), | ^ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/xtensa/bootparam.h | 1 + hw/xtensa/xtfpga.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/xtensa/bootparam.h b/hw/xtensa/bootparam.h index f57ff850bcb..4418c78d5bb 100644 --- a/hw/xtensa/bootparam.h +++ b/hw/xtensa/bootparam.h @@ -2,6 +2,7 @@ #define HW_XTENSA_BOOTPARAM_H #include "exec/cpu-common.h" +#include "exec/tswap.h" #define BP_TAG_COMMAND_LINE 0x1001 /* command line (0-terminated string)*/ #define BP_TAG_INITRD 0x1002 /* ramdisk addr and size (bp_meminfo) */ diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c index 398e6256e1d..2e264c61988 100644 --- a/hw/xtensa/xtfpga.c +++ b/hw/xtensa/xtfpga.c @@ -35,6 +35,7 @@ #include "hw/qdev-properties.h" #include "elf.h" #include "exec/memory.h" +#include "exec/tswap.h" #include "hw/char/serial-mm.h" #include "net/net.h" #include "hw/sysbus.h" From patchwork Wed Dec 11 23:03:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 2021743 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=e69AEBB2; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Y7rp52W9hz1yS4 for ; Thu, 12 Dec 2024 10:06:53 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLVlL-0003ZE-Id; Wed, 11 Dec 2024 18:04:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLVlB-0003MV-Ha for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:51 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLVlA-0002GQ-3f for qemu-ppc@nongnu.org; Wed, 11 Dec 2024 18:04:49 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-43618283dedso19686695e9.3 for ; Wed, 11 Dec 2024 15:04:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733958287; x=1734563087; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Mtq+tz8nJw6Nv1owIoGgw4Z1D4TMY45KGCnnPE+QKMo=; b=e69AEBB2j0CM1riQyst3VbzaBHFRmMXwAoSEUbAWzwSa3T1+aThqoerH802ElCuxgt jRnu7/TtE61Zad+tCwt3iS8BPinKKyyPj/jgUtnQJ+GJU9ZuKAtVbdHWSb/K2QqlgpAf ydeTkrqACOHG6Z2lrDRFsT7H8RVFYmHuasDjelkLb2e/b9m5efPFph2i677PsJocJzO8 0LL+TT+g95ulagZo3rX6ICzTkv56hjMR3lot0s5jxjlDkmdU/R4o53JpGPXqFWjf3zlw z5sTA0ifUFXqoCPc3OY1mtr+SgbcU8W/zfMdB+tKyk+QulH3/ZVQieDc0i0TPhrqxvFl bekQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733958287; x=1734563087; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mtq+tz8nJw6Nv1owIoGgw4Z1D4TMY45KGCnnPE+QKMo=; b=I9RiwlL0/q9XvbMmLUq+wvrWMJHSoebaXbyYf79+l1sTaR5IjutURu4513shZRpP4O EHTJF+yc4UiGlhXV+MebJ5z02DGj66XKcq2KJw9V+Nufth43jJ0olGrnqgDz6h2sl8rZ ZAyngFuxB3WyRBA57WnQhzohIyZIAEdsjc9+5zHsLi9tFskd1miQB9dp+WFJ8+ToAIV0 PwHy+Y6Yg1ul6HKxfGb7tVOzBIUJqy0ENsG9VuZD1KShueiWo4608GnK33iZcLBLwGvu ZPJn4DNLif6Sv6RmVkgxmlXtm9w/+8BtuJXOQQQKjWwk8tki968pS1zd9NH3IXQE6Bd7 ojPw== X-Forwarded-Encrypted: i=1; AJvYcCVGP4nMDjSv0BFCiDla2Yzf1wRTUGouJWnnkJJn1dqLMoFc0IbMqwOOTOEZHKG3IZClG2Tyt7YSCg==@nongnu.org X-Gm-Message-State: AOJu0Yy7KH/nJ7dKBfzZXZPaAuxkYzY0IIMqn4IVrBFCIIbm38nMA+pB RPm6xbNB8xTKvLIHnH/2lnysly/+VJNBZeJQP27qgr0Z4gROmaPz0EwTsV0ii7I= X-Gm-Gg: ASbGncvD8whk23Ua2m2B/vyrdknD2EzTqFl0eYZorU/KckTr7BJGyayMvPVYi5pNQCD +ttqyDGuGvH5EMMZkycEx5FqLHd2z662PDxJzURP5vR/+0tf8iTDum72bbxje07VXI2QPgusKHC 40p+xsoxR5wQ9N5ySU5OpZQKNsqoA0SfxbnPO7rZzunp9eop6CNpby0vmyGoJa+GNcrifLvDNrU 7LfT9tz0PS0mEX7DEuz0KCvKOaSxY+1R8HRKqWrrIFQdRRi+gPJ//DLLeAKRO+y6jNl+hHeAUBt QOmNZgNi6L05AyKoNGCW6C+tjfj6v+PPLQ== X-Google-Smtp-Source: AGHT+IHNxoMS7H787UzGLl1ddjWHHJT87JIsbwguE/8eCzKLWmLYd0do9HUUbufvmwY4IUU4fI9C9w== X-Received: by 2002:a05:600c:4e50:b0:431:44f6:566f with SMTP id 5b1f17b1804b1-4362282e1d9mr11425275e9.13.1733958286646; Wed, 11 Dec 2024 15:04:46 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4362429d2b7sm2433615e9.32.2024.12.11.15.04.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 11 Dec 2024 15:04:46 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-ppc@nongnu.org, qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 9/9] exec/cpu-all: Do not include 'exec/tswap.h' header Date: Thu, 12 Dec 2024 00:03:57 +0100 Message-ID: <20241211230357.97036-10-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241211230357.97036-1-philmd@linaro.org> References: <20241211230357.97036-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-ppc@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Nothing in "exec/cpu-all.h" requires "exec/tswap.h" declarations. Remove it to reduce headers preprocessing and poisonned target definitions polution. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- include/exec/cpu-all.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index 45e66769380..b45defdbf43 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -22,7 +22,6 @@ #include "exec/page-protection.h" #include "exec/cpu-common.h" #include "exec/memory.h" -#include "exec/tswap.h" #include "hw/core/cpu.h" /* some important defines: