From patchwork Thu Nov 14 10:52:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eikansh Gupta X-Patchwork-Id: 2011237 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=m5IsWuWH; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xpxx62czWz1xxN for ; Thu, 14 Nov 2024 21:59:22 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 709FA3858C66 for ; Thu, 14 Nov 2024 10:59:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 709FA3858C66 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=m5IsWuWH X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by sourceware.org (Postfix) with ESMTPS id C25443858D28 for ; Thu, 14 Nov 2024 10:53:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C25443858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C25443858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1731581595; cv=none; b=bDpcXRQpv7L6a20F0K+Q6ohWu8le7qMbaK16rcQq3ZsQ+1s1I4ZuTrFKJTuwokuM8LZk7RGs1uEJhk7MkIqLK+ecluH1M7pu4DOgLwaBcKUY2DwaT38wgyMNokS1jKyF2kllw9LcZnlRU9ECYj7Hun5BCnQ2kRjkRQ20K1aohLo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1731581595; c=relaxed/simple; bh=xtrF6QAfJ0cU0dhvXw2K8xTr3KkL5QX/HISLGKsK59o=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=T1kKjWhlvOQF0qyoBHmc0x1LTIMmSYA3REYXS4bN/JcB4V50WXJ3QV47omYVkwU3fTNd0DapIx+md3BMeM65jHpGD1eTeELQ2hVf2XuD20g/g31uubFO37MSh73uStzx9S6iGo20ijKAqfUMQ4cCFzGc3lwSPb5bNyWx3PdKtYU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C25443858D28 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AE9xrBN030322 for ; Thu, 14 Nov 2024 10:53:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:message-id:mime-version:subject:to; s= qcppdkim1; bh=J+zo4+1UI0lOLGb8PVz+t0P9Dy88ZFW9EJ1wxFT5efk=; b=m5 IsWuWHJCLIDf3q6JowHttuxBzCN2DACjELXfJ5CRPfgOSuP+lkDQ0GWkVRuZZEdp O+SL2mC6Gmlyu+YEI5wQYKBjEkWChQJVH0oz4Hy/Gff9mYmQv6LhCVGnWIOiScWZ YOJXWCUAYmtTe7OVMWesAQppu9OlQSnlKuzAQxWeMmzkRQeEHPB0YcZ3b5Jlhtk9 FeDhQFHUrqUsZ/HNA6249ceqzR7/P3cJltMZtg83nIcr4zJPJFitpEZOAMQP+05e uG37RVfKcRJPD2gwW2ZKbEfEFpjhJ1zZa2y+4RIr4EHkUQy7HgOITEGmLXKTxdzU QKWw5EeTjt0Y4WXlQcOA== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42w66gthgq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 14 Nov 2024 10:53:14 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4AEArDss001098 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 14 Nov 2024 10:53:13 GMT Received: from hu-eikagupt-hyd.qualcomm.com (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 14 Nov 2024 02:53:12 -0800 From: Eikansh Gupta To: CC: Eikansh Gupta Subject: [PATCH v3] MATCH: Simplify `(trunc)copysign ((extend)x, CST)` to `copysign (x, -1.0/1.0)` [PR112472] Date: Thu, 14 Nov 2024 16:22:57 +0530 Message-ID: <20241114105257.18813-1-quic_eikagupt@quicinc.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 6th5PuNZOFeTS3QtTnmrqkRVmVkHRImK X-Proofpoint-ORIG-GUID: 6th5PuNZOFeTS3QtTnmrqkRVmVkHRImK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=995 mlxscore=0 malwarescore=0 suspectscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411140084 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org This patch simplify `(trunc)copysign ((extend)x, CST)` to `copysign (x, -1.0/1.0)` depending on the sign of CST. Previously, it was simplified to `copysign (x, CST)`. It can be optimized as the sign of the CST matters, not the value. The patch also simplify `(trunc)abs (extend x)` to `abs (x)`. PR tree-optimization/112472 gcc/ChangeLog: * match.pd ((trunc)copysign ((extend)x, -CST) --> copysign (x, -1.0)): New pattern. ((trunc)abs (extend x) --> abs (x)): New pattern. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/pr112472.c: New test. Signed-off-by: Eikansh Gupta --- gcc/match.pd | 25 +++++++++++++++++++----- gcc/testsuite/gcc.dg/tree-ssa/pr112472.c | 22 +++++++++++++++++++++ 2 files changed, 42 insertions(+), 5 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/pr112472.c diff --git a/gcc/match.pd b/gcc/match.pd index 00988241348..5b930beb418 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -8854,19 +8854,34 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) type, OPTIMIZE_FOR_BOTH)) (tos @0)))) -/* Simplify (trunc)copysign ((extend)x, (extend)y) to copysignf (x, y), - x,y is float value, similar for _Float16/double. */ +/* Simplify (trunc)copysign ((extend)x, (extend)y) to copysignf (x, y) and + simplify (trunc)copysign ((extend)x, CST) to copysign (x, -1.0/1.0). + x,y is float value, similar for _Float16/double. */ (for copysigns (COPYSIGN_ALL) (simplify - (convert (copysigns (convert@2 @0) (convert @1))) + (convert (copysigns (convert@2 @0) (convert2? @1))) (if (optimize && !HONOR_SNANS (@2) && types_match (type, TREE_TYPE (@0)) - && types_match (type, TREE_TYPE (@1)) && TYPE_PRECISION (type) < TYPE_PRECISION (TREE_TYPE (@2)) && direct_internal_fn_supported_p (IFN_COPYSIGN, type, OPTIMIZE_FOR_BOTH)) - (IFN_COPYSIGN @0 @1)))) + (if (TREE_CODE (@1) == REAL_CST) + (if (REAL_VALUE_NEGATIVE (TREE_REAL_CST (@1))) + (IFN_COPYSIGN @0 { build_minus_one_cst (type); }) + (IFN_COPYSIGN @0 { build_one_cst (type); })) + (if (types_match (type, TREE_TYPE (@1))) + (IFN_COPYSIGN @0 @1)))))) + +/* (trunc)abs (extend x) --> abs (x) + x is a float value */ +(simplify + (convert (abs (convert@1 @0))) + (if (optimize + && !HONOR_SNANS (@1) + && types_match (type, TREE_TYPE (@0)) + && TYPE_PRECISION (type) < TYPE_PRECISION (TREE_TYPE (@1))) + (abs @0))) (for froms (BUILT_IN_FMAF BUILT_IN_FMA BUILT_IN_FMAL) tos (IFN_FMA IFN_FMA IFN_FMA) diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr112472.c b/gcc/testsuite/gcc.dg/tree-ssa/pr112472.c new file mode 100644 index 00000000000..8f97278ffe8 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr112472.c @@ -0,0 +1,22 @@ +/* PR tree-optimization/109878 */ +/* { dg-do compile } */ +/* { dg-options "-O1 -fdump-tree-optimized" } */ + +/* Optimized to .COPYSIGN(a, -1.0e+0) */ +float f(float a) +{ + return (float)__builtin_copysign(a, -3.0); +} + +/* This gets converted to (float) abs((double) a) + With the patch it is optimized to abs(a) */ +float f2(float a) +{ + return (float)__builtin_copysign(a, 5.0); +} + +/* { dg-final { scan-tree-dump-not "= __builtin_copysign" "optimized" } } */ +/* { dg-final { scan-tree-dump-not " double " "optimized" { target ifn_copysign } } } */ +/* { dg-final { scan-tree-dump-times ".COPYSIGN" 1 "optimized" { target ifn_copysign } } } */ +/* { dg-final { scan-tree-dump-times "-1.0e\\+0" 1 "optimized" { target ifn_copysign } } } */ +/* { dg-final { scan-tree-dump-times " ABS_EXPR " 1 "optimized" { target ifn_copysign } } } */