From patchwork Thu Nov 7 02:31:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: DJ Delorie X-Patchwork-Id: 2007813 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FSAcWWA+; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XkR152lXYz1xxq for ; Thu, 7 Nov 2024 13:32:09 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3F3413858D3C for ; Thu, 7 Nov 2024 02:32:07 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id C51363858D20 for ; Thu, 7 Nov 2024 02:31:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C51363858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C51363858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730946703; cv=none; b=r+G7BGO04f8RSO1TVY7RTXHxniFbGW4u5xlDXfG7XA5wBQVDShq5skE2EFWOIEGKbFVGMRtgYGd+2GhpbsvbOtyyObIcQLBey1c8x2TP3xh23xndW3CdJiJl0fBQVLhVGiiZObIh/8bwzp4OFuoEi/hXQ4Q0eTWbjrJvZ1biXgg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730946703; c=relaxed/simple; bh=guBcF7Qytxa68aByZ0GwGlwQXEzmafPqoMf5sf2cPGw=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=WNpVAcvnyJiDuRe+Yr2lKALDosKj78tGUXnc/5AgAvpP7AXn2sM5Jx01KrZuvQp1sOygfjxZvJpWSuJzR7yntcS6YiD5HdBUZ4Q+KRzG0bhUHYMS2nzmjBVH/FmS25d4xPgdbr/IjWR4efTb1a2t73u1VSQdIyMbU8Jxvva/CqU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730946701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:content-type:content-type; bh=eMs0T9aPJps2ZBAeorZwywLoG6kRv2S6KzGjeJQZFWI=; b=FSAcWWA+vgtz1ohMRjJhCURH8q4UiPdHXycLCRgPFrh/M44+APGBdA/u4I+VzPMpJ+R3kK 0KixUMcDFk05QRZvYGA2Q6MZ0BQxD7kCi72MrergEo6GFpBjKPc4rqAyFsL9T//S/kba7Y XU3xuJBRhMdJLKoKTSuTduhiY4Lgdg4= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-bbaLuszjP-CVVKjmOclAQA-1; Wed, 06 Nov 2024 21:31:40 -0500 X-MC-Unique: bbaLuszjP-CVVKjmOclAQA-1 X-Mimecast-MFC-AGG-ID: bbaLuszjP-CVVKjmOclAQA Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 874EC19560BE for ; Thu, 7 Nov 2024 02:31:39 +0000 (UTC) Received: from greed.delorie.com (unknown [10.22.88.52]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 295861955F41 for ; Thu, 7 Nov 2024 02:31:39 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.16.1/8.16.1) with ESMTP id 4A72Vbnt1320811 for ; Wed, 6 Nov 2024 21:31:37 -0500 Date: Wed, 06 Nov 2024 21:31:37 -0500 Message-Id: From: DJ Delorie To: libc-alpha@sourceware.org Subject: locale: use memmove for potentially overlapping data X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YgfPRj8_c-JWGHmq2ngMS6KenKbkWMW0g6i6Wi4Dv_M_1730946699 X-Mimecast-Originator: redhat.com X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org While this may happen to work for current glibc, it's bad practice. Use memmove instead of memcpy just in case, and because it's more correct. diff --git a/locale/programs/md5.c b/locale/programs/md5.c index 753b91e9a8..f198223656 100644 --- a/locale/programs/md5.c +++ b/locale/programs/md5.c @@ -170,7 +170,7 @@ __md5_process_bytes (const void *buffer, size_t len, struct md5_ctx *ctx) { __md5_process_block (ctx->buffer, 64, ctx); left_over -= 64; - memcpy (ctx->buffer, &ctx->buffer[64], left_over); + memmove (ctx->buffer, &ctx->buffer[64], left_over); } ctx->buflen = left_over; }