From patchwork Thu Oct 3 02:39:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam James X-Patchwork-Id: 1992210 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XJwts6K40z1xtk for ; Thu, 3 Oct 2024 12:42:13 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9541538650FD for ; Thu, 3 Oct 2024 02:42:10 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id ABC093858C48 for ; Thu, 3 Oct 2024 02:40:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ABC093858C48 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ABC093858C48 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727923261; cv=none; b=kFSxpmULJNheiyoSyLbF/OORTsZaNq6CRCWGz76v5MsSwDeUVC5UCk/wqimiTd7Sw/jnucDQXj+Vv+AV7fXYxz5kZlPr1N8uIdtG2v76h2hcQaMLS0DbeRQ6J1aD0AMT6tRX9Pi8W5YSLs7zcEd+qL2WTnkplunHbs8n0VM/4TE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727923261; c=relaxed/simple; bh=bEai4GAGXmHsru67nELWIHau+er74BgV4CMBFayUgrw=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=p3qFjejKDKyS7SSvKvYzBG2qsU3dQ7rvcXXCiUAMR+Sr+aUsFoSgIwvQE9Wg2THfvX5aXSZOr9b0lYNdP9ew5Jgg35ZxnkFr71u817isXkH7NQJg+oory/PDsRuS1ebqtObf7/F8AxiaRlVRFPwSARdQPl+YbapwISAIWp4p/is= ARC-Authentication-Results: i=1; server2.sourceware.org From: Sam James To: gcc-patches@gcc.gnu.org Cc: Sam James Subject: [PATCH 1/2] gcc: make Valgrind errors fatal during bootstrap Date: Thu, 3 Oct 2024 03:39:32 +0100 Message-ID: <2408cb8d5bd12befb566b0e96056df6bd62a33a8.1727923173.git.sam@gentoo.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Valgrind doesn't error out by default which means bootstrap issues like in PR116945 can easily be missed: pass --exit-errorcode=1 to handle this. While here, also set --trace-children=yes to cover child processes of tools invoked during the build. Note that this only handles tools invoke during the build, it doesn't cover everything that --enable-checking=valgrind does. gcc/ChangeLog: PR other/116945 PR other/116947 * configure: Regenerate. * configure.ac (valgrind_cmd): Pass additional options. --- gcc/configure | 2 +- gcc/configure.ac | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/configure b/gcc/configure index 5acc42c1e4d9..0a999e609c92 100755 --- a/gcc/configure +++ b/gcc/configure @@ -7751,7 +7751,7 @@ fi as_fn_error $? "*** Cannot find valgrind" "$LINENO" 5 fi valgrind_path_defines=-DVALGRIND_PATH='\"'$valgrind_path'\"' - valgrind_command="$valgrind_path -q" + valgrind_command="$valgrind_path --trace-children=yes --error-exitcode=1 -q" $as_echo "#define ENABLE_VALGRIND_CHECKING 1" >>confdefs.h diff --git a/gcc/configure.ac b/gcc/configure.ac index 23f4884eff9e..9c52061c981c 100644 --- a/gcc/configure.ac +++ b/gcc/configure.ac @@ -781,7 +781,7 @@ if test x$ac_valgrind_checking != x ; then AC_MSG_ERROR([*** Cannot find valgrind]) fi valgrind_path_defines=-DVALGRIND_PATH='\"'$valgrind_path'\"' - valgrind_command="$valgrind_path -q" + valgrind_command="$valgrind_path --trace-children=yes --error-exitcode=1 -q" AC_DEFINE(ENABLE_VALGRIND_CHECKING, 1, [Define if you want to run subprograms and generated programs through valgrind (a memory checker). This is extremely expensive.]) From patchwork Thu Oct 3 02:39:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam James X-Patchwork-Id: 1992211 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XJwv74CFpz1xtk for ; Thu, 3 Oct 2024 12:42:27 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 54D5A386544D for ; Thu, 3 Oct 2024 02:42:22 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id AA857385828B for ; Thu, 3 Oct 2024 02:40:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA857385828B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AA857385828B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727923261; cv=none; b=nCWiFfLb14IBGWZI62jFS08/2DuBCg8nmxknPIKcI9NsbJ4QgaCSTfyY+Ig/p1fGDXEUucaltZYSpkNy2pXCHWArQ0Zse1FdBFM3Z2mCS0ek84zAGzwMXCG43aUB5pbenHZ3XRof2ReCQvzlr5wDfD+gtV5voDzSZ2yrvgDonqE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727923261; c=relaxed/simple; bh=VFc66qLx/GfEETZH6ZEOrkeRV2BwJO7JIRk7/v0PeLI=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=EOl+IQVp9OBWvuCNVBLvt1RBdl5xIWySgQzUnGj/RrydE4FOFRnqdEo/A4WfvSsAQmfAgd1R3CD28rckrNHpdr44uss4PE0C3oG5KbujrNchqNEiekwsHRAmhPdNUJy6kNgZN7KMbGpUn5I0sqHJaliRpoTuo7/MUbMFAQdpIIQ= ARC-Authentication-Results: i=1; server2.sourceware.org From: Sam James To: gcc-patches@gcc.gnu.org Cc: Sam James Subject: [PATCH 2/2] gcc: make Valgrind errors fatal with --enable-checking=valgrind Date: Thu, 3 Oct 2024 03:39:33 +0100 Message-ID: X-Mailer: git-send-email 2.46.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Valgrind doesn't error out by default which means bootstrap issues like in PR116945 can easily be missed: pass --exit-errorcode=1 to handle this. gcc/ChangeLog: PR other/116945 PR other/116947 * gcc.cc (execute): Pass --error-exitcode=2 to Valgrind. --- gcc/gcc.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gcc/gcc.cc b/gcc/gcc.cc index 16fed46fb35f..cb3c0be77d31 100644 --- a/gcc/gcc.cc +++ b/gcc/gcc.cc @@ -3402,12 +3402,13 @@ execute (void) for (argc = 0; commands[i].argv[argc] != NULL; argc++) ; - argv = XALLOCAVEC (const char *, argc + 3); + argv = XALLOCAVEC (const char *, argc + 4); argv[0] = VALGRIND_PATH; argv[1] = "-q"; - for (j = 2; j < argc + 2; j++) - argv[j] = commands[i].argv[j - 2]; + argv[2] = "--error-exitcode=1"; + for (j = 3; j < argc + 3; j++) + argv[j] = commands[i].argv[j - 3]; argv[j] = NULL; commands[i].argv = argv;