From patchwork Wed Oct 2 13:28:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1992017 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qwIcfxWj; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Po9lZuwH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qwIcfxWj; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Po9lZuwH; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XJbHn5Vpfz1xtY for ; Wed, 2 Oct 2024 23:29:09 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8CFD0385B50B for ; Wed, 2 Oct 2024 13:29:07 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 25AD83858424 for ; Wed, 2 Oct 2024 13:28:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25AD83858424 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 25AD83858424 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727875729; cv=none; b=bsgSH9UIx8qJ09+OBCJ/xEJr2d986/ZE0CLlNhH0h9+qRKuyrQoknpqijLZcX7WUmdtS1doewqYT2e2onLKKSnCbQcTgyNfK59Q1qE+2pYZrQzKAqmAJg8184APo1gj+QF+SKOBjLbIuEZ1aRKDgttffPwbm+7mmoQSMz4P+iCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727875729; c=relaxed/simple; bh=DZw6m+mcRQrlEQyySxqI+nsAU+dJDivfU9Q4jF6SoWo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=JjOUJmfhM4RwPSZ/g0E/ziNEaArzmtenbZEAcdm08Dv8lS+C81a0EY1A5GgoVRxRiniCB53hndzKgtWKao+r1wEs5fr+ZiNxKsCHEqNfdgxNJ0Kng5jmMDMsgK/ZO2hxtHXyipV/UVbQ0n5MN2W5ToMW7vFy4+j0M2SJjK9J+Lc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from murzim.nue2.suse.org (unknown [10.168.4.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2EDBF21BB5; Wed, 2 Oct 2024 13:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1727875727; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=LSnn0DMqGzWJJAUR4KXgJJSHZy2U9rHvBx5TpCZ9ePc=; b=qwIcfxWj02/qstbDNtt4Jk7bCqutGGdKuXFC4Q4upZPZLMwborxQt1n6ik12gs/ID9q8Tc EC+3dx2vr7WNJ75U8BJeUL1B0pD+R4Wkx8zy5JK4oaRtfIkH3ok46Y1uB4GbZxds8/qACV /5KbU+/6L/Exi0NlvQ2PaEm+n5YabXE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1727875727; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=LSnn0DMqGzWJJAUR4KXgJJSHZy2U9rHvBx5TpCZ9ePc=; b=Po9lZuwHuGYFKi/FDalVCNsKgFl5LfoWoV+kWLGhf1ACc7tkxD8sO4WWoyRF/UdlsU7osY eTXaLIG0Ho2TXLCw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1727875727; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=LSnn0DMqGzWJJAUR4KXgJJSHZy2U9rHvBx5TpCZ9ePc=; b=qwIcfxWj02/qstbDNtt4Jk7bCqutGGdKuXFC4Q4upZPZLMwborxQt1n6ik12gs/ID9q8Tc EC+3dx2vr7WNJ75U8BJeUL1B0pD+R4Wkx8zy5JK4oaRtfIkH3ok46Y1uB4GbZxds8/qACV /5KbU+/6L/Exi0NlvQ2PaEm+n5YabXE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1727875727; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=LSnn0DMqGzWJJAUR4KXgJJSHZy2U9rHvBx5TpCZ9ePc=; b=Po9lZuwHuGYFKi/FDalVCNsKgFl5LfoWoV+kWLGhf1ACc7tkxD8sO4WWoyRF/UdlsU7osY eTXaLIG0Ho2TXLCw== Date: Wed, 2 Oct 2024 15:28:47 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: jason@redhat.com Subject: [PATCH] Replace another missed iterative_hash_object MIME-Version: 1.0 X-Spam-Level: X-Spamd-Result: default: False [-1.49 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-0.73)[-0.730]; NEURAL_HAM_SHORT(-0.16)[-0.794]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_NONE(0.00)[]; MIME_TRACE(0.00)[0:+] X-Spam-Score: -1.49 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Message-Id: <20241002132907.8CFD0385B50B@sourceware.org> I missed one that's actually hit quite a lot, hashing of the canonical type TYPE_HASH. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed as obvious after the previous approval. Richard. * pt.cc (iterative_hash_template_arg): Use iterative_hash_hashval_t to hash TYPE_HASH. --- gcc/cp/pt.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/cp/pt.cc b/gcc/cp/pt.cc index 04f0a1d5fff..20affcd65a2 100644 --- a/gcc/cp/pt.cc +++ b/gcc/cp/pt.cc @@ -1936,7 +1936,7 @@ iterative_hash_template_arg (tree arg, hashval_t val) default: if (tree canonical = TYPE_CANONICAL (arg)) - val = iterative_hash_object (TYPE_HASH (canonical), val); + val = iterative_hash_hashval_t (TYPE_HASH (canonical), val); else if (tree ti = TYPE_TEMPLATE_INFO (arg)) { val = iterative_hash_template_arg (TI_TEMPLATE (ti), val);