From patchwork Tue Oct 1 23:00:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Kshevetskiy X-Patchwork-Id: 1991741 X-Patchwork-Delegate: dario.binacchi@amarulasolutions.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=iopsys.eu header.i=@iopsys.eu header.a=rsa-sha256 header.s=selector2 header.b=Cpk8YhuC; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XJD1h4GLKz1xsc for ; Wed, 2 Oct 2024 09:00:40 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5767D88ED8; Wed, 2 Oct 2024 01:00:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=iopsys.eu header.i=@iopsys.eu header.b="Cpk8YhuC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5B90C88975; Wed, 2 Oct 2024 01:00:25 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20700.outbound.protection.outlook.com [IPv6:2a01:111:f403:2613::700]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9F56B88E1D for ; Wed, 2 Oct 2024 01:00:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mikhail.kshevetskiy@genexis.eu ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=x2m9OaikvBEzDWB8esDeCvSVtviGKQsYW4PUVvWfXBftT7a4ieNMcZdNe4liAJPiMDdoWw1KNC7GLZVLnJFwy3lCvf4+ozu0ccYITq823qmLWLD91uYP9G/bUcdMiT99/aldXdXuDh7STMtu9++lhLSwpkzfN7HCifBHRT8k/p1mef/NGyellr43kPL/DMPFFaL+q94qEAgZEW9gjHGdt2gXJmcxjcKpj/5FjWg/Ub7x2wFNCyobzdKpOlubgjjYkowhT1eiTFoPm6qA5q8/iMrlr0ySVg/ZghDHy52UUYhiSRpaAa8CUc9yb1wNnXYukRg7COCnye2854y5h4d3VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gNgibGLWuOhXjAV7gStf3yF/e8WXthdlDYtyWpMTogc=; b=KI9Zmi4dw7a15OKx+N10cFeuuNMc5r56SGz2/J85KA11Z5cpnNNbPHI5UsIaIMLhuwxGT4enxsoFgHcpSUBxCbo/6cug0J+D190tXjV+sgN4/VuQLwGbIf36gW3M+ay2fCudtYMATAVehU28/LR943LSvkRLNVwg2oQLkLwu9TjLyPkhZXGeiGwb719EXoIAqfQ7bQcqMbGXZuGQcPwKCuTeO7bC4uPzZmEFaqSiM37fqpGJIGWy/2nazRpMuvFJdlAuT6YlbnnHz8jtBlxwVq9O1Tt44eZVvCMV3YA3T11wSXERfchDpE6z5BbNrU+/jY/Cir5ylogwHaYF9fuXNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gNgibGLWuOhXjAV7gStf3yF/e8WXthdlDYtyWpMTogc=; b=Cpk8YhuCQ3a+Zu/NKftoVZYLuB7h5sg7SUm29BBWUm6Qi5vaeIWwBj5ZKCh9OcZmWF0q7R0dM3sD1KaO1O7t853qzzuvTW/2+C8EziYFhRCnp+w+kkJJ/7yFKgt6fDu65ABfD6p7BoQKF+YgUnbVJXwEVr60aTGQTR95yfwC1SrmP5VwtsMHoFKsGe2TfS7fiq0gc5us2V1BQMDyjY7LiO6TmFt8jKrOorYhuaqzDVJ5tJJaCvzn+MNka0tVvqEOj/6u1YZkautobDxmI1wbxlBB+oTJal+zWhN4vvfGnbDK+Q4tRuWs86Iyj7vQEzURdvGDSSAbXT0Soe97WyeCEA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by PA4PR08MB6271.eurprd08.prod.outlook.com (2603:10a6:102:eb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.15; Tue, 1 Oct 2024 23:00:19 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%2]) with mapi id 15.20.8026.014; Tue, 1 Oct 2024 23:00:19 +0000 From: Mikhail Kshevetskiy To: Tom Rini , Simon Glass , Mattijs Korpershoek , AKASHI Takahiro , Heinrich Schuchardt , Mikhail Kshevetskiy , Marek Vasut , Dario Binacchi , Arseniy Krasnov , Miquel Raynal , u-boot@lists.denx.de Subject: [PATCH v3 1/3] cmd: mtd: add markbad command support Date: Wed, 2 Oct 2024 02:00:09 +0300 Message-ID: <20241001230011.954429-2-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241001230011.954429-1-mikhail.kshevetskiy@iopsys.eu> References: <20241001230011.954429-1-mikhail.kshevetskiy@iopsys.eu> X-ClientProxiedBy: GV3PEPF00002BBE.SWEP280.PROD.OUTLOOK.COM (2603:10a6:144:1:0:6:0:10) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|PA4PR08MB6271:EE_ X-MS-Office365-Filtering-Correlation-Id: 420c8650-ebbd-438f-261a-08dce26cd260 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|376014|366016|52116014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: ZZGCOvkCCNdW7RmID6e3JE8vF/9IZ9ykl0yCM8WEvyrQL99bJS/NHdkBCZ6FSbT3uLVyi+XMCUcxz1h2RvU+RT1M2FHwXoCuHMrMVzFAOmnrO0XxNbC32LsB7gEL31y3NiE3cbjGtWWkU1UZKFfsFyJSb1WVgbO386LRfPkbQygKu01ivc6NxCIoO47c3geS9FFtpY0Aqt8TcVQp2YhcDziSG7Y9K9MJBjy1tG1GpVOrF5ZMjQ5SUuIpfr2/eUPVk1N9dYEMGIbcmykIaJjr2jvmScf2qEPh6ck7WLAt8pNNXY+KUw/w5hxLLyz1lIkKzDlNsRf5OVSYDplFxGJHS4hxpd33MrC80bqNBgBqFVLgig9ktDKfks6JC8FIJ7Jws1FuoQ4zsJc4g1oV8UiYy/gBMJj0YvXeYy3Xw+8LJ6f/rvE0esajJTmJxcYDkP3Rf3ZrAP2I/NoFtB1BBEyYtwhs6qbb2M+UYqFFlxvzShguc9xCXdlik7PyTQdl2oPdNmxInh+pKIuSO4WOy+a8gk4Zhx494d+UU1GXpRdnSL2R1xZXGkVkkXWp5PojSdUU8YyQP3BmTTLlKax3hH00BcXhbZgtoByas5D+Z166vvDAsp5+vms2tl1nOUP758jnPiWh9z8gH5cQeTMnWcUi8G3hOLIcJSMDbxGd74d964TYV9RFrUv2G0MrMFD1JEW7qpAf53ELZ7KtU5B1FRCyGcpChBEGPln8hOh3bysXXtbswOCNDFHnlh18wzLH3LKDPLBy35a1WAOlcq0RTwV7+0Y7gzXEJmYUrQkhaWPuWotiC6Jatfn+nCDMZTcQoC80kzsVir7+xpMgHc84kOVdVTuOd3TI3l9wTS8riBCHNMXCQBToDiCr+CWxOfjRJB2PaUXY5cCKDJuNCTJ0/K1LgnAbyKFN4p8KX5tL/cMVPQbBCJqEOPV700PivcjCru655bQdnZAw6H0GSDiQWFv4uE1yO9kmyOMYdenOmy5yyvWBW1rzQU3pdUnTWnXo438KF58aENvVbitItbrZrbx4MwK/SRN/Cc1U2jfIkCNx1UXspSRqFAF0L+Xqk5ehbu6/RiFM0aeYn9no8MTqa8ef7Hiomxio6GCEqOOkURMfiXud/aDJbvtG1KOcq6wMjnZhKfOovO8auOU0wvS6DYYKLcp2X31V9b7Eur3xK2JhKEpzLG/wicXPYG0lOMOnggTVsNV+4JSMu0qjj7oyfmfveJRMiv1dw7AWcR/ykmzHHhwUkTs/LoNnAEDEqPHihz/6KDrwyNp4pzBm1oGwVuq9CMJ2LxqzuAkLygbp7RpRvuHM0dqCdkSevDBPF1BtT2BD2fkR5ClVFKv09bQ9Ml9MNEt3fWmKRP+eHBFq+vS/9xs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:GV2PR08MB8121.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(376014)(366016)(52116014)(1800799024)(921020)(38350700014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: igiEH4ERYIm7eG7EHPRxXzp4LNeGbMSCBcst+iYX6GhdH4hJFdC70tB6JLLE4ZYlCefsWdRFhXYkykGlKNoDonfQ8XNeZ4ipX/fGUZohfIPMMTwOfTfhYBKCuuJaiWW7NmESJhPZUwH71pQLASE1kvzYMCofQvX6hRtJeW1fgQmE0hjkU31IgBalNkwuiVNe+vD+x+8RrDlafopVQRng+wz76QU7FpRmOl9BpVf/4PGslQ5EX7NAimolxfCfe11W2RJPSQkGCp3HJBZiZ34CHdI8LSHDXGyu8KlntfnS1mVLDjpJ/GRyxdjjHWCFATWORGVo1eHCfDb6xJdoZhL5wGiz5DzjxJ+wcOwhep56IOh5HH+oJnvjBT05+yTMH0bzHMkxnvZ+64MFS+25FXJKG3ZMgYasAfpFuOEB2fhG+pX7rocMS4eIo06we7ymyujyPmavtb9Go30UgIvpx2saX29W4NpuBWzqqR97XTmj+cNKdiX4E3Skrnfw/FjWeP1J648usIYk+FZqg7ETMjpy1QykMZEDzmolkiNas6IbF6FrIf+bIL9bd+1z9TbhMcUgBJUgvqP6s/0hveYZswgMGF4Rn9k2sB4cg3Kke6BJZNC7H0WeVkw0579N8fnh3t7jrdu9FUTM2vguv41r9Uj0ZqtmVs+34PMg7WVLPZWZaF1mKFIiQn7BFjopSywscFRzlfOxz8as1h5xHUQC7q/xGJoj1TqP/oYLASgc7OopMJgiLNxrjewDU7GCiJxpU/UIF1Q6wi0ec00DUPFjYO/CM5Vk+lwlrSYmrj7irLGFo8uvDFwLFFp0pzjjITRMGoh8msZlFmqgwGfc3tZNdq3C1+/+W3XZemPEJ83tMSqOd3CM5moMZ3jI906sqEoJz111t/tsb1b9+JwuZLi47B5JrYq3NKljXRgFnbhObhhWE/XA5MZseSHM4d/7fmrc/7JDGaS7S5aQJDDAQ0qTAMyOP+MZcXDxDJpq/Z8YRyRnRPmrdibpv4X7JmXDf5R3bn7mq0l5jbdYErAPyo9ArShxzSazkbnbZ0tsFi4zvjt47HUOM17jAK5xPZODi39FB6dgG7KV3KpBcZq7jNW9XxA3jqynQSdulmXMa8m6IF0hLbEKbTrSU4o5g/a459q3Wcv8rg5SRFcP2+43tFyeDK8dj1v5o5yBX/PYo+tBPGJXBVOAlQjC3gMsZTSFG9LwnTmt/XQB5+PeQN5vYOABxhh1pf8Ud5D03eZcNoK6FZl7luQqvovbNn3/If4BVdv5tUpIrQYjZsE1sM8f6A396ICzq+6BFYroT5BrE5jnMTDIYy7pfUfo+ojevUp04WeOsZEY3xCKTdYngey5nEpZt0Rc6C/s907L0/tu/gR4cepYpHbBdqmboH9J5lhooyp/6jx1Aq43zxsA47pf0J/qUkh6wqjlaUOFutkxGHwIC/sDrPmJHPUAa2sS1vuBQLs4OuFBnmL5AJS4wTN5vLvyWEL1xWBfm2eUmUjGoIhuVEqWFLhKf7qtl0FBnXGcOAFtMEDBKTGOu4VGwh+CmL26OJWvopFE112l39CZgYSUzxkwrweUKmmhYPFJTMmIABDcEjRhIXro1N+2ZYbccHDaeg040JNF98xBMwHCSbu/BeUByP0= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 420c8650-ebbd-438f-261a-08dce26cd260 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2024 23:00:19.5483 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N9qZWCJ/p25czB8Gbp0x/aZHg5+chbWzRIcvO2iffzhnvCJu/DcdC/pjrLZyW/+HRXVsvOikDwItbXLhpMWPGaEegQ+ODkZ1Vv+RE5J5SO0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6271 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Some nand flashes (like spi-nand one) are registered with mtd subsystem only, thus nand command can't be used to work with such flashes. As result some functionality is missing. This patch implements 'nand markbad' functionality for mtd command. Signed-off-by: Mikhail Kshevetskiy --- cmd/Kconfig | 8 ++++++++ cmd/mtd.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 66 insertions(+) diff --git a/cmd/Kconfig b/cmd/Kconfig index 5ef3c8a8748..e830b731d24 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1449,6 +1449,14 @@ config CMD_MTD_OTP help MTD commands for OTP access. +config CMD_MTD_MARKBAD + bool "mtd markbad" + depends on CMD_MTD + help + MTD markbad command support. + + This is a clone of "nand markbad" command, but for 'mtd' subsystem. + config CMD_MUX bool "mux" depends on MULTIPLEXER diff --git a/cmd/mtd.c b/cmd/mtd.c index 795aaa2b37d..45084d39d3a 100644 --- a/cmd/mtd.c +++ b/cmd/mtd.c @@ -691,6 +691,57 @@ out_put_mtd: return ret; } +#ifdef CONFIG_CMD_MTD_MARKBAD +static int do_mtd_markbad(struct cmd_tbl *cmdtp, int flag, int argc, + char *const argv[]) +{ + struct mtd_info *mtd; + loff_t off; + int ret = 0; + + if (argc < 3) + return CMD_RET_USAGE; + + mtd = get_mtd_by_name(argv[1]); + if (IS_ERR_OR_NULL(mtd)) + return CMD_RET_FAILURE; + + if (!mtd_can_have_bb(mtd)) { + printf("Only NAND-based devices can have bad blocks\n"); + goto out_put_mtd; + } + + argc -= 2; + argv += 2; + while (argc > 0) { + off = hextoul(argv[0], NULL); + if (!mtd_is_aligned_with_block_size(mtd, off)) { + printf("Offset not aligned with a block (0x%x)\n", + mtd->erasesize); + ret = CMD_RET_FAILURE; + goto out_put_mtd; + } + + ret = mtd_block_markbad(mtd, off); + if (ret) { + printf("block 0x%08llx NOT marked as bad! ERROR %d\n", + off, ret); + ret = CMD_RET_FAILURE; + } else { + printf("block 0x%08llx successfully marked as bad\n", + off); + } + --argc; + ++argv; + } + +out_put_mtd: + put_mtd_device(mtd); + + return ret; +} +#endif + static int do_mtd_bad(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) { @@ -773,6 +824,9 @@ U_BOOT_LONGHELP(mtd, "mtd otpwrite \n" "mtd otplock \n" "mtd otpinfo [u|f]\n" +#endif +#ifdef CONFIG_CMD_MTD_MARKBAD + "mtd markbad [ ...]\n" #endif "\n" "With:\n" @@ -807,5 +861,9 @@ U_BOOT_CMD_WITH_SUBCMDS(mtd, "MTD utils", mtd_help_text, mtd_name_complete), U_BOOT_SUBCMD_MKENT_COMPLETE(erase, 4, 0, do_mtd_erase, mtd_name_complete), +#ifdef CONFIG_CMD_MTD_MARKBAD + U_BOOT_SUBCMD_MKENT_COMPLETE(markbad, 20, 0, do_mtd_markbad, + mtd_name_complete), +#endif U_BOOT_SUBCMD_MKENT_COMPLETE(bad, 2, 1, do_mtd_bad, mtd_name_complete)); From patchwork Tue Oct 1 23:00:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Kshevetskiy X-Patchwork-Id: 1991742 X-Patchwork-Delegate: dario.binacchi@amarulasolutions.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=iopsys.eu header.i=@iopsys.eu header.a=rsa-sha256 header.s=selector2 header.b=v/H+LXBZ; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XJD1v49rmz1xsc for ; Wed, 2 Oct 2024 09:00:51 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C323288ECB; Wed, 2 Oct 2024 01:00:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=iopsys.eu header.i=@iopsys.eu header.b="v/H+LXBZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7C74288EE8; Wed, 2 Oct 2024 01:00:26 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20700.outbound.protection.outlook.com [IPv6:2a01:111:f403:2613::700]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B84C988EB7 for ; Wed, 2 Oct 2024 01:00:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mikhail.kshevetskiy@genexis.eu ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jlVW3LcVRMMCOaVqpUg4DFRKJn5WNpCNa416fSb+FIvK4QNJ+FwAgykOb7EmTgnD5J1UjFuD6bDSrmEsdtbOzUi4w6J2A9npExySr01N3G2DOPN3PduS85C+dIkEbgj3QON6aRFD99xD8oI7qYa+nMKkfB3JdgQVLoDNU0GXBtEmI3MntUd9Owskddeb+4QDs3zZy1TtSSV7W2luElu/uuP8NznCsKcn61ebz1LkfiMuLG65WI8Z8pWjbweuCCtVTjTQA/JIkhacBZygHHce/LMHTsAtTSU3IXJq5P5MdjF8te9ZcBFbassLdVwySVljKsqEfUT5rUlTVWO5MBk5uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tDKFWOVsGTrbvCDHPRXcbfSD3JZBxJMCSuTJTRyeNes=; b=o9QILSv9UsjstuqT36FOQWcMTATwOAAzUfd9Ew4p8Pa6N4bcL4Wdb4WVcnOw4tP4kxexSxfrNAP+jYxfdQC3S+YEOJEZXm0IhAZLmAa9hd3LjR54IKRJJbrpBiKJe9GIegcG6CwpMXcepC4A9gmmJR3+ofK5wQNDqiNnf1pvl5Ojq6T7sgylPTaVFpFLQWv2Ujjk8THUH/g6rez3nxiVnlcIorp0m+GkqzjlqslFHleHQ33BY0HT9/J1Hi2/0T0+qddvi24H53jM1jP6p+NCBm0Or2/dB9PuLcqgerqsaqA5oivHUxDc2c2O0pWfGz/llVvwG6bo7+vp6CGhHZAyHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tDKFWOVsGTrbvCDHPRXcbfSD3JZBxJMCSuTJTRyeNes=; b=v/H+LXBZgP9d/NDIq/SBvsxNfvcKCSgRCmfg3uw6GSji2MDo5nWYP/bTEK/EmxJopQPKSPvrkm27HV33g8tKUsKPEzalKiszzdhY80A5eBrVQrnmpGxe00No1q8f4zsy75iPKCUAEWqOUhJ8O0SpjGcoTTiQkNJ+Tw3jnUEFAUKTaY0LbTvha1RfL40+x5sFnZVZBZW+FXzQUCOijjDItQxb9vQ2ZokaDbjqNnRQ+9rmztGdzUkclvo3EUiGKW77scC3VHLqQuRpVb1dkv0Zju3zaber3Ev9wzdVv0MHaW3+J7lRTk+e3t9eRbWcG62vrqoJ1OgkkFh6nOYVfcQadg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by PA4PR08MB6271.eurprd08.prod.outlook.com (2603:10a6:102:eb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.15; Tue, 1 Oct 2024 23:00:20 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%2]) with mapi id 15.20.8026.014; Tue, 1 Oct 2024 23:00:20 +0000 From: Mikhail Kshevetskiy To: Tom Rini , Simon Glass , Mattijs Korpershoek , AKASHI Takahiro , Heinrich Schuchardt , Mikhail Kshevetskiy , Marek Vasut , Dario Binacchi , Arseniy Krasnov , Miquel Raynal , u-boot@lists.denx.de Subject: [PATCH v3 2/3] cmd: mtd: add nand_write_test command support Date: Wed, 2 Oct 2024 02:00:10 +0300 Message-ID: <20241001230011.954429-3-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241001230011.954429-1-mikhail.kshevetskiy@iopsys.eu> References: <20241001230011.954429-1-mikhail.kshevetskiy@iopsys.eu> X-ClientProxiedBy: GV3PEPF00002BBE.SWEP280.PROD.OUTLOOK.COM (2603:10a6:144:1:0:6:0:10) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|PA4PR08MB6271:EE_ X-MS-Office365-Filtering-Correlation-Id: e382399c-665c-4798-813f-08dce26cd2fd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|376014|366016|52116014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: Xtok8ze23MS+bXCCVtd53Rxn2WipLtMiBJwD1NSMB3ogoLCLLOu9YzTdkEFw9/H9wV37AjJYg2GN+pdS12aV6bUELYnVt3Zst07kHOFDrB1LPpNxh6p3iBi0+9bprNuwUUJQGEIHzWsYpP7U/QklLg7HQj/o9Lmm+LLZVa6ospELsXDusIVsxEFRfksYkcYsFTPCwV1HrpL0mkVB0QcrdrG1JZEXfk8qsEV2WI/W+iNyUCdhKoVoXSFBEXBTvC8SgEKzgETTpP8Hc5pbGMBlItfu1ytoYGUt34Ix8d5ARZ2K1+LKdC/fO51YOkn0WdJ7AWKuG2XnsL3px7zscXk2fF0j5cszphEAOQ31btMg0SPPvtZn7fH4zghJR2n7FsWVBbgIJ96/6TskiUcziGMyU5PHZE8ZLlHetizDxfsLEBDX3ZoeURENpxYSIlrg0vcqtdGRk+rdosKWN7JnnTI1zFqFeNGK23XAnMpnhA3Lzu/Q7tlJT3rqaSsqSCTu5AWWUT4KCDqWpRY/6Gc8N0CRyJvXg/J5Z7c9z06GPi2Tq8ZrdBEGBHl0otwnl+CSRzRCiGtq0vmgu6mZ5FMbeW3ojPDKSZ4sesPzevSaSqkZBsgOH0h5UDgbpiFSKgX0thaFNsKBgoFNDxjq8E2stVK7BwkrpvtV/8+XRAXrG8j7Dq5wlfJqju3mNENB0TtPZYwmI6/zT+IG8RtLlDiND5wGo8clLLsWPa7jehc3gtJpS/ecaF8WEtw3uMXbvhi2pbKCDtNPf7XRc5SbZkwokQ612eMliyX5ai+Hw3cRDxmBO7e6FU01iHcGgoEeJqU9edjLTYRrM1TrVQMq8un2Jb7+Ax7C/rlvI/qpzIGj9PxetUEIa9RU0/sqEtFjPZeYYorpcBKzqYCm9QZOuotbUcNIxooZcqgIole25505qydA/p2058g8MQlT/Lf7r0cm48S7E7iL6hJm1DFgcl4wZlhHb3JZpiDxlbZtDGJ6aWH6lqAfiPUnSyDOloHyytkZAhwa+o3A3J6ff/3RmYWyqRZk3nuNgZNI9q+NZC8u+5HQBlVnLbFHV3gnXQjJfE6Ax3uCTeRIFkfKk/ic2nn4Dp8XedS5OvjDBYSv+nrNy19zJH/a0l502GWczf9I5WGjDS8aUIvAykR0saB9BOMw3n0iIb1s3CTjFODPGlsTcr7TuISiAGMwa8r8wwBBG1mH9FpzLKCvQBVnJjJNlDeCejtbEUhWB9J/co85Pcp0eXnicqvfFk5GRQVnt9UzlNpUir98P8SD1b2sU2inypXo4UnAXJME/GF0HhLEvCjKFJKzkZ8FTtxgJdqG9hQhtl033c6AvUREqpdYgA7153WYK+HYxw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:GV2PR08MB8121.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(376014)(366016)(52116014)(1800799024)(921020)(38350700014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +z4SQAN00yac9juo5hxWGd5rLijkx9nQ456jpYcJKrC5ZhlBT2QNhFU5k9+EfO9k2zNAa4jTuWljNo9pdFYDE3RaRB6iw0jmrxfWBrLSM9EC3tURxmXUKyHIw5x57rega7mY7pKxu/qbo6gxZng5HAgjVXArW05pji0YS/kdn7TIeH+BO9jR2VH7kGmKSUXxuP04FXTKKM5rggqWqIYfeik+fooTTl7/CWOKh37Qh8J/Yj+v/RdDg6W66rasgpP5YYo2mcXBjjpDqgxg19B+OjDKkk0CHkv6kkWt8g7j5lPZwTX2Yhm3U5ViaBlwRoxKq8vIIpw0N/9hoCD/Zo2f0zS8J8mUpfrKRGWqzz3ull2DA7CwTtnxHAACf+B8IhDfg8BJc6TIR4LN2E7XCor5v75VDRrLs3ZY6K2mGlTYP8V6N7x8lvgOWvO3QNXn4/DEUlXWt3eWqvRSGsOUOXcqQ2MfJENCfpJ2LF+ms0TnfU8FnUsWMHCWnDWKBsWSfbo1VdNNKJC7uXkrgP5/20WJAxeGTgVBQN0LNcatAKnRl+XwLjSGxnydwsvhhDid1r3nQagR7hwsHXfdMpk/coKqZgWJj8zT9FTkbqMjg4EQ/XU8ZKTDG6gXXqMd6qUDA9O6LBI6n7mu6EW4Wlfo3mkbeYcYn3MtZCEFClAaNDBnaDkCVmWCGj1JkCoKSDJDMDcPPT8a4sH8GnNOSTFZNVm5x7AUhbqEMqmU12TBaiCltH0SJ2MW4P0mT+BrRFZv7nQHhjPo9NGKEoNaZrI/aECx+G9iQ299WrbPHOhJI0bdEE8j0Ry04yBUj5GS1W+NhuiLh8gz96qH6o40O93/1iEfNCtxSF/QxAo82SIF7oikPiYJoHnKYJyOQyFdDBcPc/x5LfibUZL1eEa15MOsmGRAXa0qQ+vimD+O2rBeeGcfxT4gC0EijrqE6cFEdei/1zWpZQCuswq6NZOpp2nh0DlVfnTNskeD6Y5PndKu6p0rzSYhKoXS90D6/NYjnjibjInGChVVjNRA17/BqWfIgo4mSZANmw5i1YqRL3Ylpm39Swpg4mWCM1aA9c68NOi5Evf4knHeUCjzlalIeeYG45FPsBYdjsAjIft1qiu7kU09B0ltuGs6P+snyPw0eUuczT3GRTV1Kkh44PxFUzaQEv6DKezz+7PsCZdpu8mwBw2XFbKPJ/kEF3DcdZW/H4S/EzaPppTOG1ZhfpTCMlYDzpeSmLW++lGS+leB3me8wX36jQE45t2rrl50tlLw/Otbo7sohFJLtMZRlF0Dh1C0LW2Z9Tf9fiORk95IzeXVsON+emy0+WIdWcO1o7cpRCml9SfmqOWAAbkovRuDRQtUJhFnS4ZYs1AwHrvUl5aqAQXpwwD22k92oUFxW381Ak9wR4LPnDS0D9fL5kVqvd2z8DBEVxkeVy5cIXyWhai+PUFrKS1cc23W6hNZnb7UKMRM+k30gEZQsM/wbQ9vZy/HyH41cPI0M2J9VAXYbqzm8mHNKamYvwIrl7mO1FKrPnuQGvEN8fmyYdM0SimtgkYSvhCnt88B3qq514kctXS5FyqveENZ/22ecwc/8gzE3pgUY0W3npPF+ESh8zWANhVtjWhmU9dtbQXAphG0qA1CDbKGaXk= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: e382399c-665c-4798-813f-08dce26cd2fd X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2024 23:00:20.5309 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Bf3f6lJMPd0md+XkZOAJBM1nOmQXTt60k4Up0XeCBjyIrw1dENO7RaFvOgEJSBf4LAaQcabOLdfFHxddRiwGFZpNmwqLhYZmD2r0z3lZ4kA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6271 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Some nand flashes (like spi-nand one) are registered with mtd subsystem only, thus nand command can't be used to work with such flashes. As result some functionality is missing. This patch implements 'nand torture' functionality for mtd command. Signed-off-by: Mikhail Kshevetskiy --- cmd/Kconfig | 14 ++++ cmd/mtd.c | 197 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 211 insertions(+) diff --git a/cmd/Kconfig b/cmd/Kconfig index e830b731d24..ea0491d3155 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1457,6 +1457,20 @@ config CMD_MTD_MARKBAD This is a clone of "nand markbad" command, but for 'mtd' subsystem. +config CMD_MTD_NAND_WRITE_TEST + bool "mtd nand_write_test (destructive)" + depends on CMD_MTD + help + MTD nand_write_test command support. + + Writes blocks of NAND flash with different patterns. + This is useful to determine if a block that caused a write error + is still good or should be marked as bad. + + This is a clone of "nand torture" command, but for 'mtd' subsystem. + + WARNING: This test will destroy any data on blocks being tested. + config CMD_MUX bool "mux" depends on MULTIPLEXER diff --git a/cmd/mtd.c b/cmd/mtd.c index 45084d39d3a..739a8a52cbd 100644 --- a/cmd/mtd.c +++ b/cmd/mtd.c @@ -18,6 +18,7 @@ #include #include #include +#include #include @@ -742,6 +743,194 @@ out_put_mtd: } #endif +#ifdef CONFIG_CMD_MTD_NAND_WRITE_TEST +/** + * nand_check_pattern: + * + * Check if buffer contains only a certain byte pattern. + * + * @param buf buffer to check + * @param patt the pattern to check + * @param size buffer size in bytes + * Return: 1 if there are only patt bytes in buf + * 0 if something else was found + */ +static int nand_check_pattern(const u_char *buf, u_char patt, int size) +{ + int i; + + for (i = 0; i < size; i++) + if (buf[i] != patt) + return 0; + return 1; +} + +/** + * nand_write_test: + * + * Writes a block of NAND flash with different patterns. + * This is useful to determine if a block that caused a write error is still + * good or should be marked as bad. + * + * @param mtd nand mtd instance + * @param offset offset in flash + * Return: 0 if the block is still good + */ +static int nand_write_test(struct mtd_info *mtd, loff_t offset) +{ + u_char patterns[] = {0xa5, 0x5a, 0x00}; + struct erase_info instr = { + .mtd = mtd, + .addr = offset, + .len = mtd->erasesize, + }; + size_t retlen; + int err, ret = -1, i, patt_count; + u_char *buf; + + if ((offset & (mtd->erasesize - 1)) != 0) { + puts("Attempt to torture a block at a non block-aligned offset\n"); + return -EINVAL; + } + + if (offset + mtd->erasesize > mtd->size) { + puts("Attempt to torture a block outside the flash area\n"); + return -EINVAL; + } + + patt_count = ARRAY_SIZE(patterns); + + buf = malloc_cache_aligned(mtd->erasesize); + if (buf == NULL) { + puts("Out of memory for erase block buffer\n"); + return -ENOMEM; + } + + for (i = 0; i < patt_count; i++) { + err = mtd_erase(mtd, &instr); + if (err) { + printf("%s: erase() failed for block at 0x%llx: %d\n", + mtd->name, instr.addr, err); + goto out; + } + + /* Make sure the block contains only 0xff bytes */ + err = mtd_read(mtd, offset, mtd->erasesize, &retlen, buf); + if ((err && err != -EUCLEAN) || retlen != mtd->erasesize) { + printf("%s: read() failed for block at 0x%llx: %d\n", + mtd->name, instr.addr, err); + goto out; + } + + err = nand_check_pattern(buf, 0xff, mtd->erasesize); + if (!err) { + printf("Erased block at 0x%llx, but a non-0xff byte was found\n", + offset); + ret = -EIO; + goto out; + } + + /* Write a pattern and check it */ + memset(buf, patterns[i], mtd->erasesize); + err = mtd_write(mtd, offset, mtd->erasesize, &retlen, buf); + if (err || retlen != mtd->erasesize) { + printf("%s: write() failed for block at 0x%llx: %d\n", + mtd->name, instr.addr, err); + goto out; + } + + err = mtd_read(mtd, offset, mtd->erasesize, &retlen, buf); + if ((err && err != -EUCLEAN) || retlen != mtd->erasesize) { + printf("%s: read() failed for block at 0x%llx: %d\n", + mtd->name, instr.addr, err); + goto out; + } + + err = nand_check_pattern(buf, patterns[i], mtd->erasesize); + if (!err) { + printf("Pattern 0x%.2x checking failed for block at " + "0x%llx\n", patterns[i], offset); + ret = -EIO; + goto out; + } + } + + ret = 0; + +out: + free(buf); + return ret; +} + +static int do_nand_write_test(struct cmd_tbl *cmdtp, int flag, int argc, + char *const argv[]) +{ + struct mtd_info *mtd; + loff_t off, len; + int ret = 0; + unsigned int failed = 0, passed = 0; + + if (argc < 2) + return CMD_RET_USAGE; + + mtd = get_mtd_by_name(argv[1]); + if (IS_ERR_OR_NULL(mtd)) + return CMD_RET_FAILURE; + + if (!mtd_can_have_bb(mtd)) { + printf("Only NAND-based devices can be tortured\n"); + goto out_put_mtd; + } + + argc -= 2; + argv += 2; + + off = argc > 0 ? hextoul(argv[0], NULL) : 0; + len = argc > 1 ? hextoul(argv[1], NULL) : mtd->size; + + if (!mtd_is_aligned_with_block_size(mtd, off)) { + printf("Offset not aligned with a block (0x%x)\n", + mtd->erasesize); + ret = CMD_RET_FAILURE; + goto out_put_mtd; + } + + if (!mtd_is_aligned_with_block_size(mtd, len)) { + printf("Size not a multiple of a block (0x%x)\n", + mtd->erasesize); + ret = CMD_RET_FAILURE; + goto out_put_mtd; + } + + printf("\nNAND torture: device '%s' offset 0x%llx size 0x%llx (block size 0x%x)\n", + mtd->name, off, len, mtd->erasesize); + while (len > 0) { + printf("\r block at %llx ", off); + if (mtd_block_isbad(mtd, off)) { + printf("marked bad, skipping\n"); + } else { + ret = nand_write_test(mtd, off); + if (ret) { + failed++; + printf("failed\n"); + } else { + passed++; + } + } + off += mtd->erasesize; + len -= mtd->erasesize; + } + printf("\n Passed: %u, failed: %u\n", passed, failed); + if (failed != 0) + ret = CMD_RET_FAILURE; + +out_put_mtd: + put_mtd_device(mtd); + + return ret; +} +#endif + static int do_mtd_bad(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) { @@ -827,6 +1016,9 @@ U_BOOT_LONGHELP(mtd, #endif #ifdef CONFIG_CMD_MTD_MARKBAD "mtd markbad [ ...]\n" +#endif +#ifdef CONFIG_CMD_MTD_TORTURE + "mtd torture [ []]\n" #endif "\n" "With:\n" @@ -864,6 +1056,11 @@ U_BOOT_CMD_WITH_SUBCMDS(mtd, "MTD utils", mtd_help_text, #ifdef CONFIG_CMD_MTD_MARKBAD U_BOOT_SUBCMD_MKENT_COMPLETE(markbad, 20, 0, do_mtd_markbad, mtd_name_complete), +#endif +#ifdef CONFIG_CMD_MTD_NAND_WRITE_TEST + U_BOOT_SUBCMD_MKENT_COMPLETE(nand_write_test, 4, 0, + do_nand_write_test, + mtd_name_complete), #endif U_BOOT_SUBCMD_MKENT_COMPLETE(bad, 2, 1, do_mtd_bad, mtd_name_complete)); From patchwork Tue Oct 1 23:00:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Kshevetskiy X-Patchwork-Id: 1991743 X-Patchwork-Delegate: dario.binacchi@amarulasolutions.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=iopsys.eu header.i=@iopsys.eu header.a=rsa-sha256 header.s=selector2 header.b=KHHDGHYq; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XJD2C5LPVz1xsc for ; Wed, 2 Oct 2024 09:01:07 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7649B88EEE; Wed, 2 Oct 2024 01:00:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=iopsys.eu header.i=@iopsys.eu header.b="KHHDGHYq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8993788EB7; Wed, 2 Oct 2024 01:00:26 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20700.outbound.protection.outlook.com [IPv6:2a01:111:f403:2613::700]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D254C88ECB for ; Wed, 2 Oct 2024 01:00:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mikhail.kshevetskiy@genexis.eu ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=A1XAMFfNLuCACA5sem26udAdA5+lSMdugiJP3znSoqHAIn2HkZvB54gcrtvoYjXDgsLzZancn7TTi0r/xv1GiFowgrelGpT13Txm++VoO2hVYgcXbiTnyvvDbdJa723bMOChtlOEpoSKnolu6Ec+pYv3G7NFGtJxStaVk49Yzk8yGrvWD4mf1/dSUAovE5RGR5FkNyXmPoDvOtJejNrNzP01OGdspVynZfJpy9AkwMTurB3qn7qx5tJhjRCzceE05PCCZE6gGffrKCaGdlQVu28IxH+jh4qSF28RPin+rbxAEgjKvC4afkT2bck6zPoBtcsF1F4QRiIp5XawWVWRsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cQsQOrsN2p0YRHuZ0Hv/EnOUjxgc9j4BINd0bQIEWHI=; b=J+KhZy9aEyaS5dkvft9Fe1ROerdDdueiV/sV2WHaug7qfZkBGkvn85L9SsBmKEr7qMRCqTDbHFymesZIHqeLieJAmdXf8foY5/ZA2cqCMqeSxRIfNqkvxu/m8RHYdPavMiNfxTkUPGm2lScTrMkv+54C8jCqXfORWHPforK+p1AOj1hClKPswDxFPyVMISMwmZ4yqBzKlw0uya9K2SCaYl9JO2j3pWcszmwSCKd3rUPoFnT7WAayyThT+oy1xWJTx76e8N4k42oZ/Wgftx0N/BLIjOsLi206mQgxdHWlTWkAIgTp3ljcmki+vej3n4pz1uJFMSIyZBFPJXQLAB14UQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cQsQOrsN2p0YRHuZ0Hv/EnOUjxgc9j4BINd0bQIEWHI=; b=KHHDGHYqeqNSXzvhLARuUaSjiQbDec1bYOM7pfaNqXbBLls+UWR9DB2jZfw4+0nWZQYj3rcBqgPUZCSnmOkkliMaLCSUSqPiCXVySytxKqB1ehCNHq4psux7CmzrQCi6Aqms/ym2o9Pu3qiMEZ20idG/CxTqTIkF26ZkqmZIFRYxrzZSYyGPK7NzTmpw1adxvRT4Evm/eRBZe1ROmgdunFLbUc2LJJYJW0VMFb7m9R0auM3ztpwHFC+vJiSK5V8+DL42u3xRRhXHtHcq4Z/891z2Mlyefo1crkQl+3uWyp9qCR7ZbC1VTDEUa0oKxzG9cXhAKb5P/30xT1S88B9s3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by PA4PR08MB6271.eurprd08.prod.outlook.com (2603:10a6:102:eb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.15; Tue, 1 Oct 2024 23:00:21 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%2]) with mapi id 15.20.8026.014; Tue, 1 Oct 2024 23:00:21 +0000 From: Mikhail Kshevetskiy To: Tom Rini , Simon Glass , Mattijs Korpershoek , AKASHI Takahiro , Heinrich Schuchardt , Mikhail Kshevetskiy , Marek Vasut , Dario Binacchi , Arseniy Krasnov , Miquel Raynal , u-boot@lists.denx.de Subject: [PATCH v3 3/3] cmd: mtd: add nand_read_test command support Date: Wed, 2 Oct 2024 02:00:11 +0300 Message-ID: <20241001230011.954429-4-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241001230011.954429-1-mikhail.kshevetskiy@iopsys.eu> References: <20241001230011.954429-1-mikhail.kshevetskiy@iopsys.eu> X-ClientProxiedBy: GV3PEPF00002BBE.SWEP280.PROD.OUTLOOK.COM (2603:10a6:144:1:0:6:0:10) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|PA4PR08MB6271:EE_ X-MS-Office365-Filtering-Correlation-Id: 45e288c3-e4af-4851-652c-08dce26cd391 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|376014|366016|52116014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: f+FDtVWqPcOvkz0T+p7umqKyPoJSzx8vCqy4e+znF8R4Im2Jsuk3Wvql5YWTXGz+Fs/jHFiaLeEheT9h5gWyfnCs85wIymqgZjqEYbT9gU0DDb06HUbw9Moomt53KmmHFQqkVjsiE8qhqvPamm362SrgnxyHwLfySXtE/Uvs/t/WgMsAB99a7RUn+pMiYwIdFeJTGdIhmVkKAVZFEREaaDF0lguW1rAmLHlcM5oFxLJuRMGBSVKfElh5z+T/xuFRY1Cx3NK8xzJcwtxImiLUoXj8RDbX/Z+KCKKG/m6VxOGQqJ4DJ5zHStynApOpoc8ljIV4Xm5776gThAgqRJhcNAKYAtrnIepudj87B8qijHqDDfk/raKcP47wSJjA9Jxr2gTSQ5U+wsZ7HZeW52U0h2qntzi9s4jtZkCfYr9/VYcGkPNti1NabevQ6ZYybibxcUHjvMYdEVlChP+vjj1tMWS2Oe/lSzo67lXlvnluxhoM2sSny0NA2T9pUiGbsVUp0xJt0QHPSrTiRIm/AsUN7hlQbT7tVBqkLcpqkCe0M41LfZQOnnwQTx+fbTndLo+/wm8BZj61et9+2lphOfPVwRCM9s91zVtsao6eUywIHsqFvSP3L3FfBXOfUlE+2FNHtSYFDVPkl/aQ36RrZlIc7F7EX1q3xzLNmr2aCEmPWlHxCZY2SEk78U7ToCJUwsz6mxbodKu5+hY/ifyKOt04XN/QGMwzqdJJltQttWMGU/VjzJTuApxyLJ6GonLUsLsJEgD1lDo3mE2tUE4NJHtyKozFnxdHt4MHPdFH3NdIPSrw8ZBNmgrBYaau6IBgNeojwYdSb8r3+0IPMdYzovj2RUvVkTeU5/APTqVbzmBeBttsS/xlM685u+ON/ifCsMA27Jx623hoC38AtL6lLUZStF6738VFrtlmXoTZ1p4hiBB18Z2q+2XWFX2CuntFK1a0YE3O710X3Le0oWUdvsyP7N753th9YOrlPmzWtd+OTUTGfLnnMJ4dXmCPd/oq5RsZ13PC/SN+GbTrjZNz8h3Uu7cNsVepwbYM5ojNYk2hVG6Ch1PV9flEzshu5BcGRNx26xO1KkELHSwhrkGENNv8D9HFzIFPXhnpcNnzLGqCYKUeCJLG3XqWd9duqE18DA3qXv6vfcC0m3PiR1sLz/mPs5iobyfZekNki6IoCNwoeWN4T7+1AwIhO9lNXksU3ovT5Wh0GhNoQuc4atJQEs3Ody1UKnBv+0AGLLPuil1Wrrh52/JEskzuU6QL2pJDHb1qGcQ49phwVc1Ry+yuI1M/cfH3CiZJ+GUl/pPLvcTzxCxb4UHu49oarAsxBFVBFp4DtI9jq1/TWBMdvkuWZuJjcKQeJ8Hq+L2d471jQZ1ivV0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:GV2PR08MB8121.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(376014)(366016)(52116014)(1800799024)(921020)(38350700014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ejT4rGBVEk9p4KT5dCaX6Jw7xhfRjm2vvwuZLZNBcOvns9mNXikxP3lBEFbBQqBm94/vRw3NsWukHSbAoR+wqa5yFHFg3XM+y+SCC6waUI1J5Zxa8ndFwJ58ka+6GeQVFGgtvzCBdFkBXe+s2keKakNmkvqM8COrFeq4AKYynW5tWw1KhjRc1w5U9HgheEiteXhx2HCs+uEcFrcdNs7+mg9fBoaj8aNfHnu4exZSMXt5pLsDFh99Fdlqk35i/YoZmKa7wLM4VoYQLZ/tdJYmSe1jNF6mintpTOd3XGVItEAXb8Q0LsPJRDsRMQKGExhSND3Dl8RDDdhqibr8cTDJfgoFk8aS20kXosqsBKB1dGpeS0P750zcIVG/vu/t6UvmOUjuYeFhjUlcYBKVcoW1FMbEZ04mjQRbdh4Kd2jLlLBJlrlZSfTA/Vx8k/nWWtJD5/KXlfWxMduU88cGZu4hzx7j7L8p4zjzDwMz80slS8nTfNjvMypqMzuDS49jlEwkXeOGRfMJTunGuH/zihC4I3SOl/ey6/JiWIFWAPB2XS+H0gX7Xjz6clbBtxoOOMs8oCd780AFmy0e/nndrpB5/a+MfbAbXLy10A7WyISKgbIE8JaIVNdJCIVFJorUvZgz4WssF3Rj5pNMYVbC6cs0IFfecIpmTmvP3MUPWBQk9HM8OrTWgreWj+/PQdfOtmCwIdv413VsiuPPBTarb/r+hHDIzjFabJt3qDAMfuyEB+tcttJVV0UcSxz5h7FOw3rltoUXnPstfErhyecWyauMhEzdAsa1pecbZ8cWvuic54sj/S8pUO7oSLAbqRmzMANaVROvr8poBOhN3pNybhR7ojo+wQ3/h6EoAmr1grc2XWGllqUIYUiGZ34b+GU04PckrQOQyMrzkt4a1WoV3r0UUXSQp9H943D7DpU76jBEKUbyS2p28iUjjju1uW5DoBR1T5E0qQn2PzTxd+6FsyFwHxIEa/L+/IwuShwaN4zDrnjsDG4DbtUaseDHlzD9Y3JYhO9GzAzS7X8oNwegYw11h6Y0D67HyEmSyZyoQKtrbQ6ePailiwnhFQ9LRR3Z09y7ymlhYvt70Is7qYsrn9T7g8AyunZSqSO8jg4a2oZ2sf+/Qd3tiKcmCW3Cjt+VvJJvW4d51jBwW/j5jYSn11DEOfRCdhp1Mbxm+3Lor3h+Cqir99K5GkOBLiwOPO1sIcqTRAKFlqGoUvTSbkinTOFiJ/dqE328CkBNo6oDaf2SwDqaTiUtcz13kqnDAeD5OOOTkXW5jxOZwH02KrUFd+kI672AEOHOKQBGG2EE37LPmYo+oKZGcddrEkazJkaW/Y61Mi2C1HTyFdKucuRVFt+9xoYqRivBPxDh20UkwkfHE8NafNTyNMl0NhxsuWU/2YA1Ek7Y8MQTGGTZGFLye+lp1dq/jguk/xRSZ6RN2axRumCvLqRRoRZ6WldLBExNV742hN71n2d0B+DqRf83BpoHsilymGmnngzlgK+jjKf+GvntO1CXgXxJZ6tuAG/3w6FlmvY+yMq1RRS3Pj+NstPEqzSwAL+9azb4hr98mPDhsDfLFFZBj5F4D3g8Tj3xnIvx4U1h6ceveedMJq2Cs89fVrIH7X7rUXomJkf1vHr/Kd4= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 45e288c3-e4af-4851-652c-08dce26cd391 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2024 23:00:21.5096 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RI7WhRwPP/+wg0pYQPAk8kxXXhXrqGwq4e+RoKUbrw2eMM4r1eDwq7EN0T4UvpKCD4fpIrbc2iHmAoIA0OuGLFFgMJFoXVIP8D2aJD68T/Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6271 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This patch implements read-only test of nand flash devices. Test reads blocks of NAND flash in normal and raw modes and compares results. The following statuses can be returned for a block: * non-ecc reading failed, * ecc reading failed, * block is bad, * bitflips is above maximum, * actual number of biflips above reported one, * bitflips reached it maximum value, * block is ok. Signed-off-by: Mikhail Kshevetskiy --- cmd/Kconfig | 16 +++++ cmd/mtd.c | 193 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 209 insertions(+) diff --git a/cmd/Kconfig b/cmd/Kconfig index ea0491d3155..5a0efb7b173 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1471,6 +1471,22 @@ config CMD_MTD_NAND_WRITE_TEST WARNING: This test will destroy any data on blocks being tested. +config CMD_MTD_NAND_READ_TEST + bool "mtd nand_read_test" + depends on CMD_MTD + help + MTD nand_read_test command support. + + Reads blocks of NAND flash in normal and raw modes and compares results. + The following statuses can be returned for a block: + * non-ecc reading failed, + * ecc reading failed, + * block is bad, + * bitflips is above maximum, + * actual number of biflips above reported one, + * bitflips reached it maximum value, + * block is ok. + config CMD_MUX bool "mux" depends on MULTIPLEXER diff --git a/cmd/mtd.c b/cmd/mtd.c index 739a8a52cbd..1bfe9fc97da 100644 --- a/cmd/mtd.c +++ b/cmd/mtd.c @@ -931,6 +931,191 @@ out_put_mtd: } #endif +#ifdef CONFIG_CMD_MTD_NAND_READ_TEST +enum nand_read_status { + NAND_READ_STATUS_UNKNOWN = 0, + NAND_READ_STATUS_NONECC_READ_FAIL, + NAND_READ_STATUS_ECC_READ_FAIL, + NAND_READ_STATUS_BAD_BLOCK, + NAND_READ_STATUS_BITFLIP_ABOVE_MAX, + NAND_READ_STATUS_BITFLIP_MISMATCH, + NAND_READ_STATUS_BITFLIP_MAX, + NAND_READ_STATUS_OK, +}; + +static enum nand_read_status nand_read_block_check(struct mtd_info *mtd, + loff_t off, size_t blocksize) +{ + struct mtd_oob_ops ops = {}; + u_char *buf; + int i, d, ret, len, pos, cnt, max; + + if (blocksize % mtd->writesize != 0) { + printf("\r block at %llx: bad block size\n", off); + return NAND_READ_STATUS_UNKNOWN; + } + + buf = malloc_cache_aligned(2 * blocksize); + if (buf == NULL) { + printf("\r block at %llx: can't allocate memory\n", off); + return NAND_READ_STATUS_UNKNOWN; + } + + ops.mode = MTD_OPS_RAW; + ops.len = blocksize; + ops.datbuf = buf; + ops.ooblen = 0; + ops.oobbuf = NULL; + + if (mtd->_read_oob) + ret = mtd->_read_oob(mtd, off, &ops); + else + ret = mtd->_read(mtd, off, ops.len, &ops.retlen, ops.datbuf); + + if (ret != 0) { + free(buf); + printf("\r block at %llx: non-ecc reading error %d\n", + off, ret); + return NAND_READ_STATUS_NONECC_READ_FAIL; + } + + ops.mode = MTD_OPS_AUTO_OOB; + ops.datbuf = buf + blocksize; + + if (mtd->_read_oob) + ret = mtd->_read_oob(mtd, off, &ops); + else + ret = mtd->_read(mtd, off, ops.len, &ops.retlen, ops.datbuf); + + if (ret == -EBADMSG) { + free(buf); + printf("\r block at %llx: bad block\n", off); + return NAND_READ_STATUS_BAD_BLOCK; + } + + if (ret < 0) { + free(buf); + printf("\r block at %llx: ecc reading error %d\n", off, ret); + return NAND_READ_STATUS_ECC_READ_FAIL; + } + + if (mtd->ecc_strength == 0) { + free(buf); + return NAND_READ_STATUS_OK; + } + + if (ret > mtd->ecc_strength) { + free(buf); + printf("\r block at %llx: returned bit-flips value %d " + "is above maximum value %d\n", + off, ret, mtd->ecc_strength); + return NAND_READ_STATUS_BITFLIP_ABOVE_MAX; + } + + max = 0; + pos = 0; + len = blocksize; + while (len > 0) { + cnt = 0; + for (i = 0; i < mtd->ecc_step_size; i++) { + d = buf[pos + i] ^ buf[blocksize + pos + i]; + if (d == 0) + continue; + + while (d > 0) { + d &= (d - 1); + cnt++; + } + } + if (cnt > max) + max = cnt; + + len -= mtd->ecc_step_size; + pos += mtd->ecc_step_size; + } + + free(buf); + + if (max > ret) { + printf("\r block at %llx: bitflip mismatch, " + "read %d but actual %d\n", off, ret, max); + return NAND_READ_STATUS_BITFLIP_MISMATCH; + } + + if (ret == mtd->ecc_strength) { + printf("\r block at %llx: max bitflip reached, " + "block is unreliable\n", off); + return NAND_READ_STATUS_BITFLIP_MAX; + } + + return NAND_READ_STATUS_OK; +} + +static int do_mtd_nand_read_test(struct cmd_tbl *cmdtp, int flag, int argc, + char *const argv[]) +{ + struct mtd_info *mtd; + u64 off; + int stat[NAND_READ_STATUS_OK + 1]; + enum nand_read_status ret; + + if (argc < 2) + return CMD_RET_USAGE; + + mtd = get_mtd_by_name(argv[1]); + if (IS_ERR_OR_NULL(mtd)) + return CMD_RET_FAILURE; + + if (!mtd_can_have_bb(mtd)) { + printf("Only NAND-based devices can be checked\n"); + goto out_put_mtd; + } + + printf("ECC strength: %d\n", mtd->ecc_strength); + printf("ECC step size: %d\n", mtd->ecc_step_size); + printf("Erase block size: 0x%x\n", mtd->erasesize); + printf("Total blocks: %d\n", do_div(mtd->size, mtd->erasesize)); + + memset(stat, 0, sizeof(stat)); + for (off = 0; off < mtd->size; off += mtd->erasesize) { + ret = nand_read_block_check(mtd, off, mtd->erasesize); + stat[ret]++; + + switch (ret) { + case NAND_READ_STATUS_BAD_BLOCK: + case NAND_READ_STATUS_BITFLIP_MAX: + if (!mtd_block_isbad(mtd, off)) + printf("\r block at %llx: should be marked " + "as BAD\n", off); + break; + + case NAND_READ_STATUS_OK: + if (mtd_block_isbad(mtd, off)) + printf("\r block at %llx: marked as BAD, but " + "probably is GOOD\n", off); + break; + + default: + break; + } + } + +out_put_mtd: + put_mtd_device(mtd); + printf("\n"); + printf("results:\n"); + printf(" Good blocks: %d\n", stat[NAND_READ_STATUS_OK]); + printf(" Physically bad blocks: %d\n", stat[NAND_READ_STATUS_BAD_BLOCK]); + printf(" Unreliable blocks: %d\n", stat[NAND_READ_STATUS_BITFLIP_MAX]); + printf(" Non checked blocks: %d\n", stat[NAND_READ_STATUS_UNKNOWN]); + printf(" Failed to check blocks: %d\n", stat[NAND_READ_STATUS_NONECC_READ_FAIL] + + stat[NAND_READ_STATUS_ECC_READ_FAIL]); + printf(" Suspictious blocks: %d\n", stat[NAND_READ_STATUS_BITFLIP_ABOVE_MAX] + + stat[NAND_READ_STATUS_BITFLIP_MISMATCH]); + return CMD_RET_SUCCESS; +} +#endif + static int do_mtd_bad(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) { @@ -1019,6 +1204,9 @@ U_BOOT_LONGHELP(mtd, #endif #ifdef CONFIG_CMD_MTD_TORTURE "mtd torture [ []]\n" +#endif +#ifdef CONFIG_CMD_MTD_NANDTEST + "mtd nandtest \n" #endif "\n" "With:\n" @@ -1061,6 +1249,11 @@ U_BOOT_CMD_WITH_SUBCMDS(mtd, "MTD utils", mtd_help_text, U_BOOT_SUBCMD_MKENT_COMPLETE(nand_write_test, 4, 0, do_nand_write_test, mtd_name_complete), +#endif +#ifdef CONFIG_CMD_MTD_NAND_READ_TEST + U_BOOT_SUBCMD_MKENT_COMPLETE(nand_read_test, 2, 0, + do_mtd_nand_read_test, + mtd_name_complete), #endif U_BOOT_SUBCMD_MKENT_COMPLETE(bad, 2, 1, do_mtd_bad, mtd_name_complete));