From patchwork Tue Oct 1 13:33:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1991473 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1AvhUtXg; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=AH4TgUty; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1AvhUtXg; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=AH4TgUty; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XHzRB3QWpz1xtY for ; Tue, 1 Oct 2024 23:33:26 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 503193870889 for ; Tue, 1 Oct 2024 13:33:24 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id E26053841886 for ; Tue, 1 Oct 2024 13:33:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E26053841886 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E26053841886 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727789584; cv=none; b=vMYbCa0MH9S95s8X7zk06kT1O0cHisnOvC1Tz7HCE1zu3djL9XP6v9K7GCabxupsex/ElxsuBV6l3HgmiTQPFZSR5NkhPCv1ji5E2eu8UnqnBizpqJWxajqdKXsipRhPwV5qX5XhDCzUhDFIHyJKKwOcT2DaWyXo4TkyRJdZTi0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727789584; c=relaxed/simple; bh=CYKXmituFxvPZQn9yG7hiS2DvTS9Pe0OZDPEIap2H5o=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=FKxkTzhd1QJaXLLHEAEIis2KkRm818v6+l18ZuDB26VJLGql73gYamRqM7Dp5QInXnBvkpnj80d2Z2mvs3RPIkzWp6NoLQ4khlL9cnWqeTtlXoyakr4t5QQs/Lc57yGK3tbMIOz+JHfpDk5qZCU03kIxFQgozNwFr/47RiqqewE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from murzim.nue2.suse.org (unknown [10.168.4.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CB8741F815 for ; Tue, 1 Oct 2024 13:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1727789580; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=RB5flrZOA8qbTIM84jpWbjiIKjf7Gei+gBe7FAOCaco=; b=1AvhUtXgb3SF9tNOVRpRUnlOZPcqj4kphS6Se69M1J+pdIVaWX9lBaB3eVqhknXAyUk/ff 6SY0qRgmc7SpeS9xVRMmTjpSoJooiIpjO0UCFxXWb5P6zZWGSD6eWekwTRLpxnjpAfl9ae xnxD73Cgwysme6W0Z++KGXFTsUfv3xw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1727789580; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=RB5flrZOA8qbTIM84jpWbjiIKjf7Gei+gBe7FAOCaco=; b=AH4TgUty/z/p3CTra8YHBZC4t6/78d/pKeSBj6mDVO4HqstQ10mYyRbQpXQu3wKFLMtCJc DGcyiDooAHSxyjDw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1727789580; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=RB5flrZOA8qbTIM84jpWbjiIKjf7Gei+gBe7FAOCaco=; b=1AvhUtXgb3SF9tNOVRpRUnlOZPcqj4kphS6Se69M1J+pdIVaWX9lBaB3eVqhknXAyUk/ff 6SY0qRgmc7SpeS9xVRMmTjpSoJooiIpjO0UCFxXWb5P6zZWGSD6eWekwTRLpxnjpAfl9ae xnxD73Cgwysme6W0Z++KGXFTsUfv3xw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1727789580; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=RB5flrZOA8qbTIM84jpWbjiIKjf7Gei+gBe7FAOCaco=; b=AH4TgUty/z/p3CTra8YHBZC4t6/78d/pKeSBj6mDVO4HqstQ10mYyRbQpXQu3wKFLMtCJc DGcyiDooAHSxyjDw== Date: Tue, 1 Oct 2024 15:33:00 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/116654 - missed dr_explicit_realign[_optimized] with SLP MIME-Version: 1.0 X-Spam-Level: X-Spamd-Result: default: False [-1.16 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-0.36)[-0.360]; NEURAL_HAM_SHORT(-0.20)[-0.982]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; MISSING_XM_UA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_NONE(0.00)[]; MIME_TRACE(0.00)[0:+] X-Spam-Score: -1.16 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Message-Id: <20241001133324.503193870889@sourceware.org> With single-lane SLP we miss to use the power realing loads causing some testsuite FAILs. r14-2430-g4736ddd11874fe exempted SLP of non-grouped accesses because that could have been only splats where the scheme isn't used anyway, but now with single-lane SLP it can be contiguous accesses. Bootstrap and regtest running on x86_64-unknown-linux-gnu and powerpc64le-linux-gnu (might take a while since I have no good baseline to compare). Richard. PR tree-optimization/116654 * tree-vect-data-refs.cc (vect_supportable_dr_alignment): Treat non-grouped accesses like non-SLP. --- gcc/tree-vect-data-refs.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gcc/tree-vect-data-refs.cc b/gcc/tree-vect-data-refs.cc index fe7fdec4ba0..920e3c120a6 100644 --- a/gcc/tree-vect-data-refs.cc +++ b/gcc/tree-vect-data-refs.cc @@ -7170,11 +7170,11 @@ vect_supportable_dr_alignment (vec_info *vinfo, dr_vec_info *dr_info, same alignment, instead it depends on the SLP group size. */ if (loop_vinfo && STMT_SLP_TYPE (stmt_info) - && (!STMT_VINFO_GROUPED_ACCESS (stmt_info) - || !multiple_p (LOOP_VINFO_VECT_FACTOR (loop_vinfo) - * (DR_GROUP_SIZE - (DR_GROUP_FIRST_ELEMENT (stmt_info))), - TYPE_VECTOR_SUBPARTS (vectype)))) + && STMT_VINFO_GROUPED_ACCESS (stmt_info) + && !multiple_p (LOOP_VINFO_VECT_FACTOR (loop_vinfo) + * (DR_GROUP_SIZE + (DR_GROUP_FIRST_ELEMENT (stmt_info))), + TYPE_VECTOR_SUBPARTS (vectype))) ; else if (!loop_vinfo || (nested_in_vect_loop