From patchwork Mon Sep 30 20:25:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuxuan Luo X-Patchwork-Id: 1991188 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XHXdv2cSPz1xsc for ; Tue, 1 Oct 2024 06:26:10 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1svMxx-0004gh-7V; Mon, 30 Sep 2024 20:25:57 +0000 Received: from smtp-relay-internal-1.internal ([10.131.114.114] helo=smtp-relay-internal-1.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1svMxv-0004gF-Nd for kernel-team@lists.ubuntu.com; Mon, 30 Sep 2024 20:25:55 +0000 Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 9B3DF3F1BD for ; Mon, 30 Sep 2024 20:25:55 +0000 (UTC) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-2e06c9217bcso4590371a91.3 for ; Mon, 30 Sep 2024 13:25:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727727954; x=1728332754; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yoZgY6GgsG75pjoLd0pCUD2eWS+EOMPTcMGo5UqAkug=; b=BR+yyLvUnjImQRvOigC3hRD7St2dmHUZp4sX9M3yK/x0UHS+tDpXMtowaN5Gauq+VH tIoh1uM6H55kwJ9utwT/I1EMSNr6yYecrbWo+GhcLDeLiBKmZXkXCORg3gbD7hkmNajS SKvilMp901hvGtatO9gsgyusl9kzHlzTqVzEWLqxsfQUBYpYDcpa623Bph1o0nBhud5u F5JKw52eMfzaQl7BYVleRPODnFJI7VqRutW8M9JUgMkDSsuWahYI4Hn/LydE46qPsCZ7 eZgBxrU5fabxQo5ZbqOFFIGngeSUWs8La7TOSMlkfjGLMExfQC01mT4tS7YxqAnffQ5Z gvWg== X-Gm-Message-State: AOJu0Yygt7ez7nE5r22iw9bvK7XqGl1cQpvLGsW5Pw4FknZ+15JSfgdW wauork0KrDVV5raQrsfJ27WYhjv44WOiOIcaWB+jahS5euNCZPOH8ep0Kv5W7kcr/1gtjSlS4dC NNmqM+0gxHk8ggwJ4RqISSqeKsTkEKay/U7dbVb3h9k0LKR5jcbypcgnNRixzkjpAJPpaYFvsO3 hGBxMbs5wxl+zY X-Received: by 2002:a17:90a:f016:b0:2c9:9f50:3f9d with SMTP id 98e67ed59e1d1-2e0b89a239bmr15035264a91.5.1727727954119; Mon, 30 Sep 2024 13:25:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJZSKyXxUxzjYkcMHyZsOivqRB4euectOi2KJuYMRTDrq0VKR1PMFpvI+AxQqfbvPoAy+Z4w== X-Received: by 2002:a17:90a:f016:b0:2c9:9f50:3f9d with SMTP id 98e67ed59e1d1-2e0b89a239bmr15035253a91.5.1727727953783; Mon, 30 Sep 2024 13:25:53 -0700 (PDT) Received: from cache-ubuntu.hsd1.nj.comcast.net ([2001:67c:1562:8007::aac:4795]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e0b72aef19sm8423549a91.46.2024.09.30.13.25.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 13:25:53 -0700 (PDT) From: Yuxuan Luo To: kernel-team@lists.ubuntu.com Subject: [SRU][N][PATCH] atm: idt77252: prevent use after free in dequeue_rx() Date: Mon, 30 Sep 2024 16:25:39 -0400 Message-ID: <20240930202544.397418-2-yuxuan.luo@canonical.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240930202544.397418-1-yuxuan.luo@canonical.com> References: <20240930202544.397418-1-yuxuan.luo@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Dan Carpenter We can't dereference "skb" after calling vcc->push() because the skb is released. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller (cherry picked from commit a9a18e8f770c9b0703dab93580d0b02e199a4c79) CVE-2024-44998 Signed-off-by: Yuxuan Luo --- drivers/atm/idt77252.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c index e7f713cd70d3f..a876024d8a05f 100644 --- a/drivers/atm/idt77252.c +++ b/drivers/atm/idt77252.c @@ -1118,8 +1118,8 @@ dequeue_rx(struct idt77252_dev *card, struct rsq_entry *rsqe) rpp->len += skb->len; if (stat & SAR_RSQE_EPDU) { + unsigned int len, truesize; unsigned char *l1l2; - unsigned int len; l1l2 = (unsigned char *) ((unsigned long) skb->data + skb->len - 6); @@ -1189,14 +1189,15 @@ dequeue_rx(struct idt77252_dev *card, struct rsq_entry *rsqe) ATM_SKB(skb)->vcc = vcc; __net_timestamp(skb); + truesize = skb->truesize; vcc->push(vcc, skb); atomic_inc(&vcc->stats->rx); - if (skb->truesize > SAR_FB_SIZE_3) + if (truesize > SAR_FB_SIZE_3) add_rx_skb(card, 3, SAR_FB_SIZE_3, 1); - else if (skb->truesize > SAR_FB_SIZE_2) + else if (truesize > SAR_FB_SIZE_2) add_rx_skb(card, 2, SAR_FB_SIZE_2, 1); - else if (skb->truesize > SAR_FB_SIZE_1) + else if (truesize > SAR_FB_SIZE_1) add_rx_skb(card, 1, SAR_FB_SIZE_1, 1); else add_rx_skb(card, 0, SAR_FB_SIZE_0, 1);