From patchwork Mon Sep 30 03:04:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Koichiro Den X-Patchwork-Id: 1990719 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XH5Xj4l78z1xsq for ; Mon, 30 Sep 2024 13:05:09 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1sv6ic-0007zp-E5; Mon, 30 Sep 2024 03:05:02 +0000 Received: from smtp-relay-internal-0.internal ([10.131.114.225] helo=smtp-relay-internal-0.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1sv6ia-0007y6-6A for kernel-team@lists.ubuntu.com; Mon, 30 Sep 2024 03:05:00 +0000 Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id CF9AB3F20D for ; Mon, 30 Sep 2024 03:04:59 +0000 (UTC) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-7db6dbaca2cso5078736a12.0 for ; Sun, 29 Sep 2024 20:04:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727665498; x=1728270298; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=orydb8wrfWJGwE+Ni6K6hRj2t7THSMUNjdNM3736BeM=; b=aaFku71nVfnkBqs2pvcGk5IV3Er4qcuoV0nPxW++rVR/vazkQrQGk5eseiRqHMGn3L c/GOYun+KSZ+R/+x+rhMsrJk41quA2nF3H6UIicyhcOh1Rmz1YGlRDsi2TNoxpRA/u8u 77JzwmCQJP/CruVXRsKAU9GsTJjUV3kU8IjQba5p8G3cbAPehkS3HwlH5McV7vLTZrkf YiReREXLTnZ4Qm1s/UBIdDYxZsc8tDRxdYWcQfnblq+Pfglg6/yok81jD0jHX7hDxwcc ARP++vfqcV/0zRLTOFpnbSSMPG/cLO+nVjDstRXT+S4IWl1uXSluB5q0ZhZEY68gaXNx Au6Q== X-Gm-Message-State: AOJu0YwOYCk3PQxxD5McbaQZ2vp2yQYO3Xhl946k5fndbYZe1EaRwJTB a22NotOeBwOfmpT/lEKwP5/1RgE5CueYuBsFrWFJUDdQOvddxe0yeqVzxsbEOF+vWtmyW2tfYZf f7PI6ojNy9UiaHA8ZyZU+YSQToyBOEBz+/bmjD5qbMbIuZSwanF2m/uqX6VGTxXmT5tTxEKS0gT 9GFSrJ6oq9iA== X-Received: by 2002:a05:6a20:d045:b0:1d5:14ff:a153 with SMTP id adf61e73a8af0-1d514ffa206mr6324490637.12.1727665497528; Sun, 29 Sep 2024 20:04:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHX0pg9mVoRA/Kbq9J7BgSVF0TQiiOoSgco5kekTXYmuppFAyD9JOMCXktMrur59/tUkm0hAQ== X-Received: by 2002:a05:6a20:d045:b0:1d5:14ff:a153 with SMTP id adf61e73a8af0-1d514ffa206mr6324450637.12.1727665497051; Sun, 29 Sep 2024 20:04:57 -0700 (PDT) Received: from localhost.localdomain ([240f:74:7be:1:c835:dd5c:238f:3a73]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e6db60bfe9sm5487677a12.84.2024.09.29.20.04.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Sep 2024 20:04:56 -0700 (PDT) From: Koichiro Den To: kernel-team@lists.ubuntu.com Subject: [SRU][F][PATCH v2 1/1] ARM: 9359/1: flush: check if the folio is reserved for no-mapping addresses Date: Mon, 30 Sep 2024 12:04:22 +0900 Message-ID: <20240930030427.591560-2-koichiro.den@canonical.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240930030427.591560-1-koichiro.den@canonical.com> References: <20240930030427.591560-1-koichiro.den@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Yongqiang Liu Since commit a4d5613c4dc6 ("arm: extend pfn_valid to take into account freed memory map alignment") changes the semantics of pfn_valid() to check presence of the memory map for a PFN. A valid page for an address which is reserved but not mapped by the kernel[1], the system crashed during some uio test with the following memory layout: node 0: [mem 0x00000000c0a00000-0x00000000cc8fffff] node 0: [mem 0x00000000d0000000-0x00000000da1fffff] the uio layout is：0xc0900000, 0x100000 the crash backtrace like: Unable to handle kernel paging request at virtual address bff00000 [...] CPU: 1 PID: 465 Comm: startapp.bin Tainted: G O 5.10.0 #1 Hardware name: Generic DT based system PC is at b15_flush_kern_dcache_area+0x24/0x3c LR is at __sync_icache_dcache+0x6c/0x98 [...] (b15_flush_kern_dcache_area) from (__sync_icache_dcache+0x6c/0x98) (__sync_icache_dcache) from (set_pte_at+0x28/0x54) (set_pte_at) from (remap_pfn_range+0x1a0/0x274) (remap_pfn_range) from (uio_mmap+0x184/0x1b8 [uio]) (uio_mmap [uio]) from (__mmap_region+0x264/0x5f4) (__mmap_region) from (__do_mmap_mm+0x3ec/0x440) (__do_mmap_mm) from (do_mmap+0x50/0x58) (do_mmap) from (vm_mmap_pgoff+0xfc/0x188) (vm_mmap_pgoff) from (ksys_mmap_pgoff+0xac/0xc4) (ksys_mmap_pgoff) from (ret_fast_syscall+0x0/0x5c) Code: e0801001 e2423001 e1c00003 f57ff04f (ee070f3e) ---[ end trace 09cf0734c3805d52 ]--- Kernel panic - not syncing: Fatal exception So check if PG_reserved was set to solve this issue. [1]: https://lore.kernel.org/lkml/Zbtdue57RO0QScJM@linux.ibm.com/ Fixes: a4d5613c4dc6 ("arm: extend pfn_valid to take into account freed memory map alignment") Suggested-by: Mike Rapoport Signed-off-by: Yongqiang Liu Signed-off-by: Russell King (Oracle) (backported from commit 0c66c6f4e21cb22220cbd8821c5c73fc157d20dc) [koichiroden: folio_test_reserved replaced by PageReserved due to missing commit 8b5989f33337 ("arm: implement the new page table range API"). folio conversion is not backported in general, so notice that even d389a4a81155 ("mm: Add folio flag manipulation functions") does not exist in Focal] CVE-2024-26947 Signed-off-by: Koichiro Den --- arch/arm/mm/flush.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mm/flush.c b/arch/arm/mm/flush.c index 6d89db7895d1..8ce681d76665 100644 --- a/arch/arm/mm/flush.c +++ b/arch/arm/mm/flush.c @@ -280,6 +280,8 @@ void __sync_icache_dcache(pte_t pteval) return; page = pfn_to_page(pfn); + if (PageReserved(page)) + return; if (cache_is_vipt_aliasing()) mapping = page_mapping_file(page); else