From patchwork Thu Sep 26 08:04:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 1989684 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DbqDfCrm; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XDmNV1TGGz1xt2 for ; Thu, 26 Sep 2024 18:04:58 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DDCB2385829B for ; Thu, 26 Sep 2024 08:04:55 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 4951F3858D29 for ; Thu, 26 Sep 2024 08:04:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4951F3858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4951F3858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727337882; cv=none; b=ODHXkxRGDV5x8ChnuwH2ZwOdU9z+OrhnJSDLirPwv97VIfL9rt5ZLQ9WtjJl2CHABJrXEUqdpQA0Gx400f3zwAOc6n4YOGbs/XZRK8oaFg1q670jMyyRCv3Zl/BfJxcrzb1QG/RLbt7HgRhKqamTkm6+1tlWJ91Os/iEdXNTPpw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727337882; c=relaxed/simple; bh=RpL/NHBKK4YrCN5RAh6IMKGbQhEFt37gFEUooqpQZZ8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=R9Ky95fEIy2nmIHtOtBd2iQ9ZQM71nRLvL4zx5kN4qzGw6t6jW0+x6Wo7lX4ZSVIKNHSfP05cNxC8QlcZgtD/jUEMCtiYXwceY/F4PyPV6YIni09rgT+sgXtMOMlt8pcp/BNwiZV5FqaPvEbd1eBAmmLVkOJma1sDfNXIDNnx6Q= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727337880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=/+uFF26Wk8q4wlQfLVB7p6tDrXddWpAWXe2g909NiQM=; b=DbqDfCrmH9BIzygslkbdV9nchsvTpE6HHgovecFLEyjxl8hKvRWtn74/1eld1JpJ629TgJ n0apC3dbnQdWkakDBcT2VZ/HdfF+sV1/22nDinD2muFb9iGLv2IU0Xdyn1HhtKjVPQ9UeF e8JbLwwT+6Yr6hK4OVpHqknO8Ca37VQ= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-R7wal9ntN3GP_XBx5869XA-1; Thu, 26 Sep 2024 04:04:38 -0400 X-MC-Unique: R7wal9ntN3GP_XBx5869XA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A7E06190305C for ; Thu, 26 Sep 2024 08:04:37 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.45.224.151]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B70A519560A3 for ; Thu, 26 Sep 2024 08:04:36 +0000 (UTC) From: Florian Weimer To: libc-alpha@sourceware.org Subject: [PATCH] stdio-common: Fix memory leak in tst-freopen4* tests on UNSUPPORTED Date: Thu, 26 Sep 2024 10:04:33 +0200 Message-ID: <871q16alim.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org The temp_dir allocation leaks if support_can_chroot returns false. --- stdio-common/tst-freopen4-main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) base-commit: cc84cd389c7329ceb38228f931044e8c84ca7245 diff --git a/stdio-common/tst-freopen4-main.c b/stdio-common/tst-freopen4-main.c index e169442cf4..7284677a97 100644 --- a/stdio-common/tst-freopen4-main.c +++ b/stdio-common/tst-freopen4-main.c @@ -33,7 +33,7 @@ int do_test (void) { mtrace (); - char *temp_dir = support_create_temp_directory ("tst-freopen4"); + char *temp_dir; FILE *fp; int ret; @@ -45,6 +45,8 @@ do_test (void) support_become_root (); if (!support_can_chroot ()) return EXIT_UNSUPPORTED; + + temp_dir = support_create_temp_directory ("tst-freopen4"); xchroot (temp_dir); /* Test freopen with NULL, renamed file. This verifies that