From patchwork Tue Jul 23 10:05:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivian Wang X-Patchwork-Id: 1963718 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=dram.page header.i=@dram.page header.a=rsa-sha256 header.s=mail header.b=KJ8AUxKe; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WSt9g5NtSz20Cs for ; Tue, 23 Jul 2024 20:07:19 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWCPg-0001RA-NJ; Tue, 23 Jul 2024 06:06:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWCPe-0001Lu-MM for qemu-devel@nongnu.org; Tue, 23 Jul 2024 06:06:30 -0400 Received: from kuriko.dram.page ([65.108.252.55]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWCPX-0007Hw-HB for qemu-devel@nongnu.org; Tue, 23 Jul 2024 06:06:26 -0400 From: Vivian Wang DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dram.page; s=mail; t=1721729179; bh=ArdmnQR1Llme4HvtFTBZiU27PCQzl4QNiM7wMwOD1vo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=KJ8AUxKeIiGfLW71lkfqNWw1Q8PGzXyLE/SAvb5FHjYfr7zFAaL380eX91kd6yQfR jKRIc276tOCifb/rBijLNAu/T461JHVwzmRef3dyBm+HkeS+oFqVHODtPZzJwogEs9 V88/RWAJd50cKxLDfcmV7Fpc407MvT0QYmyMMi8k= To: qemu-devel@nongnu.org Cc: Vivian Wang , Richard Henderson , Laurent Vivier Subject: [PATCH v2 1/2] util/getauxval: Ensure setting errno if not found Date: Tue, 23 Jul 2024 18:05:44 +0800 Message-ID: <20240723100545.405476-2-uwu@dram.page> In-Reply-To: <20240723100545.405476-1-uwu@dram.page> References: <20240723100545.405476-1-uwu@dram.page> MIME-Version: 1.0 Received-SPF: pass client-ip=65.108.252.55; envelope-from=uwu@dram.page; helo=kuriko.dram.page X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sometimes zero is a valid value for getauxval (e.g. AT_EXECFD). Make sure that we can distinguish between a valid zero value and a not found entry by setting errno. Assumes that getauxval from sys/auxv.h sets errno correctly. Signed-off-by: Vivian Wang --- util/getauxval.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/util/getauxval.c b/util/getauxval.c index b124107d61..fad16c406e 100644 --- a/util/getauxval.c +++ b/util/getauxval.c @@ -95,6 +95,7 @@ unsigned long qemu_getauxval(unsigned long type) } } + errno = ENOENT; return 0; } @@ -104,7 +105,9 @@ unsigned long qemu_getauxval(unsigned long type) unsigned long qemu_getauxval(unsigned long type) { unsigned long aux = 0; - elf_aux_info(type, &aux, sizeof(aux)); + int ret = elf_aux_info(type, &aux, sizeof(aux)); + if (ret != 0) + errno = ret; return aux; } @@ -112,6 +115,7 @@ unsigned long qemu_getauxval(unsigned long type) unsigned long qemu_getauxval(unsigned long type) { + errno = ENOSYS; return 0; }