From patchwork Mon Jul 15 02:35:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ivanhu X-Patchwork-Id: 1960391 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WMmX35CCHz1xrQ for ; Mon, 15 Jul 2024 12:35:30 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1sTBYh-0004x0-Bp; Mon, 15 Jul 2024 02:35:23 +0000 Received: from smtp-relay-canonical-1.internal ([10.131.114.174] helo=smtp-relay-canonical-1.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1sTBYf-0004wr-Hj for fwts-devel@lists.ubuntu.com; Mon, 15 Jul 2024 02:35:21 +0000 Received: from canonical.com (unknown [10.102.137.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 717C93F383 for ; Mon, 15 Jul 2024 02:35:19 +0000 (UTC) From: Ivan Hu To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpi: acpipld: modify the test description to aviod misunderstanding Date: Mon, 15 Jul 2024 10:35:15 +0800 Message-Id: <20240715023515.32851-1-ivan.hu@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" BugLink: https://bugs.launchpad.net/fwts/+bug/2073023 This test does not verify that a connectable port has the _PLD method. Instead, it ensures that a non-connectable port, identified by _UPC, does not have the _PLD method. failure such as, acpipld: The ACPI method \_SB_.PCI0.XHC_.RHUB.HS06._PLD exists on the port claimed not connectable by the \_SB_.PCI0.XHC_.RHUB.HS06._UPC. Change the test description to avoid misunderstanding. Use the following description: "Check that the ACPI _PLD methods exist only on connectable ports. Signed-off-by: Ivan Hu --- src/acpi/acpipld/acpipld.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/acpi/acpipld/acpipld.c b/src/acpi/acpipld/acpipld.c index 638b36d7..df81ae0f 100644 --- a/src/acpi/acpipld/acpipld.c +++ b/src/acpi/acpipld/acpipld.c @@ -104,18 +104,18 @@ static int acpipld_test1(fwts_framework *fw) } if (!failed) - fwts_passed(fw, "All _PLD methods exist on the port connectable."); + fwts_passed(fw, "All _PLD methods exist only on the port connectable."); return FWTS_OK; } static fwts_framework_minor_test acpipld_tests[] = { - { acpipld_test1, "Check the ACPI _PLD methods exist on the port connectable." }, + { acpipld_test1, "Check the ACPI _PLD methods exist only on the port connectable." }, { NULL, NULL } }; static fwts_framework_ops acpipld_ops = { - .description = "Check if the ACPI _PLD methods exist on the port connectable.", + .description = "Check if the ACPI _PLD methods exist only on the port connectable.", .init = acpipld_init, .deinit = acpipld_deinit, .minor_tests = acpipld_tests