From patchwork Wed Jul 10 03:08:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Damien Stewart X-Patchwork-Id: 1958658 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=yahoo.com.au header.i=@yahoo.com.au header.a=rsa-sha256 header.s=s2048 header.b=MSPSwl22; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WJjcM4gKhz1xqc for ; Wed, 10 Jul 2024 13:13:39 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=yahoo.com.au header.i=@yahoo.com.au header.a=rsa-sha256 header.s=s2048 header.b=MSPSwl22; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WJjcL2yVsz3d2m for ; Wed, 10 Jul 2024 13:13:38 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=yahoo.com.au header.i=@yahoo.com.au header.a=rsa-sha256 header.s=s2048 header.b=MSPSwl22; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=yahoo.com.au (client-ip=74.6.130.42; helo=sonic308-3.consmr.mail.bf2.yahoo.com; envelope-from=hypexed@yahoo.com.au; receiver=lists.ozlabs.org) Received: from sonic308-3.consmr.mail.bf2.yahoo.com (sonic308-3.consmr.mail.bf2.yahoo.com [74.6.130.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WJjVz2RF3z3cBd for ; Wed, 10 Jul 2024 13:08:56 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com.au; s=s2048; t=1720580932; bh=pFcvWEYYdzbPah9aVh7w+TDgPDQHveH9QaoValF0lXs=; h=Date:Subject:References:To:From:In-Reply-To:From:Subject:Reply-To; b=MSPSwl22VP+yAVyJviGnT4s42skSPE+WhcXQQ1+rB1t+m7w4PDLTMrMT7U1QAL7+QkO2Moo2diM2VSQfc9SUKYKaaqFua5DI43uPrMOKMGgzby2ZFjTnf78j4JPP7UP+IaXYibYIq1+j/pe9B1mrMXJ72TWq28+xZvCqBWCxRTc4PtGM16M9PJhgY4qyLhjPbBb2VGaoDbNMFi3lypKbtTkFkImKV5IlkiHe1IFDtqm61g3zYxa2sxE6HatovZb0yiHmWLAbpVlQNt3+CnK7YRaNWbMxSfkbvIOrXobWRH5byn9Q1Nbu57+brMVGx+3DdD//27jBRq+nVfnKKNEhrg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1720580932; bh=jL4ysDo5zYVdeKV62oyajm6DqD4B8BNfYcb+70gkA/S=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=tkn17Mjmyr811+PVbI5gvGt7o+7wr4Kv1g+bb2gji0lcwVhS48d5p/n2iDXCR+mOKsnwOdingCUKTFRhw5rsQnYnM8nsjUOhGFQhYgFvV5qZxhn8urrXZumZJGAi7YLWZHEm+ERdBM2txYA39w8nxb85ENeRDTBhrp8nLohdVC/LPhRgvPwOR7p10yuBzfT4xzCwYCLIrF6F/WHUv7s3aCHoc3CL3jieY0x9Ci/n2jA2A1X3c9k6/DyoYHdA0stysVqfF5ON2ry0aN+ajP9hVsjH+GGpQfzIvcHfWMRiG414r8Ac64YGQeCIhLfgQpxGx1GagLQ2LJk2hkau1NX+JA== X-YMail-OSG: CWFgtSkVM1nQTCe5LCYWz330qh_Z0UsAjZm4m7.xJX8JEKm5Q3OBJRZsPGnlQsO OoZszET0HIFCb0iQaapBtglMLm4BFuwEIUQFJN5SQELpFcKio_mtmMEsZyOs8J6XpqNf58ayedUX tDU2vEGtas0eHivKzR2WfMlz1e8YYSVKqpxWM8eTTf8x4KwBunbKejYiY2jYFiuol0G_uF3r1YUN L4ddzCW5bkNEKhPkz.UBJVuc9d5mmCxOljm3b_jz04nIbqGuCyTd2PpCPFQ2uh.236LzEHbaENKd sVn396qEMCX3gqsHGzjyLpf.bZvrxK7Ij8.jI7WcE7XAFaJx5p1RFmUZ4rqbcdr50qDNBuFHBJuE k.pAAXmVI219PWxBq9BRv0i71dwgz6LC.prXH9hlFEJZf.8MDwEbXZHKKnrX8FunFrKAYhvQnmko TtAcWpcwNI_Jn4oLI543kKCDTKNR6IdDWDOu.EtaCfxKMXosPMsMInI.3XbrgcdWM6nwrnSfBfPr Ctrudat0oIo2lw0pBEb4sMkSNICSlLtBGKrmUsjo6fFzB_AKaCMdqnle4OAQD.nXlARcuUtojeS. bULrovOumwwZvTxBkPiUhlVzBlBXoy0etDRloe4WrGzBIGkHMWs0LaDuv5ISP_hYTwrTM6J4_87W hUCzdZifJ8bhGjq.w_g9RZLibu07qoHxsewaoUD4VyZFiuc9.H5Nw0afC2mmL7Ftc13JFOur8d6M Fs.Zlx11CCE0k5iR.rGZq8zF7oLW4YogCXB0NGrXezzM7aebvzQz0iA9McUaX6FogFYIzbanXoA7 jKOxSio18ZB298HA3IxAqUJRXe1OIeg_bnP_Q6nOIIrrpkpudYhzQobxCMpY67Lfry.xfy5QmpR1 iIDsJE_qOSWkzTKYBJzMYdVZ3baVruq_QoFwBTk5SZNBA3r7Tj4lDpzFbfHfc7k8ztT1WOf92s8F Uxz4gKGeeCA06pMImcpfUWldx_g1_TzJnTxqqzxa8jI1AchX3FiIqOK54i3_8efkAm8Sne4b_X12 2VP1p9F7uu2fdYLZByZBIdlScwf.wMe9Qr_iB7UpI9QSjOwK7mNRZ2eWGoBNl5Y99DNWAmJEOaQb AQr8nm2Y9ENv5LLUU2JLNdzkwC8xq.czK.hx6fOpcgZE8q9w6esv7_YUctsVBXP0cqunLzC69Sg4 QgSULE4jQJfL3ViUkDpnH0IcymWXwnXURzbcUOzq13B1YYrHiHxUbApJSIWtqD3TkzWpsuKo.kq7 XTchtYcqaNfKvt.OJLGflKWglQhOeVcGQt.0oRYDuIb50Ori97DiFFhSKYH8OMmd6F5vbap6X9xP rNlhpzI3IP9Vya2jcoiDmNfYv9SBibOoHLou0QoCCimkvpi.XFFAOdDGqSPWTxruQpJc13hKlGxx Q2h7KOsnTsduLYIi8LB4Q6YJ27d3FrldNCwF4UX7UW3c0eEy93cK5iaomXSWrx8bibqLIYRaB01V mf8wOUiCE0HHtCGmuAYqfabz8jNGDXxQ0v0diR7r861J93xFGcuYSUMumoETmWgSuocV4Zr0m8Xs srj7xQoevE6_hMJcxe3s8nlN2CpMdrhtQ8yY2tC2UNoakkQOANIh473qy8qfqYYnCE2O7ompFSpV lNb2ui88.3sOQsY2BreEnSFfagiARGjwM1bzgd2alPCbAthCF.fqbuIjVd1ccGsPmyaLDT63vmaU KNDuWjj6vQOg8rVISCsLeEJ5laijD5OBv.D9xzq_baVFtw4lpFQPP4SE.lpxlUaCUzzoqWBXyqMK r8PuPpkGFsc1VIJYjiS34lpFHd5YDlhTPCBDMBMah9ci7zeHIsuumYinAcTXWKY0MF_uRC_l8LsF yIQSY.CHzx2BJ7taSOq.EsZ8K8qps59GIMnLiVvOsbzcV5auxpyybsaSuNe.BhW9EOO0BhC8z9._ ZWHezViCHmttiZxHFuZe2hEP0OGMSP3qrOBTnaUBMbMKgRuNJfOn7bnVuf7AfTPAP_oqwD_4Sdm9 58o.TLadbElcOB5YD0QAwkg.5SdDIWW6ynZCguObqDKtwrSUwIt7XkKtSiRpAZHDKy5VvGrA2Z.7 ZVAr_j9tHVYiPuhp_IevAIywQWFLeUy23PLh2JTQ2bzpjvSx.ed0i8uNahQNWqZ0Ua_TgV6ODWYi nrkk70zLAqFWLNmWnD.JVOY5faN2eKViVWKejgxffu0JUmvHN.W3vhU5uANYgHDa.ZrfX58Rq4lw M2xnb_KLGr6YzP0.xkGrIL8yIaF_M.r4Kt21Ohcm5eQMMhXy2aFAGi8wqNHrwIFSBsNteKQ-- X-Sonic-MF: X-Sonic-ID: 117b8497-613b-4836-9ac4-9f1276b0294d Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.bf2.yahoo.com with HTTP; Wed, 10 Jul 2024 03:08:52 +0000 Received: by hermes--production-gq1-799bb7c8cf-zh7nt (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f0c035dff3d766f5f34b9e2bbb0401b2; Wed, 10 Jul 2024 03:08:49 +0000 (UTC) Message-ID: <8e07238a-06c0-4913-aec8-824c626f7461@yahoo.com.au> Date: Wed, 10 Jul 2024 13:08:45 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Fwd: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29 Content-Language: en-AU References: <7c578eea-02c4-40a9-9fa6-5e5c99c398f5@yahoo.com.au> To: linuxppc-dev@lists.ozlabs.org From: Damien Stewart In-Reply-To: <7c578eea-02c4-40a9-9fa6-5e5c99c398f5@yahoo.com.au> X-Forwarded-Message-Id: <7c578eea-02c4-40a9-9fa6-5e5c99c398f5@yahoo.com.au> X-Mailer: WebService/1.1.22464 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-Mailman-Approved-At: Wed, 10 Jul 2024 13:13:25 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 9/7/24 10:48 pm, Michael Ellerman wrote: > Thanks. > > Which kernel is the bad log from? Just plain rc6 with no patches? So, no, the bad log is actually from a patched kernel. I've attached the diff for clarity. > What happened when you tried the patch from me? I think Christian called > it vmlinux-6.10-17. Did you get any different output? If I have the correct patch this one failed. Yes it was one called vmlinux-6.10-17. It reported a (failed?) interpret command returning -1. Internet seems lacking info on OF binary API, but plenty on user commands.  Christian released another after as vmlinux-6.10-18 with a working patch. Also included. > Does anything appear before the "hash-mmu" lines? Those are from the > kernel, we'd really like to see the output from firmware which runs > before that. > > cheers Sorry I managed to cut that off. The dmesg actually does the same. I've grabbed another log of both patches. diff --git a/drivers/of/irq.c b/drivers/of/irq.c index 462375b293e47..c94203ce65bb3 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -81,7 +81,8 @@ EXPORT_SYMBOL_GPL(of_irq_find_parent); /* * These interrupt controllers abuse interrupt-map for unspeakable * reasons and rely on the core code to *ignore* it (the drivers do - * their own parsing of the property). + * their own parsing of the property). The PAsemi entry covers a + * non-sensical interrupt-map that is better left ignored. * * If you think of adding to the list for something *new*, think * again. There is a high chance that you will be sent back to the @@ -95,6 +96,7 @@ static const char * const of_irq_imap_abusers[] = { "fsl,ls1043a-extirq", "fsl,ls1088a-extirq", "renesas,rza1-irqc", + "pasemi,rootbus", NULL, }; @@ -293,20 +295,8 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq) imaplen -= imap - oldimap; pr_debug(" -> imaplen=%d\n", imaplen); } - if (!match) { - if (intc) { - /* - * The PASEMI Nemo is a known offender, so - * let's only warn for anyone else. - */ - WARN(!IS_ENABLED(CONFIG_PPC_PASEMI), - "%pOF interrupt-map failed, using interrupt-controller\n", - ipar); - return 0; - } - + if (!match) goto fail; - } /* * Successfully parsed an interrupt-map translation; copy new