From patchwork Thu Jul 4 14:47:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: CLEMENT MATHIEU--DRIF X-Patchwork-Id: 1956926 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=eviden.com header.i=@eviden.com header.a=rsa-sha256 header.s=mail header.b=SQiMwa9C; dkim=pass (2048-bit key; unprotected) header.d=Eviden.com header.i=@Eviden.com header.a=rsa-sha256 header.s=selector1 header.b=OwD1Szdy; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WFKKG26fPz1xqs for ; Fri, 5 Jul 2024 00:48:50 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPNkh-0003P4-8C; Thu, 04 Jul 2024 10:48:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPNke-0003OL-MJ for qemu-devel@nongnu.org; Thu, 04 Jul 2024 10:48:00 -0400 Received: from smarthost4.eviden.com ([80.78.11.85]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPNkd-0003KV-1N for qemu-devel@nongnu.org; Thu, 04 Jul 2024 10:48:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eviden.com; i=@eviden.com; q=dns/txt; s=mail; t=1720104479; x=1751640479; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=iKgWTW73+sONWU+F9uuFcnPrFDqHO//Sx1zKx7/KBTY=; b=SQiMwa9CJetiQJHx35LmIpI3/UCo1yz3IC6lLqlpfXAAKBW5rXYXriZa YUnAveKnyEp/t97hEj4LeCfg3RJr1XzK9nz0EY44h/ob/FmFUkqhR0q7a Sg+CSyz6Uls1/KebJtabPpp66bzK3PWJwYpXeIlHhTHmoTxwSwBoW3JuR bmqZn1UqjH+ZaKrJJE/ST+FZEC47fDN2cvvqF0DvvQx2mfBiDWOzGH/q9 TGGumM6RUxOnlbVjguyLh7Oe2QAEU5Eyw+YECtPpNPh6T6FmQboZpfFdl KMsy54f/hZwRUJRStRNj0rSVwmON9sDbWqDl+9eZzo6T5EgywYDZqLtPZ Q==; X-IronPort-AV: E=Sophos;i="6.09,183,1716242400"; d="scan'208";a="16005881" X-MGA-submission: MDHHAwn0dQXRYrONlGIN7dz8bDAZUDLaNcZp05xRK5Gh0+ZB+1vv+5iA8Z7VMQuTaIPdOGFHQrafqH9OKSb+y6wl+sl+NqrNBrwZLK7hF7JZF+wzN0zb2yrwr0mD5zv+SJkss+GcfHCA0ArWJ8ONapguxzXcPQfXL5xZu3xoBZaB4w== Received: from mail-db8eur05lp2105.outbound.protection.outlook.com (HELO EUR05-DB8-obe.outbound.protection.outlook.com) ([104.47.17.105]) by smarthost4.eviden.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2024 16:47:57 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ISlvHX5/kGRuV6A22897bc4xHpGOzZFlUWvAtdudBwZf/OiThodjeT093YQuVUs4BxJdGKZSRsLmYdRwkZMA/4CoPFD1imk/oO6qV5gu5N+OIJ1+OGcLhffSdVATTWj6adVUj6rrSIvkuFNSfoVrJQcguWY1dannCZEh2mzfRznAT+bttT/l4xds/9MDHTkLUVgInFhzU1yUrK3avJmlQKy3NfKiMQQWbw3SY3JwpHR/yk9pb3TZERQtd6ZzGjFegTpDwt3tZEaOYyReP1Ek37bpGFiE9YPnaaUAolXBLJ+vSsGuxkGynHTUqwAqIgQ0kCJ5V+gabAOFvQXZCiZ1tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iKgWTW73+sONWU+F9uuFcnPrFDqHO//Sx1zKx7/KBTY=; b=jxnWGYZ8jFioIfrWEBfD7/qL7y/bvOhpKylGzGcMzui+sRTmHWU//5j617L8f91zKxbfYlZJWQzqijbSje9YG8lTlZA6rBsvtgt+q1eRNdd12gkGV5WTAZunOaclhqkzTO8kgWBMe9TWfpsMErezclE6jwJ4MPTVGA2lcq/+KKYrhmvhcgyL9eVBqw7whmL07aTGjdMxPi42h/2ErA5kdXFC5fk+A5l2ded9ZSCPkuZ3lgt1Cg/9f5yJsUunIomFA+xg5SzoSK70TWQr2snK49DXLjcPvjTXjUhccCtSQPnDsDp35uN3OZTC994GXfE83LK/pRiEkqu3KKv0xA6w6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eviden.com; dmarc=pass action=none header.from=eviden.com; dkim=pass header.d=eviden.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Eviden.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iKgWTW73+sONWU+F9uuFcnPrFDqHO//Sx1zKx7/KBTY=; b=OwD1SzdyrFiW0gtV8ks48F3EjsOovFUC7uqdFT3Ai+4HIY3zcdS0uyB4LSuoH+4NUcWpvdybXqj0EFFbepI/sDPsPpM2QfmLSwnD5zOszckOir+9FoV6+ljnPKRPkmSda6eN1zf47b2SRxaL0IZ24g4OF5g/NEr7t+zIRWdJsLmsWQBkEVM8nxTDvIL9M/goRSX4ogkJ1d2PF94MxKS/v0FSuwivdbp1UoPZord1ulpDLNOFmMKHo8lRsFTnAL2InGgwpyhuUYHTqQwhOOGoyEFh9Ld0lYEr4CWTDMZmBAAbYUrJ1Q+QnJqCpbCFRRst5rrhZ4vuYPdu0wUYyh32vg== Received: from AM8PR07MB7602.eurprd07.prod.outlook.com (2603:10a6:20b:24b::7) by VI1PR07MB9499.eurprd07.prod.outlook.com (2603:10a6:800:1c8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.29; Thu, 4 Jul 2024 14:47:55 +0000 Received: from AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d]) by AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d%4]) with mapi id 15.20.7741.017; Thu, 4 Jul 2024 14:47:55 +0000 From: CLEMENT MATHIEU--DRIF To: "qemu-devel@nongnu.org" CC: "jasowang@redhat.com" , "zhenzhong.duan@intel.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "joao.m.martins@oracle.com" , "peterx@redhat.com" , "mst@redhat.com" , CLEMENT MATHIEU--DRIF Subject: [PATCH v1 1/3] intel_iommu: fix FRCD construction macro. Thread-Topic: [PATCH v1 1/3] intel_iommu: fix FRCD construction macro. Thread-Index: AQHaziEntPU4BZdwwkqAjCf6BiuOgQ== Date: Thu, 4 Jul 2024 14:47:55 +0000 Message-ID: <20240704144737.996889-2-clement.mathieu--drif@eviden.com> References: <20240704144737.996889-1-clement.mathieu--drif@eviden.com> In-Reply-To: <20240704144737.996889-1-clement.mathieu--drif@eviden.com> Accept-Language: en-GB, fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=eviden.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM8PR07MB7602:EE_|VI1PR07MB9499:EE_ x-ms-office365-filtering-correlation-id: 3a3d150f-c827-4e6a-55d2-08dc9c384a32 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?utf-8?q?zSO2DL0rRDzh3tNDThNHprweg9KTUT/?= =?utf-8?q?LeRCdlYEycOiVgT4ft8ds/2JWgz9tIbLz+Djg3r7+Ty0zGvwjhIxycbKJUq1iWYdZ?= =?utf-8?q?Kr/Drn+uIxCYOeRUFogrKGKSK8/p/sGL53RKHnJLuYpxlpAHJxxoyEKqsnUVfTHgA?= =?utf-8?q?bNBx6NahJ+9JogxwgnrHKaO63zztVsZWXsM0N/qyVVQE2pTBfOZ/LfA5How62285J?= =?utf-8?q?zzbL8qIoZxtSLTi7ZMc5QHeU5iOGrc+WwXCX31z3s+uRsgb/N4Z6eJXo2fgnoouq9?= =?utf-8?q?EjTfLuxQeYeDp8nhWspN96TFK0PrWMVfmqiXIAa7/ZdHeu2Iuz5TbLObpUiTu8d1m?= =?utf-8?q?+v5I23GhTi8vHy7Nmv2DlomlpbLi1Agd495DHFWy6xYdOAoJZu6/n1QKmbBs3S2zq?= =?utf-8?q?bkFuKnvgdbGWFWHi+DlhcDOPylAO2ci0XR8g2K/a4hLrGH7I7QBAPzUXuSjsZWP2R?= =?utf-8?q?NRqK3WMczZdJIkhJVJva50zmhMHN8tFoq2y780z4el4nt1R5WYR0o5GFxhS7z3buv?= =?utf-8?q?ywoMGOtBFjM6G/wSixZaNrsePzvRast9IbIAeXthi/kCZ5tzB+5tZppEMgvL4Y31l?= =?utf-8?q?MONGmah72LxUk5w7r6RWIKhAUo5GpWxgFfRGe9p7Oq2qCNKs4ddw/OE27wm8nDauw?= =?utf-8?q?8dYKMfOsCU4+D3UFSoQYMjMxkdU9ofgurM0Ybscoq7CpVRF1oe0+efY9Uq2Wq3cO3?= =?utf-8?q?rzy9oDldID3KpSzOfMAzxAA03kQ4OaAtTysEvvMrKxGMu5Hz4QG6d550uy7IsFdYQ?= =?utf-8?q?Z8rGDqzJqxozfDuh8uF4vxDp9stUzuAnFDwxXSns0breWb1VV/z/k4b+jiEhqRXce?= =?utf-8?q?nk8iJH7OV1wnAx02xBBU7ZLvG7n9txRiTlvhZ286/8F9HMxfaAtrOnZFbHtXTeUO6?= =?utf-8?q?uD+UXYdjnb47g2l/5Q9KLUeQkFESdjlBszG1BaxAbNZNSz/isFVpDVQaNsZT+Y1fC?= =?utf-8?q?HALK9IKZpzbbUTr9QgQtxBVwi5/5h7nixMgmsRPBIvlIWWn45FrEc4H1dgSkxDLeT?= =?utf-8?q?od0wIYBGLdB75ZCZG2VgFoS/HQ0nj0bcqPSEZ4Zdmv9QB6nawG+R3SZJNsmC+5gmM?= =?utf-8?q?hlyFABzIzoZMRL9QcNzHyMYyF/tEH9FoERsBdfTsg6YpZuYkMQu2ceGyRVcDURx6x?= =?utf-8?q?nxZfaz+FFykJ+8SYQS7nSa19udbuCcUIcxb0jUf7JnQjUl3vOBaLPGBGlT0rmqHIq?= =?utf-8?q?Rsi60W3gNux+6bZ8XHuTjJTFZKBguMLE9yE/xfCy2v2eJTSw0ABSG9GDHCUQAQJen?= =?utf-8?q?7UlIYKRombW+uPNtdT172ep0vpn/tqitIoWPXHxFjkJc+Eq+rFUzgi3P1QGnTeD94?= =?utf-8?q?eA8F2NZECyAnvVlg+5sN5LGhRGmDWjRldQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR07MB7602.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?n7YCnSbZPDUs5a/pJ3H13aqPGpsz?= =?utf-8?q?hiEMSWJNPFmb/MIEEmkZUXdGWgVlSCafn3+7HXWC8CLccRYZw4egMq4WyXN9V+Rbw?= =?utf-8?q?A8h5ymN0mzAWwcQEhBc8DdfwamagcBf/9fEzIJvboK9Zpc9vcTOS3V+n6//LxvGNW?= =?utf-8?q?XI+7Mx+lQpIpR3EHNyLiEqszojLUKPMsBU7nHjsDY9n6K6AF6OJ1u3Gc6vJIqwuXl?= =?utf-8?q?z7nQjiFblHXtjUPv9g9BEKBj1ATtA49PhJRC4Lq25CR/QDX5Og5yjcQ5Scw5ROs6Z?= =?utf-8?q?qrEVLy5WmFeibpj4TnM7cBW6xGZszhHZ6n6mqlSiVmCPm47prdjTkCcoV2rKZ0ABa?= =?utf-8?q?zdOTpNvAn2APPppu082sBFmUFZHAM2iZat9cpt/vNKhe4SG264thkQejm4xWv4n2T?= =?utf-8?q?XLW5sr77c+5itu+ftC6FFr49qxFmUKehpzfdULoe0lAznvc10Mtgus1Gnn2d4H9eY?= =?utf-8?q?lDoPHJ1Kybm/u4yBclmTkobXisJvopd6Dasu3t2piW+td8wuBsKLZuhH11p/7DEBG?= =?utf-8?q?B7inydtd8zllITXCSo5eeXiEYJF6+X65/tF0kvOj38/6FwJ0v7drE9o9nlOCIrven?= =?utf-8?q?5FlWrYfIZXQVDDs2WLnn2ElyUrg+tMj5OQEL7MtgtI1kFJZ9eAypilIRZXnLH55Qb?= =?utf-8?q?tJYzxYYWmWQff3HDLyJFFXC3spfB9KfC6ySCS48GHMoxMTYoPiq+NBj8rW9mT1ZAC?= =?utf-8?q?oJJzsjFAuVF/fmYEwz9U1TTRAZD9uosS7RHkcqazbIY69CAE9tGPm3FGCvTMKyK2l?= =?utf-8?q?gGuc55Sb4ZBhZKmiHTmAbifwNdVmkyeAtqFRhTV3TflQKSVycj3LTSIgMjee1QBNz?= =?utf-8?q?lzFV67X9GtbxA8p1/KFKEzdKHm2oCpDq9/rrYpRLu/ROKqd1SaQjRCD9UAo8Ncrc6?= =?utf-8?q?td0vtLY++PbM1OV2fwIsOelXx4qhlpFIz0fIS/m6hPm2xgFeIJFHXGp8e2JBHhzZ/?= =?utf-8?q?xhI0oCsL1+efPDNZWIezo+J1K8k1L8yapUBgiuQTTlYB23Qimd0LdiDz49FFpTop0?= =?utf-8?q?RjBpXiPRIgVyVoYn5Au6WfcUYhiPtOLFcEfb1USwC0iMZB9sZh2U2POlA0Y7ZO7Er?= =?utf-8?q?ueWln+d/6OUy0Fx9N2Betkol+V8uGAx0C14WMBXIvguj2Wvy9V+I+QjYb0J4bT4nC?= =?utf-8?q?mmkb1u2lgceQ3Rb/mlUTJuPSYRlcB8FLXRaSCoXUqacgfhllj6dL4qTRRbNLc4+ef?= =?utf-8?q?fk+hc0/13dmaPNKqPb2lhtHqv7yIRox1b3uv5Oaaz2bAl4/HtuE5c0p8obPCHqRK8?= =?utf-8?q?HA0jC7KCNow1v8Z1kKm1rftIz2coqNvFrM8ZAwAzfbcPYuET338UXIVc7AfwE0XtW?= =?utf-8?q?KnlsTeG+T1hknKSWIFdWYU/2hOuCcntJNzQfPHkcuX6/BmozIUYEa+WEHT2VQmyR3?= =?utf-8?q?7efow3WVrXRMSfjb3xA/HAgMpBGzBpjAkoaM4AMz12phryU+K0lzOa9LFNjZUisLk?= =?utf-8?q?/hZTKO1Eare9kepyFLq639K3zoBK9XtUZnNvhleMzow67awl5b/I1H+kS8Ad6EiQj?= =?utf-8?q?YYEF91Z6/Lo2lq55WIzuj4n0jW6AmE5rkb0O8lwNo2VBK/HyYUMRTTo=3D?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: eviden.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR07MB7602.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a3d150f-c827-4e6a-55d2-08dc9c384a32 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2024 14:47:55.6102 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7d1c7785-2d8a-437d-b842-1ed5d8fbe00a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1Wx/DDKasGc7ODiYT5h4lElaJLdAgUPaSQZ1QawZj8kl53Hgl9Bv3RPzplSZyFfplFh7f8pQQiQ7O02UJR5lo2o/9bKQ2zWWJdNfVak/1CylsPEW+QRA1plQQOu0uVyh X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB9499 Received-SPF: pass client-ip=80.78.11.85; envelope-from=clement.mathieu--drif@eviden.com; helo=smarthost4.eviden.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Clément Mathieu--Drif The constant must be unsigned, otherwise the two's complement overrides the other fields when a PASID is present Fixes: 1b2b12376c ("intel-iommu: PASID support") Signed-off-by: Clément Mathieu--Drif Reviewed-by: Yi Liu --- hw/i386/intel_iommu_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h index f8cf99bddf..cbc4030031 100644 --- a/hw/i386/intel_iommu_internal.h +++ b/hw/i386/intel_iommu_internal.h @@ -267,7 +267,7 @@ /* For the low 64-bit of 128-bit */ #define VTD_FRCD_FI(val) ((val) & ~0xfffULL) #define VTD_FRCD_PV(val) (((val) & 0xffffULL) << 40) -#define VTD_FRCD_PP(val) (((val) & 0x1) << 31) +#define VTD_FRCD_PP(val) (((val) & 0x1ULL) << 31) #define VTD_FRCD_IR_IDX(val) (((val) & 0xffffULL) << 48) /* DMA Remapping Fault Conditions */ From patchwork Thu Jul 4 14:47:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: CLEMENT MATHIEU--DRIF X-Patchwork-Id: 1956925 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=eviden.com header.i=@eviden.com header.a=rsa-sha256 header.s=mail header.b=nwpRLJWu; dkim=pass (2048-bit key; unprotected) header.d=Eviden.com header.i=@Eviden.com header.a=rsa-sha256 header.s=selector1 header.b=X6ilOpyH; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WFKKG2JJlz1xqt for ; Fri, 5 Jul 2024 00:48:50 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPNkk-0003QZ-NH; Thu, 04 Jul 2024 10:48:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPNki-0003Pe-LS for qemu-devel@nongnu.org; Thu, 04 Jul 2024 10:48:04 -0400 Received: from smarthost4.eviden.com ([80.78.11.85]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPNkg-0003Lq-Uk for qemu-devel@nongnu.org; Thu, 04 Jul 2024 10:48:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eviden.com; i=@eviden.com; q=dns/txt; s=mail; t=1720104483; x=1751640483; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=2svyLmHlQ6d1l2Iag7bhkpug/Bb2fDl8x+3PvU0cF0w=; b=nwpRLJWuDl9F0k0yKs3ZL8KwfaOPK1gxqitfYOMfqcU7rLB87ZGpT4yX hsvxbne1c5miALI0hQ1yUER2Pj6vF2YKFrS0gakvotwTYAqKFzi+EA5BU 7qCAnR/tR0QHMVYRU+yYVODSFPmcGxPySURh5GUIj9XwyineEUTDaO2Vb /symxrfiB45bg9sFBFbg3xqQY0zpPabKh0GHaHaOBsJjkA9cU+DlieFzv +CG9Vly6wCEYci+jXl/BnYOQRUL4msQZwzLRNQANIj3XAbTJY9EV6SPT1 0d+AM8YONLqT2D4KuIzpLCEE43rXiufjIi8PkYp66xtoylhe6hSURe3ak A==; X-IronPort-AV: E=Sophos;i="6.09,183,1716242400"; d="scan'208";a="16005887" X-MGA-submission: MDHvxumJxW+xlRTDGNcApb8433uaACFQtIPj128wY/h2RP1GrNjNeB+1EWlf0UhEYlhtQID2TJA0/dcJkDaSEKxkAMBKAZD0YqMW9hPs5NzxmnXNxwLEQMglMxdFg6BtvzHS3fgfsTSPazjDOXmwQHI4UuvfX9jQRehaZ7dc34Lm8g== Received: from mail-db8eur05lp2104.outbound.protection.outlook.com (HELO EUR05-DB8-obe.outbound.protection.outlook.com) ([104.47.17.104]) by smarthost4.eviden.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2024 16:48:01 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AVf5W14V3tB0wlRChXB2HhZPZlpCAxiXNGdDPkYEQc7idmKe4gNz2JnSBPwq5uVtFiG/4fQg8R92W3bPon20dueKurwgcxaWn/FNprAJMuPfR4NGRqClXMOAtk2kt8Pkn6oborvugivo1KJjgshTzgl1Vx7Pw/qOsr4J9CC172fhsKJQiVXZ+FwQmBB29uyZOa1MsJlQlEk643QT69DW8Ia8FPgS0ildQzFoL+EHIaQRZYPI/UNXP1f2o2xRoKyJ/7Tozht8k8t1Ik4Pmtp3bbT06vrAwsxUCjld4L3UG1lr103G+6ihhLGXKDbpaTgm2U1FAvQPpaSGz8LiEgTQRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2svyLmHlQ6d1l2Iag7bhkpug/Bb2fDl8x+3PvU0cF0w=; b=K3JnJcmwIIU0/bxs3QVoW1e9A+Sy+gYpUF5UThoLqKtaeh+X/SHxUSTLz77f+fTZjhbvSvLKxuxzNydu9IWyF05HhDIqMNNb1ZZXnCUkh5YzqAWH9L4ZNcmCdmXVwVIc3ZWrH5pAB2lzsRULten0id7AOMjYHIrmRUv6BtonSw6YsWinIVOTVPCa4S/do0gxPRYBijjeb6pm3le4NLsUyg+rfTS9pjgojWixKvjzZznxcK59Qi70fNC043bBFJdcG+1W30iAbHAXLrIL/EMkZi/wV9eY14vlTfM9lc88JcZ7iMQW5OCwSdS6hbvTchzrtQ8iopuvtkOmzDuZibEw/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eviden.com; dmarc=pass action=none header.from=eviden.com; dkim=pass header.d=eviden.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Eviden.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2svyLmHlQ6d1l2Iag7bhkpug/Bb2fDl8x+3PvU0cF0w=; b=X6ilOpyH3OlPuUKf2S6f8GjjpdlEcPQ3peKaVLOGQyEZDvRSGVnwDHeI3HXG1ILXj82SH0NXIAqVICT814fbFfkSR4pCxu+sJrnGX7dxiRrpKNAIaR4Qb74jefzwjqqpahcfV+zKSs461KRJyg2glIsEV95f5IAhEWWqmlQuLpNuSkJVxlOxz5h4GqfcNHkPjZjfqC5xRhto0OUG/VuvgFJN4jGJMogUsXo+ptyS1EL+j3sNDszQBm8cwgJe6DsCRwvnRxiVZA++IAPF2ubou7FzG81z5tKLWaPdXyW2YmJfsuB4EHTaC98+zqv49q5OOFtQaniSAs7cPhxOnEsnzw== Received: from AM8PR07MB7602.eurprd07.prod.outlook.com (2603:10a6:20b:24b::7) by VI1PR07MB9499.eurprd07.prod.outlook.com (2603:10a6:800:1c8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.29; Thu, 4 Jul 2024 14:47:59 +0000 Received: from AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d]) by AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d%4]) with mapi id 15.20.7741.017; Thu, 4 Jul 2024 14:47:59 +0000 From: CLEMENT MATHIEU--DRIF To: "qemu-devel@nongnu.org" CC: "jasowang@redhat.com" , "zhenzhong.duan@intel.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "joao.m.martins@oracle.com" , "peterx@redhat.com" , "mst@redhat.com" , Clement Mathieu--Drif , CLEMENT MATHIEU--DRIF Subject: [PATCH v1 2/3] intel_iommu: make types match Thread-Topic: [PATCH v1 2/3] intel_iommu: make types match Thread-Index: AQHaziEpnBS59oBIpUuVMnrpPnUfBA== Date: Thu, 4 Jul 2024 14:47:59 +0000 Message-ID: <20240704144737.996889-3-clement.mathieu--drif@eviden.com> References: <20240704144737.996889-1-clement.mathieu--drif@eviden.com> In-Reply-To: <20240704144737.996889-1-clement.mathieu--drif@eviden.com> Accept-Language: en-GB, fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=eviden.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM8PR07MB7602:EE_|VI1PR07MB9499:EE_ x-ms-office365-filtering-correlation-id: 078e6f02-8941-4a44-235c-08dc9c384c78 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?utf-8?q?U/NTGl41UvsBAlvFZhze7USaAF4avPZ?= =?utf-8?q?TNLK9fhAQsKtv1k1IJ5XmlelrXY8b+XyW3kRXhBC9hKaP7We+rZUXy2i9PWiosAyj?= =?utf-8?q?8IMlPO4uacgH8DdUXH7YPCxT4ovI1EpeFNtXWvP0uHKlTp1gdvKkpGfsQUPqnu4F2?= =?utf-8?q?DC6gxt149kmkiKcx+4xgSPA6oWXYcgIQOQfTozXZtncjw5bzB3oBU+FUOXwqvLIg4?= =?utf-8?q?/krQUtloZaM7RXMxP1Ajf6ImhIymKDkaEdgmpf/ofv7wcSCUR1XIPT+vSVZOXYlGG?= =?utf-8?q?OsP+2JX00au8s3I+FaRQeOwJOmupz1vXQa4iJy9MRlqHQvgJhzIkBvqfDuCos/be6?= =?utf-8?q?A49wZ3qCbXwmqTvWK9M2zVyy8s8sw4rDMCXKE9FPIpESY16hgGyDm/3HmLkG3aRcA?= =?utf-8?q?fVq0dMqV7hAPcLKZHrd12TDMHT19NgVkbi9sESWg6O1zBhWegC2SDVFVqac0adL8T?= =?utf-8?q?Z+1p4F6jScbGKgR1GpWNkDAqJ86QRxHYarK/d1EMdXIh8hBdmYj3sK/DxP01rvmic?= =?utf-8?q?aXOurzcHxcnhbTXQEj4a4TxQbPUhyWGAOd1fKRs8oG21nTRkt2ustdZiJ2MsdGwL9?= =?utf-8?q?BSnCzRDH+c+P1EtYzFuJMHMqfDMJdkd/HM25rmxiIT6xFw090yci00kgbpR2awV7M?= =?utf-8?q?yXy/+JOldT6rxS1Bm+pGWICWiHptY0nT9zXu1GmASp1f6817C0dK12EEj0LuAVfvA?= =?utf-8?q?zUowiYQW7dEA10/bi8GoOCqZdG2oYyQP8VUlE7BIxxEsUBZDiayEYxZRjtfXkg0MD?= =?utf-8?q?HICpoC4wbK7mHNA3Jtd3xl1vYJUaSqT8R+M1e4q06E7KAqTnSC+8pC1WGJrLnzsyB?= =?utf-8?q?cb5/4z9qx56JxuyJe8cWnynzUEiO9AWYGahL5ppH7M6/3eHiDwTjG2lS3Xp9z81Qd?= =?utf-8?q?o0yvtDz3Gy5jZkX4fNvfIaRTZTObrR2iDFdddvN70Npylgm0+gSAViUKMKxIPLWKU?= =?utf-8?q?+TrS35BFQaf8pppdW7Maa3xqm9q2i/aMf5HFsIVMMkb3VBDaBmJi8ayoztbbH+OCM?= =?utf-8?q?/nkUEUNTDCKIsPw2uPOqXXPr0tDrO9h8ikp1JVZAoea0XBWQckzVUHkYeySjzPtgT?= =?utf-8?q?XkOuEJR/QhQfoKzc5UIRE/NCmN1VSrJpzERl3gZhNC+SOh9dS/f+Sl5+f49LDcMRM?= =?utf-8?q?PAbbgkcnWOyKk+nijXcV4jo2qd0aQqeu1knQe6Gw5mgXyEkICMlescPCs/QSQ3Viq?= =?utf-8?q?pd3xzj0RJyv0musrL2W1N+tVYL0SOsM52J9E5nFjHXaOAKbhTeG32Elfncii9vzUl?= =?utf-8?q?sm0963VOkSXNGoElfklrHkVAvS4iyTPvCxPNwuSIEOi504rY19BN6T/hJs21EicsE?= =?utf-8?q?NH5XLR9Sbrf+o5q4ZiZzjJdc6fdNzeSdQg=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR07MB7602.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?1ML8rQnRFq4fN2XLWndupg1+uSoR?= =?utf-8?q?PeAXmnNlq/JiAYWTrjhasZKxNGvV2NSw6ftbpmH/XLK32ydpFXImZw9USp/u6DhJs?= =?utf-8?q?mIQFQ871DK5LvdiLrx3kAGnrrndjC4jAcuLruEDaVoYI18+mCOHbxS0co0woDZy/S?= =?utf-8?q?vml9vklj/Jyu4cJ8kv6a+TJISelojajbkaohrh4jq7cJxRI+cnO3J1K6ng1dwAPd8?= =?utf-8?q?JlwOzCSjsbp++KtoUM41vOuuB9SdedyKAFcMdJu3mXjg1iYTd+7XqyE76Ogxd+WrS?= =?utf-8?q?EvxCBLydfVfKW+GLHy/Vip0V6Cnevxjkeu+aFX4X5FdOAkc6KRGabqusl6Lh8VReN?= =?utf-8?q?uRcjA8kJ66aHKY9TZsEeUDoDJzbAwOkvWObrVupO88ZQeQKElmf602YMw99ScVJNE?= =?utf-8?q?yz8zc8ZeW30QgdSiGjooCXR5inoKXqOFiaHzSBb/7LXK8We7SY/9kLJw3u2xf08/q?= =?utf-8?q?1BtzGXNk3TUHGn6W1w/oTc/uyQ1/PBAXvEVGXEUD3sGwVqLD9rF8iJdcNT0lHetEs?= =?utf-8?q?CEIweCmnOSNjSwu3vz3KE2q8UBcWFVWr4oVh9hZj2B6nJcTYNypbijv5t/u38/j4/?= =?utf-8?q?4TyP1JRCeFYUcJEsx2zH88EzEH+4eh9Z5lLeiWL9A8uhTT3fEjqc4EyCyHBPRqlOx?= =?utf-8?q?6cw/7gdPMshXe1sVeG1P3jfksWnUdF3L+IhLJ9Iluwiv1uJSyfK/Us+Zi27CHRn64?= =?utf-8?q?lp3NHlu2StTx0O2yNzxO4TnITVf450hzDRBfyas1bQJJGJo9R4ocaK8JIWeW1uj0b?= =?utf-8?q?uwEny2yRo//jGRlQYxRXUtkhVZdxKPDypas4qQVYpj8YllugS9IpYbU2VYqceM9sr?= =?utf-8?q?NbX24SmT3x+RpWemwq55TZJiN1jWa6bcMSIb27TUuPBScTfIgAzqkA5V9f5qsEXhe?= =?utf-8?q?wPYJT6KvULUKcSN/YmZYuJ5tXiHo8ga681j3jVFWlgmH8n8EpOuiKZ0mJZYaaS4je?= =?utf-8?q?KoHqTuggQPZPOekpHn83ue6wT/gW0LDS6pUCaicACliOI1dinteP/RpqWzLT+T2kt?= =?utf-8?q?MgK6jnvMKHjn3mRyHGTGcKIuWzQEGsk4cp/SoiWC+UqOgHHEatAyIPHMEeGZ+/tbH?= =?utf-8?q?GltgEdhz1B13zIoaPulvzxEWVHx0HZ/fBb7n6ap/gEMFhCqPFA7fEf2QpKz0mQIOl?= =?utf-8?q?9prpttnNEWrVn0BJFZR3CRFY4lrFRM9fWx5ZxkaYmP/Vag4kQdH7fSi7rWNTaiJmK?= =?utf-8?q?e1hthY7aY7q6OHTLQMtiVkqlOP1fRZPHxKzv6eGNJIoykii/vGJF8tVjkcmdK13jM?= =?utf-8?q?nYo3SngpvOe/6mbrOIMJLy0j4uyPcsr/EDWixVFHQj0YGg9gh+S8U7bHlayGGipCu?= =?utf-8?q?c8l7O/1r8s9HTA1d95v9AMbBbn039orrk6Xk81mpdIP9sfOGisZ+oaVY1iHJMxkQK?= =?utf-8?q?IbSvKd2nildqZtHQZdVWF9eKDWVa/mIJ5GkFkdSUj6gm6AEbf5HTsfGjSzBE53+/c?= =?utf-8?q?hreM+Fn24Msc7psMPw3HEFEoXcaBKRRhujK1TBUHE6VMG7txBcoRW/je6t7W8IoMq?= =?utf-8?q?2CxvayMAG6YEL0NUoxk6Z7p2onxqejyh9PvNBEAKh4NoIYz7+F0Qwgs=3D?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: eviden.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR07MB7602.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 078e6f02-8941-4a44-235c-08dc9c384c78 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2024 14:47:59.4631 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7d1c7785-2d8a-437d-b842-1ed5d8fbe00a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FWo9zLY5LXmPcvzneebd2UALRQFOHmy513cPPXABLK90QV1lzvoAXZ9/Sfx0ziH0AjYS/12nsXHFQreA2Nsu0ssmF+xQLCozBUkg6c5yOsa6dKU4SL3OnnQEsaLsxYSj X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB9499 Received-SPF: pass client-ip=80.78.11.85; envelope-from=clement.mathieu--drif@eviden.com; helo=smarthost4.eviden.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Clement Mathieu--Drif The 'level' field in vtd_iotlb_key is an unsigned integer. We don't need to store level as an int in vtd_lookup_iotlb. VTDIOTLBPageInvInfo.mask is used in binary operations with addresses. Signed-off-by: Clément Mathieu--Drif --- hw/i386/intel_iommu.c | 2 +- hw/i386/intel_iommu_internal.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 37c21a0aec..be0cb39b5c 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -358,7 +358,7 @@ static VTDIOTLBEntry *vtd_lookup_iotlb(IntelIOMMUState *s, uint16_t source_id, { struct vtd_iotlb_key key; VTDIOTLBEntry *entry; - int level; + unsigned level; for (level = VTD_SL_PT_LEVEL; level < VTD_SL_PML4_LEVEL; level++) { key.gfn = vtd_get_iotlb_gfn(addr, level); diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h index cbc4030031..5fcbe2744f 100644 --- a/hw/i386/intel_iommu_internal.h +++ b/hw/i386/intel_iommu_internal.h @@ -436,7 +436,7 @@ struct VTDIOTLBPageInvInfo { uint16_t domain_id; uint32_t pasid; uint64_t addr; - uint8_t mask; + uint64_t mask; }; typedef struct VTDIOTLBPageInvInfo VTDIOTLBPageInvInfo; From patchwork Thu Jul 4 14:48:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: CLEMENT MATHIEU--DRIF X-Patchwork-Id: 1956928 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=eviden.com header.i=@eviden.com header.a=rsa-sha256 header.s=mail header.b=BYXF9B67; dkim=pass (2048-bit key; unprotected) header.d=Eviden.com header.i=@Eviden.com header.a=rsa-sha256 header.s=selector1 header.b=LRSmNWLT; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WFKKh1Vnmz1xqq for ; Fri, 5 Jul 2024 00:49:12 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPNko-0003SA-DR; Thu, 04 Jul 2024 10:48:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPNkm-0003RE-CT for qemu-devel@nongnu.org; Thu, 04 Jul 2024 10:48:08 -0400 Received: from smarthost1.eviden.com ([80.78.11.82]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPNkk-0003Mu-J9 for qemu-devel@nongnu.org; Thu, 04 Jul 2024 10:48:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eviden.com; i=@eviden.com; q=dns/txt; s=mail; t=1720104486; x=1751640486; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=QQb36lRclXYTkFjtwY0m8Lyj053oQOM+CfZ9/7UX5G0=; b=BYXF9B67ECto9NruHiUBh/LPTSuLOjRN4UK1+g8xBmqFyOQek45qaCpN /KogIaKwyKFvQXQtk4YsiB9nSmD3W1IUeaYnyzWrGvfOS+Qy5F87j1Yim +M9EOpxzcQdvknEc5znGHlhIiTO3eFOXGnqu1Na34Z86BCtipmE5rb/Ru yzL7EOfXyt3bNJsEN2IojELYWvuka4K3cL9f8O69ddRd5ZERnL/60u9vw EnnpwBhUnaTGCR1FNYSafGFF+Y/ltn7MPu0TGYogbDguMKhaxgpqyu6ow 1HhSPImxzBqfJTz/v/bsdPNK1FvHhsqEfCuKyexaKrJac0PwzTsaGatMd Q==; X-IronPort-AV: E=Sophos;i="6.09,183,1716242400"; d="scan'208";a="15900767" X-MGA-submission: MDE+WswcBz3JFwimMrhWkbhout1gA3DnuuzYTsvXwuP+7meO8zIjdl9RShBbQVmTV24g1iaJ7dMzvJ5rSIg/zDFycmFXW1UKb7IkxXc/3krlXdpKkKpS69AZLfjRPNBvK8GqhXxfsUVx7EmPPdRblmzDA2McNQjdZH+kb5R0mZb5zQ== Received: from mail-db8eur05lp2105.outbound.protection.outlook.com (HELO EUR05-DB8-obe.outbound.protection.outlook.com) ([104.47.17.105]) by smarthost1.eviden.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2024 16:48:02 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IPns+1ZQlcWikVS6E3wwOM1rHfGjWcTc6ye8KFT2VpbQsNymZNI7YTw0FirzV/0le7eVwLMsoKMa1a3mlmHDoVhLJF8Hkg6kW72enGS83N7du6mavzkSDxhao5jWPAOsOGzbQoqNZItqfKOkOSBRr/xzzifz9Sg91X0hCfMxkWg/xwhd4sO7h3WixxBPudDwLMyIiTIDnhqdtOLde8FME6h/MSnQvLsUoiQStIsdCrX/9iZzEcpnfkCx9AytXlZwv3ILFYfjsyjZhq8E7bar4UEnxu/lqegDeha1mHJd31BjyezPpxO7b0TXnRcwqAsZFMG/F3Np8unABtt7p3GZzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QQb36lRclXYTkFjtwY0m8Lyj053oQOM+CfZ9/7UX5G0=; b=Kvc7I5d/DJCq2Ys1jHK42uwoBnyJEoUM/+xWRGrsC6tEBWb/n45RYJEpdyWErCDzC3eWKKaHivGfmDBeiHP/20dh18XqAmHaePxHd6fcz2tUhDk2ht0tGZs5yhVgWDFEARRUngqcVwu0rMRmVKE+qaf2jAPftAyiB26mfBteJJfXjEn01ny8SGMFnkJ6WDIOMnZkVvO6Psgmh/5qmhbtv2+RjvqzhX90V29lYT6ptr3nBpdWkw+HtRyXFk+t3eny33H831HPoFtoEI+1WpGdS4iEd3maDz/4R8uxvoFn/jEAyimRF+O2K+iCwOo/pRzKTNQA9NRk43Dipo3iiC+k8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eviden.com; dmarc=pass action=none header.from=eviden.com; dkim=pass header.d=eviden.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Eviden.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QQb36lRclXYTkFjtwY0m8Lyj053oQOM+CfZ9/7UX5G0=; b=LRSmNWLT82D4/6//I31gSEoeTM0gnWMlxR7ebQgtWXmpFFdWzoKv5EOx9kVuUSxqWMunlbN9YlaUSEkjGzx3cNTMeVzf5+er4V5QkpmUHrNyG1Ag3G5PxR0RUkoJEJF4GMfVuEpMDk4sYaUdyeCH1RCiJ09H3XSoRR3vavevcKN9p6DifUbp/GoZIonZZ9uV1q+d9YPIS34ITBQ4top1dWRvcQ8isaXfDNG3WQBq5+Kd3eKNGt3dnViB9XgI2iBkq0m4cVscAbwtn439h1a6SPuosfnmmmXWe60ga6NStSgVIZOVSFZ3/IMsyYmzSauW4w7RuGmiWHudQSnsdju3tA== Received: from AM8PR07MB7602.eurprd07.prod.outlook.com (2603:10a6:20b:24b::7) by VI1PR07MB9499.eurprd07.prod.outlook.com (2603:10a6:800:1c8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.29; Thu, 4 Jul 2024 14:48:00 +0000 Received: from AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d]) by AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d%4]) with mapi id 15.20.7741.017; Thu, 4 Jul 2024 14:48:00 +0000 From: CLEMENT MATHIEU--DRIF To: "qemu-devel@nongnu.org" CC: "jasowang@redhat.com" , "zhenzhong.duan@intel.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "joao.m.martins@oracle.com" , "peterx@redhat.com" , "mst@redhat.com" , Clement Mathieu--Drif , CLEMENT MATHIEU--DRIF Subject: [PATCH v1 3/3] intel_iommu: Bypass barrier wait descriptor Thread-Topic: [PATCH v1 3/3] intel_iommu: Bypass barrier wait descriptor Thread-Index: AQHaziEqYSd3fPOVYk+uet6FPduJ+A== Date: Thu, 4 Jul 2024 14:48:00 +0000 Message-ID: <20240704144737.996889-4-clement.mathieu--drif@eviden.com> References: <20240704144737.996889-1-clement.mathieu--drif@eviden.com> In-Reply-To: <20240704144737.996889-1-clement.mathieu--drif@eviden.com> Accept-Language: en-GB, fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=eviden.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM8PR07MB7602:EE_|VI1PR07MB9499:EE_ x-ms-office365-filtering-correlation-id: f34f8d91-3a57-4517-6f3e-08dc9c384d40 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?utf-8?q?Qc6wNmmLqKZhp/2ypmGKtwhTWcoxqT+?= =?utf-8?q?NOhUHgFYko+bjb+cy9vvTub0r9vixw7sKMBandK8zAbte0+GBONiw7bswwSLmSpXC?= =?utf-8?q?+84Ur/jsUipypLosN7+UkNgbTu/cLI286L3gffTUnJhUUXz2mQU0LKgGPIQWNevnw?= =?utf-8?q?d4RWQvUhnWScKphAPWNucZuSvu6VOBsiJXDg5qT4DzorS5mye/UMhurGJILXGXvrM?= =?utf-8?q?EaPZM6tj4/Of5Nmg8DBZ0stlr5ELqUp7Oi6LBf5VDQG8aiMsXgaigNSx+FNW2l6LN?= =?utf-8?q?OO5Hn299zcb91k4/0EcyWoTOqAdW1gcRiY/82zY9TNrPMJH3E/Z7lpaf+b0PCcWu2?= =?utf-8?q?sLBW6ebBwsXhVCr2xUfx4Zxgy2IcFV4AVjm/5S6VxDZqksS/0xqwkT0+DYXgbCJ0G?= =?utf-8?q?P7DIYSCnj9HhJIYRkF25RG42iDXWrsOur/Ys0PvY0DE469i9z2yPIKVacBLGKfsQO?= =?utf-8?q?5TeRdaJyLomc2Fezbspd5G63w37WSS0EnNGfj4WMplA/jyZ0I9oD11GR2CcCJpid6?= =?utf-8?q?jFfoR7pBqQh9bYnEa9M/Mb8ffrAokEzGfx7OvBImE9a3kfM8TI/6RRVVeECaGecXG?= =?utf-8?q?hAya5O1zdP1JGEEC/+qW9subV0xA3Ve6IQG0cGa5wGzZhhD6dNwTFzeWZuBMNSEUZ?= =?utf-8?q?qtcQOFfSp4JAoRcnIZJgF4Hf3xSoP7KXDgl2nu+Fy91UF/7vyMBx2Z7A96J5lnbci?= =?utf-8?q?kDQCWQzX+/LTwfgJe3gWb98nRvdBOSlfdVfsiWmLaxS7aYPEEh7zWD4QfTyG3pbIR?= =?utf-8?q?7ZZXCtoU2v3/vOy90EyxBzE40l64JZ/LLiSEnsc4vy0d4j8EA2S0TL4HauwCnpRlD?= =?utf-8?q?tdfwdhOmuVVkwBDy44PPOm0HZEdqvnMrqx4oVQpcn7RIxqAD5w8RJphsYTLxXvAoa?= =?utf-8?q?spLhoM9cFEQz0ga8tRZ0hESGyz53GQgNqnncjxxVEliorZKbBxKImr0hCvv/vb2oJ?= =?utf-8?q?lNv+HlwveRNlOiFAJbPssKzzYM4rT+gMQu1EtLld25FPt9XR7RlQ9twuYhaO74nSt?= =?utf-8?q?dD3u+FTpKf6dKgk8VqXT98tv8YCISJCvzEmD1WeN5+/nNZWg+5O5IYzMeNINzWTHO?= =?utf-8?q?1ndbJOmuDUKp/rzG060kxoGWqA4Qa7bGoiL45Y6vnf0zj7DeiyMwB+n+heWF0wTEW?= =?utf-8?q?kjuBX/6qk+gy2Sl9kshmUUi3rSoJ6itDXpPso+z5sfqFTDmvPDVm2LAGFoqVM4Jfa?= =?utf-8?q?6IEkcklKkvWppUW3ROaLRx0lSCRNG/9VB6LFT8xWns4107k+TGTlABSBHDfGtyMED?= =?utf-8?q?5on6idcm5CvMdgBjH8T5Lt1H8FFtqonnsvOamPij8N3JTA5m8CaEIViZLdN4Dw2XZ?= =?utf-8?q?jp21RkajWARwQhHKlX30NnytRKFUGKfzPw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR07MB7602.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?k3Ru5RWfyxLCYjjDPBurMurWSQJO?= =?utf-8?q?76DTaHI1hA7wRIfed/AAz6bp6uOZmSMgpCvVQZQqQ+Hh1X23O+llrF/rcSduv6EVB?= =?utf-8?q?1PReyLznUfqCHBUOBz0GjvaAw4tCQw9I5M4eqYiHPiuLSSu7v2YV9UZFQQcnn5oDn?= =?utf-8?q?Pll82kTO4J3bzxfWnA/za4yujCj9wIfqrknExxrE3T+i42dSGYHcynOjGJa59ZaIc?= =?utf-8?q?DJnpq3+awolP0jzGZA82Zikp6GMW7dZchHh+sTuRl00MKIMOXqZLUTwUPG2lcwG0a?= =?utf-8?q?VE5Ml6TnwCLrczawg+ZC8H1DVYja01nFaimYmSBxs3/uKaAE1oS+XlHVujASSU+bI?= =?utf-8?q?pfM5pPzKqmd8bHh+tae4iz7uL72rLx+wxeJcFE7MlvtZO8DIxh536lgAyZ7LuQbyd?= =?utf-8?q?Zm+O7wUo0LROpis9C1lU85kAZenCWObmud98kLww4cB+6Vz44Thg1ZGmdle2DJY77?= =?utf-8?q?/nFuWv5k+zfzf2qOAUBHt5YZhPUgdj191ssQS3871hNlfZaD0rNN8bYWS3Gw9VK3m?= =?utf-8?q?nq6ZuhMgFrrqqgilRTGPrt9KH1cS5jMx1Qh83pSAXT8D8ZjS2siBH9v/c8M8V0TeP?= =?utf-8?q?kWqHi7ZyZE2bDEQWNCHFxq+6TD810rq2fphBXhM3ytUN2UwWsbTENrPrJbbUpBBum?= =?utf-8?q?BBWeY6gusCntcnXNUUTlHTg06JD00Czn8oppXjmJlSLugLeWWWQ0/OoUIJgK8nHzd?= =?utf-8?q?3cyMZtCiW1lHSUuGGA+pHlUlZ1ss49N9ba7dTJPb4dGvLVKi6WdqSOrTlMBgxWKuC?= =?utf-8?q?L6ExVNBETbamcFX2Y+a2qsI1TsasJ9D9KH1E6zy5EcMza1XbhX0VUTrfDyLqdRbhm?= =?utf-8?q?ZJTHRe7361pIR1xxHf2XG2VNSL9fuppSrcW3LdY8obxE+eNion4efo5QFVDQnxc2d?= =?utf-8?q?NyaoxvjejHnSsxrHIDpXsOm/oL6/t70G0e0ps2DGB7C+eDwU4qPxgSqlel/VfIX6G?= =?utf-8?q?TnTnh6OMRlozm6N5/phLhEehPX508AF8FuCtE4QXNuFq2xghCMSj2ViBkN9VjsQBb?= =?utf-8?q?6ncHWnckQ6MVk/fmlnIelLIHs/4cXxC185ZQCUOCHfCYsBN0RLHRSjkOV7Pv2C7S5?= =?utf-8?q?QbtSaaeYIdHrrTf5wpkx8ABwg2KanqJNso8dhKykcqZdzg+nN4gVXmcy/9e2EugYR?= =?utf-8?q?uusD+K5iRtZa4QDqE0hpkpoJ0uKmWynil0dw7O9EPeuwx03ePL+6YbwKa41pzH5/I?= =?utf-8?q?No87+em+j8PYYeENHmCSLYjxqthgZpQB4CIOF6H6yK5drXfQtLmBIGASXKkAn/I4i?= =?utf-8?q?ycebC3P8i6BvYzokidv2roo82OsVedS+mAVmIVcM/Ayq7LQ+QI03GFHQF+0OsPLJZ?= =?utf-8?q?Fth60ZTZj/awGwOCx3hiZeoNqXAtl1LQy3ztinCsIOBy/jkw4cvXWm5iORotCDNw2?= =?utf-8?q?/TiEyDusDT/Sg/ZptNnLq6Vij0ou8NtDH9PN6BwUQA+IDBNY+xqgn0p0fSpWcJ6hT?= =?utf-8?q?2QVweaejt5r5ZLREk04GleVrRYxUMwvMcD+eQufspL7qSwgzCt4edf+RNHreJlhLh?= =?utf-8?q?fCle3HjSLHEEC5kzqtAmD+ZMXjZ+XbmDKQEkWKUmhBmj9veZrZb975Q=3D?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: eviden.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR07MB7602.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f34f8d91-3a57-4517-6f3e-08dc9c384d40 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2024 14:48:00.7514 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7d1c7785-2d8a-437d-b842-1ed5d8fbe00a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3uw6qK4VvCH60Qegk9xsPdXFvvgOBtf8hz3mv05GBpkH8qyz3X9dkVDgWnGWP/mknT3bYPs405WWy+bTGsvPm7XB3KObl5hC1QtpA1hAi8MpLjw05uAt/XFRJeFMCeuL X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB9499 Received-SPF: pass client-ip=80.78.11.82; envelope-from=clement.mathieu--drif@eviden.com; helo=smarthost1.eviden.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Clement Mathieu--Drif wait_desc with SW=0,IF=0,FN=1 must not be considered as an invalid descriptor as it is used to implement section 7.10 of the VT-d spec Signed-off-by: Clément Mathieu--Drif --- hw/i386/intel_iommu.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index be0cb39b5c..12ea3a9aa0 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2561,6 +2561,12 @@ static bool vtd_process_wait_desc(IntelIOMMUState *s, VTDInvDesc *inv_desc) } else if (inv_desc->lo & VTD_INV_DESC_WAIT_IF) { /* Interrupt flag */ vtd_generate_completion_event(s); + } else if (inv_desc->lo & VTD_INV_DESC_WAIT_FN) { + /* + * SW = 0, IF = 0, FN = 1 + * This kind of descriptor is defined in section 7.10 of VT-d + * Nothing to do as we process the events sequentially + */ } else { error_report_once("%s: invalid wait desc: hi=%"PRIx64", lo=%"PRIx64 " (unknown type)", __func__, inv_desc->hi,