From patchwork Thu Jul 4 11:41:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5LyK6JekIOWkqua4hQ==?= X-Patchwork-Id: 1956816 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=OUTLOOK.JP header.i=@OUTLOOK.JP header.a=rsa-sha256 header.s=selector1 header.b=phtolmfx; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WFFJF4PCTz1xpP for ; Thu, 4 Jul 2024 21:47:41 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPKvZ-0000SO-PF; Thu, 04 Jul 2024 07:47:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPKvB-0000OE-VK for qemu-devel@nongnu.org; Thu, 04 Jul 2024 07:46:52 -0400 Received: from mail-psaapc01olkn2043.outbound.protection.outlook.com ([40.92.52.43] helo=APC01-PSA-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPKv9-0006p3-9P for qemu-devel@nongnu.org; Thu, 04 Jul 2024 07:46:41 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a71SilfVqAWcI3eK18GsQdvW090Y31fg+oekrDDKZhGjR2IPjQe57BnRJzE1BOcTLdPtPk8JGZ4bxdIBTa0NA+oAexH/vPgD45nFMa8VnctJkhoBHLcsMhk495yg5h2C7/F1XMqEon8kJPbe46suSpEeljvu7q5I8hnNKXfbhtsMAZTXSlqJxAl6h/bUNFigo86tRcgXOn9FqhHlB65jzsVonW5VG7LVnZX+6ucEh8YfiXbpM/vejmSNYcKyJhOAgLLjEMwKiBFavpTx2jjXktiIJJH3E30yKubFhWyuHMXBxXNvt01k8NP+i4D8Fz+VdzBtEWpSoOwaunjEbmrHMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Qa6n0X+dkBwMnLj58pB0afoR0708MFJ/jgSl1iQMlg=; b=f2c2tGyyaFjzz9Ml4znmBzv/8Jw/GKkhMGrntTBr2aWfyNkMpTXIwN/B4x6L8P0/AlDBZUv2+87wz7VvCqxjOZoglm/oPztZ/rp7p7oaJZWuXtu7WTUm0W+aUhBjmAxzYYt/V2+pC1HbD5FsJwTsRSatxqthEdLbF7x3cI+7rOs9Z+qlAAl4IBMQOdHJ3RdMJGtO1Gxl5P5hFcXBA8CykesiUGKPEf6eyvEECfPFU1LCbujgC7SEhzE+FyfVs8yWFCXlOpU+Mcr1q6oMsPpbTao9TiMle6sQdjVqzy8tLwVobC+ZrS9UJkwBd0/M1FCfOocXN6uUFArWwyg+rrnWEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=OUTLOOK.JP; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Qa6n0X+dkBwMnLj58pB0afoR0708MFJ/jgSl1iQMlg=; b=phtolmfxVFIYzyUirzubGe2cDoeFzesOSGFU+tPF+1UQDm+PEFlPfTKLo7NCylRZcZ0CqyzQD3c9eJW9c4aAbn6sWyXbPIK1zkQpL4FA2+5WEnusjqh1zUPTI5z6kXlggJOR1aTcgDdLAW/qvnk8jXTYA6wqEXj0SabL+zDTY5uuYduODmwU8P9I5D6SWPrAlmROFRrwNjr5ldxXWtIlM1KQcUV5tQJyY7PJ+onJfXmdLPkHleYIJ0FHcbc8FUCzjW0ypG06dtl48KXddCby3kM1URP2S28g5s811+o+PL//M6KQI4dC5W+utvmO/EgoA/4HFf34V/O2q6OyULTh5Q== Received: from TY0PR0101MB4285.apcprd01.prod.exchangelabs.com (2603:1096:400:1b0::11) by TYZPR01MB4233.apcprd01.prod.exchangelabs.com (2603:1096:400:1c6::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.29; Thu, 4 Jul 2024 11:41:28 +0000 Received: from TY0PR0101MB4285.apcprd01.prod.exchangelabs.com ([fe80::85c5:f6c5:8a81:ee35]) by TY0PR0101MB4285.apcprd01.prod.exchangelabs.com ([fe80::85c5:f6c5:8a81:ee35%4]) with mapi id 15.20.7719.029; Thu, 4 Jul 2024 11:41:27 +0000 From: =?iso-2022-jp?b?GyRCMEtGIxsoQiAbJEJCQEA2GyhC?= To: "qemu-devel@nongnu.org" CC: "mst@redhat.com" , "pbonzini@redhat.com" Subject: [PING][PATCH] hw/timer/hpet: Fix wrong HPET interrupts Thread-Topic: [PING][PATCH] hw/timer/hpet: Fix wrong HPET interrupts Thread-Index: AQHawYD83w/3eGv8102bpXalgrtacLHmijKV Date: Thu, 4 Jul 2024 11:41:27 +0000 Message-ID: References: In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-tmn: [Ccj+370vPsGTtopOz5OMrlw/UVhImozM] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TY0PR0101MB4285:EE_|TYZPR01MB4233:EE_ x-ms-office365-filtering-correlation-id: 4ce333db-a6b0-40e6-2d88-08dc9c1e3d77 x-microsoft-antispam: BCL:0; ARA:14566002|461199028|9400799024|8060799006|102099032|3412199025|440099028; x-microsoft-antispam-message-info: 1P5NEL2N9gd6kFHdNi3AhHi2h7uwaO0FS9o5s6Z0LLhYv380exnRPQdmgRJDZyo1UFGyb7jtC8FrvCbl7SiETQ93YPwhVAjXfYEFvZB3L3/Y7UZe5jkMNgc8r7J5c5wtNbZ0lR989Wyl24gQ79pPpcbHaBn0230Te/5AcaZ3jrgoSNscc7aWzICYbVhCnd0PIN7DQm+C0l2roGaE0uO+xzMw5oufHBAnNagSkMSgMV/2ECewGg+VIGYXVpgY/Xc/pjYfnhoI3p5wnmW5Lnd1f2gbR4VxyCGoSv/JliawLc0VVj+6J5tQL8wFeq8y9E5FDgNLqQP534hmxMZqTOoeWoP/KBNMiMRcDT2FM5W02qGhsOfAqkIbgdrrMBdXX4eTizQ7uHRG1CA3aBsp8fMk92G/DvQpSKNkjnsL7p7UZ0cYqSTJlXkt98H/kmP/hRZ9WZFI4wRQ7s62bKJJz27zyNXn2PhxncIz8Jdx6QrjeG9zQW4SK+dt3pGyhglIIhUWvhQHqLHMC/zsgSraIQvGPXS5/Q6lQPhCqLizrQSarbScERf2Q/9X5qGmJiAj+PtJykQayIPF3w7GtZzfvxnVgcQFpw7x6SZ6vRLqVJKN0X7TenXZnS7CdE/iIeOtenE/4xsvmiMnLrYiWFDtj2QWVTbY+77261G8fgj8ZspywM2MsqK0hYd6Z4CcbDXu2Xuq x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?b?RSs4NmdId0RJT1RmSHVz?= =?iso-2022-jp?b?bERSQjdJTi92aWlWQlpCK3lmMytmU1Yydktpd2IxcDBxd25sRVl0RDhS?= =?iso-2022-jp?b?dU1ESU83KzNZZDRtaXVQTDRxQ1BSakc4emdyUjVGWTlvTmw4Mm1uMjZQ?= =?iso-2022-jp?b?SjZCTjk3NkxGazJMTThpK2VOMUF4KzdLZklWcXd1OUdmbTVScENVQkdr?= =?iso-2022-jp?b?T3lzNFY5SVk1dVJkOGdVZTIyTzlxZm9adHczamplUkVqMmgzTnluTnZ1?= =?iso-2022-jp?b?ais4cVZ4bDJaYXBDcnNMb2F0Y01UeXJTUzZ3c1BOanZZL09ETGNSY1lM?= =?iso-2022-jp?b?eXJ5ekFaUVErVlpFbThSelBqd3NCRjdFVFlVUy9ZdXZJb1k5WEJnMVZu?= =?iso-2022-jp?b?cGltUzd6dzQwbGNSem02bXdLQy84bFlOc01tS08yNEtGNzM3OU8wNFdz?= =?iso-2022-jp?b?WTBJNXROb2hQNHA3dGYvM1ZIa2lyMFVUL0xHYXc5dStsR2R0aG9nczVs?= =?iso-2022-jp?b?MWc3Q2VhM0dlOURvRVp4dEFQN09MTnhtQng5eVU2TkxHaWJSdmh4OWYx?= =?iso-2022-jp?b?cHcrZEdJbGF5STdtd1F2TEEyUi9wTGN2NlRxODJldmZNWVcrR3RiOTZ2?= =?iso-2022-jp?b?a01YeFl3MnExcWxuQkU0bkJZSlVZYnF4WlkyNnhmbnVmS2c1NDUzdnQr?= =?iso-2022-jp?b?eHZkU3hhenk2ajNhWDIzZHllUHI3Z3ZGWHlQM29tYk1CajlMRUs0Q3dH?= =?iso-2022-jp?b?eXNqY1p3aVRieUsyak5OQjN0eEJCQzFBdkFCU2M2S0F0cC8yT1ZYTU1M?= =?iso-2022-jp?b?UWRCSHYzMHhWMFgySi9Da3BJdC9IREFmNUpxenkxKzV3R0R6b3V3VWl6?= =?iso-2022-jp?b?VlBIVzFCZHhZejhTMDcyTDF0SHZBOEdvZStvQTFTV2g4MGl4TXRXd2ZT?= =?iso-2022-jp?b?NWluSnlnZUJtQnFvSithSExYU0hRT2RrMGxuWVBJbUl2TDB1bm1NbTRF?= =?iso-2022-jp?b?QlZMTVJZOWc1OEZhRnVVSU5VdDBZeHloT0JHdWMybTByeFJEczZLU2tS?= =?iso-2022-jp?b?cDlQR3BNcUN5eVZtNFpxQXpmODYxNHNuMjh6cS8xbUtJdVpLbzZLTDdQ?= =?iso-2022-jp?b?UDZXT29Yb28zbWpnR0JUUndhbGpKV1pFc3ZLRVlaNElLUG90RjIxYUh1?= =?iso-2022-jp?b?QmlpSC9FYWRHTFRYRmR6YWE5ZzBZdy9Mc0hMSzRpak5GWVI1cEx0SFFk?= =?iso-2022-jp?b?S3lHTDlLWElnMU9xdXhjNk13bE8vRFYwUE4vL3V3TWJxYTF6dEJ2OTM3?= =?iso-2022-jp?b?dnVwS1N6VkZtMEVjKzhQa3hnaGMyVnpCTzg2dzJ0SXdvdVZTY2VkdGVB?= =?iso-2022-jp?b?M1N6YU1RYnhOU3QrSnhiSVVjekNFSGZDekp5ejZvL0txcERtZnRjdi92?= =?iso-2022-jp?b?NDFwWitRYitxSjBqUlhYUE5oRzYyNk1nd0YxUzUwcnRkaTNWeUZObzg0?= =?iso-2022-jp?b?SnhXM0x2RkNhWFNIWFhoWjFCend6M1hBZHYzR2RaVFNqRCtQWmNCR1E5?= =?iso-2022-jp?b?TmlyU2FqUE1ZZzZhRHMrSDNacFJTRXdzYzUwUkYrYXQraWhHSGQzeU54?= =?iso-2022-jp?b?MGh2RE5GaU1UYU83M29USDhhMi9oMUFVUGJCSG80YW5Tb0RXMGFsQVg1?= =?iso-2022-jp?b?NzBhcjQ3RHBXY0lWYklkcUpXZjVLbVpGQ1VZaHBnTEtYUmtEYnAwSk5o?= =?iso-2022-jp?b?Wk9tL295QkxjZXE2TjZZU0RWVGNTeUdJRFJOb1JNYVJBbnpxS0FDOVVR?= =?iso-2022-jp?b?ZWN3QWUwc2tkK1lYWHcvOWk0cTc4NTdJaFU9?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-b4c57.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TY0PR0101MB4285.apcprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 4ce333db-a6b0-40e6-2d88-08dc9c1e3d77 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2024 11:41:27.3417 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR01MB4233 Received-SPF: pass client-ip=40.92.52.43; envelope-from=taisei1212@outlook.jp; helo=APC01-PSA-obe.outbound.protection.outlook.com X-Spam_score_int: 13 X-Spam_score: 1.3 X-Spam_bar: + X-Spam_report: (1.3 / 5.0 requ) BAYES_00=-1.9, CHARSET_FARAWAY_HEADER=3.2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This is a ping for the patch below. https://lore.kernel.org/qemu-devel/TY0PR0101MB4285838139BC56DEC3D1CCFDA4CE2@TY0PR0101MB4285.apcprd01.prod.exchangelabs.com/ diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index 01efe4885d..2dcefa7049 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -599,8 +599,12 @@ static void hpet_ram_write(void *opaque, hwaddr addr, s->hpet_offset = ticks_to_ns(s->hpet_counter) - qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); for (i = 0; i < s->num_timers; i++) { - if ((&s->timer[i])->cmp != ~0ULL) { - hpet_set_timer(&s->timer[i]); + HPETTimer *timer = &s->timer[i]; + if (timer_enabled(timer)) { + if (timer_is_periodic(timer)) { + timer->cmp &= 0xffffffffULL; + } + hpet_set_timer(timer); } } } else if (deactivating_bit(old_val, new_val, HPET_CFG_ENABLE)) {