From patchwork Thu May 30 11:19:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Celeste Liu X-Patchwork-Id: 1941865 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=FQifG8B4; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Vr1NY67zqz20Pc for ; Fri, 31 May 2024 08:37:49 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=FQifG8B4; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Vr1NY06R4z3fwT for ; Fri, 31 May 2024 08:37:49 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=FQifG8B4; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::d44; helo=mail-io1-xd44.google.com; envelope-from=coelacanthushex@gmail.com; receiver=lists.ozlabs.org) Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VqkLj6VZ2z2yD6 for ; Thu, 30 May 2024 21:20:13 +1000 (AEST) Received: by mail-io1-xd44.google.com with SMTP id ca18e2360f4ac-7e97d38584fso28030239f.2 for ; Thu, 30 May 2024 04:20:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717068007; x=1717672807; darn=lists.ozlabs.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yMLg5P8GKaZTkgjzD8R/QqO0sSQDVLJa6m0BArXde/g=; b=FQifG8B4EQaihKnu6AhnzRmwnX/W93XsLNC8RK8amFA5rg2vwve0NuAU6FBQeVfNj8 YUUlTyC7t701+t7uJ+KgOHyfTtmTDTn9kqmvQLNr430RNeTsr1xCIJDbMo7nvAACMQWv EjsT4lywC4tNZrtjw9tvdP/pdDURgi61h5WLM2kNDvIuCZ+L8dn/7rsme8Vvue4Czo0j D28V1FK+gQ+uEPoisMbcRtrCkUSkdJZLUZX7NCQxZxNY2qr81oVkcBHjHwzwyprAD7+F 4+nj36/T6BUnXCZElGXLrFtFppCOxy7Rvk3Go6b7tYqIwkZeopwC3WgJbjjZWdcKv/aJ PU9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717068007; x=1717672807; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yMLg5P8GKaZTkgjzD8R/QqO0sSQDVLJa6m0BArXde/g=; b=LZvsAwnGNEm6IepZzehbulZmsu6BkeXJk9WMZ0ir32N1iPSrNd8xFCqrvMn7qwHkzR Q+Uv5jy1QwUkyOhjnwaoS+FHsbCARReWbYdGewbOp/hpd1KieSxGiw1QtrR1R+CRxJyR P3zhZTndhwQjMqxDDPbAcgPmpwhAAKKg5eajzM5RSzwQVGZdsLPxbVcE+1sghSPeOkRr RRMiLho+F2/JhyXpFL/slC14QXC4j0cqd18OMWNeJdxq7dlwWAKsvAKs6Siv9iZk+rQQ o8+zSNFmEWVGtuBSNyMRzLIRiyqyAHASRcnqPYS4iEpFYBLBTuBTZTOLNxrgr4V8lQQ2 zT6w== X-Forwarded-Encrypted: i=1; AJvYcCVyN5y76yACJV4yRvrY22cr/gciOoDPc0xni7jre8R+PRRNeodCb0SWm5WoLmwXMqqM4uPSOnwvAvZjMJJUA5AQ5ABwjHC0fwG6fhHG7Q== X-Gm-Message-State: AOJu0YxE5QglbxBtgjFKvNR2++7GQyiIan4BjOeoTOhxqYse7bcwoDXq I4d7eoH+xSvgzmf1K+7KRlfSkFkZ/pYaDi7GUCUNi/L064Il6him X-Google-Smtp-Source: AGHT+IFxgfGuk4WvYoxrChp+N4lQDR0Si7/7Vlzjuk7wpmJrGZ30ttsy31urG1IDYNTmVV6Zs/i1hQ== X-Received: by 2002:a05:6e02:b27:b0:374:6472:d923 with SMTP id e9e14a558f8ab-3747deba9demr23632145ab.0.1717068007160; Thu, 30 May 2024 04:20:07 -0700 (PDT) Received: from localhost ([212.107.28.52]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6822198a7e3sm10550697a12.34.2024.05.30.04.20.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 04:20:06 -0700 (PDT) From: Celeste Liu X-Google-Original-From: Celeste Liu To: Heinrich Schuchardt , Anup Patel , Guo Ren , Palmer Dabbelt , Paul Walmsley , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , Vladimir Kondratiev , Gregory CLEMENT , =?utf-8?q?Th=C3=A9o_Lebrun?= , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N . Rao" , Sven Joachim , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Russell King , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Tony Lindgren , Thierry Reding , Jonathan Hunter , Arnd Bergmann , Mykola Lysenko , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org Subject: [PATCH 1/6] riscv: defconfig: drop RT_GROUP_SCHED=y Date: Thu, 30 May 2024 19:19:49 +0800 Message-ID: <20240530111947.549474-9-CoelacanthusHex@gmail.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240530111947.549474-8-CoelacanthusHex@gmail.com> References: <20240530111947.549474-8-CoelacanthusHex@gmail.com> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1883; i=CoelacanthusHex@gmail.com; h=from:subject; bh=FEk4ZichD7CqTRAppezRH+4H9dhTF4GYT9EUDpibpAE=; b=owJ4nJvAy8zAJfY4pvNJRPo6U8bTakkMaREJ16rP/zv78xijc+SbFuluq7KoDVxfdGb3ntmwV 4b5b/rJ87kdpSwMYlwMsmKKLGI7n75eVvrowzJekxkwc1iZQIYwcHEKwERiuRj+FyWbH5kg7nGC bXudX8b5SVrfDn7ffNohZmU9l4bwcat4U4b/tfNS9VctvP7+NI+h5NrpGpcrHCr9as+x9XPYVM9 LOc3JBwDwgkw9 X-Developer-Key: i=CoelacanthusHex@gmail.com; a=openpgp; fpr=892EBC7DC392DFF9C9C03F1D15F4180E73787863 X-Mailman-Approved-At: Fri, 31 May 2024 08:19:55 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Celeste Liu , Lennart Poettering , bpf@vger.kernel.org, Icenowy Zheng Errors-To: linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Commit ba6cfef057e1 ("riscv: enable Docker requirements in defconfig") introduced it because of Docker, but Docker has removed this requirement since [1] (2023-04-19). For cgroup v1, if turned on, and there's any cgroup in the "cpu" hierarchy it needs an RT budget assigned, otherwise the processes in it will not be able to get RT at all. The problem with RT group scheduling is that it requires the budget assigned but there's no way we could assign a default budget, since the values to assign are both upper and lower time limits, are absolute, and need to be sum up to < 1 for each individal cgroup. That means we cannot really come up with values that would work by default in the general case.[2] For cgroup v2, it's almost unusable as well. If it turned on, the cpu controller can only be enabled when all RT processes are in the root cgroup. But it will lose the benefits of cgroup v2 if all RT process were placed in the same cgroup. Red Hat, Gentoo, Arch Linux and Debian all disable it. systemd also doesn't support it.[3] [1]: https://github.com/moby/moby/commit/005150ed69c540fb0b5323e0f2208608c1204536 [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1229700 [3]: https://github.com/systemd/systemd/issues/13781#issuecomment-549164383 Fixes: ba6cfef057e1 ("riscv: enable Docker requirements in defconfig") Signed-off-by: Celeste Liu --- arch/riscv/configs/defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig index 12dc8c73a8ac..de85c3ab261e 100644 --- a/arch/riscv/configs/defconfig +++ b/arch/riscv/configs/defconfig @@ -9,7 +9,6 @@ CONFIG_CGROUPS=y CONFIG_MEMCG=y CONFIG_CGROUP_SCHED=y CONFIG_CFS_BANDWIDTH=y -CONFIG_RT_GROUP_SCHED=y CONFIG_CGROUP_PIDS=y CONFIG_CGROUP_FREEZER=y CONFIG_CGROUP_HUGETLB=y From patchwork Thu May 30 11:19:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Celeste Liu X-Patchwork-Id: 1941864 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=ePqfRUmf; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Vr1Ml0DFtz20Pc for ; Fri, 31 May 2024 08:37:06 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=ePqfRUmf; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Vr1Mk0x7Jz3fw5 for ; Fri, 31 May 2024 08:37:06 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=ePqfRUmf; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::643; helo=mail-pl1-x643.google.com; envelope-from=coelacanthushex@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VqkLj6dNKz2ykt for ; Thu, 30 May 2024 21:20:12 +1000 (AEST) Received: by mail-pl1-x643.google.com with SMTP id d9443c01a7336-1f082d92864so6320505ad.1 for ; Thu, 30 May 2024 04:20:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717068010; x=1717672810; darn=lists.ozlabs.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UKDbsptHUOf10z9ycdwLPkvcPnlZIVKylvaMWlEqffg=; b=ePqfRUmfXowbGfZMiOGaaXZ56eTFOU5jsb//T2l/9+Y/+zeckSHNwdZj8Nn0eGhLEV w0YN2CBl3cca6eg1hD02jt10VawD/dW5098KAfEfGd+LDfZFVZMP6qohSXNbuVaoql23 KzVtJkc9U1SicHOpypwNP40nOmGgKwUm4t6ObC7R5vcJ/NtFYR1Ju8vcQ2+O2Gbd6uJU VgyrlJZGze9jlfZDaK6Zi4CMrmi+fQICy0nncCig30nAfZbQUoIYbcqXdIyDpM6KZkpt jpGk7erua/++tvxtoARb7KyWpf5wHXWFS1EmhjJOQ1Ohc4A56a3+yUwtDYfZ+7Ruy6JZ PE5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717068010; x=1717672810; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UKDbsptHUOf10z9ycdwLPkvcPnlZIVKylvaMWlEqffg=; b=gh1xfQL7peoCreqi3BPNpahRzxANx3PHKQxspkwUlnnsuILJpAZALpsgljerjkci7w sfdOJPIVfHZYfhWHpUjsFuVIp2uPQY+fo+7HIPjop23sVIW71xy2SMrQmle3ZAuFVL/R D+rdNzF8Uhq9W9lKakRe8JsUEdRfR9Dw+WjjwCtMgc6Aololea1XaWVefpIzeuhRsvG6 sV8hrkkomOteE0XaaJIU9R6pZ7RqliToI9XGQ/zSy/hSVo0S2QTdqDlu0jvWVJFRDnSv JYvjGN6DearklA8b7WQPkfZHNK3kNjBYFrR7LZJKYBDgD3FVx1ZGFX7Z1DHO+FsPw/qC lpig== X-Forwarded-Encrypted: i=1; AJvYcCX1j7+5dg1Aj7O/CpF0dkRpMy8woU9rI0U+plGRs1aB2nFbUQm6JtmmyZtaW2Qlr9VKbX17C1FhBYg5kJQJW1SkikdNgxS9DXLSzAHhZw== X-Gm-Message-State: AOJu0Yx0fB4HNIu5cahR1n1/3DIkisGwhSYT+rlrczFNNpsTj6yidldw 9p2Oe19UqS5NMiS/QfPYNvc+rNYFLQfNoPOTIm/DlbfdcGuNHI9X X-Google-Smtp-Source: AGHT+IG8jDyJ8as1gn+77mY1eHAg+/C0hnh88tNUqGm5hMTpX2IBrtY6RK5OpQr2kS5B3uzx1FXS4g== X-Received: by 2002:a17:90a:b005:b0:2bd:f3dc:62d0 with SMTP id 98e67ed59e1d1-2c1abc41427mr1745172a91.37.1717068010054; Thu, 30 May 2024 04:20:10 -0700 (PDT) Received: from localhost ([212.107.28.52]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c1a777a976sm1534201a91.20.2024.05.30.04.20.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 04:20:09 -0700 (PDT) From: Celeste Liu X-Google-Original-From: Celeste Liu To: Heinrich Schuchardt , Anup Patel , Guo Ren , Palmer Dabbelt , Paul Walmsley , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , Vladimir Kondratiev , Gregory CLEMENT , =?utf-8?q?Th=C3=A9o_Lebrun?= , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N . Rao" , Sven Joachim , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Russell King , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Tony Lindgren , Thierry Reding , Jonathan Hunter , Arnd Bergmann , Mykola Lysenko , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org Subject: [PATCH 2/6] loongarch: defconfig: drop RT_GROUP_SCHED=y Date: Thu, 30 May 2024 19:19:50 +0800 Message-ID: <20240530111947.549474-10-CoelacanthusHex@gmail.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240530111947.549474-8-CoelacanthusHex@gmail.com> References: <20240530111947.549474-8-CoelacanthusHex@gmail.com> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1629; i=CoelacanthusHex@gmail.com; h=from:subject; bh=h4glHeoHIj1lCrO/9cfcaGCSQbc7rI3O4B300cL/OlA=; b=owJ4nJvAy8zAJfY4pvNJRPo6U8bTakkMaREJ1/n69Xxaeu7NP36NP963pkB213cGx83nk+e+3 76w6tID+4kdpSwMYlwMsmKKLGI7n75eVvrowzJekxkwc1iZQIYwcHEKwESKNRn+WU/3fra1weNu krm/TiCjVtvfa8brLyYvXBxW9+bE9hjTBwx/hWUiri0SdmdLcHzGfvl11UovoVVOsWVy29fF/F/ 2874CBwCfBE2n X-Developer-Key: i=CoelacanthusHex@gmail.com; a=openpgp; fpr=892EBC7DC392DFF9C9C03F1D15F4180E73787863 X-Mailman-Approved-At: Fri, 31 May 2024 08:19:55 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Celeste Liu , Lennart Poettering , bpf@vger.kernel.org, Icenowy Zheng Errors-To: linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" For cgroup v1, if turned on, and there's any cgroup in the "cpu" hierarchy it needs an RT budget assigned, otherwise the processes in it will not be able to get RT at all. The problem with RT group scheduling is that it requires the budget assigned but there's no way we could assign a default budget, since the values to assign are both upper and lower time limits, are absolute, and need to be sum up to < 1 for each individal cgroup. That means we cannot really come up with values that would work by default in the general case.[1] For cgroup v2, it's almost unusable as well. If it turned on, the cpu controller can only be enabled when all RT processes are in the root cgroup. But it will lose the benefits of cgroup v2 if all RT process were placed in the same cgroup. Red Hat, Gentoo, Arch Linux and Debian all disable it. systemd also doesn't support it.[2] [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1229700 [2]: https://github.com/systemd/systemd/issues/13781#issuecomment-549164383 Signed-off-by: Celeste Liu --- arch/loongarch/configs/loongson3_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/loongarch/configs/loongson3_defconfig b/arch/loongarch/configs/loongson3_defconfig index b4252c357c8e..4d93adb3f1a2 100644 --- a/arch/loongarch/configs/loongson3_defconfig +++ b/arch/loongarch/configs/loongson3_defconfig @@ -23,7 +23,6 @@ CONFIG_NUMA_BALANCING=y CONFIG_MEMCG=y CONFIG_BLK_CGROUP=y CONFIG_CFS_BANDWIDTH=y -CONFIG_RT_GROUP_SCHED=y CONFIG_CGROUP_PIDS=y CONFIG_CGROUP_RDMA=y CONFIG_CGROUP_FREEZER=y From patchwork Thu May 30 11:19:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Celeste Liu X-Patchwork-Id: 1941866 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=NltOoTaK; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Vr1PN6mC0z20Pc for ; Fri, 31 May 2024 08:38:32 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=NltOoTaK; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Vr1PN2mD3z3fsq for ; Fri, 31 May 2024 08:38:32 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=NltOoTaK; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::442; helo=mail-pf1-x442.google.com; envelope-from=coelacanthushex@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VqkLm3G7hz2yD6 for ; Thu, 30 May 2024 21:20:16 +1000 (AEST) Received: by mail-pf1-x442.google.com with SMTP id d2e1a72fcca58-70109d34a16so670170b3a.2 for ; Thu, 30 May 2024 04:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717068013; x=1717672813; darn=lists.ozlabs.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iS6/3rMP5XMaNOKzvqnjBVlN/YxRA0hOsUbIiKByQ6o=; b=NltOoTaKkZLGpcToNm0f5byiiYyiA+pl/TVrdM9CBCh9fhbPCIKbmziYyNQeTtrq4P 9nLnTk5nLvujZhgIarQIFOUT3ctn5C0CYxp4r+qDQ8v+2pZKUlfy1j+XBV0q2i0Xav54 /KiGqT++HMa4W2+rlWy2f8TKp0VOI1hmnkrCqFHxTZuAdteOJN/IXxLRps41u/JVDieX Wk0q3kdOH8dzDDXLyl7j30q3QfxlcNihqXMqjlsKgvNUhiVpEmKoCxSInd2hBspD8m05 k5kSf1CXMUAcA5yyvsrJ4j0CIQGfX7xJjO4/4zDpNOCv4Rv6T67azzpr4m6rI9nIDe3N zhKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717068013; x=1717672813; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iS6/3rMP5XMaNOKzvqnjBVlN/YxRA0hOsUbIiKByQ6o=; b=r6nfh4NiRmEPp0aec6iu2c/ulFJVRmcy6EREQn8vrrkILSiP/JqxLp13giT9wpPN8S SV8pjGLVtZ7hV52/Yx21j1V/jXEjN1csGy4urZbOouw/Jva+49yfusJOvpiCrPRTZ5n2 Zaa6BGMIdmARKeWpnVY82OQfT0Jp3eRTGO7O4mYWVaHOvFYXcu6ddEZBqxzMmwYGZ5FI r+8t7e2H3ukW69A5q/WOdcyDnFGeGkjKoOtsydzPHMFejI8AeNEkqmN94BLpQlRLr7er 5X8iQJ00292dPXal1LP29RLPoGtRKn2jN/nm0oovKQK1e1fPJ0zJD/sTJr5+z0dBdqf1 inRg== X-Forwarded-Encrypted: i=1; AJvYcCXIIi0tBr0aP1H0+xvxNnhlWZUOerb6eLNI+cQ5+lUHzbI8cdNcBmukF60Eep3diNYu4FfMh7pvWFHAFAimc+jq5Nec9nGjJQvtRNISUg== X-Gm-Message-State: AOJu0YzVcL7wdXbkPAzdzMbuvxQjLwDizfmW0mR7tU9YSHZxdnXS+xGb aktMUYCvFkmeBQK2WObUwjVF4lAcU1gB44Jeeqpk4u3tbgz0dtJr X-Google-Smtp-Source: AGHT+IEz4if+6nQ+0nx1w/27JH/n7YuyuluXY8+GolxtiPn58HNH1t1JZeRF1Dn7No9YQVVS74OoWg== X-Received: by 2002:a05:6a21:9982:b0:1b0:111f:2b7f with SMTP id adf61e73a8af0-1b264645684mr2023903637.39.1717068013130; Thu, 30 May 2024 04:20:13 -0700 (PDT) Received: from localhost ([212.107.28.52]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7021feb0b7dsm2116952b3a.25.2024.05.30.04.20.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 04:20:12 -0700 (PDT) From: Celeste Liu X-Google-Original-From: Celeste Liu To: Heinrich Schuchardt , Anup Patel , Guo Ren , Palmer Dabbelt , Paul Walmsley , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , Vladimir Kondratiev , Gregory CLEMENT , =?utf-8?q?Th=C3=A9o_Lebrun?= , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N . Rao" , Sven Joachim , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Russell King , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Tony Lindgren , Thierry Reding , Jonathan Hunter , Arnd Bergmann , Mykola Lysenko , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org Subject: [PATCH 3/6] mips: defconfig: drop RT_GROUP_SCHED=y from generic/db1xxx/eyeq5 Date: Thu, 30 May 2024 19:19:51 +0800 Message-ID: <20240530111947.549474-11-CoelacanthusHex@gmail.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240530111947.549474-8-CoelacanthusHex@gmail.com> References: <20240530111947.549474-8-CoelacanthusHex@gmail.com> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2501; i=CoelacanthusHex@gmail.com; h=from:subject; bh=iuzxupRQlKvaCQIBiZ4xlf2r612WVp0v0y+1iZrYbx8=; b=owJ4nJvAy8zAJfY4pvNJRPo6U8bTakkMaREJN5aHbSvetGXDI9/Lgg/2RZ0Pr9tZ2Zeh8l34s JFf/NkbX3s7SlkYxLgYZMUUWcR2Pn29rPTRh2W8JjNg5rAygQxh4OIUgIkc2cnw3+dB99H+ecua Oiy0mLQjDFasNi7dvfTwkdv38ytDfrqaLGRkOOx28cCrP0VHmn/UfmB7LhiTWCzOvmna5ka3YIu yCes1WADtNVCT X-Developer-Key: i=CoelacanthusHex@gmail.com; a=openpgp; fpr=892EBC7DC392DFF9C9C03F1D15F4180E73787863 X-Mailman-Approved-At: Fri, 31 May 2024 08:19:55 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Celeste Liu , Lennart Poettering , bpf@vger.kernel.org, Icenowy Zheng Errors-To: linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" For cgroup v1, if turned on, and there's any cgroup in the "cpu" hierarchy it needs an RT budget assigned, otherwise the processes in it will not be able to get RT at all. The problem with RT group scheduling is that it requires the budget assigned but there's no way we could assign a default budget, since the values to assign are both upper and lower time limits, are absolute, and need to be sum up to < 1 for each individal cgroup. That means we cannot really come up with values that would work by default in the general case.[1] For cgroup v2, it's almost unusable as well. If it turned on, the cpu controller can only be enabled when all RT processes are in the root cgroup. But it will lose the benefits of cgroup v2 if all RT process were placed in the same cgroup. Red Hat, Gentoo, Arch Linux and Debian all disable it. systemd also doesn't support it.[2] [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1229700 [2]: https://github.com/systemd/systemd/issues/13781#issuecomment-549164383 Signed-off-by: Celeste Liu --- arch/mips/configs/db1xxx_defconfig | 1 - arch/mips/configs/eyeq5_defconfig | 1 - arch/mips/configs/generic_defconfig | 1 - 3 files changed, 3 deletions(-) diff --git a/arch/mips/configs/db1xxx_defconfig b/arch/mips/configs/db1xxx_defconfig index b2d9253ff786..6eff21ff15d5 100644 --- a/arch/mips/configs/db1xxx_defconfig +++ b/arch/mips/configs/db1xxx_defconfig @@ -12,7 +12,6 @@ CONFIG_MEMCG=y CONFIG_BLK_CGROUP=y CONFIG_CGROUP_SCHED=y CONFIG_CFS_BANDWIDTH=y -CONFIG_RT_GROUP_SCHED=y CONFIG_CGROUP_FREEZER=y CONFIG_CGROUP_DEVICE=y CONFIG_CGROUP_CPUACCT=y diff --git a/arch/mips/configs/eyeq5_defconfig b/arch/mips/configs/eyeq5_defconfig index c35c29a4d479..3794707c9522 100644 --- a/arch/mips/configs/eyeq5_defconfig +++ b/arch/mips/configs/eyeq5_defconfig @@ -8,7 +8,6 @@ CONFIG_IKCONFIG_PROC=y CONFIG_MEMCG=y CONFIG_BLK_CGROUP=y CONFIG_CFS_BANDWIDTH=y -CONFIG_RT_GROUP_SCHED=y CONFIG_CGROUP_PIDS=y CONFIG_CGROUP_FREEZER=y CONFIG_CPUSETS=y diff --git a/arch/mips/configs/generic_defconfig b/arch/mips/configs/generic_defconfig index 071e2205c7ed..fa916407bdd4 100644 --- a/arch/mips/configs/generic_defconfig +++ b/arch/mips/configs/generic_defconfig @@ -5,7 +5,6 @@ CONFIG_IKCONFIG_PROC=y CONFIG_MEMCG=y CONFIG_BLK_CGROUP=y CONFIG_CFS_BANDWIDTH=y -CONFIG_RT_GROUP_SCHED=y CONFIG_CGROUP_PIDS=y CONFIG_CGROUP_FREEZER=y CONFIG_CPUSETS=y From patchwork Thu May 30 11:19:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Celeste Liu X-Patchwork-Id: 1941867 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=TBEfYXY/; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Vr1QF6P95z20Pc for ; Fri, 31 May 2024 08:39:17 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=TBEfYXY/; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Vr1QF0LFMz3fyc for ; Fri, 31 May 2024 08:39:17 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=TBEfYXY/; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::641; helo=mail-pl1-x641.google.com; envelope-from=coelacanthushex@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VqkLn74B6z2yD6 for ; Thu, 30 May 2024 21:20:17 +1000 (AEST) Received: by mail-pl1-x641.google.com with SMTP id d9443c01a7336-1f48b825d8cso6851585ad.2 for ; Thu, 30 May 2024 04:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717068015; x=1717672815; darn=lists.ozlabs.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dH4BG/CKSo6jMt/U3mBL2fbfMm4MpAzh5hyuRszV+t4=; b=TBEfYXY/J475NucUNli9hhn/di+WmgAgBPR8t+dZ5U/9JtCW0/NXmGvRtcoPp3ar5Q H9yt+bxK6ct2FImgKfEmyXsi60+OuFR9u5PnYclaaAqvOkDWjqkwA4gEvpB5dBaGIA68 8naN8hBs+h0X6rOdmQ8QAdiBr60VHyo1uffI4XHeZWbG1yNWRvdvJilhwCKaWt9eu9Ux SiZEkZIt5/iZQgKZFi0FWGY2MIzcv/gNtNSSNRFPye4BSAaSVl8lkuD6V3EfmOK9KCFi sY8Hw1eNAnABEEG0NJ4NacHV5cihM0FZV7NVDS68uoVxhf8+XzGSTVjTplhr9YMkyO9y JxGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717068015; x=1717672815; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dH4BG/CKSo6jMt/U3mBL2fbfMm4MpAzh5hyuRszV+t4=; b=mwKHbMoKj388ofUJBlvs4sq+4Sq9a7HQcWVvOc8wYKph2zYNUJyFF2cgRp1opSx1UG nW3oNqn9psG6VuLKAvvjhE5sukvgUZ9sPiQkUb+mMkXs6iZwVPsU+URQ7iusM55G21ai IULvltYQyzkprAL55ZnMa0+BO0FeVbQrDA3WfHJUVSaKD1R4AP+Z+6AELtln8gRETXTj j2WmCg9ZhzdX9nHY4pvdYVYHj/uBXBCbcZsLEUVm6bqLvLmI8G5Zc04JE4fleT3GK1K/ BWvucZZArgGHsMY4nznlNbORjipg79eNzbgX7R9HB+bZ0yLuL+/zPXX643gja/kxPZ8/ yTCg== X-Forwarded-Encrypted: i=1; AJvYcCV0uqteNvTB76PJBOCxaGO2Tbr4fAmR8gHhUo2B6YnJrr8enXGsP9NCrz/hjjvealo3NV0klsvJlTe8gCS4EZ5ibViCiOyJUuDoRvQNjg== X-Gm-Message-State: AOJu0YyexsB2iV1eGTGAGQ705E9u37F8iybETyAt3/35DLAqFa1xEWFM kU5pk/MRWQ0P4x5IJZYKKSnmdbIXWAWcL87jAR9kADjInzOMgxst X-Google-Smtp-Source: AGHT+IG8jHeaxjvonyo+8k1nlUsHHhRggP/hzSY+HPghj9Yo3s6jnJryohh0teWJzBXwbeSfn/+xNg== X-Received: by 2002:a17:902:ef45:b0:1f6:1a91:e744 with SMTP id d9443c01a7336-1f61a91e96fmr18511035ad.21.1717068015407; Thu, 30 May 2024 04:20:15 -0700 (PDT) Received: from localhost ([212.107.28.52]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f48bbbcaf0sm81594105ad.48.2024.05.30.04.20.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 04:20:15 -0700 (PDT) From: Celeste Liu X-Google-Original-From: Celeste Liu To: Heinrich Schuchardt , Anup Patel , Guo Ren , Palmer Dabbelt , Paul Walmsley , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , Vladimir Kondratiev , Gregory CLEMENT , =?utf-8?q?Th=C3=A9o_Lebrun?= , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N . Rao" , Sven Joachim , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Russell King , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Tony Lindgren , Thierry Reding , Jonathan Hunter , Arnd Bergmann , Mykola Lysenko , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org Subject: [PATCH 4/6] powerpc: defconfig: drop RT_GROUP_SCHED=y from ppc6xx_defconfig Date: Thu, 30 May 2024 19:19:52 +0800 Message-ID: <20240530111947.549474-12-CoelacanthusHex@gmail.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240530111947.549474-8-CoelacanthusHex@gmail.com> References: <20240530111947.549474-8-CoelacanthusHex@gmail.com> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1725; i=CoelacanthusHex@gmail.com; h=from:subject; bh=Y154zJjweZqXiEFejTlLKuxlmlIxiSlX1+quATRaPS0=; b=owJ4nJvAy8zAJfY4pvNJRPo6U8bTakkMaREJNwz83B+K5vRMSbg2N3g2v23ulidmG/9Zikz5N r1Q2vnFpk0dpSwMYlwMsmKKLGI7n75eVvrowzJekxkwc1iZQIYwcHEKwES4nzD89/SoEmo8dO8G n0eO7Aw1cZt90Zb+dnteRPD1pkVFLBEsZmT4umrj9jtvzS78ub1pD3/1w7Mzvl6+8T9jVc6dBXm cuVf72AEUHU7d X-Developer-Key: i=CoelacanthusHex@gmail.com; a=openpgp; fpr=892EBC7DC392DFF9C9C03F1D15F4180E73787863 X-Mailman-Approved-At: Fri, 31 May 2024 08:19:55 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Celeste Liu , Lennart Poettering , bpf@vger.kernel.org, Icenowy Zheng Errors-To: linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Commit 6e5f1537833a ("powerpc: Add a 6xx defconfig") said it was copied from fedore's ppc32 defconfig, but at least since 2015-06-10, Fedora has dropped this option.[1] For cgroup v1, if turned on, and there's any cgroup in the "cpu" hierarchy it needs an RT budget assigned, otherwise the processes in it will not be able to get RT at all. The problem with RT group scheduling is that it requires the budget assigned but there's no way we could assign a default budget, since the values to assign are both upper and lower time limits, are absolute, and need to be sum up to < 1 for each individal cgroup. That means we cannot really come up with values that would work by default in the general case.[1] For cgroup v2, it's almost unusable as well. If it turned on, the cpu controller can only be enabled when all RT processes are in the root cgroup. But it will lose the benefits of cgroup v2 if all RT process were placed in the same cgroup. systemd also doesn't support it.[2] [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1229700 [2]: https://github.com/systemd/systemd/issues/13781#issuecomment-549164383 Signed-off-by: Celeste Liu --- arch/powerpc/configs/ppc6xx_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/configs/ppc6xx_defconfig b/arch/powerpc/configs/ppc6xx_defconfig index 66c7b28d7450..c06344db0eb3 100644 --- a/arch/powerpc/configs/ppc6xx_defconfig +++ b/arch/powerpc/configs/ppc6xx_defconfig @@ -12,7 +12,6 @@ CONFIG_TASK_XACCT=y CONFIG_TASK_IO_ACCOUNTING=y CONFIG_CGROUPS=y CONFIG_CGROUP_SCHED=y -CONFIG_RT_GROUP_SCHED=y CONFIG_CGROUP_DEVICE=y CONFIG_CGROUP_CPUACCT=y CONFIG_USER_NS=y From patchwork Thu May 30 11:19:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Celeste Liu X-Patchwork-Id: 1941869 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=U6Sk9+Nq; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Vr1R73r2zz20Pc for ; Fri, 31 May 2024 08:40:03 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=U6Sk9+Nq; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Vr1R66xlbz3g0N for ; Fri, 31 May 2024 08:40:02 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=U6Sk9+Nq; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::643; helo=mail-pl1-x643.google.com; envelope-from=coelacanthushex@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VqkLq0bg9z2yD6 for ; Thu, 30 May 2024 21:20:19 +1000 (AEST) Received: by mail-pl1-x643.google.com with SMTP id d9443c01a7336-1f44b59f8daso4801635ad.2 for ; Thu, 30 May 2024 04:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717068018; x=1717672818; darn=lists.ozlabs.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FGiqpKa0bHIEpa15rly2elByLBlsz+mavCGVuSQB03U=; b=U6Sk9+NqsJck9hjTkNKe91iaUxoaZP697w/6ch95cVb8Q9EzIsU7n7UnRQ9Hy72KTD k93HBeuAXf6mluZR6wyVPjlq4kOuKqyg6ZuRS6dFlzBzztuIF8vr8+JKXC5nUMxMJnms 9bvNxSB7hT2UJt4yNnRBcirvfg3CxSrI45luk7o+OHs2Sz10jkSndUurzcdoMFeuVNcE 72Aj0fTDV4l35i2l3Y+SExV2ZImvBFXkpjULloH1VeePye+8fTTwNj/0WLw9LQ5oKPms k36bxwhZvJKcTAmg93nwylq1CpGsqZv1ilop910Sxi5awaoFSU6PbkT0YLmuRfPJiz2I W2TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717068018; x=1717672818; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FGiqpKa0bHIEpa15rly2elByLBlsz+mavCGVuSQB03U=; b=Zp7QCOIApiML7XkY0QoRP1XNFOojgwuEblLDe8qx02li4H4v843vFxmCYPUJJgMaHT LdIgIpozutDzqD5osZ1pPCzK4cMHuo9PxI2FGL2TLERauEqyuJALWJzqiGMVbev3Qqj+ G/QweAwvPL1n8SJFqBVdwgctBcjXTa1bCEMyaIsIq1abt2p/cEC+ysU1tidRZl60U6sb pz4J7DahOMLdWZDXSrpoghbSJ5iUYE3CFUhRgKP5o4CMFMw40bkj/mDuAMs22j7wX4MK hOkj4mXUKJF5x8F3l/OkcIxLVfg5x1Lh7ICkgCnRL2Ou6bQTAGlUAZyJ3UCVBtI70Uc1 dlBQ== X-Forwarded-Encrypted: i=1; AJvYcCXwS91l4ZkiODKNuD6CC5pBFKBxwl3SMCsoEtsVcCsmEcu40L9f8/e37RiIjuJByB2407hM3+xyHjOrH5gmJLaTWwI/H0DQiRQ/hj8YLA== X-Gm-Message-State: AOJu0YyBM0FQq9oLrFuiflUzmUkgz0B4ixXmj6NyxL5Eet24ehMsbLn5 8nXGKX+dhjBHxthc9+e142MrQ2KmXBFLQAqr5l52vgNw7wL3/Ct5 X-Google-Smtp-Source: AGHT+IH8SBUM4HFPal7PP4GlEtGKEuppsnSX92o9KNQGYi+syJrrgm3CpsZ+Cwm0ovcoR5ODsoOSkQ== X-Received: by 2002:a17:902:f1cb:b0:1f4:f1c1:646b with SMTP id d9443c01a7336-1f619610e86mr13465395ad.33.1717068017750; Thu, 30 May 2024 04:20:17 -0700 (PDT) Received: from localhost ([212.107.28.52]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f62218d9e6sm9517475ad.117.2024.05.30.04.20.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 04:20:17 -0700 (PDT) From: Celeste Liu X-Google-Original-From: Celeste Liu To: Heinrich Schuchardt , Anup Patel , Guo Ren , Palmer Dabbelt , Paul Walmsley , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , Vladimir Kondratiev , Gregory CLEMENT , =?utf-8?q?Th=C3=A9o_Lebrun?= , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N . Rao" , Sven Joachim , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Russell King , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Tony Lindgren , Thierry Reding , Jonathan Hunter , Arnd Bergmann , Mykola Lysenko , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org Subject: [PATCH 5/6] sh: defconfig: drop RT_GROUP_SCHED=y from sdk7786/urquell Date: Thu, 30 May 2024 19:19:53 +0800 Message-ID: <20240530111947.549474-13-CoelacanthusHex@gmail.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240530111947.549474-8-CoelacanthusHex@gmail.com> References: <20240530111947.549474-8-CoelacanthusHex@gmail.com> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2029; i=CoelacanthusHex@gmail.com; h=from:subject; bh=kOqrnzdbmJCW+4DZmJVchuzFR6LT5fL9WaReqTWmC8g=; b=owJ4nJvAy8zAJfY4pvNJRPo6U8bTakkMaREJNwub0yXLjr83sFl6+r9m9kR/++RbfTfmNMpv7 my3dmlavLujlIVBjItBVkyRRWzn09fLSh99WMZrMgNmDisTyBAGLk4BmAiHHSPDiWeRLf+fbOwM 1WVrORm/XDDz8bQ1DJ+etga9dN23//qBHoY/HAcKm/+7fhPVYMsRuzTfViI8IXPz8oWr86eHXVw Sp9rHBgChF03a X-Developer-Key: i=CoelacanthusHex@gmail.com; a=openpgp; fpr=892EBC7DC392DFF9C9C03F1D15F4180E73787863 X-Mailman-Approved-At: Fri, 31 May 2024 08:19:55 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Celeste Liu , Lennart Poettering , bpf@vger.kernel.org, Icenowy Zheng Errors-To: linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" For cgroup v1, if turned on, and there's any cgroup in the "cpu" hierarchy it needs an RT budget assigned, otherwise the processes in it will not be able to get RT at all. The problem with RT group scheduling is that it requires the budget assigned but there's no way we could assign a default budget, since the values to assign are both upper and lower time limits, are absolute, and need to be sum up to < 1 for each individal cgroup. That means we cannot really come up with values that would work by default in the general case.[1] For cgroup v2, it's almost unusable as well. If it turned on, the cpu controller can only be enabled when all RT processes are in the root cgroup. But it will lose the benefits of cgroup v2 if all RT process were placed in the same cgroup. Red Hat, Gentoo, Arch Linux and Debian all disable it. systemd also doesn't support it.[2] [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1229700 [2]: https://github.com/systemd/systemd/issues/13781#issuecomment-549164383 Signed-off-by: Celeste Liu --- arch/sh/configs/sdk7786_defconfig | 1 - arch/sh/configs/urquell_defconfig | 1 - 2 files changed, 2 deletions(-) diff --git a/arch/sh/configs/sdk7786_defconfig b/arch/sh/configs/sdk7786_defconfig index 7b427c17fbfe..3599b1683593 100644 --- a/arch/sh/configs/sdk7786_defconfig +++ b/arch/sh/configs/sdk7786_defconfig @@ -17,7 +17,6 @@ CONFIG_CPUSETS=y CONFIG_CGROUP_CPUACCT=y CONFIG_CGROUP_MEMCG=y CONFIG_CGROUP_SCHED=y -CONFIG_RT_GROUP_SCHED=y CONFIG_BLK_CGROUP=y CONFIG_RELAY=y CONFIG_NAMESPACES=y diff --git a/arch/sh/configs/urquell_defconfig b/arch/sh/configs/urquell_defconfig index 00ef62133b04..9cf4a719001e 100644 --- a/arch/sh/configs/urquell_defconfig +++ b/arch/sh/configs/urquell_defconfig @@ -15,7 +15,6 @@ CONFIG_CPUSETS=y CONFIG_CGROUP_CPUACCT=y CONFIG_CGROUP_MEMCG=y CONFIG_CGROUP_SCHED=y -CONFIG_RT_GROUP_SCHED=y CONFIG_BLK_DEV_INITRD=y CONFIG_PROFILING=y CONFIG_MODULES=y From patchwork Thu May 30 11:19:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Celeste Liu X-Patchwork-Id: 1941870 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=VKzUIu3W; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Vr1S00h9Tz20QB for ; Fri, 31 May 2024 08:40:47 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=VKzUIu3W; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Vr1Rz1csqz3g0w for ; Fri, 31 May 2024 08:40:47 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=VKzUIu3W; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::644; helo=mail-pl1-x644.google.com; envelope-from=coelacanthushex@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VqkLt4VYfz3cSy for ; Thu, 30 May 2024 21:20:22 +1000 (AEST) Received: by mail-pl1-x644.google.com with SMTP id d9443c01a7336-1f082d92864so6321615ad.1 for ; Thu, 30 May 2024 04:20:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717068020; x=1717672820; darn=lists.ozlabs.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=10Khnm7VAFiOR+x13kGKX5QXUNu8EX2jhqaMmuaAe9Q=; b=VKzUIu3W0tDfIHuMBvRzDy5EA31pxnevTEPulsXL8/flOIQVEL78NBPJL1ZO5Ws033 DmVz0XWY56wQsO3SlTXCsYqr1eRwDrkbrhKFbgh892Q3LmoUN2UYKhN6ySEUJV/IVLac IirJbamE+ktKN5Rx1s+Q0nOWNVhhosu+i3k1e3aI2XodZzsx722Os3fHhCcGwuC8plla Le6NsOdXbiMMwiMD+DZ/TquV4Zo4IJipZV5B409zmrEmdvYXrh4N3qju40CCwe51Q8dw RifF/pcyc7qT3Fv63pYM8VXPEarbNG4gaAJC9n9GqYtGx3LAAyAu9pt4S8I8Ru5TQg5B nbiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717068020; x=1717672820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=10Khnm7VAFiOR+x13kGKX5QXUNu8EX2jhqaMmuaAe9Q=; b=cbZo+HoIogrFSF0UyJ2WQhX9Afh66S0QPxC5OZCdYGAr1OYexIpRQgwzBvPmH4/oUd oLRg4EYwIVfQxlwjLiGpaVqUTfgtXM8NzoKyFAaY2H7+3MGo9AkLZhHNJVJE4VmF9awk 4cxrmFXBAp7K/CfdJ50QVOpOc7KNBLS6/cMu+Vp3AWClykly1GB4sON8tHnHCXr4MMTG UPJMpg8N+v07SiaA4Kq7KdQekFqP8x+IP4zX5d/dVfWmlX5aZtdTR1x7ir53UCESzh/f vgsq7Vx1nPGPtXdvcw7UYnbGrzWHvv6MqvZovdDf+oq7Qo+HA4loiUibM+f0r4LKlEH1 2PNw== X-Forwarded-Encrypted: i=1; AJvYcCUk9X+4f/6u38VWQ175pUe1bsbM0ySfXxZ0DXQ9bX5+vVx+qn0mEG8coEnaVjvhipux1wiPA3soVCC1H9OAWhy8xVxyiovKbH7z8pOxlA== X-Gm-Message-State: AOJu0Yy6T19HeZD9LqZqZL07tlRmltPkHzmEt96BQlQcN0DFz1HO+Eoz opIaO+sWs3/Sb945IgoUgGG9OSgKRQqVHRC3XFpCHW5+RQnxW3w0 X-Google-Smtp-Source: AGHT+IFxkZxBxtRo803YeGMuC8sIHF/n8GOkz3SCFQuOwIu4wbjvdjgInTxjR211s2831JVg1Df+Ag== X-Received: by 2002:a17:902:f682:b0:1f6:846:c15d with SMTP id d9443c01a7336-1f61983ab3dmr21091605ad.47.1717068020137; Thu, 30 May 2024 04:20:20 -0700 (PDT) Received: from localhost ([212.107.28.52]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f48e95c85asm80546745ad.34.2024.05.30.04.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 04:20:19 -0700 (PDT) From: Celeste Liu X-Google-Original-From: Celeste Liu To: Heinrich Schuchardt , Anup Patel , Guo Ren , Palmer Dabbelt , Paul Walmsley , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , Vladimir Kondratiev , Gregory CLEMENT , =?utf-8?q?Th=C3=A9o_Lebrun?= , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N . Rao" , Sven Joachim , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Russell King , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Tony Lindgren , Thierry Reding , Jonathan Hunter , Arnd Bergmann , Mykola Lysenko , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org Subject: [PATCH 6/6] arm: defconfig: drop RT_GROUP_SCHED=y from bcm2855/tegra/omap2plus Date: Thu, 30 May 2024 19:19:54 +0800 Message-ID: <20240530111947.549474-14-CoelacanthusHex@gmail.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240530111947.549474-8-CoelacanthusHex@gmail.com> References: <20240530111947.549474-8-CoelacanthusHex@gmail.com> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2729; i=CoelacanthusHex@gmail.com; h=from:subject; bh=z/Xh6Oh4/edMyA0oTGEdVRRBweOMR/LS4ucNKKx8jxk=; b=owJ4nJvAy8zAJfY4pvNJRPo6U8bTakkMaREJt//Jpz1/9vq+ftrjnHPOdUJ7Zl16y3oqfNMJ2 c4TmxeuZVnZUcrCIMbFICumyCK28+nrZaWPPizjNZkBM4eVCWQIAxenAExEIJzhf8HRRdu8P/5W lRSfdEtSzuIjW+AJrhe/BHfb27mxp8vLBjP8D+rcabfgddQ8Botz1wy6Gi5ev2tY0Ppvy/7rzt8 y5t8MZQUAhClPwQ== X-Developer-Key: i=CoelacanthusHex@gmail.com; a=openpgp; fpr=892EBC7DC392DFF9C9C03F1D15F4180E73787863 X-Mailman-Approved-At: Fri, 31 May 2024 08:19:55 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Celeste Liu , Lennart Poettering , bpf@vger.kernel.org, Icenowy Zheng Errors-To: linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Commit 673ce00c5d6c ("ARM: omap2plus_defconfig: Add support for distros with systemd") said it's because of recommendation from systemd. But systemd changed their recommendation later.[1] For cgroup v1, if turned on, and there's any cgroup in the "cpu" hierarchy it needs an RT budget assigned, otherwise the processes in it will not be able to get RT at all. The problem with RT group scheduling is that it requires the budget assigned but there's no way we could assign a default budget, since the values to assign are both upper and lower time limits, are absolute, and need to be sum up to < 1 for each individal cgroup. That means we cannot really come up with values that would work by default in the general case.[2] For cgroup v2, it's almost unusable as well. If it turned on, the cpu controller can only be enabled when all RT processes are in the root cgroup. But it will lose the benefits of cgroup v2 if all RT process were placed in the same cgroup. Red Hat, Gentoo, Arch Linux and Debian all disable it. systemd also doesn't support it. [1]: https://github.com/systemd/systemd/commit/f4e74be1856b3ac058acbf1be321c31d5299f69f [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1229700 Signed-off-by: Celeste Liu Acked-by: Kevin Hilman Tested-by: Stefan Wahren --- arch/arm/configs/bcm2835_defconfig | 1 - arch/arm/configs/omap2plus_defconfig | 1 - arch/arm/configs/tegra_defconfig | 1 - 3 files changed, 3 deletions(-) diff --git a/arch/arm/configs/bcm2835_defconfig b/arch/arm/configs/bcm2835_defconfig index b5f0bd8dd536..27dc3bf6b124 100644 --- a/arch/arm/configs/bcm2835_defconfig +++ b/arch/arm/configs/bcm2835_defconfig @@ -7,7 +7,6 @@ CONFIG_BSD_PROCESS_ACCT=y CONFIG_BSD_PROCESS_ACCT_V3=y CONFIG_LOG_BUF_SHIFT=18 CONFIG_CFS_BANDWIDTH=y -CONFIG_RT_GROUP_SCHED=y CONFIG_CGROUP_FREEZER=y CONFIG_CPUSETS=y CONFIG_CGROUP_DEVICE=y diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig index 3a166c2f02bd..9cb265c8d414 100644 --- a/arch/arm/configs/omap2plus_defconfig +++ b/arch/arm/configs/omap2plus_defconfig @@ -13,7 +13,6 @@ CONFIG_MEMCG=y CONFIG_BLK_CGROUP=y CONFIG_CGROUP_SCHED=y CONFIG_CFS_BANDWIDTH=y -CONFIG_RT_GROUP_SCHED=y CONFIG_CGROUP_FREEZER=y CONFIG_CPUSETS=y CONFIG_CGROUP_DEVICE=y diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig index d2a094ad360c..3a9bda2bf422 100644 --- a/arch/arm/configs/tegra_defconfig +++ b/arch/arm/configs/tegra_defconfig @@ -6,7 +6,6 @@ CONFIG_IKCONFIG=y CONFIG_IKCONFIG_PROC=y CONFIG_CGROUPS=y CONFIG_CGROUP_SCHED=y -CONFIG_RT_GROUP_SCHED=y CONFIG_CGROUP_FREEZER=y CONFIG_CGROUP_CPUACCT=y CONFIG_CGROUP_DEBUG=y