From patchwork Mon Apr 15 10:19:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Babic X-Patchwork-Id: 1923671 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20230601 header.b=F1E7VyLS; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::438; helo=mail-wr1-x438.google.com; envelope-from=swupdate+bncbcbolppcvamrbhx66oyamgqemlnf2ja@googlegroups.com; receiver=patchwork.ozlabs.org) Received: from mail-wr1-x438.google.com (mail-wr1-x438.google.com [IPv6:2a00:1450:4864:20::438]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VJ37C2dLZz1yY4 for ; Mon, 15 Apr 2024 20:19:17 +1000 (AEST) Received: by mail-wr1-x438.google.com with SMTP id ffacd0b85a97d-343ee8b13aesf2581588f8f.2 for ; Mon, 15 Apr 2024 03:19:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713176352; cv=pass; d=google.com; s=arc-20160816; b=P4fL7vxpY/vPBsH1rlzdKPPQlltVJfVe9CHputwSmLrkis5przhx+a1UfHX2OGbVw5 uYfpJs0mNCcsT08qNCrotwUsgYbwoI2L9CSxNa4vnNps88yDFZX89fc/hjuXRnKWqvPw AfL8yfLkYenkJBLd/AHawFMVvL7tYPgtPedc090hwvIxVHqkLOZSBxbouaYGJ46bWZnw GV57wIDLlSBJE+Bd/zA3vAMlo8og/M8KKh+yAwKKQTOyfZ8tzc0AeOrn3hX9JGOQ4Pcd 32UfWH9BwTYzXY94FKKbk8NxmZgSrd/lZf9WwG7TkUbTgucm5J5DVUjl11SXZ2kcow/I 7q/Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:ui-outboundreport:mime-version :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=PFtSRfRFpc0Rttz7Jxhb26Td36tY4DjVQVPQvhRhTPw=; fh=Si11CMOgnnHzaMFBEsebOBbSvRSSP1EOGz7ulHJsu/k=; b=ckMg3Sy5bNBbIzaC8fsupkG5YBW7cDyLPHPfIS9Ia9Ndj0iqeGdJnTZleVFnrQy9nO WFNW/7Fgjy6UFqLRC+kzDQYedFpVSYsvA9g56SV82ilTvTggGCPcvAgoCGiO54w7J4/m E5Eornqm54sLpgX/Qg3QXPAjl8f9P0T+2bBPHu31w40/9ct57NyoCEclmqzfzFjjN8DV tdldoueNuLFTQI7yuXNmEkG9IFjLLma8N8UO4CMUfpxNL2zSBCy0V710gwTl4qBCxJaI Hm+pa0HREQ8fAYR/hP8ajcw2M7KkssVkfmDwWHEMkOVhNtCnSv6qtLqTYkaJ8cydG63j wAIg==; darn=patchwork.ozlabs.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=FEWjyrvc; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 217.72.192.75 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1713176352; x=1713781152; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:ui-outboundreport:mime-version:message-id:date :subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=PFtSRfRFpc0Rttz7Jxhb26Td36tY4DjVQVPQvhRhTPw=; b=F1E7VyLS8LchzjirY0trlgL/vA221eQ9JhenU3bDFBDL7zZmOgu6o4RI7u4ZL8vyO0 1gkcIIVWOqItKB7U5v/LJjGjqJyaISualw4XEaCH89kK9rif2SfSclr73T8t35xv/VtI ISFOhfVE9Dldpqmc7nccN1KsPyK5iBPPd7L8CVjK/bjtPMd6ERd7z3f9UXuJAaj5bPxn 4Kjd44pxGJdZ+JAN4ASXYW0CfN7LB+5a+wjEeJWa9rDG1ymvm+xRrqmAblpjFUqcDci0 mNFYw4xxzwodHt02yGao1VZi6tv1K16PgHDn2VSN0dozTIW2Sb1h5o9h4dvx3twzpjQk gRqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713176352; x=1713781152; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :ui-outboundreport:mime-version:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:sender:from:to:cc:subject:date :message-id:reply-to; bh=PFtSRfRFpc0Rttz7Jxhb26Td36tY4DjVQVPQvhRhTPw=; b=SQAgJqLnKkNdNh6usWJ9iNOcNvPB9WQZRqphwJ6r5aZePj1NU3I9DjnrchDHaFFEC9 nNd++uUo4vr+K5XMptvUm33a577P3wxFenCR8pamDqsO0Eg+dX/y9eUD2gVub0NSC0/d KEn1EERJydMx13uUEQB7lUIl0KKcaR9WT0/+nyJ9gZRI18Pl3wH95fZzGEzOrqkKdzq5 78nP70w9SimERKYTR3zDwCFm8PgiEduqsaFQMveatleIeuxnj7IZ8208rE/Qp0VCc4N5 LEalzgm0KDNkuoa+RsdvrraL+2UIi4trp7ZfUW4OJ5Hq7vc2ifNqu7U6g6dg8sXwO+lp taog== Sender: swupdate@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCVSObxFNAeZmeQ1HXwx8GnZ02VZiAHYXVTpnp7/zcH/+9vJNr1mnFWMo/Ur9Pv/PQYk3IyW3O1nR1DwBagfD55eM+y0JycSfOzv/uzfTQ== X-Gm-Message-State: AOJu0YzyzNT+a7pjAwUue/A2CtWb/Rd09UxkAfUjJqaR5NDT9OxC/S/d MQz83969obEE5U5PtJF2YqlU1fa/Hk6Itgk8wZ78DNzjew/yQiqw X-Google-Smtp-Source: AGHT+IH9Xo/9YnrPxyD5lrhSfCwLc3KaZLbgoGw6HVjZep3KFp3htbKDvXyFZXpB33tGmN0btq37ng== X-Received: by 2002:a5d:42c2:0:b0:33e:ca3a:1bba with SMTP id t2-20020a5d42c2000000b0033eca3a1bbamr7634674wrr.20.1713176351620; Mon, 15 Apr 2024 03:19:11 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a5d:464b:0:b0:347:37f3:a087 with SMTP id j11-20020a5d464b000000b0034737f3a087ls1243886wrs.0.-pod-prod-05-eu; Mon, 15 Apr 2024 03:19:09 -0700 (PDT) X-Received: by 2002:a05:600c:3847:b0:418:4e4e:2847 with SMTP id s7-20020a05600c384700b004184e4e2847mr3072326wmr.14.1713176349341; Mon, 15 Apr 2024 03:19:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713176349; cv=none; d=google.com; s=arc-20160816; b=gDbicNIvDt3WhFaFINAXySF3L0cIEPZlx4i3hJr7mThG/h1UlW/avInXMr0c40nnqz r1QhSnbmXY4WSZ+B0RASK+41CwRAumpYYvW5O1Y37+zfuqgRvWr227eKhegPkkijLI26 l8doBcl2VgPHuoeZLXJHulahJIXeRDj4D3VquotJNHCDzOcamOH1Z0tqovm4CHLWWdlN fd+JwxrgcJR6gl2uv7+LZhW6e8JA6jQYfJJJPbB2doOwFfIhtDOaMH797kZccPeShrv/ 9T+1k1qnp7pqKvv7acytvK1wO7aAK282uu9J9Te+KZ+xjrbJ1Z3PT4+5MuhLlssblK8Q ThoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:mime-version:message-id :date:subject:cc:to:from:dkim-signature; bh=M1obE3kAdR2QQxgXoWpBhjwm4EuDXVX6BEUQ2HPJflI=; fh=TiEWcqMcKpHk5s7uErzpntoONrNfOXwKpI5P8bIlggk=; b=ZmB/m9G4CIZtqWceEoWs0ZQrtVaMu2oBMkKYZjcFQNLtXrtoPx+T69xuyuGc5by0uP yUqcE+8ac0I7s0+cQkD3sQcohX5zUIWdTwukMigdHSCTN8ZdSioWcCPV+dCxY6oIYNi3 k4qmjVSv9tyNgkuaQw/RZju+LteAU0UPC1McWV17RkgIjzZFKNs5spKXnS6bCON9BvmO TgvYT7MikXwADxY3ZMIhuZRsNB5XthEaWpqCXcoAPORXLTiZMy8beLSNRTv/bbCdeEXs YuwI2e1wjrXI8kAtFsC+wspHpTEg2wEWIZe+klVPXHI1YVmQtQXLrn4wO9+pfJcpgGO6 1FZw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=FEWjyrvc; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 217.72.192.75 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org Received: from mout.kundenserver.de (mout.kundenserver.de. [217.72.192.75]) by gmr-mx.google.com with ESMTPS id y20-20020a7bcd94000000b0041682cc5beasi330009wmj.2.2024.04.15.03.19.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 03:19:09 -0700 (PDT) Received-SPF: pass (google.com: domain of stefano.babic@swupdate.org designates 217.72.192.75 as permitted sender) client-ip=217.72.192.75; X-UI-Sender-Class: 55c96926-9e95-11ee-ae09-1f7a4046a0f6 Received: from paperino.fritz.box ([88.217.136.221]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1M1qbm-1ru6VA38bA-002Gwi; Mon, 15 Apr 2024 12:19:08 +0200 From: Stefano Babic To: swupdate@googlegroups.com Cc: Stefano Babic Subject: [swupdate] [PATCH 1/3] BUG: hawkbit: check if details are sent via IPC Date: Mon, 15 Apr 2024 12:19:04 +0200 Message-Id: <20240415101906.45782-1-stefano.babic@swupdate.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:ENipS4tvH2O9RwjuQJd1Zy59lk8rz/7yg3yYj4P9qSu/8OcSYix 0Y6nZxZgvopR4tahztk+F/VF5wWx9us98o9xkbyz7kNPT5V3tL+T8L0g6457n7x/TjjqpA7 tRzKW0rNWCy61yt7QYTRVXagnTTFtQYYQ2FbnI/BUggah0Rg/hHTbXqaR2+yeGkYY289Yso y3DTjB/Qgm4fYy0Nqqvhg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:q4yJcJItjug=;+1gLhvhms1Yo73S4xSn04K+fH+w 3vI16DdtvtUDe/iGTAyNl4+sq9O2hnGCHIHDKd4K5SA4VaXzo3y8JPGn91zu3mLdNRFXEUtOr NZbzqbzS3QqjErZkgKTlb0tT/N4aprfzLISOYq9dSDVJjh7UPHObzDgDXzoFCHIlXioLimVz2 sVNCJUdtUbh2nSJqRL+KYandggJ/Z6m3SIgS7t4vQBWxLq6+rZ1WpWIZ9W+mKpNLvlWfJ00HM S5Kry+MbykUQ/azPMBPBdVz+rlR4M9TLPlGON7uXyTO3FD3BdlDmXK1JlRNDbjj9mSRzPNmAY NZoM4sFMqEPeDBHNjvoh+WPC574x7ROH9YBPz5kKJqRTmAs8+UtSggUyIfo1cAN4BD5xU46k7 ZaXN6qN8IX5+g7fnhdKmPOg3SmDc//FDmtEw05UCj+HF9iKHsQLMR8DEpsjxu1LhDTtViRTwF uC8E3qM0oi5EqwknkRAcsr/XeVg5HQ/METBtlqSEl/Y7DOtg33BMdB53IthdAn5EwZL4HzBXP BWrvklspTgmfSZ4g3JIZgQvdzaGj/PN4/6j0M17sKL8n9mN0yUuXjvQif25th9beQ7+s7KvpZ 8I5Md1jspdIlPHt7eZMGZ4DM004f+O6s6eHSkWpuqW0pc8M+ZRUaBcDACkZzbOPbq5CKFBAAK WJpS7FkAqGonwcJi85XmaYjkLQC2sWMNWADXuIy68ZoD5U+MJxdgKIbhZDCYwCyXb9GLz+cFO EPrMaMQrpLkJEG73skBTMZKUhRyBNp4u9rGctYqkyh8I9XDS0+aSQk= X-Original-Sender: stefano.babic@swupdate.org X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=FEWjyrvc; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 217.72.192.75 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , SWUpdate stops after assert() fails if details are missing. All fields are mandatory, so check that even details are sent. If not required, a dummy string should be sent. Signed-off-by: Stefano Babic --- suricatta/server_hawkbit.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.34.1 diff --git a/suricatta/server_hawkbit.c b/suricatta/server_hawkbit.c index 7ceb1dc0..f1948c68 100644 --- a/suricatta/server_hawkbit.c +++ b/suricatta/server_hawkbit.c @@ -2054,6 +2054,10 @@ static server_op_res_t server_activation_ipc(ipc_message *msg) return SERVER_EERR; } + if (!json_data) { + ERROR("No details are passed, they are mandatory."); + return SERVER_EERR; + } int numdetails = json_object_array_length(json_data); const char **details = (const char **)malloc((numdetails + 1) * (sizeof (char *))); if(!details) From patchwork Mon Apr 15 10:19:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Babic X-Patchwork-Id: 1923673 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20230601 header.b=rm+HvpSx; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::53d; helo=mail-ed1-x53d.google.com; envelope-from=swupdate+bncbcbolppcvamrbh766oyamgqe72p7nvy@googlegroups.com; receiver=patchwork.ozlabs.org) Received: from mail-ed1-x53d.google.com (mail-ed1-x53d.google.com [IPv6:2a00:1450:4864:20::53d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VJ37X6Nj7z1yY4 for ; Mon, 15 Apr 2024 20:19:36 +1000 (AEST) Received: by mail-ed1-x53d.google.com with SMTP id 4fb4d7f45d1cf-56e353671f7sf621458a12.1 for ; Mon, 15 Apr 2024 03:19:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713176373; cv=pass; d=google.com; s=arc-20160816; b=AD6NSHCN0iwR47N8sCXhdliC1kBit5Gi6Q7u6EDR0rHyl1+n6KeefJ/e0cek0vSeIT 2opYpApBaee/GrJcGV623G2NGXRBiL0E2cDBUtrZREBI0HaVtGSirfGvX3TcToG1GBvl glg8Kk9ftIcnIv9f6qrZKKuNza2mQYhvHmdqFRRd709zUmYoyHEKA/vpHoagqH9a7mVi WL29ekjAXejGniBVgbkD6j5EqkkRXpcOvmYgDfwRFt+b7nngEzBRPy/PPCGOcsnVzkg/ 9RR9rYnRDMirEIfhXNcYM7S9McuLTIR1Ic5OW5T9mROBX7DGqCnoKAmtVnNw4IJEHAtF eGSA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:ui-outboundreport:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:sender :dkim-signature; bh=7MlafbKwJ8kUAldWI7YhGdCm5yjek4VmsB8krEuOEtk=; fh=zjZj+VImD0rE57AkWEN4/svl+83lyUWdH6zfRPKiL4k=; b=qLWo+gTFizC97w2Y0LMW9/UYKlL23EZC6YpbWTLid7tVwlB1rJMVYo4a5spa6pFwI6 hnDfkHKvrwPAkawlqAdTrVS6Df9E50nwG+GBr9E7hV5tpyZ++5bUkgB+pYz7zRzBvEN9 dK4vqK8gqUMsjBFl9wAh75Aj4FmYP2/uPm2n5N3n1nLSxpi3QX1SpNQB5XmkEx7Agh5a F84NmQWcSq+No8AxEkXEjyVsZkQ/r2mq2wNk1l+mQNgXuVMHKK45fZSvzRrQjCN2smhM cvEoLm9gQ+3dk1VZ9ONTRbFZhI1ihqJPHLm6g4hZNxfA79HbWxcTqYkKYcfGjEZ5eu2A qd2g==; darn=patchwork.ozlabs.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=FTs9EE9A; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.17.10 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1713176373; x=1713781173; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:ui-outboundreport:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=7MlafbKwJ8kUAldWI7YhGdCm5yjek4VmsB8krEuOEtk=; b=rm+HvpSxlZNqJd1MxLFmJia9oOpX59IHMd3TZ4LTlcdKM079OM+wa31RUgXOKs2ycM v305fXb6HxljlYyxY025fnyaEBLEdCIlYVOM9NDs9R2v/ONrho0q+ozwcDjCb4LUnnso ysJd7DGx7oNkJ/s2KX1PSClLwGvrkuCQwWBZwgM9i/HABFzd2UF8LIiM8n6vkIkJ1YEW PBlXSRFvk4lW+p7Pv5/t46pZIX34/NJXAckKgQn7wPj7IvndBa5dlEBtmF/LUge+HWrU L+AeyqJ95x7FzKaGBF7k6CnA9X00RXHjKQXs6e/KeHTpCOzIhpJWocrvL9gQB6Ruyo/3 k+mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713176373; x=1713781173; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :ui-outboundreport:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:x-beenthere:x-gm-message-state:sender:from :to:cc:subject:date:message-id:reply-to; bh=7MlafbKwJ8kUAldWI7YhGdCm5yjek4VmsB8krEuOEtk=; b=dLM2+UbQowwkDneUx1A6rZyXvZkBVe+vj3lwwVtGiwKx4GvzNOCvE52VB5KVf9iLGg keQ156e/cBt03rN9yRP+1GIOSsLrsyPTf0KaxYHF2bwi6RHg6ZzbrAcoKkFewFvIFC+G tjR7GjpsaYDiC5BNAV8LQ+giUwFaXKC2WKrlouiL0hnzVN6LiEXFQ22OLKTvj8gBuE/u T0nnxTdzLknQjnppKOvsxyDlFoP94TZEAV9A50vLVyiGmmWGNLjHUrCbMVHX3ITUreJV 1s3sQII//XdWOXyZYZI8uAT2EEp1pDNRRpVFHVAyDDvf878Ja1Ho42eTcHkn4zFvvmb/ 3rqw== Sender: swupdate@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCUoF/6L7AnifNp+mHif249R3Q5hpbe+F6xFOF/cnnlqVmy8GqTO8jSi7EWAAuyo+f+rP37Hb5SiUo4X/CCdaBC/ONLh/O2k8KptmMWA3w== X-Gm-Message-State: AOJu0YyNc2gVsf5uHe+IeG/5jGRH1v1umUxnI8f5ORLuPz3cqz2p2RaL IM+Hr8hDvZ1qFSu3WtFekU+EQi4ro78eo7K3BDfhaK/py3YNKEsb X-Google-Smtp-Source: AGHT+IGC1iNg04flfIHf9Af/MnoOc1vpeCk8atBmnPzTwnOyZMSHf1ZXDKV8cxw3upZywoyX6NGLlA== X-Received: by 2002:a2e:9853:0:b0:2da:9ccd:84f1 with SMTP id e19-20020a2e9853000000b002da9ccd84f1mr489894ljj.2.1713176352497; Mon, 15 Apr 2024 03:19:12 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a2e:a4c1:0:b0:2d8:3dd7:a9bf with SMTP id p1-20020a2ea4c1000000b002d83dd7a9bfls962020ljm.2.-pod-prod-07-eu; Mon, 15 Apr 2024 03:19:10 -0700 (PDT) X-Received: by 2002:a2e:6e12:0:b0:2d8:3eaf:86d2 with SMTP id j18-20020a2e6e12000000b002d83eaf86d2mr5867272ljc.47.1713176350049; Mon, 15 Apr 2024 03:19:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713176350; cv=none; d=google.com; s=arc-20160816; b=Qpv9zExXt3taNMnZBEzbn8oxeRD3pRvnAcbRVd1ZL8/WIzS2f5xtBPvtWtXQLfbfZh ZEO4KaMBk0R+VnAf1fc/wkhRzcWPeXMOR7/y1SN7jMmRndrEfVSiWiLpS+xxjToakLTb BW/oRqV3ezVdjZcVTivuexUTAJbm+UWMxZLfmpd8dj0uK77QAAbCEgGGR0PKbJR8+fW9 3aywwnG3Y7gXLo5UOfsDt1w+grWYTuwcduoNT299iu9casdeKS/kKvjvcf45+w4xjDDF rzlxniFlwvj2U5kd0ukefC67kGKzF0w8grF1onoxOWOR5ZlVUy1hogsHNY4JTJFtY2Mp 5x8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=ln8Mu8iCiOcfsV00WQl8eVk7doqgPOpofRoXIVX5zV4=; fh=TiEWcqMcKpHk5s7uErzpntoONrNfOXwKpI5P8bIlggk=; b=eL9ZMLwm9DqCfszZ3Tx3hNiLvjdk5VC176AbeCtVoYSI60UoQiwb9LX215IRTd4JQQ UD6xxlMyfAFIkbo41J2isyABzuzlttv8Rbq0N5FK09a//GFKombQ8M3XGTWtxWGtGkZZ XdXp9Y9OmDUw33SsFvOjFxDUmRwr2IEXfanO7SOaRh6g/d/lNzmey8F9yF0RctqSWP/9 FRdDVaeMQgSegtB5TFf3n+psQtk3yVqD+gp+OrsDOk24Ki7tl8KZzXEuCtzUqTBEtPGH EXV5EPAsF1zlwwUWPlmZTopAeqd8BA0Ct2pxH5kyqAGvrId++jzdxyuIL/hoZ17JsNKF 8kRg==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=FTs9EE9A; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.17.10 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org Received: from mout.kundenserver.de (mout.kundenserver.de. [212.227.17.10]) by gmr-mx.google.com with ESMTPS id k19-20020a2e9213000000b002d83db42d33si272207ljg.6.2024.04.15.03.19.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 03:19:09 -0700 (PDT) Received-SPF: pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.17.10 as permitted sender) client-ip=212.227.17.10; X-UI-Sender-Class: 55c96926-9e95-11ee-ae09-1f7a4046a0f6 Received: from paperino.fritz.box ([88.217.136.221]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1Mna0x-1sdJ9t3inl-00jcdZ; Mon, 15 Apr 2024 12:19:08 +0200 From: Stefano Babic To: swupdate@googlegroups.com Cc: Stefano Babic Subject: [swupdate] [PATCH 2/3] hawkbit: check for validity of action_id Date: Mon, 15 Apr 2024 12:19:05 +0200 Message-Id: <20240415101906.45782-2-stefano.babic@swupdate.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240415101906.45782-1-stefano.babic@swupdate.org> References: <20240415101906.45782-1-stefano.babic@swupdate.org> MIME-Version: 1.0 X-Provags-ID: V03:K1:SjZN1ZVbAC97sSTGn3YbPtiF6H0RNm21yQwHYfcBvxrqczaAIA3 sO8tJwIFhOGePzUlTer9aowZleAmoIsXbzpAiVM8eD2yhJ5vB6JyF2a8tueHUYbYPpEWT+i ZgfGba5DlbeqPpA5dQKZy3TUBnhfvtjqj/QNJPdWJHC5AnzLkWwpDphYZ8zqrI9hz3od375 977hGa9UZneum+UGSwGRQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:wPD23/EhON8=;kPvhLZH7lOwDKdE+6YuiOJ4LLp1 28F3GfqjD/NK16My8KIFKiNabTsxqIjEUKlpHO2sUc8oAOOdXu7DvSSCVcPrl/7D1MtkJJo0K 0ACmVVVpWvzthoId7L5r0QpTd08nvK42PrprwF9JEElSZwg942daIxkJ5wNn9tbRQoXEUtmxu iCI1L4BNRimriAVPecRWSDyAsuFF0hERNy05gKr4oSSpxwAHqTjBlWT8H4RXEtzrds6telmFN bTyQfAqttq/jFVLQOjqEmnUfdUjOOKK/zx9tXMnqcZqPy0XKPcG+IUJIZ+hgZB84K/RaEWbsZ a2pnwXr1dkEv88xcWmFN7e0SLOTI8Rl0Tz/jNWwR8Zrg8jLXSJGnsUz+eqDF04PmiBNejBbxq ArYxV6RiYWJc/SL7Le2W0nGSVma9zdx+f9xIvpPbEFtD5VuXvj8TAv3/EwxPIKxcICAh/E7DD ybhBENfVngQ7X0L3yZGHay9ptrA5g3OSZJ0CYQfPytCgU1ZI/gDnBfjibvljLGeZcmULKrvw5 J2egVKldwD7aJVEzOZXd1FwUFvz2BMNoG/d6/ujR0pEv12RVKyo0XUVahtD4jlVjoetTlu/kU AwWT08nGU66MN7IrtkVECq+kt3rmXXMmFlNgRn2TbnUJy62QhBwN+5gZYEwpUSa6TpsymFAmo +G9fybT9ykJol/r214hFPi5eSEflwHJOGhVEjFiXEiwMx4OWAuAQjl8DfYtN7UIvVt/Q9VxpD hb2GJrpwJA6kLT0oaWE8s7EDDp1atKAt5IneqfkIW/HhGg81PsJH3s= X-Original-Sender: stefano.babic@swupdate.org X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=FTs9EE9A; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.17.10 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , The "swupdate-ipc sendtohawkbit" tool allows to send a feedback to the Hawkbit server with external data. Commit d770ad59e introduces that SWUpdate can persistently store the action-id between runs, and this worked after a reboot when SWUpdate is started again. This patch introduces the same feature when IPC is used. The action-id in IPC can be set to 0 or -1 (invalid for Hawkbit), and SWUpdate will then check if a valid action_id is in the environment. Signed-off-by: Stefano Babic --- suricatta/server_hawkbit.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.34.1 diff --git a/suricatta/server_hawkbit.c b/suricatta/server_hawkbit.c index f1948c68..5199eefe 100644 --- a/suricatta/server_hawkbit.c +++ b/suricatta/server_hawkbit.c @@ -867,6 +867,7 @@ static void get_action_id_from_env(int *action_id) * Get the acction_id that corresponds to the done update if it was * stored. */ + *action_id = -1; char *action_str = swupdate_vars_get("action_id", NULL); if (action_str) { int tmp = ustrtoull(action_str, NULL, 10); @@ -2023,11 +2024,12 @@ static server_op_res_t server_activation_ipc(ipc_message *msg) int action_id = -1; if (json_data) { action_id = json_object_get_int(json_data); - } else { + } + if (action_id <= 0) { /* 0 is not a valid action id */ get_action_id_from_env(&action_id); } - if (action_id < 0) { + if (action_id <= 0) { ERROR("No action_id passed into JSON message and no action:_id in env"); return SERVER_EERR; } From patchwork Mon Apr 15 10:19:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Babic X-Patchwork-Id: 1923670 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20230601 header.b=e92zza+/; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::43c; helo=mail-wr1-x43c.google.com; envelope-from=swupdate+bncbcbolppcvamrbh766oyamgqe72p7nvy@googlegroups.com; receiver=patchwork.ozlabs.org) Received: from mail-wr1-x43c.google.com (mail-wr1-x43c.google.com [IPv6:2a00:1450:4864:20::43c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VJ37C35cZz1yZf for ; Mon, 15 Apr 2024 20:19:18 +1000 (AEST) Received: by mail-wr1-x43c.google.com with SMTP id ffacd0b85a97d-343d6732721sf1947300f8f.2 for ; Mon, 15 Apr 2024 03:19:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713176352; cv=pass; d=google.com; s=arc-20160816; b=BYpgVyAi0mdUiuf2rz1PzwI/nHpyeZXdRa+VzY9qQtuC7DKd0KBvU3R0c+Acbu9yAl pA6h0GcidpPBrhlpV5cDbESrgyL19QhK8PoPkUfEVYgM0kdl0YswddQu4xhZmRsfrq4l 72YImAKfhE2TZOv2MRIM/ClS67YkCPKdYFtb1vQMegEfpVx/LJlVvV633kbOdKfX3vMH zpgmbhrY8vCdx+nXfHgn9iAecIMgOSvUgrvTuNRy22iu5XgNEUeHxQs/mW79hWsI/7mq 7ic31h/SLkfkEQQf1Vs9+bHhOlC8E3PavnH2U1mLClBrrTYvzYtKZdeT6cVcELXn323P rX6g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:ui-outboundreport:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:sender :dkim-signature; bh=5RmI68Q3RSaJsSkXUKTQVa6aeaIQv/+CpRWtOMJkbRM=; fh=AWS+B/XCaLt/4qZxQuw7PZJVUoXKtP9B1GTHnk9T6t4=; b=k//ZNUl7Nt4YDkkJ+ozpeqv+9+oIpGpW3t/6VEtyoJQ3NV25vzM4/XuYkVEb1sjlGg 3tje8uTWKWXdy0lvNTK2KJRXUKUO7X+y3SICVXN6JeWH341wlSp+6kjgOXWKZC2o9pRj o0JDI2gJQwPtMupNXBBaATH3fMqe9Q8xpOwjwkKHqpclIF0RNrwqQSpInz/y/TduEgaM IkGwhzS/VmS+ckDgxc4gRrHGh8y9teM5fs6hQWg7e8tuI+5YGGrtMDMyuqVQ3KHpd8Hw jLRArggh+dqWf1Vjn6N9tErKq+ErqSoZjfrVfIHnwFa6ZkIYGcGnxqeqxBKvQ6RcC2GL 4Ptw==; darn=patchwork.ozlabs.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=GHQQ+kOx; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.17.24 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1713176352; x=1713781152; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:ui-outboundreport:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=5RmI68Q3RSaJsSkXUKTQVa6aeaIQv/+CpRWtOMJkbRM=; b=e92zza+/l3gNCd9RCxeebNbR1OP/Aa0BKrtCkY8HN6eafCm/XM5+CjFsXD/cDCe6+3 7GdBBvXQ/xiTrR9Bfl+RZmUWbk9dqZu56XcKdikrfYXP6dhROnNiDU6Hrvw5LcDCwwlh ZP7EjT3TTUChozLALSQ+Sp0jPGmGAPJHG5MUGMbbn7OpwsZ5pEguZNiVu8HySpx0pcmM RbjW6QAhgKPj4FiHfg5KsBMYYRpUnAInhzUKJs7A1h06/LddlIMhEVi9jyHQ/1mBjhQ3 5xkKv+AVVxN/9hlZL5H8fFchAhNViE5JiE2ZZEqsSpjNTus0waKy+GzWkf+hwIlTREC3 NHGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713176352; x=1713781152; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :ui-outboundreport:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:x-beenthere:x-gm-message-state:sender:from :to:cc:subject:date:message-id:reply-to; bh=5RmI68Q3RSaJsSkXUKTQVa6aeaIQv/+CpRWtOMJkbRM=; b=Ke+qtjTGdYUHItTQh3w+Y+SvtkJ4jAwLgy9TJDBrifPtWJWyo8eTfgFkzKgdRWGkJ2 4egRR182EgI2C93TQwqsyRJ2R0InonHNS5qiR1MS70J8OShfrDnKlljirr3zDjrSy2Pr cRdM1m+xebbEAuh57jsgeHUD/aqnlIuBkYDhGAIBpzFXzPsQcO5rdSpu4kdstg+J30VP Sj1l2ixNzNABadRdLcgt1QZM1u5A7UQiYH83GCpmiC4T+GTZ+F1oivGpm+1J30ea/6dM gNbZVgnrXqwsNaGIw6n63yxN+aNJJ7vOPAUldN9ZEGxVMqCVPA8AjptCuqssaMfF2K8W SRWA== Sender: swupdate@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCWB0pV2h08SVUHDSyV+sf0y0eamSsLLAdcbyuIiJRUKArAAIHdq88+Axn9b6wxThJA+zwa28UAJ2eBrLMd+La+dYGOypaFRWctM4e4ERw== X-Gm-Message-State: AOJu0YyoGx9fCg9hLACrJi4vdS2jo+PfQLQFHYrIvl5Xj5RAA/Gm2zPS oVRb9/L3FyJF3I0IGxMDtCU7I7rvNrDJPJn1iYPXIX4qy15p6bnC X-Google-Smtp-Source: AGHT+IHmizwB8RjKTGPol6IZoRUx70RmIAI4oMtFKqi1bCNB/Dl1b1zw5bUxXCpMdKf7dFBcm0Y6lQ== X-Received: by 2002:a5d:47c2:0:b0:346:958f:5ef4 with SMTP id o2-20020a5d47c2000000b00346958f5ef4mr8717906wrc.56.1713176351621; Mon, 15 Apr 2024 03:19:11 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a5d:4648:0:b0:341:b78e:d240 with SMTP id j8-20020a5d4648000000b00341b78ed240ls1479370wrs.0.-pod-prod-08-eu; Mon, 15 Apr 2024 03:19:09 -0700 (PDT) X-Received: by 2002:a05:6000:1811:b0:341:89da:540c with SMTP id m17-20020a056000181100b0034189da540cmr6998174wrh.26.1713176349475; Mon, 15 Apr 2024 03:19:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713176349; cv=none; d=google.com; s=arc-20160816; b=fm8pSpo+E9QMYlF2ko5zkHVgksDq7SAjqFjuumoOHPr17cSPvjA699bC1Q2YdREYSt H0qxmQx1uymZZU6X6FzXk/xppMjDMRevlJEtW1v9MHM1/jqtdn5l2SzgIPCqfwKbSUBl eZnVUDe+kkctmqK1UU+HF/yYH/PNKIaoV+y7MpEYpr9UVEyn/gwEBsqdw6PrVSZcLUOg YuzSnToUxFuYoDUQRz/446bfviR0tqkVlhtb5/k7x9wXPbbya5/afLF+kWxizG9Rg3Qf 0cUtsLrVHo6hLJNkzs8rtHZ2IgM9t31CsUv2Xi5VHKsjPav1X0nKsrq+zi1GkFTOQiw6 Ig3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=rjddq2/6N25tfvUeJSVStU+Jpd2BkbshfqAdWLP/tA8=; fh=TiEWcqMcKpHk5s7uErzpntoONrNfOXwKpI5P8bIlggk=; b=vBpqOWy4JtaOr8+rEk3iaDNgkRoLOXk/Jl2KG+l51/vKXFr7cQkJRHcs7tY0nng0vS blCKOo1MeiOd/ul6gLCptUF7RHkU1ICuFzYrWhBwINA4YGmsfPYLZF3EXyXv/ofNGD3U eNnfh8wnL2Hc81vcjYxqlwSXsE4GsjVsr5v9zos9O24fctBMYhZOkkeXtJzDWR/8uFjb YlFNsJZacx+B5L07uqgA0j+H1CGbLFOaUpbpUQTH/49QoWFTgyDTlMZNQ/ttzo9lA1+Q BHpxUVK/6BGB5MRwW3ZiFVa8dtpV5ryql7xg634gJDBuMr6BXh24tol9hjDnmf56zNRQ 6umQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=GHQQ+kOx; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.17.24 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org Received: from mout.kundenserver.de (mout.kundenserver.de. [212.227.17.24]) by gmr-mx.google.com with ESMTPS id q7-20020adff787000000b00343ad9e321asi260535wrp.2.2024.04.15.03.19.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 03:19:09 -0700 (PDT) Received-SPF: pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.17.24 as permitted sender) client-ip=212.227.17.24; X-UI-Sender-Class: 55c96926-9e95-11ee-ae09-1f7a4046a0f6 Received: from paperino.fritz.box ([88.217.136.221]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MsIbU-1slF7X0H2A-00tgqY; Mon, 15 Apr 2024 12:19:09 +0200 From: Stefano Babic To: swupdate@googlegroups.com Cc: Stefano Babic Subject: [swupdate] [PATCH 3/3] swupdate-ipc: extend help for sendtohawkibt command Date: Mon, 15 Apr 2024 12:19:06 +0200 Message-Id: <20240415101906.45782-3-stefano.babic@swupdate.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240415101906.45782-1-stefano.babic@swupdate.org> References: <20240415101906.45782-1-stefano.babic@swupdate.org> MIME-Version: 1.0 X-Provags-ID: V03:K1:LJfRFzqIuM4R9nFLHvc3+tMiO2ohJuTkz3BuzuSAhHSYKVUdyLO 6b2yAV3YEhly6FOzhjr4CGJ6QpDwpsuse4uW1cJb3elfU7EnfDDT+KmZY7Cx41b7P16BfYY LltbN+4qI0N9/wpMtcaUyZ3vPRIJ3K+nCXcxPNMr+/RQgSY/atAhNgdAJx4kxkCIr5c07fX THuyMboaIYUn4gFbicLgg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:lUGQABbrhjI=;Nc0BRbU9g3Q8F/EfkmBZBdG81Cl CiRvEhF0Q5S+MQRADvioyPVHDfEh3zVosi0dlwA6VhZ5R3jWOPO1w2toQtwZenZtSCFhumkhg 8y52ExzQBiBtPKgNZMI5sW8E2TR7nwzCSIDHFXvkEq+QJn05+/KyNLPKXFgx7zVULVs1fOzqh GD/6MygZswbKgWJCOp7vO0zH73BBPbxxLLb5Efqi5m3Kijjq9eXGT+S5gEx8rbwn+GElmEtLY k3uV+L/AscZFVtVvrCoo0yHzpwQBfY3Btyc4Ke/uZnzHAqUmWAWWtpMpc9k2w9AjqvaQD30z+ L1BM+rt+o2YSttln0FCF+FPyJSHjphSLjGEkYUH+46607cP01oj4OMUh6fbWzoOu7aG/gsGky IabAkYFg14zV6xgAKB80gGQlIpvEjsxa34lrX3aBObgVeJXdNeck+c2jw3BJY6Afl4dvRoMb6 EwGZeexHkVDPf0mUryRr+Zp5xRDP9WkjVfx8lAkGYRH8bVuNKF1XzFw1KDr2QaczWaQRgYL4S kPhlOEh7OlHXf63mX2R/7pIB89z3WLxb+Viqz/NvAYStGC1WhLiqvtpPY/KgeY+8DadLy6xJH /VECsLzyIyB3xwxklTDcePjNLzq00Ff3j+voGmWwajHweRRLap/AiANRhi6LD4l71pJtfb3ur 4NxEOspjSRI+aeuTcMM/DoCBxoMrXYq5JBRwkpGXz3KxMxC5Sdk8EsDmwo1UzBwWUXFssHPPz x7nPSE2Xr5sena/FOfa3kGkbgPyBiQxRBicxL8crRTOzrBz6M4EnC0= X-Original-Sender: stefano.babic@swupdate.org X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=GHQQ+kOx; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.17.24 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , sendtohawkibt is quite cryptical because it just forwards parameters to the Hawkbit Server. Add explanation in the help about paramneters. Signed-off-by: Stefano Babic --- tools/swupdate-ipc.c | 7 +++++++ 1 file changed, 7 insertions(+) -- 2.34.1 diff --git a/tools/swupdate-ipc.c b/tools/swupdate-ipc.c index a2502aa2..0dfaeac5 100644 --- a/tools/swupdate-ipc.c +++ b/tools/swupdate-ipc.c @@ -63,6 +63,13 @@ static void usage_setversion(const char *program) { static void usage_send_to_hawkbit(const char *program) { fprintf(stdout, "\t %s " " ..\n", program); + fprintf(stdout, "\t\t : 0 - asks SWUpdate to find the action_id (first env, then network)\n"); + fprintf(stdout, "\t\t > 0 - valid action_id stored by application during update\n"); + fprintf(stdout, "\t\t : a valid state, see values in state.h\n"); + fprintf(stdout, "\t\t : one of \"success\" \"failure\" \"none\"\n"); + fprintf(stdout, "\t\t : one of \"closed\",\"proceeding\",\"canceled\", \"scheduled\", \"rejected\", \"resumed\", \"downloaded\", \"download\"\n"); + fprintf(stdout, "\t\t
: strings that are passed and stored by Hawkbit server (User information)\n"); + } static void usage_sysrestart(const char *programname)