From patchwork Fri Dec 22 10:05:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Hu X-Patchwork-Id: 1879596 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SxNGN1tdgz20R1 for ; Fri, 22 Dec 2023 21:05:31 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1rGcPC-0002W4-1I; Fri, 22 Dec 2023 10:05:22 +0000 Received: from smtp-relay-canonical-1.internal ([10.131.114.174] helo=smtp-relay-canonical-1.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1rGcP6-0002TJ-Sd for fwts-devel@lists.ubuntu.com; Fri, 22 Dec 2023 10:05:17 +0000 Received: from canonical.com (unknown [10.101.194.164]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id DE8373F6CD for ; Fri, 22 Dec 2023 10:05:15 +0000 (UTC) From: Ivan Hu To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpi: fadt: add PERSISTENT_CPU_CACHES bits to fixed feature flags (mantis 2206) Date: Fri, 22 Dec 2023 18:05:04 +0800 Message-Id: <20231222100504.25385-1-ivan.hu@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" BugLink:https://bugs.launchpad.net/fwts/+bug/2047212 This is new to ACPI 6.5 Signed-off-by: Ivan Hu --- src/acpi/fadt/fadt.c | 12 +++++++++++- src/lib/include/fwts_acpi.h | 3 ++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c index 346fccbd..c402506d 100644 --- a/src/acpi/fadt/fadt.c +++ b/src/acpi/fadt/fadt.c @@ -151,7 +151,17 @@ static int fadt_info(fwts_framework *fw) fadt->flags & FWTS_FACP_FLAG_HW_REDUCED_ACPI); flag_info(fw, "LOW_POWER_S0_IDLE_CAPABLE", fadt->flags & FWTS_FACP_FLAG_LOW_POWER_S0_IDLE_CAPABLE); - + + if ((fadt->flags & FWTS_FACP_FLAG_PERSISTENT_CPU_CACHES) == 0) + fwts_log_info(fw, " PERSISTENT_CPU_CACHES is not reported"); + else if ((fadt->flags & FWTS_FACP_FLAG_PERSISTENT_CPU_CACHES) == FWTS_FACP_FLAG_PERSISTENT_CPU_CACHES) { + fwts_failed(fw, LOG_LEVEL_HIGH, + "FADTCPUCACHESRESERVED", + "FADT persistent cpu caches value 11b should be reserved."); + } else { + fwts_log_info(fw, " PERSISTENT_CPU_CACHES is 0x%" PRIx8, + (fadt->flags & FWTS_FACP_FLAG_PERSISTENT_CPU_CACHES) >> 22); + } fwts_log_info(fw, "FADT: IA-PC Boot Architecture flag states"); flag_info(fw, "LEGACY_DEVICES", fadt->iapc_boot_arch & FWTS_FACP_IAPC_BOOT_ARCH_LEGACY_DEVICES); diff --git a/src/lib/include/fwts_acpi.h b/src/lib/include/fwts_acpi.h index 2d7bacd1..b4671b06 100644 --- a/src/lib/include/fwts_acpi.h +++ b/src/lib/include/fwts_acpi.h @@ -56,7 +56,8 @@ #define FWTS_FACP_FLAG_FORCE_APIC_PHYSICAL_DESTINATION_MODE (0x00080000) #define FWTS_FACP_FLAG_HW_REDUCED_ACPI (0x00100000) #define FWTS_FACP_FLAG_LOW_POWER_S0_IDLE_CAPABLE (0x00200000) -#define FWTS_FACP_FLAG_RESERVED_MASK (0xffc00000) +#define FWTS_FACP_FLAG_PERSISTENT_CPU_CACHES (0x00c00000) +#define FWTS_FACP_FLAG_RESERVED_MASK (0xff000000) #define FWTS_FACP_IAPC_BOOT_ARCH_LEGACY_DEVICES (0x0001) #define FWTS_FACP_IAPC_BOOT_ARCH_8042 (0x0002)