From patchwork Sun Dec 3 15:48:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 1871834 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Skr386Dv5z1ySd for ; Tue, 5 Dec 2023 17:19:15 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1rAOlu-0005a6-Az; Tue, 05 Dec 2023 06:19:06 +0000 Received: from mail-bn8nam04on2087.outbound.protection.outlook.com ([40.107.100.87] helo=NAM04-BN8-obe.outbound.protection.outlook.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1rAOlp-0005ZK-IL for fwts-devel@lists.ubuntu.com; Tue, 05 Dec 2023 06:19:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EDqABFBtyBjUL4j6kH8E4qzZ7cHKhVUBEy4n7dBEEbmMMpJjp9zsfg8DbjPg1lBUId2/sfPG7PytJWdc4WHfQ3OQpN9N5yVrLa21Vkc91oZ+inb+mI4HdswnETGhi88oS1xvf/RtG2XHsxXNB8mnVLLQmor7QIGNJwBu8QinjCNoUdSLWkIkrlpxTaL3Ow0+KJdyLr0rXlvh6fzVDo/AxFFJqdydu+ShVBoCiOZEt00b/BBr0OHvV5xZjMQMDe+mpVQPcnP28VmdGuUvPjmFwFoAjy3YlP7Q2blKqmA45403WDe5JZLIODzCBMgdBHDnFt1tD4PLf3dQbW8z16jnPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B1PFXfuPTaxM64OOa1IiV3zB3E9o0W9GztWXabXmJD8=; b=HyHn6+UgTF6BuKS4BDK0l+35YAUq/iNZnHjekPcy1Tgi/6Y1NtoBWeBzuAXyEHqax5U5j+kCB7o9Qz67GOQFYijOqNdxE6031a6CoIcqB2p9tQ8X8W4tgK8pUoKARucq7Bfru/zMHFFoXHjkcfR0sr4R30kX0TKyP3N/jCa+WtCfHYzlauYI6wBI2dijEit+K1x3ti5OaTvVIG/En85lZYhrPXQldnOTK3NYc9LlbTLEGcA8hJg67x2HiyXdcafk+fKdP9rMwFuGuUf0QEmhVf/3TKJSrGKZQ7gEyeA+8Ud+v8sJgxxwl6xNJDomlLhrtyuoqi/5lBGnoEqczUNvRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.ubuntu.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) Received: from BL1PR13CA0385.namprd13.prod.outlook.com (2603:10b6:208:2c0::30) by DM4PR12MB5793.namprd12.prod.outlook.com (2603:10b6:8:60::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.33; Tue, 5 Dec 2023 06:18:58 +0000 Received: from MN1PEPF0000ECDB.namprd02.prod.outlook.com (2603:10b6:208:2c0:cafe::63) by BL1PR13CA0385.outlook.office365.com (2603:10b6:208:2c0::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.23 via Frontend Transport; Tue, 5 Dec 2023 06:18:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MN1PEPF0000ECDB.mail.protection.outlook.com (10.167.242.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7068.20 via Frontend Transport; Tue, 5 Dec 2023 06:18:58 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 5 Dec 2023 00:18:55 -0600 From: Mario Limonciello To: Subject: [PATCH] Upgrade MCFGMMIONotReserved to HIGH error Date: Sun, 3 Dec 2023 09:48:42 -0600 Message-ID: <20231203154842.41464-1-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000ECDB:EE_|DM4PR12MB5793:EE_ X-MS-Office365-Filtering-Correlation-Id: 11daf124-f53b-40c0-6091-08dbf55a10fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uUzyk2F/XizSUneuve7HaWecBTFwNGGjjO4meLQRTbDi0ZvaarBoc+BBWp0giV+cepVCGY5lEiUaHhNjIv/O/8lD1xP2ZEXxqZGs4PADuLW67M9dxCP5hqyk6KVgO0JCuE/lwHNGg5nCw8favscwF5U2auYa2VFiWYIkrB40jfDVDyAtWTOol7HA7CYHxsAWOg2lpUFu04Obl6FXJK+VMMG/27t97Tr8eIhvSDWecnTl9/bC4vv2EiXlDnG+sSbbzhIk0AdAYt6J45Rh/nclxZgFb1ovdb8GyxVeRdPM6XqLTNWbpo3KYgSxGSVED0M3qrZT5LqY9QIbHqoQTk8bdXvK0f0jeRP74hHTnCP5V7olW3FORy/A7nYK5Dxj9NGJDhPp/ackSXYhLMXEeB8zZpPaMGCicHETgoqm0tK3B0PiKzQm0K0sedvDKSQ8KeK82/WdAzuGG2sX619LMuck4nDxY3BJraB3Ih8qrMXzZgWCVAWdqTXzTtGHFWINw6BZxQcKF3J8JoeIzaSo09Fk7Rbr6ziw1ryhnrdg/9JxncAoHrsEyEHYof2viyq7JSWTA+i4yHJ6BXEkV/wj35k/cwBR/J7/a5/sPg2hZyPaRsMxtQE+Ty6gygTzb14x7llrQ842EqeukXGQN9r0h53l5Jkmz1PpHz1SYlEbvAT0J6JbvJn+W6J2TjnK4ZaIZgYurGpbXYnPUu3Wk/RNHLOAd80k+pN2ObJfeFuKRhZkMzcnc+wgcZ8BbjmNTADd/wsgK75JbF8kjI3LZtS7mWrgGw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(346002)(376002)(136003)(396003)(39860400002)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(82310400011)(46966006)(40470700004)(36840700001)(336012)(426003)(16526019)(82740400003)(83380400001)(478600001)(6666004)(7696005)(1076003)(26005)(40480700001)(2616005)(4326008)(316002)(8936002)(70586007)(6916009)(54906003)(8676002)(70206006)(36860700001)(356005)(47076005)(81166007)(5660300002)(40460700003)(2906002)(41300700001)(36756003)(86362001)(44832011)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2023 06:18:58.3425 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11daf124-f53b-40c0-6091-08dbf55a10fc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000ECDB.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5793 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mario Limonciello , Mario Limonciello Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" From: Mario Limonciello This impact from a BIOS with this problem is actually quite dramatic. On a laptop with a dGPU that uses resizable BAR it will cause the dGPU to stop working after runtime resume from D3cold or from s2idle. To make it more obvious it must be fixed during BIOS development upgrade the error to High. Signed-off-by: Mario Limonciello --- src/acpi/mcfg/mcfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/acpi/mcfg/mcfg.c b/src/acpi/mcfg/mcfg.c index 7e0bc397..d6d602d6 100644 --- a/src/acpi/mcfg/mcfg.c +++ b/src/acpi/mcfg/mcfg.c @@ -206,7 +206,7 @@ static int mcfg_test1(fwts_framework *fw) if ((memory_map_list != NULL) && (!fwts_memory_map_is_reserved(memory_map_list, config->base_address))) { - fwts_failed(fw, LOG_LEVEL_LOW, "MCFGMMIONotReserved", + fwts_failed(fw, LOG_LEVEL_HIGH, "MCFGMMIONotReserved", "MCFG MMIO config space at 0x%" PRIx64 " is not reserved in the memory map table", config->base_address);