From patchwork Thu Aug 3 15:50:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 1816535 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=xa9P7o3v; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RGthY4cm2z1yZl for ; Fri, 4 Aug 2023 01:54:53 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1qRaf2-0006Sb-65; Thu, 03 Aug 2023 15:54:48 +0000 Received: from mail-dm6nam11on2059.outbound.protection.outlook.com ([40.107.223.59] helo=NAM11-DM6-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1qRaey-0006SU-HF for fwts-devel@lists.ubuntu.com; Thu, 03 Aug 2023 15:54:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gvDw7dr9Dpyajcq2amjW2XU/08zrhwO9JGLE37ICaVCyt+BMaR4oG6Q5CjD+06bz7eXbdkMz0cOw9bHn93uk4BcvRsvLHXf/wxej8e8w+5mPiYF8jeST1xCDB5lOQcoaAnMi62KpHFRom5vZvJWXm6h4G0cAlk0LSr5m4CTBLifmFNwf0UpbdkX7OZKvbhRdFzNT9ul/clmYw18YJ7Z3uyhXaRdy0EgXg21qN3MjeFwu85GUfcZC5TI19VVds9+837mNvtXmegk3pu58DKqIBJNI8NQB4wdC/BG3o8z8d7Isguk9JHZnTaoxVLTbmOdZb+6n2McaBxV/VOUoGPZXLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i+UxT6VrDKLK3NOldHxoTq6I9HrZd2kuFObQzFtTu7c=; b=NwX5lajBi0zMkd+48LxJ7OF4MdkEr4qVXhnDeaToIl/WfaMU5biVCcSjmV6pb8xs2zM33KdhYj4eWqKYjCjLZndTQvRuhkychbRH8uaX8f6c/F8lVCBKLjsxBsi4ECKyxBTfGRmx8s8+Vk23W+GqG9eUFFUFjV8ZPF7+Jd3HgcbafjJ6w2MCdlfATF4fCuMZgRWpceDPJJm3ZE1HgSQK5+3MUnJvz+C/2UbAVkjiEQEWX33+CAwZD5r7DakabQG52KRmkzGJvqfxfRWu5o8jKwofb+P4iLXPVabCpM9EZVyICNcKtsAUFL7UFzmOPweuePsWVVvOb94au61Dgq6+Cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.ubuntu.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i+UxT6VrDKLK3NOldHxoTq6I9HrZd2kuFObQzFtTu7c=; b=xa9P7o3vl4COq/pgRyS7oi+cBzm7GFJ4qmHLW0OK+IzdzcxZVsAa7yxiXF0qXswOwkZNOSPmXyQ6TMv91Kpah/4jLGgzjbPPdkW9ibD76bAaalBoubR0/BVxZ6lJSD4gmTIr/h3co6AKH8MnwQfm4BdVYCooc+2ZvP8txs2ShfE= Received: from MW4PR03CA0252.namprd03.prod.outlook.com (2603:10b6:303:b4::17) by CY8PR12MB7433.namprd12.prod.outlook.com (2603:10b6:930:53::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 15:54:41 +0000 Received: from CO1PEPF000042AB.namprd03.prod.outlook.com (2603:10b6:303:b4:cafe::21) by MW4PR03CA0252.outlook.office365.com (2603:10b6:303:b4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20 via Frontend Transport; Thu, 3 Aug 2023 15:54:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000042AB.mail.protection.outlook.com (10.167.243.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.19 via Frontend Transport; Thu, 3 Aug 2023 15:54:40 +0000 Received: from AUS-LX-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 10:54:39 -0500 From: Mario Limonciello To: Subject: [PATCH] Upgrade the max value for "Processor Upgrade" to 0x50 Date: Thu, 3 Aug 2023 10:50:10 -0500 Message-ID: <20230803155010.11367-1-mario.limonciello@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AB:EE_|CY8PR12MB7433:EE_ X-MS-Office365-Filtering-Correlation-Id: aa0f3787-d714-48d6-be43-08db9439f2bd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qEGmfiQtMtXx4HCUlTLMvvLH8sovDv+gb0j6MiWzX8BGTy90B5Frmv7MLqNSxJMtikMssWxTkFaTN7/LT3UZCynkrIS22mPBt5YCt3UZouUSapzE45mlCB4BxaGWov+o0LcXFbfSRAx9/qUHhAXISzqaIhgNKBdldWkr82c5iKCxbIeEckEkRTFOtwxJuW2ONgWqx3vGOLjtVUXmRYCCB3yRPcgDxK1ZZUdrx4Qe4xPW94DdNu9Pstr+qRuDmBMQx7nLp4uQFAz8k4FrmnHpXSz6c71IM34WAy5j/KZyDHYRIz8qKf/iMtQFFprgzZ3GyrhVVIPLZRD17iWtaMlhVryWlHJ3juaoitOzGZQsDyslfAqsQDqRVHIxX/+GoF9qgKD7BdbsFCgncoftuqeTJLGfvrBfLSmdJ3VzN4UYSs3p217gRrOAoIyg55Q2iZgWIEXXXttCti95f2a/ZkzagU30Qz6TJojVs88NRcJfeU0hvaw8fx/lAJFTfklcDMFllGRp9OhFwstteLW0Hr018SDvgBe8dJsfGNMAkzn6UF8fdmy9Iof/HRHi5rPOEtZLObZlebaVna0thCWz5PsMblTxbS4C6C9wx/02vQ8FpLL87WVObrUELM7WDot5lBeAV36VmCps7PmUHOACB4d7V4jHnLURMzFJowARgKdunpHj8FWhOXTE8wYJjCfzGZLhzrgYUVh+SR+E3XvzSJcE3K73M82WdiSO+QxuXWgFbeWBZhz+7KUQZNLhAFNfXSOuVADzUDrVUkzQTqYUNiX7Qw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(39860400002)(346002)(136003)(82310400008)(451199021)(40470700004)(36840700001)(46966006)(40460700003)(16526019)(1076003)(2616005)(426003)(336012)(36860700001)(83380400001)(41300700001)(26005)(186003)(8676002)(47076005)(8936002)(2906002)(4326008)(70206006)(70586007)(5660300002)(6916009)(316002)(44832011)(6666004)(7696005)(966005)(478600001)(40480700001)(356005)(81166007)(82740400003)(36756003)(86362001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 15:54:40.8218 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aa0f3787-d714-48d6-be43-08db9439f2bd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AB.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7433 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mario Limonciello Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" SMBIOS 3.7 spec specifies new socket types that are not covered by fwts. This fixes the below error on an AMD AM5 machine: ``` dmicheck: Out of range value 0x49 (range allowed 0x01..0x48) while accessing entry 'Processor Information (Type 4)' @ 0x8856856c, field 'Processor Upgrade', offset 0x19 ``` Link: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.0.pdf p57 Signed-off-by: Mario Limonciello Acked-by: Ivan Hu --- src/dmi/dmicheck/dmicheck.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c index f7262b03..50082b24 100644 --- a/src/dmi/dmicheck/dmicheck.c +++ b/src/dmi/dmicheck/dmicheck.c @@ -1410,7 +1410,7 @@ static void dmicheck_entry(fwts_framework *fw, table, addr, "Status", 0x18); dmi_reserved_bits_check(fw, table, addr, "Status", hdr, sizeof(uint8_t), 0x18, 3, 5); dmi_reserved_bits_check(fw, table, addr, "Status", hdr, sizeof(uint8_t), 0x18, 7, 7); - dmi_min_max_uint8_check(fw, table, addr, "Processor Upgrade", hdr, 0x19, 0x1, 0x48); + dmi_min_max_uint8_check(fw, table, addr, "Processor Upgrade", hdr, 0x19, 0x1, 0x50); if (hdr->length < 0x23) break; dmi_str_check(fw, table, addr, "Serial Number", hdr, 0x20);