From patchwork Mon Jul 10 16:46:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Omar Sandoval X-Patchwork-Id: 1805942 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=osandov-com.20221208.gappssmtp.com header.i=@osandov-com.20221208.gappssmtp.com header.a=rsa-sha256 header.s=20221208 header.b=W7RF0loq; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4R09044zsRz20XS for ; Tue, 11 Jul 2023 02:47:16 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=osandov-com.20221208.gappssmtp.com header.i=@osandov-com.20221208.gappssmtp.com header.a=rsa-sha256 header.s=20221208 header.b=W7RF0loq; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4R09043RHjz3bwL for ; Tue, 11 Jul 2023 02:47:16 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=osandov-com.20221208.gappssmtp.com header.i=@osandov-com.20221208.gappssmtp.com header.a=rsa-sha256 header.s=20221208 header.b=W7RF0loq; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=osandov.com (client-ip=2607:f8b0:4864:20::1030; helo=mail-pj1-x1030.google.com; envelope-from=osandov@osandov.com; receiver=lists.ozlabs.org) Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4R08zh56kvz30N3 for ; Tue, 11 Jul 2023 02:46:56 +1000 (AEST) Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-262ef07be72so2205302a91.1 for ; Mon, 10 Jul 2023 09:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20221208.gappssmtp.com; s=20221208; t=1689007614; x=1691599614; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=a8oejiBn24nsImiUBzXJJgIV0SyvtPcohAcYwp8oH8Y=; b=W7RF0loqZPQ8hOG/Ubw68wnRb17UCsNyHtSGd39NfX83uxeE9ObR+gZXBzNV5yXMHZ 9dNW8LXv84GZhOdBM03MX62tz37PKR49XQ/1+mLZqqL1JSO4CVTT8uXcKA6DMu3kNX16 13DWyplnk7IDKrVPwrDpCHF6oRaHPfmPBBlL6tDdKL39VnffJ2olpQM5SYrN3SPchgw/ dGFCqhuBL6TVRDaWMF/lGHAE0q/9B8Q/FuLrl0ulYNQC6FipZxWzf/oYa53/9S+1Vsna 444COZeLvH8mUnKxFekiuER5k0sVCrWLUwETPl1v3nS0qFFoGoEoNmqxOCx6z04kjd+n I3fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689007614; x=1691599614; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a8oejiBn24nsImiUBzXJJgIV0SyvtPcohAcYwp8oH8Y=; b=Zal0z1RVyU1BE8wtVh2kHuuQfHOAXgY+tvaR9ptqUwmc+TUoxqsyA4aacwYP7jbi4O OwZtqHHz8/iH2BX1ps4VVKz2Xnksn0+88YbOkBqNkJKgQ6W4IAyELd1Z/wmL5H/4N/aM CKtJBkssj91m5mJgK079qrE+2TkaOilLj1RDpT9dJSexGUru3CFwhKIO9tx0acoHVJid Aq6fy9M3Bur71OMg8cTpejmcdr8DB00J7kY+GI6tpIUxKhij0o5A6cDmfSmNv9JUjovc NoE3WumdixWaPy+gUihEPDUwzRFC4asjwdkPyQjC8wepiamv+ABenXKxmBgyLwQIKyzh V91A== X-Gm-Message-State: ABy/qLb9MqWT7i0okbqGjme0gD5px+MrZ3U1YOuM8S44QjjunzliqpHC C4LBYCukiNVQ09lq2GnCSwK0fYliPKq8Wp15oLk= X-Google-Smtp-Source: APBJJlHxV2VaI+4KlKIdhJFoJdxnPIPkX+6dSFWtIsS6zSaAZ+6dMorgWu91AsapzGJzh4sSeNMaJg== X-Received: by 2002:a17:90a:2a87:b0:262:d029:69fc with SMTP id j7-20020a17090a2a8700b00262d02969fcmr10311106pjd.34.1689007614196; Mon, 10 Jul 2023 09:46:54 -0700 (PDT) Received: from telecaster.hsd1.wa.comcast.net ([2601:602:a300:3bc0::77bb]) by smtp.gmail.com with ESMTPSA id fh22-20020a17090b035600b00262eb0d141esm171208pjb.28.2023.07.10.09.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 09:46:53 -0700 (PDT) From: Omar Sandoval To: linuxppc-dev@lists.ozlabs.org, Michael Ellerman Subject: [PATCH 1/2] powerpc/crypto: fix missing skcipher dependency for aes-gcm-p10 Date: Mon, 10 Jul 2023 09:46:46 -0700 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Danny Tsen Errors-To: linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Omar Sandoval My stripped down configuration fails to build with: ERROR: modpost: "skcipher_walk_aead_encrypt" [arch/powerpc/crypto/aes-gcm-p10-crypto.ko] undefined! ERROR: modpost: "skcipher_walk_done" [arch/powerpc/crypto/aes-gcm-p10-crypto.ko] undefined! ERROR: modpost: "skcipher_walk_aead_decrypt" [arch/powerpc/crypto/aes-gcm-p10-crypto.ko] undefined! Fix it by selecting CRYPTO_SKCIPHER. Signed-off-by: Omar Sandoval --- arch/powerpc/crypto/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig index ad1872518992..81ae015861c0 100644 --- a/arch/powerpc/crypto/Kconfig +++ b/arch/powerpc/crypto/Kconfig @@ -100,6 +100,7 @@ config CRYPTO_AES_GCM_P10 select CRYPTO_LIB_AES select CRYPTO_ALGAPI select CRYPTO_AEAD + select CRYPTO_SKCIPHER default m help AEAD cipher: AES cipher algorithms (FIPS-197) From patchwork Mon Jul 10 16:46:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Omar Sandoval X-Patchwork-Id: 1805947 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=osandov-com.20221208.gappssmtp.com header.i=@osandov-com.20221208.gappssmtp.com header.a=rsa-sha256 header.s=20221208 header.b=zmH+qpmO; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4R098z4pg5z20Ph for ; Tue, 11 Jul 2023 02:54:59 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=osandov-com.20221208.gappssmtp.com header.i=@osandov-com.20221208.gappssmtp.com header.a=rsa-sha256 header.s=20221208 header.b=zmH+qpmO; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4R098z0bFxz3bqC for ; Tue, 11 Jul 2023 02:54:59 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=osandov-com.20221208.gappssmtp.com header.i=@osandov-com.20221208.gappssmtp.com header.a=rsa-sha256 header.s=20221208 header.b=zmH+qpmO; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=osandov.com (client-ip=2607:f8b0:4864:20::c29; helo=mail-oo1-xc29.google.com; envelope-from=osandov@osandov.com; receiver=lists.ozlabs.org) Received: from mail-oo1-xc29.google.com (mail-oo1-xc29.google.com [IPv6:2607:f8b0:4864:20::c29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4R098d5Fkqz30h2 for ; Tue, 11 Jul 2023 02:54:41 +1000 (AEST) Received: by mail-oo1-xc29.google.com with SMTP id 006d021491bc7-5636ab8240cso2471137eaf.3 for ; Mon, 10 Jul 2023 09:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20221208.gappssmtp.com; s=20221208; t=1689008078; x=1691600078; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=29cLZA2TFmOmSIEI5sE7QNoVfee3zL34fPIVTwe293c=; b=zmH+qpmOOYQBo44GsVhuIBbwMNuGrBeToS3nD7+fHJj+aC5Vwi3RDxNxbRXJQMH6oG ROVOYMgw2kFT9B61rPRuBfr20h2L2dKv9I+O8DQNHXbZq4hcShEaV665Uy0gBI/AyKLn 0UAHkJUCJg3xs6DHYkdF1DGBjzCX2/iXaoUuA9Ww+YWTumNUfBM46n7UYlE9X/9unHC+ 8qGC1oT8Ig/GGeajXiBPKJAu6iy7Bybzd2XbjmZUVbLOzBglNhK1MbtDfQ06bp8s5T6Z Ahh/l9+W5BcEwkhgZHxH42ajOQbaYQVu1TyDS9Ia9uZ+h4S+3PK2ry5ddLclWTWfGDpR 8Gyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689008078; x=1691600078; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=29cLZA2TFmOmSIEI5sE7QNoVfee3zL34fPIVTwe293c=; b=V1b6PbjoN++WA7OUb/QLwh11+nVxxVDr6QMelUBbju2lihThY1GVE1dnaNKznOU1CZ F5ISYVZ1+bi7YnYwJNrzpvwhq5qop6Yn+FmUlQmyc8QvLJHI1A7gaK1AeT2n8WAHqB4N TjTEzCDzOI2zmWG2sqEQLwpMHIc5HAezSVdY50EzoHsjYhU9XqWdsX1FgmO45w5szJfv 3qVJLUklwRqEpOCjXEKX4KPGeHeSjrtUs3FI0jb37/y/cH6reDiLJKxKtBx5o3n2NlyI 8waLeMbhvAzIjZBeaQlv+Xfff6kt4HD7xnqQ1fd78qAsLxYDbUfF3aTyvrGlCb6eazMw 8iDA== X-Gm-Message-State: ABy/qLbfVdrmj+E9Kvfqmf12690WkPvObMb30sU7bR5a66NwpmyuTyGW aI+LUNpGcdg7vK8aQxA2e12F1y4HFVkAlmcYXBQ= X-Google-Smtp-Source: APBJJlHdT0QanAyVX9kfyY2Vr8kXQ+knYay1oTIWHwZ6O40bX65UR3PkXIYj+GBb0ZsGhNDq3JW1oA== X-Received: by 2002:a05:6e02:604:b0:345:a3c6:87b8 with SMTP id t4-20020a056e02060400b00345a3c687b8mr11787861ils.12.1689007615137; Mon, 10 Jul 2023 09:46:55 -0700 (PDT) Received: from telecaster.hsd1.wa.comcast.net ([2601:602:a300:3bc0::77bb]) by smtp.gmail.com with ESMTPSA id fh22-20020a17090b035600b00262eb0d141esm171208pjb.28.2023.07.10.09.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 09:46:54 -0700 (PDT) From: Omar Sandoval To: linuxppc-dev@lists.ozlabs.org, Michael Ellerman Subject: [PATCH 2/2] powerpc/crypto: don't build aes-gcm-p10 by default Date: Mon, 10 Jul 2023 09:46:47 -0700 Message-ID: <40d9c7ebe82c9a9d4ace542ac433753d2f22c6a0.1689007370.git.osandov@osandov.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Danny Tsen Errors-To: linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Omar Sandoval None of the other accelerated crypto modules are built by default. Signed-off-by: Omar Sandoval --- arch/powerpc/crypto/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig index 81ae015861c0..97802c72317c 100644 --- a/arch/powerpc/crypto/Kconfig +++ b/arch/powerpc/crypto/Kconfig @@ -101,7 +101,6 @@ config CRYPTO_AES_GCM_P10 select CRYPTO_ALGAPI select CRYPTO_AEAD select CRYPTO_SKCIPHER - default m help AEAD cipher: AES cipher algorithms (FIPS-197) GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)