From patchwork Sat May 13 05:58:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 1780904 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=I+iRnGYI; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QJFLZ6N2rz20KF for ; Sat, 13 May 2023 15:58:46 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QJFLT29ZMz3fP6 for ; Sat, 13 May 2023 15:58:41 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=I+iRnGYI; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=rdunlap@infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=I+iRnGYI; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QJFL504lqz3c7Q for ; Sat, 13 May 2023 15:58:18 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=JwvBlXffIR0HVqcitR36C1vwkyoUehqX0Gm5NBSTvZk=; b=I+iRnGYIbH0GzESG0nV955gJUa 0UPKyS/3Qb6BMiTbeTDcCOdZb6t8rJdRYDvFibJjoDDonE/XO1JsdC8BigzdBGV+1XQMUYDN1ilsi 2qw908Jr765lQtgmh5i9NvGx2y5UGEEwdrKcPepoeExmP11o8zlVXSnrdSKTayT6U0WY1jh2L3C84 iq+q935gdVdCRN32X0qWWlqn7dccEOqU7m5spB1uEBTo/W5Ex55QgNHeczWkLIWDJ/dzesIGwJC+e MXjwSqBFH7N3PX1PvB7OfzjFl6o0hdZ5MHH8iQ1uwmBd+xoc3IVTY3k3bmtWWX+ipK5kjLC1CrsKl tUnFsPRQ==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pxiGc-00DlRD-1n; Sat, 13 May 2023 05:58:06 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Subject: [RFC PATCH] powerpc: udbg: export udbg_putc Date: Fri, 12 May 2023 22:58:04 -0700 Message-Id: <20230513055804.23775-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Pali_Roh=C3=A1r?= , Arnd Bergmann , Randy Dunlap , Nicholas Piggin , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" In a randconfig with CONFIG_SERIAL_CPM=m and CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error: ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined! The build can be fixed by exporting "udbg_putc" in udbg.c. OTOH, maybe something like this is more appropriate in arch/powerpc/Kconfig.debug? config PPC_EARLY_DEBUG_CPM bool "Early serial debugging for Freescale CPM-based serial ports" - depends on SERIAL_CPM + depends on SERIAL_CPM=y Signed-off-by: Randy Dunlap Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: linuxppc-dev@lists.ozlabs.org Cc: Arnd Bergmann Cc: "Pali Rohár" --- arch/powerpc/kernel/udbg.c | 1 + 1 file changed, 1 insertion(+) diff -- a/arch/powerpc/kernel/udbg.c b/arch/powerpc/kernel/udbg.c --- a/arch/powerpc/kernel/udbg.c +++ b/arch/powerpc/kernel/udbg.c @@ -14,6 +14,7 @@ #include void (*udbg_putc)(char c); +EXPORT_SYMBOL(udbg_putc); void (*udbg_flush)(void); int (*udbg_getc)(void); int (*udbg_getc_poll)(void);