From patchwork Wed Mar 22 03:04:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liang He X-Patchwork-Id: 1759695 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=126.com header.i=@126.com header.a=rsa-sha256 header.s=s110527 header.b=SHIscMUX; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PhDdr1wQhz247F for ; Wed, 22 Mar 2023 14:35:59 +1100 (AEDT) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PhDdn4Kfjz3ccl for ; Wed, 22 Mar 2023 14:35:57 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=126.com header.i=@126.com header.a=rsa-sha256 header.s=s110527 header.b=SHIscMUX; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=126.com (client-ip=220.181.12.29; helo=m126.mail.126.com; envelope-from=windhl@126.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=126.com header.i=@126.com header.a=rsa-sha256 header.s=s110527 header.b=SHIscMUX; dkim-atps=neutral X-Greylist: delayed 1825 seconds by postgrey-1.36 at boromir; Wed, 22 Mar 2023 14:35:35 AEDT Received: from m126.mail.126.com (m126.mail.126.com [220.181.12.29]) by lists.ozlabs.org (Postfix) with ESMTP id 4PhDdM12wMz3c2j for ; Wed, 22 Mar 2023 14:35:31 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=F+3Kf CSK6KUGSAgjIPLcuQEtKa3TJE/IcMpjTXLV1rU=; b=SHIscMUXNjSePtkd6gptY M9yhL8S2lSwT75WBkMkmAb6E58jxTPZxi1CH/gQdP5F6G4Dzrxffo6FM5dGRuzyT PTUOW0M8hY3H/VJLs9Z0uFqnhnMl14d8l2cEiHVCawHDvfU5BWFSx+SV4VoChPBv ZYmY4cqD3UgprvM3Yb7Z2M= Received: from localhost.localdomain (unknown [124.16.139.61]) by zwqz-smtp-mta-g3-1 (Coremail) with SMTP id _____wBnOFI3cBpkuYWWAQ--.2256S2; Wed, 22 Mar 2023 11:04:24 +0800 (CST) From: Liang He To: mpe@ellerman.id.au, npiggin@gmail.com, andriy.shevchenko@linux.intel.com, linuxppc-dev@lists.ozlabs.org, windhl@126.com Subject: [PATCH] powerpc/mpc5xxx: Add missing fwnode_handle_put() Date: Wed, 22 Mar 2023 11:04:23 +0800 Message-Id: <20230322030423.1855440-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wBnOFI3cBpkuYWWAQ--.2256S2 X-Coremail-Antispam: 1Uf129KBjvdXoWruw18JF15trW8XrW7CF4fAFb_yoWDCFX_Ka s7uFyxArs8Jr1rCFs3AryfJ3y7J3y5GryxCr1Ig34xJw1Yk3yDZrWIvFyUWryUuayayay5 G3yUtwsxAa4S9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sRKD737UUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbiuAA6F2JVmg8uBAAAsd X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" In mpc5xxx_fwnode_get_bus_frequency(), we should add fwnode_handle_put() when break out of the iteration fwnode_for_each_parent_node() as it will automatically increase and decrease the refcounter. Fixes: de06fba62af6 ("powerpc/mpc5xxx: Switch mpc5xxx_get_bus_frequency() to use fwnode") Signed-off-by: Liang He --- arch/powerpc/sysdev/mpc5xxx_clocks.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/mpc5xxx_clocks.c b/arch/powerpc/sysdev/mpc5xxx_clocks.c index c5bf7e1b3780..58cee28e2399 100644 --- a/arch/powerpc/sysdev/mpc5xxx_clocks.c +++ b/arch/powerpc/sysdev/mpc5xxx_clocks.c @@ -25,8 +25,10 @@ unsigned long mpc5xxx_fwnode_get_bus_frequency(struct fwnode_handle *fwnode) fwnode_for_each_parent_node(fwnode, parent) { ret = fwnode_property_read_u32(parent, "bus-frequency", &bus_freq); - if (!ret) + if (!ret) { + fwnode_handle_put(parent); return bus_freq; + } } return 0;