From patchwork Wed Mar 14 13:37:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madalin Bucur X-Patchwork-Id: 885799 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 401Y4q6rlMz9sSV for ; Thu, 15 Mar 2018 00:50:03 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="OqgNfXFS"; dkim-atps=neutral Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 401Y4q4Wl1zDqBf for ; Thu, 15 Mar 2018 00:50:03 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="OqgNfXFS"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nxp.com (client-ip=40.107.1.59; helo=eur02-he1-obe.outbound.protection.outlook.com; envelope-from=madalin.bucur@nxp.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="OqgNfXFS"; dkim-atps=neutral Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10059.outbound.protection.outlook.com [40.107.1.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 401XqZ20FWzDr71 for ; Thu, 15 Mar 2018 00:38:33 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=igXcEX9XylooDX3HdFiqbfvqGgLbACbjpgrnI6HKDy4=; b=OqgNfXFSn4QxptZ/lxHCkP44E4nk1+TlYJw8GN9GQ+gqiT/M7KiWe+bZ7Ukt/y2sWKPqBLMY5O05ONBUPvQGrXedIr8AL/oFPL0whtpJCOJTrYZlyBevhGQS8Z4HDfCoZP2bcpTA1qHnDDYbPfMiIgvFz2bySbPElOWK1JgStWA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=madalin.bucur@nxp.com; Received: from rhuath.am.freescale.net (192.88.168.49) by AM5PR04MB3267.eurprd04.prod.outlook.com (2603:10a6:206:d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.567.14; Wed, 14 Mar 2018 13:38:25 +0000 From: Madalin Bucur To: davem@davemloft.net Subject: [PATCH 1/5] soc/fsl/qbman: fix issue in qman_delete_cgr_safe() Date: Wed, 14 Mar 2018 08:37:28 -0500 Message-Id: <20180314133732.24068-2-madalin.bucur@nxp.com> X-Mailer: git-send-email 2.8.3 In-Reply-To: <20180314133732.24068-1-madalin.bucur@nxp.com> References: <20180314133732.24068-1-madalin.bucur@nxp.com> MIME-Version: 1.0 X-Originating-IP: [192.88.168.49] X-ClientProxiedBy: SN4PR0601CA0024.namprd06.prod.outlook.com (2603:10b6:803:2f::34) To AM5PR04MB3267.eurprd04.prod.outlook.com (2603:10a6:206:d::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f0f75ed4-01f4-4864-5ed6-08d589b0ddaf X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR04MB3267; X-Microsoft-Exchange-Diagnostics: 1; AM5PR04MB3267; 3:MgxEEousZxnatKHEwwfoshd0YeyFtFKoRIUFROaGLdHcWIxPCLP0HoPZ9jHyA9LITReBk/pQDEMcP/zJcwQk0x9Lqpma7pggsBSQyU03qe+FtvSjFcGOJhs05KS+d20yzocdbpfUKxxsnkyB77aEWBRQlzekAs+LQMH+yOx5SF2rW/vN4iLfXZuMTZ960jy7/dqmMLpjNcpGOD+HoDq3CmkwtUHmCZfSQr7w5TJBrtVNI6/yaXqoVj7JpGG+3vAw; 25:crhQUbdRv4HvWgE09MgULEPp3VQtVhtxsj7vfhS2jY6RoEJqyZGhBFW/jDxwljs7rywjwpt0ekgcSUXU2d6QPUtCnrFMdOhg5TRcPOyFyMQBcAfEuzyTTFLpswKhI7+rSnm66BKlOmckbNAnGpBOh4NZzMXVuQD0As0ZEP9klPUG2stRR7y7qulGDWrFKxvwzJdfAMms2+KMjEaANB9sjaCd+3Zx3dz951ByTr/CMwfhTlqe4vntXyV1xBmYEqL629V/MYJ1mm4CA/xT80vPbixYRzLSnYxBoqMhxSRrchmPBj+xVx34wF3p0XChEXZ64uZ+CDBoiyH4GGznaMv2PQ==; 31:yTGDSyHLikBnuFqSaId1DwYbiDWGw1Dvwym4GzbzOPsgiq5puLicPSVGfG/GnVvVXyHWUfyspIEWP6PbcOjEyzr0m4Zts6mdP3Cgb5CAWcb8r9GIepC3qi+IpMddcLFUdfoJsXmWLmLQwU/+frvXmZ0xJ/ZRGzrf+il0owiuQf8LeEmC5ZxP3IdPsWKNVFBXnVLdXxFM2tYcfGAbEBIwKYwXRJzW+cdSDtmXj08so9Y= X-MS-TrafficTypeDiagnostic: AM5PR04MB3267: X-Microsoft-Exchange-Diagnostics: 1; AM5PR04MB3267; 20:Bvbkt4OX1bPftrP57yaZWYWXw2JfojV/1m7KztxKzzmCFhbODwvC13aBHSQmj8uHCAHbSw0P+gzVOY+f0w4qk2bMRkEaeH7S+U9LX6vDgKiBFA+Ebo6gu2v7PGmSuP0eQW1tuuBXOwWi3hdYd6sCMGPgGy+rQGRs/ZCGP1zFZ7E1JsYhE4ngyg2yknEVD8kYq8+N0+O3mLq1xneLbeMjMwjPMBp0LDh4cMWHfqb1m+m8uARZ2LiFvINpSySDu63NfnhNe0dsVrcA3CVVkbqLdD54cmF3r7W6S/dD8Fe8BkxktMRp1Mtio8azlz0vA3lFO8ieUXX8mFTHpQV96IXPvhdUf4CXA20QwDr6v4f54tQFx0AwluJE0ZaGaNRoC6bQubSyhkduXQdH3e57tCREqXqihRThfdg4cn3LpvCceueO13EEWccBU0mg17MCK+h4UhhZK/RpwLbxLqBhNXwOh8pXmRMmr2pxhcmQ3JE/srEr47R+VQtuVrV8ZgPLtoF1; 4:Ppb56+TgqpVbuacPTIDgAXQLoXgG0XliOSjrx4B4Urr4Y2ytF7Y3xzl/XH7H5YuIA/pAGi9G1QyvZMJNikTXD8bzbrHA1OmpoSPlC0x+e/g+iyCPrcVHFWmgPI0H+UXB+VNEhCRYaRh664dkA3BkTjoR+IQ8hWi12BeX6YonwwfwObnHtG+yq32EXO1XljUv488Kq+o9txd214exJIuQp4cJunrycZWgz8jYwdCn4dsK5SboHsOj/Kq3/AfwYVgt6BZO/TJy16M/rnhtI0K3A+QRiS12gKNIvtxKBvbN7PDxd0/BNG9GH9lhbowN1Ht6 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501244)(52105095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:AM5PR04MB3267; BCL:0; PCL:0; RULEID:; SRVR:AM5PR04MB3267; X-Forefront-PRVS: 0611A21987 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(346002)(376002)(366004)(396003)(199004)(189003)(1076002)(68736007)(7736002)(6916009)(47776003)(4326008)(8676002)(2950100002)(316002)(50466002)(81156014)(25786009)(81166006)(66066001)(50226002)(305945005)(3846002)(8936002)(53936002)(6116002)(36756003)(48376002)(2906002)(16526019)(26005)(3450700001)(2361001)(86362001)(186003)(59450400001)(478600001)(51416003)(76176011)(106356001)(52116002)(16586007)(43066004)(6512007)(2351001)(6486002)(97736004)(5660300001)(54906003)(386003)(105586002)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR04MB3267; H:rhuath.am.freescale.net; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR04MB3267; 23:dtLw8xp4E18tN2ykfaR85BrCwSxWtWPgALl9RE1U1?= zzS7V/XeOcQaKDufwdVMZD3M/40Xlz79FMSf2p9xDFIWBT/KMgiSCqzygHK9WqLJx64zsC7FbuJYd1SfIg5xEm8gchqKAhhMUYLDnWC0jNsILmvUXABcXzSMXV5TG/yxEwp3ITIN8Ha6mKCIusye7A2QCKeCkKrkaFHzhuhhWbvVsc+HoHF9qV3TifH/OPF5cr8VNJVQ6CEWE0uGM1SLsh9mglMOlylUUQcnXnOtgn8MNrU7WSrFXPfrgh/emhQEeKfxtDnZDj+C3djteJPlQGQcZ7Z0WLfa79ujZ3XLrr2EDPZ6khuEV9DKuNyaT221AvNhCtzOm3Ct56nBnQRj+HmnSG+i0H0I5n31y3un6WjIZbR1tBEb1ErvSAFqyM4kEhJnVP+OR90lKqgGCm/8PlTyJM5QfIdCXbXLOw6XIjIWbXbGV9Gc69F7TD07Hdv8BzxSn4UFlJ8RJJ7YGVsR7NwZLmC6wmOTL+bU2kR9vAl9CSW9VSeb4MSLHYlTXp8nngP9sdDMzrhyLRs9187wDuRPpWjruIfONiVWuu/gsrr5b1xY4APvMYmds0OIL/U7SuCoEXEB4bYeRtP+lHOC5zFy8azA+65jTWLf4OAki1+rts9hWw3E5Y7Ro6fRnHFF9fp7Rhzt2k9EdF3ocapl932USjJsK3lXCiyILwwvlQ00yKBdxXv9ZA3jRNhHaR6ZLbB7vOHpmgmeJiOSjbVM4DNERKSBMjCA3TqZGkoXeIFSJ67FfwikWM0tQznm2M1zIflEvULGkpsOya94iIAzWlSxgguew/SPNDBTjfwSJUskMp48NSXUOiUwFKuIGoPdkAbHMH1qRP2UmLuhRFfYux7EaD/BytrME4ohIK7BevhXWBHFXDD13rPe1dqGG6ECYkSDlAOfz5SqzJVhzJ0qywmVx3DY6GzvNDB45xNSeSofzrlBgmwqLHyhOYw8SWHj3uqApowKAF53tLhj2Z4KTDsIjerOqelHr7A9wezSn8STfN47PVlxSJdx2TnrMC7px+Dy3e5fVnx6iD7+oujv1Tx3boHg+EMui85QcyU202s10GTwP0XWReICIa5Ngw45UIPWLreRRQ30u3zHyQqoJ+LUvepSSC07S6OinQ4lCSwdO9Sn8TJyoHLpCWwTmI0VRvmwVxWO3p3SQGLt2UFxsU3rAuZhPeFCidIMmQtfqBQ5g== X-Microsoft-Antispam-Message-Info: P/0drxJDNaC9IXJVwqiOC6IRyGUfDs9cAT7vtAaQtfqXStwC7vMcWOjSmO+sbEH5rpCYffzisLIKQvaWj/Yib5kujfcnAyXLaOTboBjj5GkFT1T8aS2ADuRVLJwNoWt/6ods5aYNKW6tXy+YFMh1Y2feIUEL/FjwWnpveW4NPnTv4VC7Y/MqRkqKXkbikEez X-Microsoft-Exchange-Diagnostics: 1; AM5PR04MB3267; 6:zJLS7psq8S3xxJ35Sg5SuACwz8479z58M4g+UtJsKkFEQwBAHvm1wom7WFVBN577lvYhf9qcw8CoROrKv30qgvxytmMnJFxt+9s4qBAbkIB2Sn9pjf9sXZV0ODuyTGvHB7o6PHVcGuuHSC/WsVRiIvkoyq2Gq3LDzzrBkWLJ1WRwMAdMKa2PkwOLtBipj1OUsaDLkhlVpFbH6Q309RBV/+42ijg7eOZRJoMUUOnT0avKH7W+EVPywMsFILoheMQwSZ4uEsCdOa232HeN0ew4wD5r6ps76Md8HvqSWkDZDmy6nhW2WTpDxxujVmto13yb2EOk2jqfzBSnyK2jMaDtDWy/TF15LqPUUewvF7uW10g=; 5:oH2yXUOWtzQaLTnG4yuUJILkFmVwcauC9frYLnLffg8LVQjjrfm3fCeJlKS2ix/foH5wJYKTyH3YqNmku+UjrB4HlWcCeXFzhRy+e9+Or6LRHOv5Rpd9lEpPmg9biGZk2vsSRMDleOIg4HL00DF7q+KbSHDM23lzptwJaYF2OFw=; 24:9iSjYu88qjYuNAoLNXQLiSH60Yq5ToJMpXE/yuQfuUIQIPtoNd24UfWSBoU+bgOZwN/KTN7IJ+Z7CSBt5hC1Kby1aXpymyLLkC/zHGxPXV4=; 7:kPyhip10yoGqflYNruTzxx7JptIBzFaGTJruFE6rtXCVlH8upkL/VMYutX6yljjtUoOlTdES/zQ6+BJDHF1Szj0iYBpLmusQBl7qguoYL/OfIp5VRObn3M5xnkm9kCfWG0BrHpbhHukEmJoQR9K5YN2yG5/RRkmK83HfEcfSzqsd2w067WOgoQ8o1wayOuKpsVwXeJcmDOKaNRu91bD3BsONxKizzNqOUdvwzeltbwh3tPde/hkRItcNMHI2/OY2 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2018 13:38:25.1800 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f0f75ed4-01f4-4864-5ed6-08d589b0ddaf X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3267 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: madalin.bucur@nxp.com Cc: Madalin Bucur , netdev@vger.kernel.org, Roy Pledge , linux-kernel@vger.kernel.org, leoyang.li@nxp.com, camelia.groza@nxp.com, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" The wait_for_completion() call in qman_delete_cgr_safe() was triggering a scheduling while atomic bug, replacing the kthread with a smp_call_function_single() call to fix it. Signed-off-by: Madalin Bucur Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman.c | 28 +++++----------------------- 1 file changed, 5 insertions(+), 23 deletions(-) diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c index e4f5bb0..ba3cfa8 100644 --- a/drivers/soc/fsl/qbman/qman.c +++ b/drivers/soc/fsl/qbman/qman.c @@ -2443,39 +2443,21 @@ struct cgr_comp { struct completion completion; }; -static int qman_delete_cgr_thread(void *p) +static void qman_delete_cgr_smp_call(void *p) { - struct cgr_comp *cgr_comp = (struct cgr_comp *)p; - int ret; - - ret = qman_delete_cgr(cgr_comp->cgr); - complete(&cgr_comp->completion); - - return ret; + qman_delete_cgr((struct qman_cgr *)p); } void qman_delete_cgr_safe(struct qman_cgr *cgr) { - struct task_struct *thread; - struct cgr_comp cgr_comp; - preempt_disable(); if (qman_cgr_cpus[cgr->cgrid] != smp_processor_id()) { - init_completion(&cgr_comp.completion); - cgr_comp.cgr = cgr; - thread = kthread_create(qman_delete_cgr_thread, &cgr_comp, - "cgr_del"); - - if (IS_ERR(thread)) - goto out; - - kthread_bind(thread, qman_cgr_cpus[cgr->cgrid]); - wake_up_process(thread); - wait_for_completion(&cgr_comp.completion); + smp_call_function_single(qman_cgr_cpus[cgr->cgrid], + qman_delete_cgr_smp_call, cgr, true); preempt_enable(); return; } -out: + qman_delete_cgr(cgr); preempt_enable(); } From patchwork Wed Mar 14 13:37:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madalin Bucur X-Patchwork-Id: 885801 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 401YDT4fbrz9sTP for ; Thu, 15 Mar 2018 00:56:41 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="K4c0bC8N"; dkim-atps=neutral Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 401YDT2M6DzDqGV for ; Thu, 15 Mar 2018 00:56:41 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="K4c0bC8N"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nxp.com (client-ip=40.107.1.59; helo=eur02-he1-obe.outbound.protection.outlook.com; envelope-from=madalin.bucur@nxp.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="K4c0bC8N"; dkim-atps=neutral Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10059.outbound.protection.outlook.com [40.107.1.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 401Xqc0ZPpzDqhw for ; Thu, 15 Mar 2018 00:38:35 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=nwvF1S3GxqMJ4l6VpRMPvAyAM6G1KRqxy9u3PfDMyR0=; b=K4c0bC8N9xt1lvOdbAlIxA1MbMZNMHJJtHCFLM63d/DKyGzie+wsPYiEPPFsAwqkpLvqMiwg3RuHrr20CGGc5hgFFIkqH5M7R8u1KoVN/Qjpk4ymBXk0dQf/7OqZ5YhVG1czg3kEjjthpzyinkm1kNHbf2B76+J0bCPoDwdSdpU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=madalin.bucur@nxp.com; Received: from rhuath.am.freescale.net (192.88.168.49) by AM5PR04MB3267.eurprd04.prod.outlook.com (2603:10a6:206:d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.567.14; Wed, 14 Mar 2018 13:38:27 +0000 From: Madalin Bucur To: davem@davemloft.net Subject: [PATCH 2/5] dpaa_eth: fix error in dpaa_remove() Date: Wed, 14 Mar 2018 08:37:29 -0500 Message-Id: <20180314133732.24068-3-madalin.bucur@nxp.com> X-Mailer: git-send-email 2.8.3 In-Reply-To: <20180314133732.24068-1-madalin.bucur@nxp.com> References: <20180314133732.24068-1-madalin.bucur@nxp.com> MIME-Version: 1.0 X-Originating-IP: [192.88.168.49] X-ClientProxiedBy: SN4PR0601CA0024.namprd06.prod.outlook.com (2603:10b6:803:2f::34) To AM5PR04MB3267.eurprd04.prod.outlook.com (2603:10a6:206:d::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b216b16e-f422-44f0-a185-08d589b0ded4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR04MB3267; X-Microsoft-Exchange-Diagnostics: 1; AM5PR04MB3267; 3:YqOUaJ27KMpcVfu1xjOzhwMpAtuGFfc3Qs8VyMlJBjsycfnnmLw/CdFe4dNz2Sqrp5QPKefBNuKcVd5/H9KbB2cHZvfmV0qQr1zeVh1AotkgsJ04Wzhm3lsQ98yRoajga0pXspLUuIh1qPufUjuysg/jufGB+4EInVoKimFxsplniEuzPRaYv8Y6m01hSwPv0uj/CUeM1gWyAOR7Sgqr6DeXdC4fIKlNEDh3vNhhXGXijAVfoSeqV2eNb2/xxzTk; 25:722utIRu44hLDxF/VgoQ/HVRI0jo9ZhleesfHZJTI5uNJd2ja+/+wODOjdL7iYLZJxyumKL2Ivt+iKw0729PXC63/eHM194BgHX91MFwT21MOQpwEiS1npYDfJOHq/ml/EzxvO+NnqNVvMMPdwEnJpoNwIwEJQhlo/FuUaUyJkbDFol3ZltYPCHm7tUb7ASzbV6xsAo1QPRaYZ4EHwpL2MHy61sh9NyuXJ/2QcDabZTPHNfNMK6F2V6LoRRDLTHl5aEhWgwbhVm+GpgbbvuVvRJCM24WPmPAvwF2IuwvoWLsWWWoi0scJwSt2djN8Bc1+qIGWCij0iicxCD5NRVAfQ==; 31:J7XNJ6r+PhikzkNoVbOdmihH28TlAIDhRbTh02qXb7jj2iLP2l5Q1DqI8HD0svadMclvikg2Qg1qiV9xCDiKHqnWZRiZxGB2cozoyRFUfULSxZZT317jwKgiDj6P8uxkOjd4L1HZxhmyb4uTizZqjTGj+9B4Zdnds0TzIDhOW5CQl3CTc6LVfv47rkaa7+aZYtfTYhYYqO+h265nh2YeVu6aHmVLTPEQsY8v5saxUm4= X-MS-TrafficTypeDiagnostic: AM5PR04MB3267: X-Microsoft-Exchange-Diagnostics: 1; AM5PR04MB3267; 20:7fiSMEpzHn9nxNxrOMyotHEePrydqSqZCdH6cEBiwK7Tl610lS8DYHKU7U1jp7A5n/cdBzVmDe4Zd73Up2itqnxTH0TmeXPaWIyQIDP+fI/+gaG0HT32mDn0ow1vSaZR/ZqmmsZ/f/oYv94AZiJSJBsqnZZVse2Bk7wcZHXaOKUd79huydSA6ikPOY/1fxwg31EUf/HhguqBReiTQxRcdjqxd91oshC+yT7pOoXWQZlAJui78WwSuv7LeuCyf/ZXkuDrq5QwOEdMlOb4PEu13X/tE2gITZ14MD3KfhILp2Y4nwuAixbtXuqcJlfb1X4Y40aly6d4mu8Gv7mce/y3j2tZ+ACGia782UyrDLQ334KFq/QqaG8nFguWDdyqe8p+i8I4e2ckyvyDQFatMD5L4GIWIEqBeNWuSVf3TP2YSgOYSJnuVPaHpWlFhj1rN3HNSfmSx+beYp5XVMnfPZnVv5KnborRX4+C5rQoUwISu1r93nmMpDYF6O6GgZRy85hn; 4:n3mpjQ8oAHWlsEmIMOuHaPZfIjlrkl/Y+4fJokL02YQcPsiDdU+NirMHYuhwEZScvrnhUZIbrNNGrVuVLgCIJ9fSu/wlDLyl8l/pi3Zmt2Sp2fzoI386zKkHvH0IlLpo5MKNbSgAzjHvDJJlhPoI2LRME12/yNRb89TwjiHCO5SPDUexvG+egyTPrA4+Ydgga+c7tXix/T/LLBnDZWiwocuTvpWHIIpuMA9zp8gah3fmYmZMqu0bRvLCeGxIL8PiiByMm/Auvm64zbYFyMfIpmRoG9p1zlXrldE5EIb4ZFN3J43+Y7Fqlnqaqg8Qaxx7 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501244)(52105095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:AM5PR04MB3267; BCL:0; PCL:0; RULEID:; SRVR:AM5PR04MB3267; X-Forefront-PRVS: 0611A21987 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(346002)(376002)(366004)(396003)(199004)(189003)(1076002)(68736007)(7736002)(6916009)(47776003)(4326008)(8676002)(2950100002)(316002)(50466002)(81156014)(25786009)(81166006)(66066001)(50226002)(305945005)(3846002)(8936002)(53936002)(6116002)(36756003)(48376002)(575784001)(2906002)(16526019)(26005)(3450700001)(2361001)(86362001)(186003)(59450400001)(478600001)(51416003)(76176011)(106356001)(52116002)(16586007)(43066004)(6512007)(2351001)(6486002)(97736004)(5660300001)(386003)(105586002)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR04MB3267; H:rhuath.am.freescale.net; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR04MB3267; 23:iRdsc05GfH8ktpU6eNdhAeFnW/W3w0IGCo6Wno+C2?= zf1ay3nQiiv5JeLMYYFpBayQvMh7W2Tjw4V80HovvSUWZKbMndJIw7uW/K4hntNcxRiwuG1/xreWUz6sGJQhpx6LXj/A9YVZris48K//JhOc1GWxFbyyW+4N1pND4npmsjk5T29hkLs9JHBcw7oav92/X8pePubwFQUi8sF3CKjbJ1gFN/ZvbzpCM3WW8iIuWJk4ijeSfZd7dtTDhtpTBMvmQ4+wF+oMAqoE1zWbdzfRpFyUv0nSQqCPEfetHMbBdefN4C3XAojpDIixCRYvpFBTJvUw9mDtgAdoyFuyM+FL6c4qLruFCF25/Hr7Xg3QZdYAAdxRdUeAOu2UZ0w1ZhwSlcIIB8Zr0JWSiWcI8X7bqDZeH+lMeByhb4sUEQY+26cPJyFO4fRMmCa3xI6HgDSjBHyls26frtYyDpYgkJUd/jwK96jC/CwT422OyAr84b6eK2aCgrUHWTbT51WGISvkWrnADvZxlY1l3+gQoFT0Ngggs44TrMnysuHHzeN9df6KmZucRJ6gxVyT6hxLyeBeE3OOo/W/rDd6W5rfhFmjrSVE6e2oaHLeQdVfqFW6RW8ALHISFsSqOD/TPKvspCUV1wUkvOlsY2OblHhnKxIg0IbORSk0jeCHqm2cDeKpZB7v4ZKHS5f5YKwPTgs0qQhGbDJxP8B72+J05oHjvmsGgct6sSLTSf2fUlUtqjYvEb/ltDrMQOzdzjvZJT72wPUnRHySZVrV/zh/6B3DjgS6oFNSVMI2ti4cgrd08E91O6piwEOxTA9k9chPeGcpBhIm9Hhd6Fce+7e6KCldSYCSd+80hBtLU1tbKDe2MOdLvGJJYlxWrFptFZINQBcpf/s/uPKwxpQzEJQ7XkM0HkLb5ZnBC3hoDaf5OUb7+8h8SWZwDWQ1uqGRHua5N5tLhU2IKeQRKa/ocy5Yw0EGAZYfWHhtZE5kl5a4s2jN+99IDSf9peGlzOrfApz2nsD6p0kTjXZSaG3tvlOFbQHCs15gu6hVwrytW7qObT5FPcHDMbxrm7Hs3JDayKY8lxl79k6Tat8Kskg+YUiz80O+dQuWtVongQOHamyhmjGnH0HmdqIelCqL1OMWxtFhg1FdhC/Tuwepz2NiMn6s9p1RruPmszQ8ZTju38Mg27lXJ88e2eE2NiFC1iTdZ7kMn6LAGdYADzyM2/rJM6Amznyb5DLIg== X-Microsoft-Antispam-Message-Info: tw2v/TeWxvo2yT+kge43gSVLHOS3yo0d0hUZ8LTT9dn2OGRSubzQV9FOkeiIdz5lz5whYrnaQpT7Oh0xTr6tSZww1JKess2Bx1GzE4rXX9DNV4mw35XC6S1jb8AaZ0+UZT/p8oyL+dxF0yq7DbP4by4Uyc+2iqjXFlHT2eyH8r4TZgEt+a7DwQHARDETD5jU X-Microsoft-Exchange-Diagnostics: 1; AM5PR04MB3267; 6:OvzM4+0VZLeA9j2w5nFSBtUxUaoQ68s3rFaDxQqdUGBmp7XRy5y82muU2AIq++AMzd6kvwbvnjDvwAUZY1Qg2Jo0ehU4Q/jC4Ve7yCP5BxOTiG02Lv6KHsOlmJHKwfKemFqQQzIe8ttXoga+S2D5ZqW+6OT47mLMrmpoVl0ZcIrj+yC54TdgIVLWvw4YXFRhC0l0h5OO65yM05+T/pYBKG6zRyoKwFq2xUdIwD0bn2MHMiS94kmAkfDyNPlytGGnnDSfnydaEwq/YgK/prTThBxE6Fr1dYo/m5uBEzJ7OdRXriSjI2OrfbSwUdvWoqjwvzQXnNDNS1pqS28dZcgIl9YkYQLQUXuGSnpboIjJExQ=; 5:oyzhdWMbX/bPoeBGcr3prMrAMpwnNsFDLFXiWwryz8m+1vGAvadWMEbJIMWo44vbskdyBggjIlj7Tte8cMp+MuYlvo2SRYCVSLu637XBiivTxh325tbs0hhXyqXGlUJdWhbrQaQ420BuCBBRhvWB5i2i3TIlfqBuhu/mBH6dYz4=; 24:8x0+N1L46KrPE3tngOWFN57d3g4opZRLHgramX66oiI+0tTyAu8SNZLUgjFjC3sbUnpBD2HGgmBkEFjy6Ya5SgZOzIf3uNA/JAx2WIZDQxw=; 7:sXza2gqQDWXiNym0jLOfmp66EvRubZxV77+zJHJy79wv7MAom7Ywh54PZ8rV18dDtHwm2PL+zgg7l8H8vd4WlY1wn2WDkjOmvHz4NQOybjXdNRDTXrHiYuUvrD5DwTw571TCu1ij3EXiQE0Wtf7WH5DkDQMsutD5kWa1lPcXLHcawYAEpme6gamJ8KAoRcka7rA+24e0rvoGrHM+yomUu3DDt0SjZ3CSRwb2iMESboRCoRbOxq4G5n3KrWSlhflH SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2018 13:38:27.2425 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b216b16e-f422-44f0-a185-08d589b0ded4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3267 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: madalin.bucur@nxp.com Cc: Madalin Bucur , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, camelia.groza@nxp.com, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" The recent changes that make the driver probing compatible with DSA were not propagated in the dpa_remove() function, breaking the module unload function. Using the proper device to address the issue. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 159dc2d..128e0a4 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -2871,7 +2871,7 @@ static int dpaa_remove(struct platform_device *pdev) struct device *dev; int err; - dev = &pdev->dev; + dev = pdev->dev.parent; net_dev = dev_get_drvdata(dev); priv = netdev_priv(net_dev); From patchwork Wed Mar 14 13:37:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madalin Bucur X-Patchwork-Id: 885803 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 401YNP4qbFz9sTw for ; Thu, 15 Mar 2018 01:03:33 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="CFpjf92X"; dkim-atps=neutral Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 401YNP2cjGzDqGZ for ; Thu, 15 Mar 2018 01:03:33 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="CFpjf92X"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nxp.com (client-ip=40.107.1.59; helo=eur02-he1-obe.outbound.protection.outlook.com; envelope-from=madalin.bucur@nxp.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="CFpjf92X"; dkim-atps=neutral Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10059.outbound.protection.outlook.com [40.107.1.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 401Xqd5rGTzDqhw for ; Thu, 15 Mar 2018 00:38:37 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=nq7dheyKEKiTHPCvduJHZ82CfxPPIjqxDgphhbZX7ak=; b=CFpjf92XmWacdiKiTywtibpHVxBvVdJ/U7vQnXk2LOqjj6p7z3S4VzNOKwM6J6dvVtsihS+bjuvGSEnEG3az5hVTiKD6b4MYuUa27vz68jY3rBuZ8z6NKEgo20SDWiQInAD51kma7Bkq9gx0BTPNhi7LE2Y9ojqt6dMsmYfnC2s= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=madalin.bucur@nxp.com; Received: from rhuath.am.freescale.net (192.88.168.49) by AM5PR04MB3267.eurprd04.prod.outlook.com (2603:10a6:206:d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.567.14; Wed, 14 Mar 2018 13:38:29 +0000 From: Madalin Bucur To: davem@davemloft.net Subject: [PATCH 3/5] dpaa_eth: remove duplicate initialization Date: Wed, 14 Mar 2018 08:37:30 -0500 Message-Id: <20180314133732.24068-4-madalin.bucur@nxp.com> X-Mailer: git-send-email 2.8.3 In-Reply-To: <20180314133732.24068-1-madalin.bucur@nxp.com> References: <20180314133732.24068-1-madalin.bucur@nxp.com> MIME-Version: 1.0 X-Originating-IP: [192.88.168.49] X-ClientProxiedBy: SN4PR0601CA0024.namprd06.prod.outlook.com (2603:10b6:803:2f::34) To AM5PR04MB3267.eurprd04.prod.outlook.com (2603:10a6:206:d::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 13b26256-a1a9-4779-1f72-08d589b0dff5 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR04MB3267; X-Microsoft-Exchange-Diagnostics: 1; AM5PR04MB3267; 3:gGDhM9zK4DQII/rj8VYv2v9NFrJn881xcw+vuXxKY+eXc43HWoy6fIyQkgK864D5+dblDBTODoAmqon1Kcvbf28tAnV7dvg1AtaMAlK6MFe/eUMZpCquMQcBI9wr6vJyrNM46iX1RYJ+r2a6A6dkzmhb/7p3wBKiynNLnE8SfAytedgP7nGyyuItq0mNMHORzvwP7qWJRMIK+Srnau2pF3qx1JQbXGm6oM6j6zYpnjBj8KMPVpNb8VfazG7z3hid; 25:zse8Yn/dq3bF/EB3sOosUqxJCLctDTzso+k9wZMRX6WEK2FgKdiWYuQfRZWkGmpLqu/o4N3THqt8NdRmlbfA9WF1T+PwjJyTWmtv/x2nyUjfl2ncKtX2cBFS2Df9dHvRbksafmgpEf9Mm4Np/mNqYaJti9ITsQsdi2RZrt2J3EjG0y5oV3KYaLfZUcbrc9pXNmgddFmdKihEkV7qMkduHJiNk4rxuOjESA7gS+Cj9n/VWXDPyzYlWCsVI6ekYhFhOe+EJ3udz8B5xBrWoGeIE1CUUENbeps0bcbNXbKMEDjE9ZgcNdholqWi3zpVACOa2Bi10VSOpzV7FI7krJdh+A==; 31:bfT5fQhb44RcyYpMTjoM4IVzMSiF77POSPNAoE/T5emPX/k+jg94hAeFUsCD+NSmFk0JEyeQWOKrPbTliLNyQ+X82dQT82xanXuW+CO3n5j/44KNziR5gNYZ8oTDrLoChGEkETrHXn/hrYRWOKYXlTdrDg72ny6RlQHJQcT8LUCUEq8qAmOFxID4zRRUVz4JiKA4RUHqbXJmouhpPvFJ/2TaSrYKoC71ji7IVOvXxA4= X-MS-TrafficTypeDiagnostic: AM5PR04MB3267: X-Microsoft-Exchange-Diagnostics: 1; AM5PR04MB3267; 20:BSeYW0qmBAf61bbkiEw8vMEt4nDw8OXpawEWyZ4uzGOet28lD0JFogNZGSZHpDdAelmdeXSQ4R0NvC/f9nZ5xhYTMVK3xmq/KBpc/qOwiRdbCyoP4EePtkPBGP5VpSs5L0Uptiw/D+NYtS/b0KsQql0qClwARYJemIHYYG/nAs5/GhBgFBIX19VDdDSBcCZj5mKKIbk1OXd5V7YG3mte0zdzot7NBJCLV3fOz0q6p7/UGaRv/i/3ViTE/pFFA7hWnGYYhium8yblNebTiKQrT4YbcBqgxOBWy6sV1wfoDIpSz0sbmjys8mllzzpgPflbyruj/biGK+yl/3Xmcwh3qrMiweKjoYT7s8srePMDxipgglJT+T4XrPIcHMbbv2oeQ19tMeDTU2PFYm5rJvI/P25noNnXsyUM5o4h2D8/lqNIdkfPNl09D5PIYXqkwOKvFeJmnhHRemOm6GsuaF5xusLbpUiAABRHP8UYrfSJohg7Ah+TgMoTBRL40c09YgSi; 4:fSQhnSuAhLYx5mlQmpBjd531onZH1qJM4XyvgUTgh2tcZBuL5uZVVLp0FA5boVibXqO3x339/h7o1NGf/vGWtN38bKyqDWPxbti4Sn0hdUdmZ0qrovUWh6D1Je3ckLhqARhI0uXvm9qk66s96a1p+q5af4YXQE3dOC4yVJoF87YwmJ1CB3VmpCQysQvOaXXm9FbSUZPniKS6hEgjAaXikMUbBZgvyp+cop1QGc66GQWDAmcTR9JB68Oc4Xnc2VyGceb3J7885iZhEHdaXVT24XShAfbtmwsq9SZeE6xV4mWBER/CA0J8OQ43//SyVBAk X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501244)(52105095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:AM5PR04MB3267; BCL:0; PCL:0; RULEID:; SRVR:AM5PR04MB3267; X-Forefront-PRVS: 0611A21987 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(346002)(376002)(366004)(396003)(199004)(189003)(1076002)(68736007)(7736002)(6916009)(47776003)(4326008)(8676002)(2950100002)(316002)(6666003)(50466002)(81156014)(25786009)(81166006)(66066001)(50226002)(305945005)(3846002)(8936002)(53936002)(6116002)(36756003)(48376002)(575784001)(2906002)(16526019)(26005)(3450700001)(2361001)(86362001)(186003)(59450400001)(478600001)(51416003)(76176011)(106356001)(52116002)(16586007)(43066004)(6512007)(2351001)(6486002)(97736004)(5660300001)(386003)(105586002)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR04MB3267; H:rhuath.am.freescale.net; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR04MB3267; 23:qkzKDP1Cy4AdzFxtn0R2f0uUiJ8bX0DaVVQGgCnEj?= xS6cLhP+9AzhVMBMFga7azD3EpDxsbklF4iCuHGjPzUfQ1jjxmLXwDokE39lCn4k08ocyZDRInedPYsWwUWHfTWUsNnfGtJolGnYoYfpK0ncR0S88xX16rIo1i8wEdSl8jNd3O8Di9/LiGx7HnfizUggQvPtL/9GgedvN35JLTjhu0DCg+PeOTJ5tf8CwU5KGaiWL1eBGB26MoBnrYtBZm9S3ZDsfgY7T4t+U2fokHgEANOGB/H/R62hhad6RMQgw3xMii+c7kTQc4KhnBpjchkNKGJzQgQAZMfn9bTXI24GXJu0nXpUKmsvnOZp5zyC23dMWy//SICx8iHtiB+8NHWW3AqR9lvwW+y7fqVQceokhzyz6rpKIRaREK35hbVrUQaypexVFLahEwXv3PH2VuyJ8KtBjRebMuzmQ3lqaSGTjLx9LnkxzpVUN/dl+6hchZek4ixrJqzXIsa8I0mnuSR8jlcqsz+t9GXCUUHtkvGajfOvKr8xRfwTbzqWJHi/uGoO0nPr2SS/tdwuFjM/FzA2g182mr073tOKC67CowjJkVnLpFnoKaR1euwmKAZ3dAy6ThQAO/utYhCMUeg3m5b5kAlrTj9DHibVv/cShpItCmiQO7yTlNSLZ9U+ZhoTSMfGRyrWQ+80GXGVuhhe6t8d8jAqOv2DRZav9TdpNE5UzrP4QdxilIKD4nnVGfYO13xtg2Ct75s3I+h2j1ANbfl+QUccoNwTMpysUPDlmtt6RaS3t9el88DyC1zXPfpiCBMwM4VurVIZJv0M5bbuKb51GATOrGrqqm54DBJBMoQzclLkKSJwW/kF70+e3UwSrN/1j4BjJiWQAPNSIfteJ8m0UBADPlHXqnBGOvZQPJJmW0LThZvZKhDDgPRwRM5dKSHoyglBqiPOKAOUlZNqjR6hbQenCau+9QfAG66YaQ3KU9uJJ3i5uWofQtTvhSXcX7E3k48nrANjlpbVwh12d9+bZADgj6v5J0xh5FJQrf/+K4XZkIRkClHD3Tie3sXyoBX0fOhCrqBhnTWOBgHNpc70qFhq5Z6a/zH2Wp0RkE2nMwXev3KOqJQhITW4U7LGG2QvTdAcuCisJbRQTM0tCrS+4zxClrj9kR/HfCODAL/QkBspmzYqJNxgRu6p1he2cJU88PrPOU9+dr800otr4a6pQmZAJWpcH09qP1pgD0JfVqQvyXEAtljdgCiJkJTLCE= X-Microsoft-Antispam-Message-Info: MLZSgHL8flDorHUgMmD67gFClIL5dUDj+WOQkVL0rr/htp3dAptN9ffcf1j7FyyxGlvX0a5zl46o8zF+mpCZopc+W4gGoE675d5jDuiziU8wI/GuG0V1ofcd8l6QIy3ISMO8cD3YlwtryRfpBsxL3v8kVilkzy/rq/oXmsviWUhcz7ZMzHdRprc1T6WA9/mS X-Microsoft-Exchange-Diagnostics: 1; AM5PR04MB3267; 6:V1MCcRw4lPO4NnhxK/OwexwqkbvbzvnOMU4HWj4fhNi8uXbCgu++q7o3qH1loyFFfMU3AZVAiNv6DIsOLy5GA0UqzGqSszB/mVgWJwXDp1KuGRGQM7E7Ze1vWQhXwrm7bcp1FTXTPaCSExDMpHJ8xBf48DsdjUUDW5dB5TMjdsGvg1ukYi6QaZddcaPzsIC4zxZ6ytCoQojHJfLsnr16HqxGV2vsz1piLtlhEX5zdJ1R8qNt7dDfAOHhWXYm1EAwxfSek8gw/wqY++pFc0g1Qy1n2DPepkjWCAEFy5bY/Tv9QRoKQwIcPSvL2m4l4uM2Ns9rCIIRM/Q+pg6bQR5ToM8YYpHfgvlde3kJezPoqOk=; 5:IRiuRYOTelSBA6SQDOYnf+zbuCfweGFdfTFRQLdYQeV8Ewd4u3hQT/H3TKL06oHDf/c4UYCaHINHzcaBsf4vbWPe1fq8OxRst1AZvbnHqw/UFRYbQThCzWOD/iGQ0ENG8hVBNCLm2Rd3TqB8Cajrzx/ChvIMsA2g1o4q5XUneBQ=; 24:MHoS6X6sk1P6dgeRw4nxiRAaSrSwo1pvp7EEDpbQrtLsQbTuiNPMthtCNIuiYc/+UepyGSYBWOIhkBnguZcPAaPrbRVmN5wvQ310KW+nxR0=; 7:/oxRwlLsi2j4FveX2Rja2I797W+aAxag67xu1jSYILUofGHxuTG86RuaYTUMIracp6b7IT+FYROHkVg+/eoDkmR7v2VCQKA91W0Gv5fx8onBfHPcwYz9NhO2kdQmnLL6Ef7nT6PF0DXokFZhShatV23tirwy0WzopVrgjuJ8P0Jzb9x+SJB1qTcB5pK76hETBP5w9eTFzZQ09C/pIeecr3Rp3uSN7vLuYOfj7bDbhf+f84iPg5lJYVnd/4WbwgTM SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2018 13:38:29.2738 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 13b26256-a1a9-4779-1f72-08d589b0dff5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3267 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: madalin.bucur@nxp.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, camelia.groza@nxp.com, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Camelia Groza The fd_format has already been initialized at this point. Signed-off-by: Camelia Groza --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 128e0a4..3e83d79 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -2289,7 +2289,6 @@ static enum qman_cb_dqrr_result rx_default_dqrr(struct qman_portal *portal, vaddr = phys_to_virt(addr); prefetch(vaddr + qm_fd_get_offset(fd)); - fd_format = qm_fd_get_format(fd); /* The only FD types that we may receive are contig and S/G */ WARN_ON((fd_format != qm_fd_contig) && (fd_format != qm_fd_sg)); From patchwork Wed Mar 14 13:37:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madalin Bucur X-Patchwork-Id: 885807 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 401YSh3LlFz9sTk for ; Thu, 15 Mar 2018 01:07:16 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="XkmXhgjq"; dkim-atps=neutral Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 401YSg3d7wzDr2G for ; Thu, 15 Mar 2018 01:07:15 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="XkmXhgjq"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nxp.com (client-ip=40.107.1.59; helo=eur02-he1-obe.outbound.protection.outlook.com; envelope-from=madalin.bucur@nxp.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="XkmXhgjq"; dkim-atps=neutral Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10059.outbound.protection.outlook.com [40.107.1.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 401Xqg3wPBzDqhw for ; Thu, 15 Mar 2018 00:38:39 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QP8zHgBEkujCdX2MmRjMF+t5iCbs1fn0qmwFTl7E8IY=; b=XkmXhgjqzYuipzd0S9rKVKiXZydFXmUlKLp/QmFl5Zs+2T4dS/EgN5CJ89/goDCSmHYsz8E9a5skUAPMzUhOBd7CRJmhNKCYz2+aK5zBMkdT0Q8i1OdK7fKqoAxtI5jcuzUqBJ+sG+ojanPzKMzDplVzYytfycXYscSB+D0/pPg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=madalin.bucur@nxp.com; Received: from rhuath.am.freescale.net (192.88.168.49) by AM5PR04MB3267.eurprd04.prod.outlook.com (2603:10a6:206:d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.567.14; Wed, 14 Mar 2018 13:38:31 +0000 From: Madalin Bucur To: davem@davemloft.net Subject: [PATCH 4/5] dpaa_eth: increment the RX dropped counter when needed Date: Wed, 14 Mar 2018 08:37:31 -0500 Message-Id: <20180314133732.24068-5-madalin.bucur@nxp.com> X-Mailer: git-send-email 2.8.3 In-Reply-To: <20180314133732.24068-1-madalin.bucur@nxp.com> References: <20180314133732.24068-1-madalin.bucur@nxp.com> MIME-Version: 1.0 X-Originating-IP: [192.88.168.49] X-ClientProxiedBy: SN4PR0601CA0024.namprd06.prod.outlook.com (2603:10b6:803:2f::34) To AM5PR04MB3267.eurprd04.prod.outlook.com (2603:10a6:206:d::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8ad45f65-6e3e-47d3-9d69-08d589b0e115 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR04MB3267; X-Microsoft-Exchange-Diagnostics: 1; AM5PR04MB3267; 3:HEa7S1M/mD3vtDEqPUfjLqPvtZYpKiR0HvW3XR5M4MyxyCpaFGvlqs5eei4cU3OGjCc8SWy/XrLB8pZ2uhBmh6VEeh8FRECxyJFk4fDze6+pPklZrx8a8nLQnBlzF/L/KxsbEn/q60EJH/5pIvR5F8IdYs7FyAQ64jYhQcSjK5w4zaMNZoE3xvTSc3hmGwoxtk7HLHXlo5kYa6cDS/7OwrqGzY8oIq8WHpExEIQS3mi56xUdhffuMDSldRLTzgGj; 25:CiEed0iimulTM3J2/5ZLKDgxH5eoiH8Y93NyAxfQTiOGCR+C5jlYVSs1SdrMJVX3VgI+GReUzQUkTd+5UGBL6aq/BipEOSS9y5FHTM+bUT4HhzDP3iy8Tecd2c1rfM21tqfbTTIVv5M+B4HAsT7E0fVOo41EVaqnn+8lMsT+gBlAcc6o+iGRFW3Hs/C6UA7lF1CH0Uh2UlBZkPEXj2kQH14Dvd6WZRbYj/Y6rQK5o7Gi7hUzNEH30ta5OZSHFjhNnqo/fd5XawUuNtxxVpQRCpZnCbxkSawTiEaZJtZttgndV5ITeUYaDiLTnxpOZNXm9oXQ8dqpFqcDZtvbFv5ZJg==; 31:u8QHKjZXvGrzuKwuqOekHEg29HkwxqjbEQs14QuzlHiycwMy8zQq+X1WOZTQzWBM/ijy7zSs8czVoa8xQeb2X+evxeQmUflF+oftm1xsWcLZPpJ5QuOlgkcmOlZX2xppoRFGqTlqmxuALOaYbj5YycxAosxhcBgtSpaSrEO+0hiEMLg4DNGnWpHr9AG+pRsArYYjiBRzbDMjBJV7o3aj++6HpZSYP7FOHZhnYRtM7bc= X-MS-TrafficTypeDiagnostic: AM5PR04MB3267: X-Microsoft-Exchange-Diagnostics: 1; AM5PR04MB3267; 20:ioRxFy/v/Sscho/uqghP779cddC05FY+gUImDf2yZBLpJ1JMO9FgSxxaMv3x9ePRBJa1zo76Jw22ewsUU1ZIklvSOKgdD7V/ki0u6nCMIfMp5c4EtM1V0eQRfe2Qag2qxQhNF6eIYvPfTGs2G8kn8STms79kxcvXXE42Z+renG4jw7iIdNqk/aDwlkf9NhOeHYsOyxJlB6PUEy5pdNLRQ6q4AlPmh6cWQ7sMD4LfrOPx1YOH+xr6RYfY4HEMQx5GuqjGYqAGxl5dSvF3EkMMfsxuFo6bvKiGQnXwIF2AsA3xrHoP2eTy9aG0ERgGsMSCDSe2Kf7i2sB2SuM5/SQNAtsLGs+laX0eGw+S9kDPogsVQXDXS/+JsKnfuRRQfDg9/fMvZDXPFkEEoLjSpCWjUdmg+feSffeqRT6uUwX/ySw+wFypVeffgC6pCdL06PE9WQSMgi7pae27NYZvB9XdNONPWNukkQ2QjgFU2qiZvgCyKkHBM76rQ8tL7crZxtFM; 4:/ByurpKfYJlVx5guZ87Ey3zJCxPY3e459XJxD9ToMji1XS8rMlTgTPSho/3IIlQp4n0ms1BhoMuI3s37wWbPYgO5wQiFWVn3ViQcMmzieojaEpVud6ZBayG1C6/BjJ3AIqns9vwcU35xuqnykvg0upp6Bs+XytUZ+yLVSup3UtjqYOtJ3suw9s+6lpC74AC969T+An3E95y/ugg+tH+jK+4RwuMMjX8MqNld7+fkVV5sKdwnbSxoAihEC2j2eSfUeuYUNdgK8f3gr1E8hqQjKQqFbVpck7jX+DySLforBwrpWcsekhRYaT/ktzoHAMRG X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501244)(52105095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:AM5PR04MB3267; BCL:0; PCL:0; RULEID:; SRVR:AM5PR04MB3267; X-Forefront-PRVS: 0611A21987 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(39860400002)(39380400002)(346002)(376002)(366004)(396003)(199004)(189003)(1076002)(68736007)(7736002)(6916009)(47776003)(4326008)(8676002)(2950100002)(316002)(50466002)(81156014)(25786009)(81166006)(66066001)(50226002)(305945005)(3846002)(8936002)(53936002)(6116002)(36756003)(48376002)(2906002)(16526019)(26005)(3450700001)(2361001)(86362001)(186003)(59450400001)(478600001)(51416003)(76176011)(106356001)(52116002)(16586007)(43066004)(6512007)(2351001)(6486002)(97736004)(5660300001)(386003)(105586002)(6506007)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR04MB3267; H:rhuath.am.freescale.net; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR04MB3267; 23:gFsVgJgypZ451Gazh1x1SyBi0vvQ5zBdWdIP84KLF?= oHp0eC3hOVin/ThGqszkwiC6pDuVxJv/dDlksVjQFD2UA63edFkIGFKcXmzseSJiLUVNN5JzJgndd/sdIeCo9KAdLU0knumCiR+92UERugvAaZTQ+cmiXoDv9x9HYTdNmf/PGZ7ILmKsDH7M/CvIAsFEXv381TWxf3ZXRn9g2Kx3WhzaKTn/iQh5eq4TbOaJGjXds9d0Eb91L/+m3VfMyiqGZLcTlHqr1l6jCpiJPE2lK6C6CrVC6jFKQwVlpuj3mGcqQsDK+q08iSM1651Ny5xsOEy2+e4ng9TzShFRww0MxlcWEX0UP5UUZfLNmgNCGrAcJKku+BeB7JHEDSdEGU/m/kbdJNdSfcSOwA/uyCejDlGVXtbQTrivD8hs1iodz9rc5tIB9PRiWd3pZ4UArkbv1JCxg01+Vi43aV8NfHCkfXZW81It9jVjmUrPlf7vPKvt1w5vt5VFcIDtbqEnej6x9rR4P2s7SoGr/S5J0t9MJx0XMEXtvSR1Bc/dJU7w9SZntQaEMhBqFVTHXtd0mlDY/itS99fDqOd9f1AbRwo/IW0blUcA+b80AMMbg9hGXsUTaDZuRgzVelziF9wqgBav4peH90pwZBTToOSoMNK7w5wtLc7xvVQqaohToQCKVTNVnsgfVrgI6wV1j6sK1usSc7hISxNO9Kn50hwCkeaRe4z5eJwBLbki/CmVWnVlx1MSq/nrRMSwRO2VC6bXgmhebSCuzsKK9+zFWd2jMTpPGrVZX/Eoq6W9mReAlC2ZFPv35mA0GUVs1pQAmpF/w1yJSqyXkSeOc7L3taSZKwnqvr9hOkPgt2fI2a/p3TNcUSXCqZ346wmXQ/lA5aVO4tYECSnYtrIzZ/rmhgMS/zO+03gOZ+ExhaNChhEMXRTe6cgtmrGGyPvMdugg6pJg+rymaolqiTPX11tsyge0wdp/I6t5LdXbWTGfnT+igaOiDxgNPRUAd9VVPec4pQQQ7llKnM60OiBTqJjEnfmo6nxeykP+xMW1YlvDmONop/owIKyiYUqsZZEJfL8IP3676q0xiluwoj//aeiVhb4f+p8fOPs/e3o6GnaXX5OixQKVphHyCfe8xDpnhEunSFmlKbxY80lSFJwei09HQRRRLhM5hnCfH3734aML1X0T6zHQs8xb17tLhTEOT8GI0sG1F5z7GXP6IFbY7Dlx+5Gk19wxx4JrnRrPpHmhunQHNWJmbPri1uwtClcD9oM+UAfIXIqamZb0Zz+Kcv+oReGkzBgs8rO5LoopvmoFQ0q78Hv9iQ= X-Microsoft-Antispam-Message-Info: oH2+M5ZQFG4VcyC5xfMAtYpDwdM955vjUUYh3SlpnaoegfkGSBeBEFWAg7PZgUVqnIxBROp8iOTc4QO8lJSvhsHYiyG+4p71SSaaBjlIioB5Z/I9zJETxUtHs7XYAjGwL3/dWb4e/u3aTWNaWEjg8Goajw+s5ol33B+DMyFJgPLhqRp5dxcDoRxEjezH0OLw X-Microsoft-Exchange-Diagnostics: 1; AM5PR04MB3267; 6:rP+jbuMtzrLnq8+yGsFmWjLm/Vozu7bZDYmFETjA0phucKMcP9bC6N63O5ECj+/Eey4a1pAX/jFOcr/ULpzaoy78t3FfEDJrCbOQzNeq/RX9Nn1LcRvfJ/72lTfmFUXYS3kw1UhrW3292cMYyXhQJ7+XCKm/nNASfs7yZdUpGoKZ9+OocQf2jNmWku3/1QOF/cdzSmP3DaHlXIk16rx4l1/2pTxFYqSgqG7b+hiOC9teFERkaCBSY++nAlb7htqaLxakZGDB54mIpr5PgFHVM7TRPO+eQDe+pxYPfInCDRh2IMTdjsQQbqdHmpbpZxcUSVTBX6V7wdHql2Uc5/3G/S5rWtv1HmD8fO6OGElIDX4=; 5:3lbRA661zt2dpyDH3YNCIBcswU4LkvrAmz/IBSwvhgV4iLfVkxwlNd6uEA5+W1i6JD9egxpXM9zxwod00Zv1HY3bqVLp7qAvtqBUCyKX3WmYY4iF9Iga+tKoWTbwCsEX9rbbzBOEUDQ0ehUmXEtOGiuwrWXi/N+v/qlhRs/bq7w=; 24:chcTL0iADVJfslDeIMo2Dd7gvV2jYz7PRQYxerQMz6NDaI7kQ27QKrPxAb5heot/qn7S/3Egd0olOCIqTII5ekA1LBL1semnNiTBv8SSvOI=; 7:thM9uD3755s0nzgY1AmOtNFjvFyD9jnRcwj8zwaveJQhT0Njr5wR/igrczGP4FoOaRLWv21tdKcIILkJZz9gE33f0N3smxhr1i8EF2WYWMs9/T5Y9qgpRf/MVjF5nBxZOvtgn97UpkObXfeBAbNWUOMgA7eboqxlRX8l9l8WglcJV+AI0g2iT1o8hrG9iDdN6BbN69KSvd5EQT0sNPs4Yn50c4LVFdNOO1F0dpMOvLhZAraY+n78BWTlli2SkiMG SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2018 13:38:31.1801 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ad45f65-6e3e-47d3-9d69-08d589b0e115 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3267 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: madalin.bucur@nxp.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, camelia.groza@nxp.com, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Camelia Groza Signed-off-by: Camelia Groza --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 3e83d79..76b3c9e 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -2321,8 +2321,10 @@ static enum qman_cb_dqrr_result rx_default_dqrr(struct qman_portal *portal, skb_len = skb->len; - if (unlikely(netif_receive_skb(skb) == NET_RX_DROP)) + if (unlikely(netif_receive_skb(skb) == NET_RX_DROP)) { + percpu_stats->rx_dropped++; return qman_cb_dqrr_consume; + } percpu_stats->rx_packets++; percpu_stats->rx_bytes += skb_len; From patchwork Wed Mar 14 13:37:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madalin Bucur X-Patchwork-Id: 885810 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 401Ycc5JvRz9sCc for ; Thu, 15 Mar 2018 01:14:08 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="FFZpiLC2"; dkim-atps=neutral Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 401Ycc2fhLzDrDB for ; Thu, 15 Mar 2018 01:14:08 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="FFZpiLC2"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nxp.com (client-ip=40.107.1.59; helo=eur02-he1-obe.outbound.protection.outlook.com; envelope-from=madalin.bucur@nxp.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="FFZpiLC2"; dkim-atps=neutral Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10059.outbound.protection.outlook.com [40.107.1.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 401Xqj25sMzDqhy for ; Thu, 15 Mar 2018 00:38:41 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lO30z80j9pjpgojVqZIO5gWMyfh2ts0RLRl/N+sRVCw=; b=FFZpiLC2CEYRHRacfhZo6GKPJ46cWWPFKUC+BlceU3Nf2xWuHAFZxlfNypb/yqTHbBPaI3i77GTb82YnM+ceX6Ojwpb2ckCZB3qP1sPdMrHkKbIGgQJu0w4KmH8ijQLvSlfqVv+j+xoMguFL5iXV9qVuiObiz96xfmIfYqnBrB0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=madalin.bucur@nxp.com; Received: from rhuath.am.freescale.net (192.88.168.49) by AM5PR04MB3267.eurprd04.prod.outlook.com (2603:10a6:206:d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.567.14; Wed, 14 Mar 2018 13:38:33 +0000 From: Madalin Bucur To: davem@davemloft.net Subject: [PATCH 5/5] dpaa_eth: remove duplicate increment of the tx_errors counter Date: Wed, 14 Mar 2018 08:37:32 -0500 Message-Id: <20180314133732.24068-6-madalin.bucur@nxp.com> X-Mailer: git-send-email 2.8.3 In-Reply-To: <20180314133732.24068-1-madalin.bucur@nxp.com> References: <20180314133732.24068-1-madalin.bucur@nxp.com> MIME-Version: 1.0 X-Originating-IP: [192.88.168.49] X-ClientProxiedBy: SN4PR0601CA0024.namprd06.prod.outlook.com (2603:10b6:803:2f::34) To AM5PR04MB3267.eurprd04.prod.outlook.com (2603:10a6:206:d::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 682895c0-526c-4383-05ff-08d589b0e261 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR04MB3267; X-Microsoft-Exchange-Diagnostics: 1; AM5PR04MB3267; 3:EbSG13DlmZmiRookfdkN5EvbQZXCaaXOoSMKU/t6OPAAnLLxDciM14hMhKPbaEyg+BTzKTqWu8K1i2WDQs5RLI0GSUDU++5wR9ffpH0nvz+aw9nX958/T/QhhFHP2cxWCpPCRUmlU2h7PqDUCiTQSwUx+ZH3YtoQZsvcPguoj+h/A7fLjx37EoHvrgeg8YSXqnZCDXgvM9RBnWe2AMlnvhvIXse0dcwyfS/Bj2jwvVQwB1d9gveJ8r0T/xiNMbi8; 25:kQBUDzneaUoqil15IVuxjXsRcUItJd2JQZrts+hOgeH9IHQEtpW1mCjngqmT3Y30e1/1lbWYcYzPtC7E0kajqTXz9FFeHVrZHV63FSV3V2TJJShAD+V1pHfmXAb8rAkHs5Q/GNgdQQ3ByfGJAUDpVZO4opi+qY/2CU+x9lQ21wJiuQIkla/vycDT/1BNvCxiLNP6t7kyfGCSL7FTwyNjR5ievezhmWImK+RcHd0540gur9f5JxL7ddeQRrcmui5xT38lYAU3N8kBxldP/Iule6HYmUnrmDMKkkXKxVq0DbFmjLyI6dZ4I0aIndct16fZ6jgzeV/yBlL4gnknUR7dlg==; 31:j+hiY1te/bsyXka7NaTGEza3Ye9NeQWN9hrOmO/HppFwIKkZYy3lEqBDdqO6paibCW3A8bQfreSu97GXMdGcbLTVjEftXQFeEduk5rW5NEQtoC1OWyXzAMRfMt8VLwCM1wMfNfQ3/L2WcEC3QiM1upRlQi1s7SHX4GXezNjMYJtppH7LomxLcXgSOytK7ZHJ4l2uD4XQU4lIpVFXX4bX0Vya7B9xpuKTMk0X3bjQku8= X-MS-TrafficTypeDiagnostic: AM5PR04MB3267: X-Microsoft-Exchange-Diagnostics: 1; AM5PR04MB3267; 20:E+CmxcUOZ68K94PT5QEuqnRRE2ADxX6qIGFrzn5o5hdxql9IgXNNQlL4rWcr0Zia5lSpcoD51Uq+9NB9XYKGbVBqTU+oGl+Ssnps21Ru+yYfox7eHc34aLdNpSrY0qTqaFMzedQMzTiyp2HjLV8sMo++SkRRH4mupRSnYGf0JFNqWdILTu6Ch/sscBBxU15iZwVQL3nmuT6WaOsWBVgx+Fex085FXebakrex8xgpFlqJ30tqp6QEBq85U45Zb5r6G8mwR9TGwHDVc4uHCwJJX4qtTl4Dtul+cU7fc01AE6AlmjmQkvf1fuT/F33zz9Wfb3f8hPNEPs5thgPs+yl1ClyXoEZYi3doX0cj+EsjtRsprYLq3At+cENuMAISa6MTmaJtVjDYZqsMvgPvhzZjnqq8KRU32pLILykO7TjRT47DLML4MQvdBpHnwTShpRRe9iAuK2xVUJ7fb8loX0jhnIzH8oxSHrvz81WIAKaF6/LMP4LqdHiq6UP5G5CDMyT5; 4:NiPLZRXMbunH6FGvpnEoMl/gA5GRstkCKQn1ObU62X2EfiBVQZT71DKHGDV5Zocp+QAI6CrND6fQo3JQjJxy2DidPuWad1sN2vqVX/cVHDS4tlKWea6/mEV8GYRea7/x7YVJ3CvH/4OujrPKFF9Mym4/pXUo/qWlcEdyhXr3UPcoetoFfkPt5yZpoEKujnOQ/i5oUpI4cv1vpCtJ3M5Rt8IJHNCcDknCPaoU70kCtWpeyPOlQtFxuaIimk6eMDChXFLuuBcwRKwolDAzZYgF5m1mW2CPecDO1DCQnMuN44X/SpS1aCf2xDmnuL1uWM4S X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501244)(52105095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:AM5PR04MB3267; BCL:0; PCL:0; RULEID:; SRVR:AM5PR04MB3267; X-Forefront-PRVS: 0611A21987 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(346002)(376002)(366004)(396003)(199004)(189003)(1076002)(68736007)(7736002)(6916009)(47776003)(4326008)(8676002)(2950100002)(316002)(50466002)(81156014)(25786009)(81166006)(66066001)(50226002)(305945005)(3846002)(8936002)(53936002)(6116002)(36756003)(48376002)(2906002)(16526019)(26005)(3450700001)(2361001)(86362001)(186003)(59450400001)(478600001)(51416003)(76176011)(106356001)(52116002)(16586007)(43066004)(6512007)(2351001)(6486002)(97736004)(5660300001)(386003)(105586002)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR04MB3267; H:rhuath.am.freescale.net; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR04MB3267; 23:IP8Pi1zYLX1NzeKci0d7TkmFqAi9hi1q5F+/QY+C7?= AclmX/ZlPJjLnV6Lcb7+XmvHrtMJIsUeRhcEFjsi6+nL4Xs6o4HA8afflkvsvnGv83KTKeXLt2KgbwlmH7i6DU848cr2ZW3IuDm2ZMDWT+0Suvvh6t6+5c/+YU8EayQDHzU+k7EWZI09gRSKUGhtwEki3oA8hqtYUY38/f5fr1PyebVcAznnn+ET6aNIqzKEYL+SVmtkkoqCJgBDk2Jj+SORZg0w/n0pV+l62Jy6742kVBfiQ+x5WrOS7/D1PnoXD+kBIZfbYVC9j9TzfD/m1eNRHVIwCmLnhdK5Vx+XJwhhTWanBBglxV658M9RiH7rtoUU+eLd1kxsVClcbWgVpvYjF0hWanIFyUu4NiMOGy3BHZ1OcceZH1+IzTkm/ULs6ASXjbGBITtaAZ/h85Z4Ymcbez9Ib/vxFgB0xiSkhZbtAd/F053B07YxK53LhZzTPSmxJ+xrQgt5Or/BtjhrPO5Ks8+HQMgQDfxKZc25EHfcWEq/FEKOK9rIL9mIKwVEe8VC+gHq0AxgV3YIlmHQUPpup2RUX5x/8OK4p4wHsbutdwzOHOEo+s6jOaIyGvg3QOS4UMv3O6A5zvIrLepoTSzwa12BXKjBuhSHI6ZS4efy6vBUu06r8bUFtgn5GkEYsJhFf4KOa/M8kvLetyEnyLHI1jsRIzzm0mc26ZGx63yvihi6vYU1Wz4hLsoKdbkSchJlX3ihhOi/jmVujtiyHjW6DZdXhCtOhIxhHhKyyA9tM7NOi4obnTuOAVidGkveepmc9AgMx1jo5Y15TCGVw3wxNq2TWxYs2OBwbX3Z4d2ZBZZnX4J+IeBevsAi8EFAY79GSrganniWTMm/gmrA3M0id9vzN2wgob2neHCYXQ8nDGfnmTu/o9gwNCKF2OWt/uHxqRl2Cs/gB7XvbVDcVI5ggrkHkqouyvQOXzj7hYhEfg/LN9g8hyK86EqCOZwu6+qSanqeq9CPy13IPBBB8NyF62I1ZwfUCeHPlFiEsLPIdW/zp9kPQBOvcJ923iYRT61NispLV+2CACgshD4vEQrROwNiOWBVRa7andJ25eUoufeL3OsQ3OSUYqZjVU99x72Vgdyh8eq6AbSYEX8spejSQfEYBw5DEqUlu3hVU3m5XWOLXg+ZszKfDDOlmHtVhUI4IDHr+KVx6HPKtObuZLj X-Microsoft-Antispam-Message-Info: jhwa7lcXSQyZxhb1n7POuT8ecn73FxlpSagVoZxfq1oSlqsM5K1YEUXSdZi3G7JGeD9ibq1fUBD/KwD42wXCuN/Jv8md4vJ84vKVm62vvzzSVvZz36/3VjeFIyvw1FQ2yIAXv1llUTG1FqVlY8t/U8NElnhBHROCkskztfTFcy642m3OzgUTIEK/VG4Ya+YF X-Microsoft-Exchange-Diagnostics: 1; AM5PR04MB3267; 6:VU4OpuDW2JZ9KJPsaYcA2vYnDIw+TLjHgkSimdEqKctF50PNDg/iOyv3XKQpH/Ivz5VOk8/oDsX20y0KjhnCxAiFHcGO0fRKp2StO4bhIC4tFXjKCwqGVrW4/ilqV/bWs+6zQqASX4R2v126iyqqcDr/+YWEnmu2nrSv7acx5OqJsbni2NZ3M+ZfMDbS/TpGODNoIiBPAFvcrDrCFMrpWInRo/00s8QbrH3AY/6eGrGWclEn6bShPHKFLEYxgaBe/qIGKI8e61YMUeT7ZUIdWOXV7MOi/feJ0FhPZW2ycQwlWDNs8pbJMZeFduPg02qpFOrUoXvs0g6zb3DwaM2u+5Li8BtxKwmwSkAjgKMt8SI=; 5:A8f0BIoiaJ4GZ7BL2av4+pqnUmh8BNloFVI07UUTqpfnK19YQsXRKLXZtQNzsItjhQgRDlK/UhmvzXnp4H7UC2Y17AgBozKRK3zQmDitmXzNjTqOFuCOFkknfTgG7ym5cVm/zD+eM+djhzQUhyrWU/9OolH7dBVdD6Cgs8p9gjY=; 24:5kwrjZ5FTL26nQRMqmD3o1z1ojlJ2j2ofGkmqFt1wLTeFqI62sKv59MyDVNiMJdjoqn8e8TDQbx4yL0V2zDHij+V6LqQgZ1YadhdoeuwjX0=; 7:smskIj8nwUx1jJ952l6TNILQUI31m2kJfWfHv8nYKolBvfRKvw36U/YOY2YnPFT1sNzBOnmsxJi/Iz5T3baBtBQwZ4jWUYO65wdoxeyrEp4vZuE2cwAPKs5NI+XApBBGayJHou0Tn256ScGwu0m/asbrUja1ol2E6xvh4A+Kv2GirEdZVY19UtX0f8FCj5GRu37W+ETbaWzttAdeOnLT7cGQWjtIthbBR7Da0K/f5PcCiGsLgl8yqy4SnFfORCZ5 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2018 13:38:33.1957 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 682895c0-526c-4383-05ff-08d589b0e261 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3267 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: madalin.bucur@nxp.com Cc: Madalin Bucur , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, camelia.groza@nxp.com, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Camelia Groza The tx_errors counter is incremented by the dpaa_xmit caller. Signed-off-by: Camelia Groza Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 76b3c9e..fd43f98 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -2021,7 +2021,6 @@ static inline int dpaa_xmit(struct dpaa_priv *priv, } if (unlikely(err < 0)) { - percpu_stats->tx_errors++; percpu_stats->tx_fifo_errors++; return err; }