From patchwork Mon Dec 19 07:49:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Li X-Patchwork-Id: 1717174 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=cLGax1Zp; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NbBhk11ydz1ydb for ; Mon, 19 Dec 2022 18:50:46 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7Auf-0008MU-54; Mon, 19 Dec 2022 02:50:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7AuY-0008Js-Kq; Mon, 19 Dec 2022 02:50:10 -0500 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7AuV-0006eM-92; Mon, 19 Dec 2022 02:50:09 -0500 Received: by mail-pl1-x635.google.com with SMTP id u7so39756plq.11; Sun, 18 Dec 2022 23:50:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5Rxk2jJJt9jMSUMAXSaQOGneB84DuYg9jnKqEKvkqbQ=; b=cLGax1ZpyaohAZSzRjEsfIilYsvjkTooba2VS7P+JHdP7vAOnx1CBnWKy94P1mvFAG /Dsfwrzt0zA5c7BVmwLlJdamVuEi58vkRh+Hpg9Lk4gA5F7nPkbuf/DhCNIAp4yNE/cU 2MVfFoLQPvcO/txZU71NTtoYUQnAOis+y8LYc6uwrGOzAh+EVpEIYGNGEY6JwsCfLBcC ypBA2BjiSsuMGZhquTYQhtFGu376IpG/H/yIr3g7cPJifdKhXUo54FUX6P/3/as6WVMI peqb3qChGvgolt9e5le4N7lJpJTtoHWlUPisrZF+kd8a3/+BP4Ic7/yexDVJCq9guNAC PCAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5Rxk2jJJt9jMSUMAXSaQOGneB84DuYg9jnKqEKvkqbQ=; b=NhO6RZ5ChMdFEaRS5ZruJQIhzpEBqUvRHxEwdsEpB6xwltbzKj+PoWsdMuuA0EVphZ 6tW0oCJT5fAE/EntSPxYlf5NdRR1f4PV/AJlhUUF3Wv5Ggnxb0cUG1VGODqA/7GRmhpl 5bZoi58PHtCgPfsqcygGLN4nACqIPKyI4P7oLy9OQnsL1aPuip7HPTJ8VHfISY0X870p cmCBjvleKDAvpAGbnLsSaxtGQ2/cYx8QKW7O8N0WqK/Y/SNX8Mj7UYsTw2kh40+j6gdU vgmROk3quHAMNit6y7LiB2HFn0ln23pVrcAtfBNaahKDoGJToNbDcHV3lPa5IhFGxORF z5cQ== X-Gm-Message-State: AFqh2kowOcSF9HQdk9QY0YFBqQHP/2adAX1V6rPDmE4/NJMw+54KcBdK u0kd/6XvzBjWoOoghApn/Bp7YonPfE1GGbZ5 X-Google-Smtp-Source: AMrXdXtratGxIel7AC/TifbKqXE23Nqz1OpDCwkUVQ24yqv48zUgAn2WDwDjPgtCq4EgGE1s8UGe9Q== X-Received: by 2002:a17:902:c942:b0:190:f537:3c45 with SMTP id i2-20020a170902c94200b00190f5373c45mr27053601pla.30.1671436203573; Sun, 18 Dec 2022 23:50:03 -0800 (PST) Received: from fedlinux.. ([106.84.132.155]) by smtp.gmail.com with ESMTPSA id u17-20020a17090341d100b001754fa42065sm6368617ple.143.2022.12.18.23.49.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Dec 2022 23:50:03 -0800 (PST) From: Sam Li To: qemu-devel@nongnu.org Cc: hare@suse.de, hreitz@redhat.com, kwolf@redhat.com, dmitry.fomichev@wdc.com, pbonzini@redhat.com, damien.lemoal@opensource.wdc.com, fam@euphon.net, thuth@redhat.com, marcandre.lureau@redhat.com, philmd@linaro.org, berrange@redhat.com, eblake@redhat.com, armbru@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org, Sam Li Subject: [PATCH v14 5/8] config: add check to block layer Date: Mon, 19 Dec 2022 15:49:51 +0800 Message-Id: <20221219074951.7881-1-faithilikerun@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=faithilikerun@gmail.com; helo=mail-pl1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Putting zoned/non-zoned BlockDrivers on top of each other is not allowed. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi Reviewed-by: Hannes Reinecke Reviewed-by: Dmitry Fomichev --- block.c | 19 +++++++++++++++++++ block/file-posix.c | 12 ++++++++++++ block/raw-format.c | 1 + include/block/block_int-common.h | 5 +++++ 4 files changed, 37 insertions(+) diff --git a/block.c b/block.c index 9c2ac757e4..09abea9da7 100644 --- a/block.c +++ b/block.c @@ -7912,6 +7912,25 @@ void bdrv_add_child(BlockDriverState *parent_bs, BlockDriverState *child_bs, return; } + /* + * Non-zoned block drivers do not follow zoned storage constraints + * (i.e. sequential writes to zones). Refuse mixing zoned and non-zoned + * drivers in a graph. + */ + if (!parent_bs->drv->supports_zoned_children && + child_bs->bl.zoned == BLK_Z_HM) { + /* + * The host-aware model allows zoned storage constraints and random + * write. Allow mixing host-aware and non-zoned drivers. Using + * host-aware device as a regular device. + */ + error_setg(errp, "Cannot add a %s child to a %s parent", + child_bs->bl.zoned == BLK_Z_HM ? "zoned" : "non-zoned", + parent_bs->drv->supports_zoned_children ? + "support zoned children" : "not support zoned children"); + return; + } + if (!QLIST_EMPTY(&child_bs->parents)) { error_setg(errp, "The node %s already has a parent", child_bs->node_name); diff --git a/block/file-posix.c b/block/file-posix.c index 269c5b508a..091a95c1a9 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -775,6 +775,18 @@ static int raw_open_common(BlockDriverState *bs, QDict *options, goto fail; } } +#ifdef CONFIG_BLKZONED + /* + * The kernel page cache does not reliably work for writes to SWR zones + * of zoned block device because it can not guarantee the order of writes. + */ + if ((strcmp(bs->drv->format_name, "zoned_host_device") == 0) && + (!(s->open_flags & O_DIRECT))) { + error_setg(errp, "driver=zoned_host_device was specified, but it " + "requires cache.direct=on, which was not specified."); + return -EINVAL; /* No host kernel page cache */ + } +#endif if (S_ISBLK(st.st_mode)) { #ifdef __linux__ diff --git a/block/raw-format.c b/block/raw-format.c index 8e42fa83ed..2fcc2ad7f6 100644 --- a/block/raw-format.c +++ b/block/raw-format.c @@ -617,6 +617,7 @@ static void raw_child_perm(BlockDriverState *bs, BdrvChild *c, BlockDriver bdrv_raw = { .format_name = "raw", .instance_size = sizeof(BDRVRawState), + .supports_zoned_children = true, .bdrv_probe = &raw_probe, .bdrv_reopen_prepare = &raw_reopen_prepare, .bdrv_reopen_commit = &raw_reopen_commit, diff --git a/include/block/block_int-common.h b/include/block/block_int-common.h index dc6ee8006c..77eb0a2a8b 100644 --- a/include/block/block_int-common.h +++ b/include/block/block_int-common.h @@ -141,6 +141,11 @@ struct BlockDriver { */ bool is_format; + /* + * Set to true if the BlockDriver supports zoned children. + */ + bool supports_zoned_children; + /* * Drivers not implementing bdrv_parse_filename nor bdrv_open should have * this field set to true, except ones that are defined only by their From patchwork Mon Dec 19 08:05:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Li X-Patchwork-Id: 1717177 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=pvpNDL26; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NbC3Q2kVqz1ydb for ; Mon, 19 Dec 2022 19:06:56 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7B9x-0004qG-5q; Mon, 19 Dec 2022 03:06:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7B9i-0004nx-E5; Mon, 19 Dec 2022 03:05:58 -0500 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7B9g-0000wC-51; Mon, 19 Dec 2022 03:05:50 -0500 Received: by mail-pj1-x1032.google.com with SMTP id 3-20020a17090a098300b00219041dcbe9so8107930pjo.3; Mon, 19 Dec 2022 00:05:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4UDRne5xZbwbkxQ2/0o7lRb66oYqvDKMKGME0yjIxmY=; b=pvpNDL26ev6HQg8n4BMhlSsySEzotAVE+ZM/QlGd1/ULrysiEBbsEgNtIHgtdB9BxO p/7oJR4Ydbgwexno67IY3xaAI/s4i+9rNk1cTfRGRq2rHXETqolaQBtmieIYKXQ3ISPI 72llP9flmv0/QjBZr74KqpRKuR6yn6ioHe5zBMWFHiXcFWtGLbXEEP0jqyBEX/yXT5DS M13HGy7/nNCYRORr+EQlsAig0xhtqGIVJR9goi6ZQ2CZ1a/FRcOYztokW+6G+cAugYQm KE0n/DEIUPgkK25UzUY6TSqAGClHMDk4ERtSaBpmkhLhx4y88EaHlz+2bPGEyt+z5j+g lTYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4UDRne5xZbwbkxQ2/0o7lRb66oYqvDKMKGME0yjIxmY=; b=7Tyv3jzjBYNCgYW+8hiu5Q1R6lz5Qyj5TquBDiqXatIQlhvjzQGAW9S0OsMemwpjgW hWpnnBA351STmkIHiUOqAGK8cxtN1gvoCSBrB0DlVC0SNgyYIAfvyoSnUbnjX2sd6YGH z+25OoJ8U3th+mLddVLjxsNDLz+c0qTHVroZsi0cICZ4hCqgDpGy1gdDQdm6Q75MGTqr TdVjI73jScqzVFOBOFqb0ikYdypGKyEG5czW6yAdL6F4nIUe2mUnBvrxMwprqgir7IEV SFpgH0IJBG5sIhA8z4AMrSncoDboc2rrfTKdlNOK2hc63//X69y5F4NUUv6QAOAZPeEr UswA== X-Gm-Message-State: AFqh2kplMlSTh6H16RB/lsSs8pmeOKc0W3/H6cZPriuc/Fs9koQ/yE31 R4f+wGSXDYb2frk5mpXghfc0sUbMS7MBa1Y7 X-Google-Smtp-Source: AMrXdXuiQknR7NxmT+f20R7UOXCxA/3M+4aiHiYwW9gybzHe2EpiWyy24HVH5Lx/4WFfckW/rCTD3w== X-Received: by 2002:a17:90a:cc18:b0:219:4011:b836 with SMTP id b24-20020a17090acc1800b002194011b836mr7733956pju.23.1671437145120; Mon, 19 Dec 2022 00:05:45 -0800 (PST) Received: from fedlinux.. ([106.84.132.155]) by smtp.gmail.com with ESMTPSA id nd10-20020a17090b4cca00b002192a60e900sm8570712pjb.47.2022.12.19.00.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Dec 2022 00:05:44 -0800 (PST) From: Sam Li To: qemu-devel@nongnu.org Cc: hare@suse.de, hreitz@redhat.com, kwolf@redhat.com, dmitry.fomichev@wdc.com, pbonzini@redhat.com, damien.lemoal@opensource.wdc.com, fam@euphon.net, thuth@redhat.com, marcandre.lureau@redhat.com, philmd@linaro.org, berrange@redhat.com, eblake@redhat.com, armbru@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org, Sam Li Subject: [PATCH v14 6/8] qemu-iotests: test new zone operations Date: Mon, 19 Dec 2022 16:05:29 +0800 Message-Id: <20221219080529.10112-1-faithilikerun@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=faithilikerun@gmail.com; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org We have added new block layer APIs of zoned block devices. Test it as follows: Run each zone operation on a newly created null_blk device and see whether the logs show the correct zone information. By: $ ./tests/qemu-iotests/tests/zoned.sh Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/tests/zoned.out | 53 ++++++++++++++++++ tests/qemu-iotests/tests/zoned.sh | 86 ++++++++++++++++++++++++++++++ 2 files changed, 139 insertions(+) create mode 100644 tests/qemu-iotests/tests/zoned.out create mode 100755 tests/qemu-iotests/tests/zoned.sh diff --git a/tests/qemu-iotests/tests/zoned.out b/tests/qemu-iotests/tests/zoned.out new file mode 100644 index 0000000000..0c8f96deb9 --- /dev/null +++ b/tests/qemu-iotests/tests/zoned.out @@ -0,0 +1,53 @@ +QA output created by zoned.sh +Testing a null_blk device: +Simple cases: if the operations work +(1) report the first zone: +start: 0x0, len 0x80000, cap 0x80000, wptr 0x0, zcond:1, [type: 2] + +report the first 10 zones +start: 0x0, len 0x80000, cap 0x80000, wptr 0x0, zcond:1, [type: 2] +start: 0x80000, len 0x80000, cap 0x80000, wptr 0x80000, zcond:1, [type: 2] +start: 0x100000, len 0x80000, cap 0x80000, wptr 0x100000, zcond:1, [type: 2] +start: 0x180000, len 0x80000, cap 0x80000, wptr 0x180000, zcond:1, [type: 2] +start: 0x200000, len 0x80000, cap 0x80000, wptr 0x200000, zcond:1, [type: 2] +start: 0x280000, len 0x80000, cap 0x80000, wptr 0x280000, zcond:1, [type: 2] +start: 0x300000, len 0x80000, cap 0x80000, wptr 0x300000, zcond:1, [type: 2] +start: 0x380000, len 0x80000, cap 0x80000, wptr 0x380000, zcond:1, [type: 2] +start: 0x400000, len 0x80000, cap 0x80000, wptr 0x400000, zcond:1, [type: 2] +start: 0x480000, len 0x80000, cap 0x80000, wptr 0x480000, zcond:1, [type: 2] + +report the last zone: +start: 0x1f380000, len 0x80000, cap 0x80000, wptr 0x1f380000, zcond:1, [type: 2] + + +(2) opening the first zone +report after: +start: 0x0, len 0x80000, cap 0x80000, wptr 0x0, zcond:3, [type: 2] + +opening the second zone +report after: +start: 0x80000, len 0x80000, cap 0x80000, wptr 0x80000, zcond:3, [type: 2] + +opening the last zone +report after: +start: 0x1f380000, len 0x80000, cap 0x80000, wptr 0x1f380000, zcond:3, [type: 2] + + +(3) closing the first zone +report after: +start: 0x0, len 0x80000, cap 0x80000, wptr 0x0, zcond:1, [type: 2] + +closing the last zone +report after: +start: 0x1f380000, len 0x80000, cap 0x80000, wptr 0x1f380000, zcond:1, [type: 2] + + +(4) finishing the second zone +After finishing a zone: +start: 0x80000, len 0x80000, cap 0x80000, wptr 0x100000, zcond:14, [type: 2] + + +(5) resetting the second zone +After resetting a zone: +start: 0x80000, len 0x80000, cap 0x80000, wptr 0x80000, zcond:1, [type: 2] +*** done diff --git a/tests/qemu-iotests/tests/zoned.sh b/tests/qemu-iotests/tests/zoned.sh new file mode 100755 index 0000000000..fced0194c5 --- /dev/null +++ b/tests/qemu-iotests/tests/zoned.sh @@ -0,0 +1,86 @@ +#!/usr/bin/env bash +# +# Test zone management operations. +# + +seq="$(basename $0)" +echo "QA output created by $seq" +status=1 # failure is the default! + +_cleanup() +{ + _cleanup_test_img + sudo rmmod null_blk +} +trap "_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common.rc +. ./common.filter +. ./common.qemu + +# This test only runs on Linux hosts with raw image files. +_supported_fmt raw +_supported_proto file +_supported_os Linux + +QEMU_IO="build/qemu-io" +IMG="--image-opts -n driver=zoned_host_device,filename=/dev/nullb0" +QEMU_IO_OPTIONS=$QEMU_IO_OPTIONS_NO_FMT + +echo "Testing a null_blk device:" +echo "case 1: if the operations work" +sudo modprobe null_blk nr_devices=1 zoned=1 + +echo "(1) report the first zone:" +sudo $QEMU_IO $IMG -c "zrp 0 1" +echo +echo "report the first 10 zones" +sudo $QEMU_IO $IMG -c "zrp 0 10" +echo +echo "report the last zone:" +sudo $QEMU_IO $IMG -c "zrp 0x3e70000000 2" # 0x3e70000000 / 512 = 0x1f380000 +echo +echo +echo "(2) opening the first zone" +sudo $QEMU_IO $IMG -c "zo 0 268435456" # 268435456 / 512 = 524288 +echo "report after:" +sudo $QEMU_IO $IMG -c "zrp 0 1" +echo +echo "opening the second zone" +sudo $QEMU_IO $IMG -c "zo 268435456 268435456" # +echo "report after:" +sudo $QEMU_IO $IMG -c "zrp 268435456 1" +echo +echo "opening the last zone" +sudo $QEMU_IO $IMG -c "zo 0x3e70000000 268435456" +echo "report after:" +sudo $QEMU_IO $IMG -c "zrp 0x3e70000000 2" +echo +echo +echo "(3) closing the first zone" +sudo $QEMU_IO $IMG -c "zc 0 268435456" +echo "report after:" +sudo $QEMU_IO $IMG -c "zrp 0 1" +echo +echo "closing the last zone" +sudo $QEMU_IO $IMG -c "zc 0x3e70000000 268435456" +echo "report after:" +sudo $QEMU_IO $IMG -c "zrp 0x3e70000000 2" +echo +echo +echo "(4) finishing the second zone" +sudo $QEMU_IO $IMG -c "zf 268435456 268435456" +echo "After finishing a zone:" +sudo $QEMU_IO $IMG -c "zrp 268435456 1" +echo +echo +echo "(5) resetting the second zone" +sudo $QEMU_IO $IMG -c "zrs 268435456 268435456" +echo "After resetting a zone:" +sudo $QEMU_IO $IMG -c "zrp 268435456 1" + +# success, all done +echo "*** done" +rm -f $seq.full +status=0 From patchwork Mon Dec 19 08:05:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Li X-Patchwork-Id: 1717178 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=ENt5p6OH; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NbC3s5k2Fz1ydb for ; Mon, 19 Dec 2022 19:07:21 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7BAN-00055M-8G; Mon, 19 Dec 2022 03:06:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7BAK-00054A-1g; Mon, 19 Dec 2022 03:06:28 -0500 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7BAH-00011J-Bw; Mon, 19 Dec 2022 03:06:26 -0500 Received: by mail-pj1-x1036.google.com with SMTP id b13-20020a17090a5a0d00b0021906102d05so8100325pjd.5; Mon, 19 Dec 2022 00:06:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=68cnbVdHo5xfPHXvFvmTVixSlcdk34mEABJbpnc1zkM=; b=ENt5p6OHjetc3Dz2b5g8GtrgwrKKbhfbsRiwqzzuTXqIDPwxpa0xqh+acyWxufBTgY 8iJx43803Tip97o1aeKtCSugtsLETWNer8KqXaryq6ZeWgqhPKB7HilZInY0/rGiHoD2 WUEUHk1rTXRqptXEXrr9aPC98Su2F9vjJT4+PxWo6i+PxuXBcgmObHKR/V7DUkktTfHa dAjnByRyRtZaQn9LgU9K8ICLOVATOueE3nIFHz6s6UrbUNbROlJsXQIiSB7eAvwDmTFb K7olQ4QTTQyDRLxVCqtmAbx+XQxoDeOsq0+NDWdybmtLejEVuRhzhksr8h7pY0ileb3T IzOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=68cnbVdHo5xfPHXvFvmTVixSlcdk34mEABJbpnc1zkM=; b=cT+19xZ5aXQqCe7MVNk42MUlQSI7yDb6SYCMUkBpKbKImgSGEoSni1Xu29tPMiXOZE 3CFMaiLoH9ylu/wTeEUyxXM1h+1rdb9VqkDts6CaryKvrIwjsPr/AIfNklSB4PgwdQHZ gXhoFIsdNa2lO9LsD9fGBsErFlwmk8aaafHCS1bBPyt/H0or9pMQfG94uyrddtgGTUxP CNWlwsjUWq8YIKwbkdYb9P3vSz7g+6ZBOH691dSj/OzCgLcgcYvqmwJ2eczXO++5Am2b CZTY7MURsqpvBp2hjLAxWMhl4TtigRZhESCGfwZGa1IunjpAn7XcRjD+yZ0TSXd+r5OF OMDQ== X-Gm-Message-State: AFqh2koeDfimgS9qyp+sQFdEgjnI0MjBKkwnegdS9KdLFiJY9Gga4Yia mvmMZKo6DOfwHrwiRnOW2ESzBxnaGFN1J0gb X-Google-Smtp-Source: AMrXdXs6gNTc00dpe7PKw3/iCwt2RmFN9pk7d4GL9BjH8wQ2szUv3H4QNIsUGF6LD1TkfHbmOnD8Qw== X-Received: by 2002:a05:6a20:9d8e:b0:a3:b698:d036 with SMTP id mu14-20020a056a209d8e00b000a3b698d036mr20126474pzb.39.1671437182366; Mon, 19 Dec 2022 00:06:22 -0800 (PST) Received: from fedlinux.. ([106.84.132.155]) by smtp.gmail.com with ESMTPSA id b3-20020a636703000000b004768b74f208sm5818043pgc.4.2022.12.19.00.06.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Dec 2022 00:06:21 -0800 (PST) From: Sam Li To: qemu-devel@nongnu.org Cc: hare@suse.de, hreitz@redhat.com, kwolf@redhat.com, dmitry.fomichev@wdc.com, pbonzini@redhat.com, damien.lemoal@opensource.wdc.com, fam@euphon.net, thuth@redhat.com, marcandre.lureau@redhat.com, philmd@linaro.org, berrange@redhat.com, eblake@redhat.com, armbru@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org, Sam Li Subject: [PATCH v14 7/8] block: add some trace events for new block layer APIs Date: Mon, 19 Dec 2022 16:05:56 +0800 Message-Id: <20221219080556.10156-1-faithilikerun@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1036; envelope-from=faithilikerun@gmail.com; helo=mail-pj1-x1036.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi --- block/file-posix.c | 3 +++ block/trace-events | 2 ++ 2 files changed, 5 insertions(+) diff --git a/block/file-posix.c b/block/file-posix.c index 091a95c1a9..517400a63b 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -3274,6 +3274,7 @@ static int coroutine_fn raw_co_zone_report(BlockDriverState *bs, int64_t offset, BlockZoneDescriptor *zones) { BDRVRawState *s = bs->opaque; RawPosixAIOData acb; + trace_zbd_zone_report(bs, *nr_zones, offset >> BDRV_SECTOR_BITS); acb = (RawPosixAIOData) { .bs = bs, @@ -3352,6 +3353,8 @@ static int coroutine_fn raw_co_zone_mgmt(BlockDriverState *bs, BlockZoneOp op, }, }; + trace_zbd_zone_mgmt(bs, op_name, offset >> BDRV_SECTOR_BITS, + len >> BDRV_SECTOR_BITS); ret = raw_thread_pool_submit(bs, handle_aiocb_zone_mgmt, &acb); if (ret != 0) { ret = -errno; diff --git a/block/trace-events b/block/trace-events index 48dbf10c66..3f4e1d088a 100644 --- a/block/trace-events +++ b/block/trace-events @@ -209,6 +209,8 @@ file_FindEjectableOpticalMedia(const char *media) "Matching using %s" file_setup_cdrom(const char *partition) "Using %s as optical disc" file_hdev_is_sg(int type, int version) "SG device found: type=%d, version=%d" file_flush_fdatasync_failed(int err) "errno %d" +zbd_zone_report(void *bs, unsigned int nr_zones, int64_t sector) "bs %p report %d zones starting at sector offset 0x%" PRIx64 "" +zbd_zone_mgmt(void *bs, const char *op_name, int64_t sector, int64_t len) "bs %p %s starts at sector offset 0x%" PRIx64 " over a range of 0x%" PRIx64 " sectors" # ssh.c sftp_error(const char *op, const char *ssh_err, int ssh_err_code, int sftp_err_code) "%s failed: %s (libssh error code: %d, sftp error code: %d)" From patchwork Mon Dec 19 08:07:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Li X-Patchwork-Id: 1717179 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=ls2kbyhW; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NbC5v5gQmz1ydb for ; Mon, 19 Dec 2022 19:09:07 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7BCZ-0006NA-UI; Mon, 19 Dec 2022 03:08:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7BCY-0006KV-Ae; Mon, 19 Dec 2022 03:08:46 -0500 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7BCP-0001K1-KH; Mon, 19 Dec 2022 03:08:46 -0500 Received: by mail-pj1-x1030.google.com with SMTP id z8-20020a17090abd8800b00219ed30ce47so12172206pjr.3; Mon, 19 Dec 2022 00:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5xermXZz2dzDd2OOV3cCqQeQVqHekRDRYxUpyHfIJKs=; b=ls2kbyhW8KzLpiZhbhICPF/Q3NWSsoxXUWxRE1b1lO3feFpnb0JQedydJikW7btx9c g53l1+q4RdExtQcBJEdavVEJQI3HWM8x5P2Fa0/M/l6+kFuov/8i31xPLNI+88ou1k1L ARfj/2tut7qZV/ARf8cDtMMqaQPLeGKLmSiklLqiuaWVxkgMhfmv7Avi6yQI44mrvcKU yDbj0Gc+2fQDbeq+Fm1KDKrKGEKzWwg5z8vQcIq8hTq/ZzmZ8gCcUwf3ulFCCTeEPNVK ZzAzMBYNATMHkb57fikG/vq7pEbDaZyvCkXf8A/D/K8wooJw5Mz34S59V8fHpsrd8Rs+ FTQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5xermXZz2dzDd2OOV3cCqQeQVqHekRDRYxUpyHfIJKs=; b=qbSR1djKJ5B8iTFKy5saki55ZvHri90WLYALIPrGEangngL3l8yI9dfC7qExonkn4f me7AOCD+D8+mm/qVYXAIngtffJhPX0zUXPtBBe+MG19DTf8W3HbB7vsJCAa/bDVDD50w +rUc+LnDeCSBuDmbMH0R1AbW5xHs7Ei1wVoAqS/28HiDsaZMJpSk77H2iAHGyM/SRUa+ 1HUi4v8QolguZuhes3EgFVAjnHFJ9IQuk9Hfunrjjqyt0PL62jeu6bzcE0aQTghtCf7J gg7Q8gWKDFbzmjEZOWD6UFkG2fksWgFKe0LqN3nTz6VxCIky6yKR5zGmzDVqVX7dNTSv Weuw== X-Gm-Message-State: AFqh2koMbz4ifEmdqLP6ZnLevm/mkIF3L/pxHSoelGXLM8LuLnyOUOUd IrSjTXOdjqmEktxYxXQC1gx7V9yGllwPGM7u X-Google-Smtp-Source: AMrXdXsqetDcAZbc93AMvEm7FL3Suy39StGipumtvDGy9DTlUxmfP15vYNcRPH7daLYsnXXBT2E5zQ== X-Received: by 2002:a17:90a:7f82:b0:223:8395:aa87 with SMTP id m2-20020a17090a7f8200b002238395aa87mr13719185pjl.26.1671437315386; Mon, 19 Dec 2022 00:08:35 -0800 (PST) Received: from fedlinux.. ([106.84.132.155]) by smtp.gmail.com with ESMTPSA id nu6-20020a17090b1b0600b002191a64b5d5sm8824155pjb.18.2022.12.19.00.08.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Dec 2022 00:08:34 -0800 (PST) From: Sam Li To: qemu-devel@nongnu.org Cc: hare@suse.de, hreitz@redhat.com, kwolf@redhat.com, dmitry.fomichev@wdc.com, pbonzini@redhat.com, damien.lemoal@opensource.wdc.com, fam@euphon.net, thuth@redhat.com, marcandre.lureau@redhat.com, philmd@linaro.org, berrange@redhat.com, eblake@redhat.com, armbru@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org, Sam Li Subject: [PATCH v14 8/8] docs/zoned-storage: add zoned device documentation Date: Mon, 19 Dec 2022 16:07:52 +0800 Message-Id: <20221219080752.10476-1-faithilikerun@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=faithilikerun@gmail.com; helo=mail-pj1-x1030.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Add the documentation about the zoned device support to virtio-blk emulation. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi Reviewed-by: Damien Le Moal Reviewed-by: Dmitry Fomichev --- docs/devel/zoned-storage.rst | 43 ++++++++++++++++++++++++++ docs/system/qemu-block-drivers.rst.inc | 6 ++++ 2 files changed, 49 insertions(+) create mode 100644 docs/devel/zoned-storage.rst diff --git a/docs/devel/zoned-storage.rst b/docs/devel/zoned-storage.rst new file mode 100644 index 0000000000..03e52efe2e --- /dev/null +++ b/docs/devel/zoned-storage.rst @@ -0,0 +1,43 @@ +============= +zoned-storage +============= + +Zoned Block Devices (ZBDs) divide the LBA space into block regions called zones +that are larger than the LBA size. They can only allow sequential writes, which +can reduce write amplification in SSDs, and potentially lead to higher +throughput and increased capacity. More details about ZBDs can be found at: + +https://zonedstorage.io/docs/introduction/zoned-storage + +1. Block layer APIs for zoned storage +------------------------------------- +QEMU block layer supports three zoned storage models: +- BLK_Z_HM: The host-managed zoned model only allows sequential writes access +to zones. It supports ZBD-specific I/O commands that can be used by a host to +manage the zones of a device. +- BLK_Z_HA: The host-aware zoned model allows random write operations in +zones, making it backward compatible with regular block devices. +- BLK_Z_NONE: The non-zoned model has no zones support. It includes both +regular and drive-managed ZBD devices. ZBD-specific I/O commands are not +supported. + +The block device information resides inside BlockDriverState. QEMU uses +BlockLimits struct(BlockDriverState::bl) that is continuously accessed by the +block layer while processing I/O requests. A BlockBackend has a root pointer to +a BlockDriverState graph(for example, raw format on top of file-posix). The +zoned storage information can be propagated from the leaf BlockDriverState all +the way up to the BlockBackend. If the zoned storage model in file-posix is +set to BLK_Z_HM, then block drivers will declare support for zoned host device. + +The block layer APIs support commands needed for zoned storage devices, +including report zones, four zone operations, and zone append. + +2. Emulating zoned storage controllers +-------------------------------------- +When the BlockBackend's BlockLimits model reports a zoned storage device, users +like the virtio-blk emulation or the qemu-io-cmds.c utility can use block layer +APIs for zoned storage emulation or testing. + +For example, to test zone_report on a null_blk device using qemu-io is: +$ path/to/qemu-io --image-opts -n driver=zoned_host_device,filename=/dev/nullb0 +-c "zrp offset nr_zones" diff --git a/docs/system/qemu-block-drivers.rst.inc b/docs/system/qemu-block-drivers.rst.inc index dfe5d2293d..0b97227fd9 100644 --- a/docs/system/qemu-block-drivers.rst.inc +++ b/docs/system/qemu-block-drivers.rst.inc @@ -430,6 +430,12 @@ Hard disks you may corrupt your host data (use the ``-snapshot`` command line option or modify the device permissions accordingly). +Zoned block devices + Zoned block devices can be passed through to the guest if the emulated storage + controller supports zoned storage. Use ``--blockdev zoned_host_device, + node-name=drive0,filename=/dev/nullb0`` to pass through ``/dev/nullb0`` + as ``drive0``. + Windows ^^^^^^^