From patchwork Tue Jul 12 10:40:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ivan Hu X-Patchwork-Id: 1655304 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=WbxZ8mCg; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Lhy2H5wXwz9ryY for ; Tue, 12 Jul 2022 20:40:23 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1oBDJP-0005xS-SI; Tue, 12 Jul 2022 10:40:15 +0000 Received: from smtp-relay-canonical-0.internal ([10.131.114.83] helo=smtp-relay-canonical-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1oBDJN-0005xF-ID for fwts-devel@lists.ubuntu.com; Tue, 12 Jul 2022 10:40:13 +0000 Received: from canonical.com (unknown [10.101.194.165]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 18CB73F1B5 for ; Tue, 12 Jul 2022 10:40:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1657622413; bh=XacvrDx9MYz82/zh2OFQnmp3ROP+rhRD/pdjD3QgtFY=; h=From:To:Subject:Date:Message-Id:MIME-Version:Content-Type; b=WbxZ8mCgxJfi5fxHXgd3f25849qUVDl/F/WUOGt6CxgrT6a5XNve/nOMfK/GXGomC nf7xxM9xxsVurmdMNrIbik2BZ85Ap1Qs5grmCRfvqYiJaLmMwo5IOX0L2zLrhMe17U 6pQy6HLRXT3QT2Jd1wFb+eIL0nOf8qACgD4MgUuGNNJN3w0JhFV+Dmb9C9PYNvbx0c 1Yz79cyZQ9W2E+NvRdge7cZcI12CQXTyG/27kkQh3vNaMucRA51e896jwJGU/gU+Ji WigjBdOv7VwfG/abGy3ukXcOEe6rymhLsAIkWiKQphWCfuYUikxM18w29YQVNHf7lz zy8wYD2F6R2mQ== From: Ivan Hu To: fwts-devel@lists.ubuntu.com Subject: [PATCH 1/2] acpi: asf: remove the checking of minmun watchdog reset velue 0 Date: Tue, 12 Jul 2022 18:40:05 +0800 Message-Id: <20220712104006.43759-1-ivan.hu@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" BugLink: https://bugs.launchpad.net/fwts/+bug/1981429 From Alert Standard Format Specification[1] The Minimum Watchdog Reset Value described as below, Identifies the minimum value (in the range 1 to 256) to which an alert-sending device’s watchdog timer should be set at power-on reset, in seconds. This value also reflects the maximum amount of time the system firmware requires to reset the initial system boot-failure watchdog timer. It doesn't reference 0x00. However 0x00 in this context means the watchdog timer is disabled. [1]https://www.dmtf.org/sites/default/files/standards/documents/DSP0136.pdf Signed-off-by: Ivan Hu --- src/acpi/asf/asf.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/acpi/asf/asf.c b/src/acpi/asf/asf.c index 74e4521c..675301ff 100644 --- a/src/acpi/asf/asf.c +++ b/src/acpi/asf/asf.c @@ -80,13 +80,6 @@ static void asf_check_info( fwts_log_info_verbatim(fw, " Reserved: 0x%2.2" PRIx8, info->reserved3); #endif - if (info->watchdog_reset_value == 0) { - *passed = false; - fwts_failed(fw, LOG_LEVEL_HIGH, - "ASF!InfoMinWatchDogInvalid", - "ASF! ASF_INFO Minimum Watchdog Reset Value is 0x00 and " - "must be in the range 0x01..0xff"); - } if (info->min_sensor_poll_wait_time < 2) { *passed = false; fwts_failed(fw, LOG_LEVEL_HIGH, From patchwork Tue Jul 12 10:40:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Hu X-Patchwork-Id: 1655305 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=Y11M9k0N; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Lhy2Q4Hhxz9ryY for ; Tue, 12 Jul 2022 20:40:30 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1oBDJX-0005yU-Vz; Tue, 12 Jul 2022 10:40:23 +0000 Received: from smtp-relay-canonical-0.internal ([10.131.114.83] helo=smtp-relay-canonical-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1oBDJW-0005y5-Nx for fwts-devel@lists.ubuntu.com; Tue, 12 Jul 2022 10:40:22 +0000 Received: from canonical.com (unknown [10.101.194.165]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 9D1183F1B5 for ; Tue, 12 Jul 2022 10:40:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1657622421; bh=09/AK/7Bjy+0sy0AiHsnfym/d3/okPQlDqzyyHwInrI=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Y11M9k0N2gcpmUFWpe5ya+Rk7kiGzsjWyGLL8nVQaeyBt/W8+423l/uh/xK8+PbAD 2MXbtTsYrURO939nU4tFHvINFHnaNenOz1uDgftjj0RrtteBSzhReVz77fqT4bcO0r zDIfFzyk+YILb9EZjtlkRtoiczU3MseKqptoUG3K+uv4ZWjnibewwE1ye936UDcxSx DpZSckmMuht8N43HkADjdaSsu6+52zIPrHXerINTLpfGo1carofCOlmBflMuEO1ps2 XPoIR2YzRV3fmE9VC7Fx0DiOGJ9rx0igo4tGwaVyOIholJGrnbyBMydSGgNdQIH808 sc8aY4JU8GJgQ== From: Ivan Hu To: fwts-devel@lists.ubuntu.com Subject: [PATCH 2/2] fwts-test: sync up the remove of ASF minimun watchdog reset value Date: Tue, 12 Jul 2022 18:40:06 +0800 Message-Id: <20220712104006.43759-2-ivan.hu@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220712104006.43759-1-ivan.hu@canonical.com> References: <20220712104006.43759-1-ivan.hu@canonical.com> MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" Signed-off-by: Ivan Hu --- fwts-test/asf-0001/asf-0002.log | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fwts-test/asf-0001/asf-0002.log b/fwts-test/asf-0001/asf-0002.log index bee1002c..656827c3 100644 --- a/fwts-test/asf-0001/asf-0002.log +++ b/fwts-test/asf-0001/asf-0002.log @@ -2,9 +2,6 @@ asf asf: ASF! Alert Standard Format Table test. asf ---------------------------------------------------------- asf Test 1 of 1: ASF! Alert Standard Format Table test. asf ASF! Hardware Error Source Table -asf FAILED [HIGH] ASF!InfoMinWatchDogInvalid: Test 1, ASF! -asf ASF_INFO Minimum Watchdog Reset Value is 0x00 and must be -asf in the range 0x01..0xff asf FAILED [HIGH] ASF!InfoMinPollWaitTimeInvalid: Test 1, ASF! asf ASF_INFO Minimum Poll Wait Time is 0x0 and must be in the asf range 0x02..0xff @@ -33,6 +30,6 @@ asf long for the size given by the ASF! table. Expected at asf most 22 bytes. asf asf ========================================================== -asf 1 passed, 10 failed, 0 warning, 0 aborted, 0 skipped, 0 +asf 1 passed, 9 failed, 0 warning, 0 aborted, 0 skipped, 0 asf info only. asf ==========================================================