From patchwork Thu May 5 16:17:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1627029 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=miDSWfIk; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvK6r2X0cz9sBF for ; Fri, 6 May 2022 02:35:00 +1000 (AEST) Received: from localhost ([::1]:56800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmeRN-0004Ox-SX for incoming@patchwork.ozlabs.org; Thu, 05 May 2022 12:34:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmeBK-0001r5-Iz; Thu, 05 May 2022 12:18:22 -0400 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]:46792) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmeBI-0005i6-UB; Thu, 05 May 2022 12:18:22 -0400 Received: by mail-ej1-x62a.google.com with SMTP id j6so9656119ejc.13; Thu, 05 May 2022 09:18:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J/6+mxJShYSyNeMzfW/wdjGGv9Bb6vFzmsX6eoKrHRk=; b=miDSWfIkmiUY/gnVWh/Ljtfwn6XC6wPipfvuBfqYxYYoDwdPJFvAYZsrVI4ea10qzS AqXyTBbeYf292uKemAOWeoVLWOa2XybcL8DlWwwrhJ1jo+u23Qba7LdtKqhVOihgBto7 MaPn+p1sCJhRGQkz3r60ut6/lzlN5y8y1YwNL+/awZXWmoIJz6glK72mJpSrRreqgYW+ 49EUzJE/rahFSEvTVWgGvZOFgfiD8p5r9ago3fT+EBaCXXAyVhCiCyUDAXS5ixgfFVgS xE5geH8DJ2xwvQOLTAXdJw3pcoIEfLSLVhUB6UvpKksg5hHH8IPmYc+dZxYHsK6Ismi7 N2og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J/6+mxJShYSyNeMzfW/wdjGGv9Bb6vFzmsX6eoKrHRk=; b=PQY5cp3G1/ZXdXtJdIDbOINjjvetZTBT8P8pCI68zCgcAUef3667l+C1/z2gmsOBqL 5wy8pU61RL2PNirkRH0l5SaWa0XKartBxtBTUfgn4McTcZjKecD5QiB8MtzYNPoiA1DO 9M03EdKtTTtn9gZvn9aM/HajZG4KuzMwLenU6b4lHPgMABt8I8c8rvLzN8zob9PJd59N mb7EhCey0R+LP+ZKZrwmyfOa+5tHDr0h/gsBUkVe2xcZGaZuQRGuM/anmSYF5b8EoqPN /Z+tYDYByZnxYNgdQUoXSpJnuSP01z91nRX8+GbMVhV7W+gEEXDRKHKsAmTDbLi24idz a5+g== X-Gm-Message-State: AOAM533vq0TvQ19YT8VBm/LUqs8Dlxtzs0NiCK47jVOUAsS03TuahD3u PW46ysv3K1lF/D2M2jz8Rp76l2Ijwqo= X-Google-Smtp-Source: ABdhPJz8vVfU/hDV5dhc96hloRUT+iF27TJTwsopYOEQixwM+6EynORU5ouK4cePv59e7cB0REOeHw== X-Received: by 2002:a17:906:cb90:b0:6f4:d91b:1025 with SMTP id mf16-20020a170906cb9000b006f4d91b1025mr7536531ejb.177.1651767498935; Thu, 05 May 2022 09:18:18 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-054-123-159.78.54.pool.telefonica.de. [78.54.123.159]) by smtp.gmail.com with ESMTPSA id i6-20020a17090685c600b006f3ef214dcfsm868542ejy.53.2022.05.05.09.18.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 09:18:18 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , "Michael S. Tsirkin" , Paolo Bonzini Subject: [PATCH 01/11] hw/rtc/mc146818rtc: Inline isa_connect_gpio_out() and remove it Date: Thu, 5 May 2022 18:17:55 +0200 Message-Id: <20220505161805.11116-2-shentey@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220505161805.11116-1-shentey@gmail.com> References: <20220505161805.11116-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=shentey@gmail.com; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Commit 250263033c5343012b2cd6f01210ffb5b908a159 'isa: introduce wrapper isa_connect_gpio_out' introduced it in 2016. Since then, its only user remained mc146818rtc. Remove this one-off solution. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/isa/isa-bus.c | 6 ------ hw/rtc/mc146818rtc.c | 3 ++- include/hw/isa/isa.h | 1 - 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c index 0ad1c5fd65..59eb1af9e3 100644 --- a/hw/isa/isa-bus.c +++ b/hw/isa/isa-bus.c @@ -85,12 +85,6 @@ qemu_irq isa_get_irq(ISADevice *dev, unsigned isairq) return isabus->irqs[isairq]; } -void isa_connect_gpio_out(ISADevice *isadev, int gpioirq, unsigned isairq) -{ - qemu_irq irq = isa_get_irq(isadev, isairq); - qdev_connect_gpio_out(DEVICE(isadev), gpioirq, irq); -} - void isa_bus_dma(ISABus *bus, IsaDma *dma8, IsaDma *dma16) { assert(bus && dma8 && dma16); diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c index f235c2ddbe..79c43391cb 100644 --- a/hw/rtc/mc146818rtc.c +++ b/hw/rtc/mc146818rtc.c @@ -972,7 +972,8 @@ ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq) if (intercept_irq) { qdev_connect_gpio_out(dev, 0, intercept_irq); } else { - isa_connect_gpio_out(isadev, 0, s->isairq); + qemu_irq irq = isa_get_irq(isadev, s->isairq); + qdev_connect_gpio_out(dev, 0, irq); } object_property_add_alias(qdev_get_machine(), "rtc-time", OBJECT(isadev), diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h index 034d706ba1..1b758ae1ab 100644 --- a/include/hw/isa/isa.h +++ b/include/hw/isa/isa.h @@ -90,7 +90,6 @@ ISABus *isa_bus_new(DeviceState *dev, MemoryRegion *address_space, MemoryRegion *address_space_io, Error **errp); void isa_bus_irqs(ISABus *bus, qemu_irq *irqs); qemu_irq isa_get_irq(ISADevice *dev, unsigned isairq); -void isa_connect_gpio_out(ISADevice *isadev, int gpioirq, unsigned isairq); void isa_bus_dma(ISABus *bus, IsaDma *dma8, IsaDma *dma16); IsaDma *isa_get_dma(ISABus *bus, int nchan); MemoryRegion *isa_address_space(ISADevice *dev); From patchwork Thu May 5 16:17:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1627030 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=ELfhp9FM; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvK7J2XpKz9sBF for ; Fri, 6 May 2022 02:35:24 +1000 (AEST) Received: from localhost ([::1]:57860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmeRm-00055z-1q for incoming@patchwork.ozlabs.org; Thu, 05 May 2022 12:35:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmeBM-0001vp-Aq; Thu, 05 May 2022 12:18:24 -0400 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]:33705) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmeBK-0005iO-NV; Thu, 05 May 2022 12:18:23 -0400 Received: by mail-ej1-x62e.google.com with SMTP id gh6so9747462ejb.0; Thu, 05 May 2022 09:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7MxLriz5xbAd+BcL6eLZMlnBhbAdcemwHPwNNnHpCCY=; b=ELfhp9FMeL2dIP+E0VbWE89x9GN9igwhGwcnXx2LbUZfO+Z+ifshd4U3jeJW/fx/nq 6UNC9TiHL0gmlui8TDz9MQB4Fe+Ck1FZTuVSg+kwO3i+WEVLmsuGnHNmZExFsXn+9a9h 9s2zNEIKypvaFYRn0yRqVVQMmrPgpR+8p5BkmVEKovbzsUwcKBMmp4XWuw1dfn5Xttjq 2w4bCsJ8cfwZGyTFgg50tMOl+3PDv4Xj1SQOsbROZZCqG0WgYBh4hWJuaQ41dXcZ3sS4 8wLtBWtEJr2zADyZK3UrQMbrYQpGtKaCBCvYSsSq2mme6Y/K/V15/lG8+WrjizKD90dw Kw7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7MxLriz5xbAd+BcL6eLZMlnBhbAdcemwHPwNNnHpCCY=; b=NaxmCfGqJeR10/6a8IGEFXj987swi2drxf712MY1oVdEJyQrRB0ly/ZG0q1KoA5ykp Aqs4RNR/HYu5d8LJWuHtBIPQrMHdAap3h0jdDGXF/XPUlEP4K5oYb5lmuVoLGZv8ZZR4 EMjYq4kaV1QlxAsxXMLvXhpx/mrLo1R51mMhRx5z81O72l1uUmqbGQDMWe2NSPnJEPqI NFismsUZ+IUDz2hH0VUqkzpb3BkEUuCk05iHDWcJ532uyozh2zy2QKBVoemT4wjxcohD so2fANvKtK7p2yPM901tYeG5AkJIhAymm+eNOhyC3eXqUl1VRQ7upercEMY/nioJCucl TynQ== X-Gm-Message-State: AOAM530xXXjOoKPtbCNcGyQ4IVAbo1+OdUzEJCpbu33/bTnr1DJDoe7f PcCxDclfUJb9EicT2UgZ19XoVUz5KgM= X-Google-Smtp-Source: ABdhPJyYxd40FUn/Oz7tVpdQk3zDoHOsx4ZNDJeHl6H3UVLUBipYazoN2tiHR/du/qDDQ3uxQ0ymlQ== X-Received: by 2002:a17:907:7811:b0:6ef:a896:b407 with SMTP id la17-20020a170907781100b006efa896b407mr26059056ejc.645.1651767500127; Thu, 05 May 2022 09:18:20 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-054-123-159.78.54.pool.telefonica.de. [78.54.123.159]) by smtp.gmail.com with ESMTPSA id i6-20020a17090685c600b006f3ef214dcfsm868542ejy.53.2022.05.05.09.18.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 09:18:19 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Mark Cave-Ayland , Artyom Tarasenko Subject: [PATCH 02/11] hw: Reuse TYPE_I8042 define Date: Thu, 5 May 2022 18:17:56 +0200 Message-Id: <20220505161805.11116-3-shentey@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220505161805.11116-1-shentey@gmail.com> References: <20220505161805.11116-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=shentey@gmail.com; helo=mail-ej1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" TYPE_I8042 is exported, so reuse it for consistency. Signed-off-by: Bernhard Beschow --- hw/i386/pc.c | 4 ++-- hw/sparc64/sun4u.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 23bba9d82c..649511a49b 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1042,7 +1042,7 @@ static void pc_superio_init(ISABus *isa_bus, bool create_fdctrl, return; } - i8042 = isa_create_simple(isa_bus, "i8042"); + i8042 = isa_create_simple(isa_bus, TYPE_I8042); if (!no_vmport) { isa_create_simple(isa_bus, TYPE_VMPORT); vmmouse = isa_try_new("vmmouse"); @@ -1050,7 +1050,7 @@ static void pc_superio_init(ISABus *isa_bus, bool create_fdctrl, vmmouse = NULL; } if (vmmouse) { - object_property_set_link(OBJECT(vmmouse), "i8042", OBJECT(i8042), + object_property_set_link(OBJECT(vmmouse), TYPE_I8042, OBJECT(i8042), &error_abort); isa_realize_and_unref(vmmouse, isa_bus, &error_fatal); } diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index 6fd08e2298..77687dc649 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@ -334,7 +334,7 @@ static void ebus_realize(PCIDevice *pci_dev, Error **errp) parallel_hds_isa_init(s->isa_bus, MAX_PARALLEL_PORTS); /* Keyboard */ - isa_create_simple(s->isa_bus, "i8042"); + isa_create_simple(s->isa_bus, TYPE_I8042); /* Floppy */ for (i = 0; i < MAX_FD; i++) { From patchwork Thu May 5 16:17:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1627026 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=eZw5SfUc; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvK490Kj5z9sBF for ; Fri, 6 May 2022 02:32:41 +1000 (AEST) Received: from localhost ([::1]:50228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmeP8-0008M4-R0 for incoming@patchwork.ozlabs.org; Thu, 05 May 2022 12:32:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmeBN-0001xX-0e; Thu, 05 May 2022 12:18:25 -0400 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]:33701) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmeBL-0005ic-5n; Thu, 05 May 2022 12:18:24 -0400 Received: by mail-ej1-x629.google.com with SMTP id gh6so9747538ejb.0; Thu, 05 May 2022 09:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WIS0fBwOWDFkFZRgtYgAQeD0VQwUFTuck+f3lMt7aoY=; b=eZw5SfUchhFBYVLW/b7paoFTX539Rww88LDlPUZYAuYn2BOMzALPoBToe1SLbcTorA 0RKBwKoJNkDWWJCX7NEAJK/dGWw/UBbu15XmOuC8Wz1GM8vvaPn3oPmlN51xbelNgysz /zvVNwgJWAixrq4XIWcXZbYlDH39MGTMctS4MaPdejzO5Pb1IqZgwwdaoVUNYhw4OSXM gd8fptBp6R6Zp3UJUpMNK7EAeaTfck1QI5Y0kZvrXfwV6Wu7OsJlmKlJD8PUC4EgFTwF QaivfsxTmJJ8zR0EbXtPOjBVylNVf29EH3oPnAUKfzdB5q1SFvD3Y5yqs0vZxGoXOiIQ Ssyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WIS0fBwOWDFkFZRgtYgAQeD0VQwUFTuck+f3lMt7aoY=; b=PlfoGfZ7jAWOd9mCbsoQZChdph41Pu0V/+Q2DecoJfV0hvwGF1uqj6XQqiutm5FAXk T02TaY5Ka53UnW60GdfRxAFDlSuxrI5ofgPHeGaS1frOqhXLIjEmRJRwb+ASu6KnA9OW eQzrOEkzZ6s9Ou/N7+y7/dYrlwGZYtz3lAo943/gXdxH6OZctrhkgpWlPil2BVxyRy22 qobN8JXBu2YCPMXP9fW7bdcXpdjWhspXWIGOh4ixqC5KNPZT5pu8YEm4qymo0C3rLDpm 7tWprTV5Q4FJp4mnFna/fuhlDnBOrGl58UVIop5QtEDo2UBLjpzsvdxqQ96ozzcGEiKr su/Q== X-Gm-Message-State: AOAM531sYsiL0Y091XFWcv5AbHLUYEgxmbWQLIoiz15f0HPCvZmYIJ3w vo7nDEAKuDcYyh0VuGYeOh6JQJDvH0Y= X-Google-Smtp-Source: ABdhPJydT6Z36pDDShAEAjBHEcYhAxy2bKCwbzlwnCwILV4M4lGgrgrKDV0LhkLT71qTcntZ51VlRw== X-Received: by 2002:a17:907:629a:b0:6d7:b33e:43f4 with SMTP id nd26-20020a170907629a00b006d7b33e43f4mr27711981ejc.149.1651767501355; Thu, 05 May 2022 09:18:21 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-054-123-159.78.54.pool.telefonica.de. [78.54.123.159]) by smtp.gmail.com with ESMTPSA id i6-20020a17090685c600b006f3ef214dcfsm868542ejy.53.2022.05.05.09.18.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 09:18:20 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , Gerd Hoffmann Subject: [PATCH 03/11] hw/audio/cs4231a: Const'ify global tables Date: Thu, 5 May 2022 18:17:57 +0200 Message-Id: <20220505161805.11116-4-shentey@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220505161805.11116-1-shentey@gmail.com> References: <20220505161805.11116-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::629; envelope-from=shentey@gmail.com; helo=mail-ej1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The tables contain spcifically crafted constants for algorithms, so make them immutable. Signed-off-by: Bernhard Beschow --- hw/audio/cs4231a.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/audio/cs4231a.c b/hw/audio/cs4231a.c index 0723e39430..7f17a72a9c 100644 --- a/hw/audio/cs4231a.c +++ b/hw/audio/cs4231a.c @@ -84,7 +84,7 @@ struct CSState { int transferred; int aci_counter; SWVoiceOut *voice; - int16_t *tab; + const int16_t *tab; }; #define MODE2 (1 << 6) @@ -142,13 +142,13 @@ enum { Capture_Lower_Base_Count }; -static int freqs[2][8] = { +static const int freqs[2][8] = { { 8000, 16000, 27420, 32000, -1, -1, 48000, 9000 }, { 5510, 11025, 18900, 22050, 37800, 44100, 33075, 6620 } }; /* Tables courtesy http://hazelware.luggle.com/tutorials/mulawcompression.html */ -static int16_t MuLawDecompressTable[256] = +static const int16_t MuLawDecompressTable[256] = { -32124,-31100,-30076,-29052,-28028,-27004,-25980,-24956, -23932,-22908,-21884,-20860,-19836,-18812,-17788,-16764, @@ -184,7 +184,7 @@ static int16_t MuLawDecompressTable[256] = 56, 48, 40, 32, 24, 16, 8, 0 }; -static int16_t ALawDecompressTable[256] = +static const int16_t ALawDecompressTable[256] = { -5504, -5248, -6016, -5760, -4480, -4224, -4992, -4736, -7552, -7296, -8064, -7808, -6528, -6272, -7040, -6784, From patchwork Thu May 5 16:17:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1627022 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=brkb2uGw; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvJq15FW9z9sBF for ; Fri, 6 May 2022 02:21:17 +1000 (AEST) Received: from localhost ([::1]:58696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmeE7-00030K-Hm for incoming@patchwork.ozlabs.org; Thu, 05 May 2022 12:21:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmeBO-00020L-9Y; Thu, 05 May 2022 12:18:26 -0400 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]:45832) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmeBM-0005j0-NK; Thu, 05 May 2022 12:18:25 -0400 Received: by mail-ej1-x635.google.com with SMTP id y3so9645910ejo.12; Thu, 05 May 2022 09:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qUtnbnlrI+UnKirLM6NXJpF8MZDLftaoOuEhflZEltQ=; b=brkb2uGwgyvMsXeFk8WzFoMDdfQSd/1o6cxzVEd4DLOKK7yDYDxVCRac5gNNxPRWn1 T7oWutMk93OTI8kETmSpZjXRmBkogqXKnCrFydvUwvOKq3SmsRYkGf/vsybYURP09sus 6Xwq5GtvaoCxjtBfdYZdfjHliTh9G9E8MoRH+BHLhR00Fd5FNQQ6IIIVHbBeK1NVtAgz w+GDX4gDfKB5dcOuEwu0mDyX6BrstXU8TqqEyEanBfvjyIDzxQIwPIcvvGAsUr0tHMnJ J1/YNGE+9bJmWCe1T6QncrumOVUvuv3swFTovEt4STh5NEeVkANvGkr5nCfmOvwdhyLb SWCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qUtnbnlrI+UnKirLM6NXJpF8MZDLftaoOuEhflZEltQ=; b=6sLgK2wvJhIBSDbiWKnHanM9GSSg4IQyK2PtFNwDGl+15FxKOP5Ja+597e9vkNdkLn jEqPuoebBwMZSJApYZqG84JNIFcHdxgpaCjd1L3uHhVLURvQ/lrq1q/QzEwvzl84DzcW l0hg2KrGzghfS5DuEguMjwxoKIkT7toG0T0iI7ACYdns6gmfD6z8f+U2h37W/TwVDZyW 09W6351iy8uB2lMzoBf4HaPVOSEztsIn7WMxwwPfGBsDIUIs8SWtdBOjzVUO267NrIb2 57Pfmp+jiU02bBrfAevkwRxjYcOsizYZ27b2LFDKZXJzk5p9N0dt7gNc7MCV3EfpqiIQ 77JQ== X-Gm-Message-State: AOAM5336f8ir6Kv9THPDFWpLZB9esEQ8PkWT6g1jGQhFuvKAQzMBcTuG IkrhOxvncothmE4ry/Vl5BFBjkWJeRw= X-Google-Smtp-Source: ABdhPJy06WVnmA4+bFFXkHCTTo6GIEsrDjZ36MYfTCwxAZbKbLL8talOL/Q5fHSgrwnmgbIuigjhNQ== X-Received: by 2002:a17:907:c2a:b0:6f4:4b49:9cfb with SMTP id ga42-20020a1709070c2a00b006f44b499cfbmr19926797ejc.697.1651767502505; Thu, 05 May 2022 09:18:22 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-054-123-159.78.54.pool.telefonica.de. [78.54.123.159]) by smtp.gmail.com with ESMTPSA id i6-20020a17090685c600b006f3ef214dcfsm868542ejy.53.2022.05.05.09.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 09:18:22 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost Subject: [PATCH 04/11] hw/i386/pc: Unexport PC_CPU_MODEL_IDS macro Date: Thu, 5 May 2022 18:17:58 +0200 Message-Id: <20220505161805.11116-5-shentey@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220505161805.11116-1-shentey@gmail.com> References: <20220505161805.11116-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=shentey@gmail.com; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The macro seems to be used only internally, so remove it. Signed-off-by: Bernhard Beschow --- hw/i386/pc.c | 9 +++++++++ include/hw/i386/pc.h | 8 -------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 649511a49b..c2975d7de5 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -95,6 +95,15 @@ #include "trace.h" #include CONFIG_DEVICES +/* + * Helper for setting model-id for CPU models that changed model-id + * depending on QEMU versions up to QEMU 2.4. + */ +#define PC_CPU_MODEL_IDS(v) \ + { "qemu32-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\ + { "qemu64-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\ + { "athlon-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, }, + GlobalProperty pc_compat_7_0[] = {}; const size_t pc_compat_7_0_len = G_N_ELEMENTS(pc_compat_7_0); diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 637367dc5f..b34c664ff5 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -289,14 +289,6 @@ extern const size_t pc_compat_1_5_len; extern GlobalProperty pc_compat_1_4[]; extern const size_t pc_compat_1_4_len; -/* Helper for setting model-id for CPU models that changed model-id - * depending on QEMU versions up to QEMU 2.4. - */ -#define PC_CPU_MODEL_IDS(v) \ - { "qemu32-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\ - { "qemu64-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\ - { "athlon-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, }, - #define DEFINE_PC_MACHINE(suffix, namestr, initfn, optsfn) \ static void pc_machine_##suffix##_class_init(ObjectClass *oc, void *data) \ { \ From patchwork Thu May 5 16:17:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1627034 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=jTz3dPVu; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvKGl3CrPz9sBF for ; Fri, 6 May 2022 02:41:51 +1000 (AEST) Received: from localhost ([::1]:39016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmeXz-0003az-Oz for incoming@patchwork.ozlabs.org; Thu, 05 May 2022 12:41:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmeBP-00023H-Dm; Thu, 05 May 2022 12:18:27 -0400 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:39792) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmeBN-0005jF-OG; Thu, 05 May 2022 12:18:27 -0400 Received: by mail-ed1-x534.google.com with SMTP id g20so5792667edw.6; Thu, 05 May 2022 09:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HsMzqxxFgcsYDTbmG5oH5cAAX9q04Igy6hB+pLUCwIg=; b=jTz3dPVutTAIAOQp8siWGrXdqlikyh42Q3AU9pId8WGxycIC0WFIRZuqQVW9F5ejCP 1NjGltRaySoCsKyH/NAx2IViW54M63Pl95v8Wu22Kgi5KEVBLw65TSJmqDF3Z26N+Cny VJ5C/jNSsT7k99X4LjpE1O73awM7G7OKn5rhPD94Y/j8zbzEWGs9N4YokF+esYhh/WaV nTEO9b9kMVicSS8UgPGkxoHvPd+dvE66cIGd68U5t+x6M478Zy4mdbYHMVxW7NS40oeJ 7G+2obwAaannxsEWHKVKUbLlrSSxDDiG4UNf4FUZoJT+u6U3Xb3EgVquX8v/yTaiJ7FQ p70w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HsMzqxxFgcsYDTbmG5oH5cAAX9q04Igy6hB+pLUCwIg=; b=LfWssNv3w5csaEdv99dpVY6Y1GCDYSekmNppgZjBAWW0bmsdQLZZnnUccKkc7w1bUj CR77JCOjC87AfldZf5tP3qBuloXfakmOOmu7AmWW7pCXslj826ShHYx/xoOE4Y5Q9dQh j8PBMqnvtyJAC3xqyoZXQAiDSSGxdCnCcZdwgEXJK0IAF4abKEcrkKzitaUL9vxIPMJq 1uwvSwWoRkvjtn2fQNC92fdCzo6HraimliiPKWeAt9Ur4+ZIT3xVUI+tqiQD7u6lAq6q k3VzQqs9uKlNByXijz/YD4TILgEy7xIxiHpQBp+l8mkEdVD8TZ+4IxG1+0o+ULt6rRvk oX/g== X-Gm-Message-State: AOAM532Brl1UxTWlk5sggjzfCC5WEi8YgU4HxaALsaRxZqn/ONWNStoj CWxyMLVXWa3Z4A6FznPwelHDQpvqpy8= X-Google-Smtp-Source: ABdhPJx0HLlzS39qLSKJSDNT/l1g96G3g+U6aVGATT8HnUyIIZPb1qYhR/whsSCrQRMauep5SmHNTA== X-Received: by 2002:a50:fb83:0:b0:425:cb1f:dc57 with SMTP id e3-20020a50fb83000000b00425cb1fdc57mr30949021edq.150.1651767503662; Thu, 05 May 2022 09:18:23 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-054-123-159.78.54.pool.telefonica.de. [78.54.123.159]) by smtp.gmail.com with ESMTPSA id i6-20020a17090685c600b006f3ef214dcfsm868542ejy.53.2022.05.05.09.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 09:18:23 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost Subject: [PATCH 05/11] hw/i386/pc: Unexport functions used only internally Date: Thu, 5 May 2022 18:17:59 +0200 Message-Id: <20220505161805.11116-6-shentey@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220505161805.11116-1-shentey@gmail.com> References: <20220505161805.11116-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=shentey@gmail.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Bernhard Beschow --- hw/i386/pc.c | 4 ++-- include/hw/i386/pc.h | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index c2975d7de5..789fe9afdc 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -569,7 +569,7 @@ static const char * const fdc_container_path[] = { * Locate the FDC at IO address 0x3f0, in order to configure the CMOS registers * and ACPI objects. */ -ISADevice *pc_find_fdc0(void) +static ISADevice *pc_find_fdc0(void) { int i; Object *container; @@ -713,7 +713,7 @@ static const int ne2000_io[NE2000_NB_MAX] = { 0x300, 0x320, 0x340, 0x360, 0x280, 0x380 }; static const int ne2000_irq[NE2000_NB_MAX] = { 9, 10, 11, 3, 4, 5 }; -void pc_init_ne2k_isa(ISABus *bus, NICInfo *nd) +static void pc_init_ne2k_isa(ISABus *bus, NICInfo *nd) { static int nb_ne2k = 0; diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index b34c664ff5..a087ea7598 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -168,7 +168,6 @@ void pc_basic_device_init(struct PCMachineState *pcms, ISADevice **rtc_state, bool create_fdctrl, uint32_t hpet_irqs); -void pc_init_ne2k_isa(ISABus *bus, NICInfo *nd); void pc_cmos_init(PCMachineState *pcms, BusState *ide0, BusState *ide1, ISADevice *s); @@ -179,8 +178,6 @@ typedef void (*cpu_set_smm_t)(int smm, void *arg); void pc_i8259_create(ISABus *isa_bus, qemu_irq *i8259_irqs); -ISADevice *pc_find_fdc0(void); - /* port92.c */ #define PORT92_A20_LINE "a20" From patchwork Thu May 5 16:18:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1627036 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=pcdpqXJ8; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvKN85mXXz9sBF for ; Fri, 6 May 2022 02:46:32 +1000 (AEST) Received: from localhost ([::1]:48442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmecY-00017C-EG for incoming@patchwork.ozlabs.org; Thu, 05 May 2022 12:46:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmeBP-00023X-I6; Thu, 05 May 2022 12:18:27 -0400 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]:46792) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmeBN-0005i6-Rp; Thu, 05 May 2022 12:18:27 -0400 Received: by mail-ej1-x62a.google.com with SMTP id j6so9656119ejc.13; Thu, 05 May 2022 09:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MEkiF45uG0tcJHA4L/93sG9+aM2PpilRQO/AdqVmaNU=; b=pcdpqXJ8iC8QpqlZeY+Tr8Aiva5pGdiIar8BZkFwn40rVJKXuFuLlUySXqgFSEt617 pVxCiZE33GAEyWd+UFKQlPDMxaWpZEupipdTXm9pz50qP+Pi8SEYtg1mUXfT+WNOgf/M 3elgPGlBhYeJlZBfR4geXzHTcNxdsOPgRvhBaoRRkgtcGurVFA6VMhgHRZ0hjX1E29tv BB2IY2ULh3FGnP3/xAMoD0+yCpMU5lOPWCE0wyM4CQHOQtGhfDU1EZart/J20mQqlLOR pm8k5RTz50ce1x2JQhTqcyEXBJwA9rmRGte02i1JkzHua9tBks+fvxzmryKLrvI3jhIX bq7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MEkiF45uG0tcJHA4L/93sG9+aM2PpilRQO/AdqVmaNU=; b=QdQvGTH3zrlSujuqsQ0YBus3QPObIlq5wbeH+ITo4rKUQImYnsqBfIxknUsmQHPgcs v0cF/yahuNnehSsDh8OrFTYQF2gHjttMi+aQj3evHMirASiQb55/vsjPmxY+oVEVr13Z 7+01QNH3mDBkunhU+SeJKcBdmLWUIetZP8P7rhHq7Aemt2gfMdwLaAz/0LpJj6sTKzoa rqer8jnSZ9gU3OJyOXm6eKPp8KdV55rQ8higN9OIiTxzrhMjsVaZbKkbRAi+bJpn33Jk b97iwKb47Sxcvd10ftWlU/tu7q5I2d3HaGKBzVW9h5PaZlSeqeSrVJbKB5+H9NFXioNW 0yTA== X-Gm-Message-State: AOAM532lsi7SDJ6QLZxe2+/jM15sc2IF2wIs7bBzd9kaXaXE7nXY1SRC ZsY9KIg+WSNVHkwdk3LmYWDOekIXhoA= X-Google-Smtp-Source: ABdhPJyVqIV5yRyA/vUAfVLAgIXvCb33+LACCdlIJNrlTh0rtAN4Ff0Dxh503XMFSU4+R7MoHJR/RA== X-Received: by 2002:a17:907:7f2a:b0:6f4:a358:c826 with SMTP id qf42-20020a1709077f2a00b006f4a358c826mr12655332ejc.404.1651767504570; Thu, 05 May 2022 09:18:24 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-054-123-159.78.54.pool.telefonica.de. [78.54.123.159]) by smtp.gmail.com with ESMTPSA id i6-20020a17090685c600b006f3ef214dcfsm868542ejy.53.2022.05.05.09.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 09:18:24 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , "Michael S. Tsirkin" , Marcel Apfelbaum Subject: [PATCH 06/11] hw/i386/pc: Remove orphan declarations Date: Thu, 5 May 2022 18:18:00 +0200 Message-Id: <20220505161805.11116-7-shentey@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220505161805.11116-1-shentey@gmail.com> References: <20220505161805.11116-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=shentey@gmail.com; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Bernhard Beschow --- include/hw/i386/pc.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index a087ea7598..2cd58ee0c6 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -172,9 +172,6 @@ void pc_cmos_init(PCMachineState *pcms, BusState *ide0, BusState *ide1, ISADevice *s); void pc_nic_init(PCMachineClass *pcmc, ISABus *isa_bus, PCIBus *pci_bus); -void pc_pci_device_init(PCIBus *pci_bus); - -typedef void (*cpu_set_smm_t)(int smm, void *arg); void pc_i8259_create(ISABus *isa_bus, qemu_irq *i8259_irqs); From patchwork Thu May 5 16:18:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1627023 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=d3oby60C; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvJxC4RPdz9sBF for ; Fri, 6 May 2022 02:26:39 +1000 (AEST) Received: from localhost ([::1]:39144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmeJJ-0000fC-01 for incoming@patchwork.ozlabs.org; Thu, 05 May 2022 12:26:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmeBR-00027x-Pi; Thu, 05 May 2022 12:18:34 -0400 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:40856) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmeBP-0005ju-RB; Thu, 05 May 2022 12:18:29 -0400 Received: by mail-ed1-x52a.google.com with SMTP id p18so5800840edr.7; Thu, 05 May 2022 09:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T3N5ocw7wyJjyTDsryXEF2wyCqbBVbiZiu2UEGxzxkc=; b=d3oby60CYMPot/H08C8LeATp6tAjV0OEX4I7K8IeuARphjQ6NJPhA2kFaRrNuulI3t BTXg2A02Sd4x+C7D+3Ih5Z/W2zdBpBFfti5qwEwbexwNgLQgsCCjAHoRB4ugJaLvB+4J a0Ao9mZh5/WkFkKpRgeXvIOVmXZJzTmqhje76DomG/faepUwhr5AbKwAM86JtsUR4G6E UGqynHkL0BSZQVUFD4l0TSvOgkUcSocx2GY/yIrLv+0v+lzxXO0JjCxmv+zkr1dQ5SrT eVt5D8XoNDgviCnWCUCG+HxDvAYMMV45jWQ6gSEO7jjbXnHcGhlI/1lFbl34fAKOcOaU nsBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=T3N5ocw7wyJjyTDsryXEF2wyCqbBVbiZiu2UEGxzxkc=; b=bBE0vJSXW2DD0LkjFYvd0onYxL9Go684d8X7Mshp5Qavf8utsf6gmG9eJBzLqbJLoc K3tlZaNO1uwygBQv43+itxuCl8IZMDybdhdihGEB/KAHHd0UgHWJvSJSWRvaM/qC35hx ReN3dVMQZMPlIzcW1jmcNZ4ypATNDIBnAHmLAl/l7vPwdfHSK+6BnTqjZn/anQ3utXRv WNDPVahyQOAyWbhHD/EMLiLrMiLzxj5h4RjWmw62p/rFmj/tGe7n48S2IJnQmuDWcK0R DuqjFTqB2VMxK7k05LhQsbHvH44D8K16duDxCyNC1MdD8SaRtKu+6QDvzTDuNs/j5qR9 t0OQ== X-Gm-Message-State: AOAM5327NyWsykPYFif0nCwCgqf1b52/KY+QyTnIDb5aUWTN7Q8i/Rgl //KrB9nisBqqsWcKEMNAaMjrF8gFR/A= X-Google-Smtp-Source: ABdhPJy0h8+C0scy9Y5eP95wLW/fFSPNpdii8ufdVYda1mX3y1wjO0ySPXv6jYDy0MpxLHdrKLuekA== X-Received: by 2002:a05:6402:11cd:b0:427:bf42:44ef with SMTP id j13-20020a05640211cd00b00427bf4244efmr24748369edw.336.1651767505527; Thu, 05 May 2022 09:18:25 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-054-123-159.78.54.pool.telefonica.de. [78.54.123.159]) by smtp.gmail.com with ESMTPSA id i6-20020a17090685c600b006f3ef214dcfsm868542ejy.53.2022.05.05.09.18.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 09:18:25 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , qemu-ppc@nongnu.org (open list:e500) Subject: [PATCH 07/11] hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE Date: Thu, 5 May 2022 18:18:01 +0200 Message-Id: <20220505161805.11116-8-shentey@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220505161805.11116-1-shentey@gmail.com> References: <20220505161805.11116-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=shentey@gmail.com; helo=mail-ed1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Commit 28290f37e20cda27574f15be9e9499493e3d0fe8 'PPC: E500: Generate device tree on reset' improved device tree generation and made BINARY_DEVICE_TREE_FILE obsolete. Signed-off-by: Bernhard Beschow Reviewed-by: Daniel Henrique Barboza --- hw/ppc/e500.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 2bc3dce1fb..7f7f5b3452 100644 --- a/hw/ppc/e500.c +++ b/hw/ppc/e500.c @@ -47,7 +47,6 @@ #include "hw/irq.h" #define EPAPR_MAGIC (0x45504150) -#define BINARY_DEVICE_TREE_FILE "mpc8544ds.dtb" #define DTC_LOAD_PAD 0x1800000 #define DTC_PAD_MASK 0xFFFFF #define DTB_MAX_SIZE (8 * MiB) From patchwork Thu May 5 16:18:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1627031 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=qX+qtO/9; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvK9q6MBGz9sBF for ; Fri, 6 May 2022 02:37:34 +1000 (AEST) Received: from localhost ([::1]:59696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmeTr-0006KD-9k for incoming@patchwork.ozlabs.org; Thu, 05 May 2022 12:37:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmeBS-00027y-I5; Thu, 05 May 2022 12:18:36 -0400 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]:44635) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmeBR-0005kW-23; Thu, 05 May 2022 12:18:30 -0400 Received: by mail-ej1-x62d.google.com with SMTP id i19so9676692eja.11; Thu, 05 May 2022 09:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+73gejvQMvAP3s/0y0ZZzesiuBYtND4qvienTeKqs0I=; b=qX+qtO/9UC8gRFM+SvnPkQOTfo8TZSaWF/7/BVmpn72DAaL2yag4BPJSzYix0EhzHi o2borlKy0HgALAbXPGksWM90QAJy6LFclyJRBHFMQHZHI/WZYNJx1/86XWbQWMu7STsk RLv2KV2eU6b60382ovVceaR7AgM/gTWdLCP9hUiizbBD3/0mgxqM91k0+LuMEgPXR6Te cfTUHQJbvkPHtCL0LKHD+IeGEzvu6LX88g/pH5vqLGq0Q+VFpRb0DHxjiy9qncAKF4KX O0jWSI9mE3kfRljFaN47Q0gTpcZIUECFlIHhZC1RHbUzlTD8BQWDDaP7McpXGz6g+153 NZZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+73gejvQMvAP3s/0y0ZZzesiuBYtND4qvienTeKqs0I=; b=Z8gaVNGk/cfSFVolAAIFNH5YUCeEReAaSXXpCC3qt0nttshG0WJZsNSluMNtSEJ145 aZYaJvk2w/WXrqOuz7ORsZPm15T5pOieJ76wdxypaung92gxvigJAilgfMtj/RuFvVej hzhevZFQm+VHGsaxkkjeJFCn/tDQiPNBgRudV+Gx1u3X2Wlcuh2GG8avHhXCUohn5meP /Sv64ZjuxvUtFkZ858KLINT/4jte1lx/BkvzbO7B0+cL8CWRMlr/o/jCfaSxpzF82Y24 NR4RXiJyhusfRWM/RRDW5bXNVE6resMvUSm+8V3Uc6rkD+9lD2pFI6usxsoOHmn6R1qD kB3A== X-Gm-Message-State: AOAM531v55vp5/Uopr7aJzwCo+3U5futiVs3BgnxBbHgD9jMxZ+Dt3c3 95vqWm8SG9G9tPy8z5BuSdLTAqPER7Y= X-Google-Smtp-Source: ABdhPJybzMHvKvGRuZnYJDJuXJhkFapGAn67U4Z3oUZ5QWQzXaVIvHsTP6Lb8AC3UfQEY0S5Jq9vwg== X-Received: by 2002:a17:907:97d5:b0:6f5:405:ef01 with SMTP id js21-20020a17090797d500b006f50405ef01mr2368287ejc.551.1651767506760; Thu, 05 May 2022 09:18:26 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-054-123-159.78.54.pool.telefonica.de. [78.54.123.159]) by smtp.gmail.com with ESMTPSA id i6-20020a17090685c600b006f3ef214dcfsm868542ejy.53.2022.05.05.09.18.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 09:18:26 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , Jason Wang , qemu-ppc@nongnu.org (open list:e500) Subject: [PATCH 08/11] hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create() Date: Thu, 5 May 2022 18:18:02 +0200 Message-Id: <20220505161805.11116-9-shentey@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220505161805.11116-1-shentey@gmail.com> References: <20220505161805.11116-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=shentey@gmail.com; helo=mail-ej1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" etsec_create() wraps qdev API which is outdated. It is also unused, so remove it. Signed-off-by: Bernhard Beschow --- hw/net/fsl_etsec/etsec.c | 23 ----------------------- hw/net/fsl_etsec/etsec.h | 7 ------- 2 files changed, 30 deletions(-) diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c index 6d50c39543..24deb47cff 100644 --- a/hw/net/fsl_etsec/etsec.c +++ b/hw/net/fsl_etsec/etsec.c @@ -443,26 +443,3 @@ static void etsec_register_types(void) } type_init(etsec_register_types) - -DeviceState *etsec_create(hwaddr base, - MemoryRegion * mr, - NICInfo * nd, - qemu_irq tx_irq, - qemu_irq rx_irq, - qemu_irq err_irq) -{ - DeviceState *dev; - - dev = qdev_new("eTSEC"); - qdev_set_nic_properties(dev, nd); - sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); - - sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, tx_irq); - sysbus_connect_irq(SYS_BUS_DEVICE(dev), 1, rx_irq); - sysbus_connect_irq(SYS_BUS_DEVICE(dev), 2, err_irq); - - memory_region_add_subregion(mr, base, - SYS_BUS_DEVICE(dev)->mmio[0].memory); - - return dev; -} diff --git a/hw/net/fsl_etsec/etsec.h b/hw/net/fsl_etsec/etsec.h index fddf551544..3c625c955c 100644 --- a/hw/net/fsl_etsec/etsec.h +++ b/hw/net/fsl_etsec/etsec.h @@ -155,13 +155,6 @@ OBJECT_DECLARE_SIMPLE_TYPE(eTSEC, ETSEC_COMMON) #define eTSEC_TRANSMIT 1 #define eTSEC_RECEIVE 2 -DeviceState *etsec_create(hwaddr base, - MemoryRegion *mr, - NICInfo *nd, - qemu_irq tx_irq, - qemu_irq rx_irq, - qemu_irq err_irq); - void etsec_update_irq(eTSEC *etsec); void etsec_walk_tx_ring(eTSEC *etsec, int ring_nbr); From patchwork Thu May 5 16:18:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1627024 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=mGOtyPyx; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvK3B6VRbz9sBF for ; Fri, 6 May 2022 02:31:49 +1000 (AEST) Received: from localhost ([::1]:47708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmeOH-0006Y2-Kf for incoming@patchwork.ozlabs.org; Thu, 05 May 2022 12:31:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmeBT-00027z-9u; Thu, 05 May 2022 12:18:36 -0400 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:46865) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmeBR-0005kq-Qm; Thu, 05 May 2022 12:18:31 -0400 Received: by mail-ed1-x52e.google.com with SMTP id g23so5789173edy.13; Thu, 05 May 2022 09:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=97XDoGXF8ui7gYguRxMIJDkZD5oW/orGdMFAxRwFGnY=; b=mGOtyPyxMTHSW0IA88ez1nV+WDhnuTPBCSmslnflOR4EiRZMvfXnbHHVRijy+UwRf2 LT/hFWuQcetaXkVYddYPbYPHTNw23Ij03saVSIyzoonkqyNenAgkL5YV64BTCSAsnSq/ pXIt045SnkTODFbTMTpnCeikhXh+HevzdPQPsdI6XCdX/i8q1VfoTE9Rd0XGvCsgwYPP mT7B2l7T2U+mDHLuTd07Yy+WuwRIDa9f/7NB5CP75GWdPcObS2RoqcON10uPWQk7aTiV gI8pl/n7vb6HGpY134g/ophulmX2TUZvTYUkVK0NFCVGGgOMJX0bfULzkdhCAPwLmRVO /n/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=97XDoGXF8ui7gYguRxMIJDkZD5oW/orGdMFAxRwFGnY=; b=rRVn5XH1Bk67srst7OssGt1MedthnKC6Z08EIIF8iKLDIemnQeWa0jMOFjVQCpx/SI rBAgRF1d0AFOSNZZdMtzL74EHOG5r8aTEL36RPkPXuXBB4pNr1uIu9pocmXNGO8nRXB+ DY7G89M5sDCV49VgBzhpYikYyEALmimmAR8QxZ4+Uz3nJ3fJ8NzMiwiOJosN42baebRw /Ymi+RFgabHJ/Qcg0elZ18Jmu3qbwibqzwmDf1nTW1pZyDNoFqMgD02NuKHAWMWK4M0E zIzfuLVBxdars/AwuCdu6jmoBtqZ5NxL9eWBsQb8QD9jbxhFMMEG4ivSGh6iSxpRyveY 2HPg== X-Gm-Message-State: AOAM532i8lwDxonZuQLgJvkparbO0LpfkIvdlUnrYgcHlWg6cFDALozZ NmxzLhCL5X5ronTSnIiA5tw0a+opy4M= X-Google-Smtp-Source: ABdhPJzVQ2lRvObH/BkCHFg/IcL9CGRfogXyDEux2AYlHwfjP8OnFYwzvg4HRO2TbU5fR6sr+8v1mg== X-Received: by 2002:aa7:c849:0:b0:427:d464:e66f with SMTP id g9-20020aa7c849000000b00427d464e66fmr19965123edt.411.1651767507619; Thu, 05 May 2022 09:18:27 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-054-123-159.78.54.pool.telefonica.de. [78.54.123.159]) by smtp.gmail.com with ESMTPSA id i6-20020a17090685c600b006f3ef214dcfsm868542ejy.53.2022.05.05.09.18.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 09:18:27 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , Richard Henderson , Paolo Bonzini Subject: [PATCH 09/11] accel/tcg/cpu-exec: Unexport dump_drift_info() Date: Thu, 5 May 2022 18:18:03 +0200 Message-Id: <20220505161805.11116-10-shentey@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220505161805.11116-1-shentey@gmail.com> References: <20220505161805.11116-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::52e; envelope-from=shentey@gmail.com; helo=mail-ed1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Commit 3a841ab53f165910224dc4bebabf1a8f1d04200c 'qapi: introduce x-query-jit QMP command' basically moved the only function using dump_drift_info() to cpu-exec.c. Therefore, dump_drift_info() doesn't need to be exported any longer. Signed-off-by: Bernhard Beschow --- accel/tcg/cpu-exec.c | 2 +- include/exec/cpu-all.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 635aeecc0a..7cbf9996b7 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -1048,7 +1048,7 @@ void tcg_exec_unrealizefn(CPUState *cpu) #ifndef CONFIG_USER_ONLY -void dump_drift_info(GString *buf) +static void dump_drift_info(GString *buf) { if (!icount_enabled()) { return; diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index 5d5290deb5..9a716be80d 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -419,8 +419,6 @@ static inline bool tlb_hit(target_ulong tlb_addr, target_ulong addr) } #ifdef CONFIG_TCG -/* accel/tcg/cpu-exec.c */ -void dump_drift_info(GString *buf); /* accel/tcg/translate-all.c */ void dump_exec_info(GString *buf); void dump_opcount_info(GString *buf); From patchwork Thu May 5 16:18:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1627028 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=AL6fSrg7; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvK6h6vBvz9sBF for ; Fri, 6 May 2022 02:34:52 +1000 (AEST) Received: from localhost ([::1]:56316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmeRG-00045G-Oy for incoming@patchwork.ozlabs.org; Thu, 05 May 2022 12:34:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmeBU-00028B-IC; Thu, 05 May 2022 12:18:36 -0400 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]:38745) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmeBS-0005lK-TA; Thu, 05 May 2022 12:18:32 -0400 Received: by mail-ej1-x630.google.com with SMTP id n10so9706199ejk.5; Thu, 05 May 2022 09:18:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OBni9ZUFXG91vLe7sySYRIw20wTNmuqnX6QYDs/955Q=; b=AL6fSrg7LWp41pQYcA4jxZ+w0VV1CzJ96ZnfRVilV7ip+dqb9ssmIop5qp42/9GWmf 3FZxGcmkRPmnE7PpdZ8ZdaT0aUzI67C/C6M/RXSAVsVInBt1bKuA/eH50BsyILWzvH/D Xudf5e3aZ9xZsAIyb/JznyKRybr7hGGj1ufyfiXZzo6T1I+ebLsJTjfKhtXjJkZnvddG jem3Gm2lfS+pxR7yLZ66XMVe2ciye0zZkc9AWV6KSA2UEnTDWMIBMeUK/FBPu76+EBXG czbNvG/WgZY9dGQLbu0YplknWUiTrQQ3w93/+6VmD5tJVk1DsRsEOAXjc+Q5GH6zMoRy KBwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OBni9ZUFXG91vLe7sySYRIw20wTNmuqnX6QYDs/955Q=; b=bRhesFmRiGkm1gS7c+arCjZ1eSLb6GKCm0lAYujr3TG7fWsJ3Oixpx3WD2tSvWX86f N6Qh8HTK3M3KPdzLz0W4Ctd80WgbHLj+BWgrmjd5/fAPkv31Xfnnhp+HHXqa59bfVr1e XxOSrm08QLEl52d6k9vKh2SY0IBIratqPeGKpcvzNnFL4niMhPAXGDUFWcU2OPSLtfXk v0sCChlgktplOi5fMD+JXTa3ESXPhnV1UWT5UauvVVWO4IqvkhZmnCnMOYGolHewjKF7 sk2lIKlAhF2tX3nkzf8YSYwmiSHKpJsIwEac/WuSvvbx5tYOJDig+O2lGlkF/tWsDGWj MNBQ== X-Gm-Message-State: AOAM5318EvK+KYW1bxmkv29gr6pN/sOrNmDYBYVBALF1uX8O0wIfkheO vBDDrEwCYLOSlaXFb3+YZQybv60agqg= X-Google-Smtp-Source: ABdhPJwY3a67m4Y7aGnUVSu0KbS6HmCPdKgi42AOmxmGO/Wpe7xWiALDfATwgGUPPTxKXE7HFTnkfA== X-Received: by 2002:a17:906:9b96:b0:6f5:cdd:9bf2 with SMTP id dd22-20020a1709069b9600b006f50cdd9bf2mr1124868ejc.364.1651767509081; Thu, 05 May 2022 09:18:29 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-054-123-159.78.54.pool.telefonica.de. [78.54.123.159]) by smtp.gmail.com with ESMTPSA id i6-20020a17090685c600b006f3ef214dcfsm868542ejy.53.2022.05.05.09.18.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 09:18:28 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , Richard Henderson , Paolo Bonzini Subject: [PATCH 10/11] accel/tcg: Inline dump_opcount_info() and remove it Date: Thu, 5 May 2022 18:18:04 +0200 Message-Id: <20220505161805.11116-11-shentey@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220505161805.11116-1-shentey@gmail.com> References: <20220505161805.11116-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::630; envelope-from=shentey@gmail.com; helo=mail-ej1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" dump_opcount_info() is a one-line wrapper around tcg_dump_op_count() which is also exported. So use the latter directly. Signed-off-by: Bernhard Beschow --- accel/tcg/cpu-exec.c | 2 +- accel/tcg/translate-all.c | 5 ----- include/exec/cpu-all.h | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 7cbf9996b7..a565a3f8ec 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -1091,7 +1091,7 @@ HumanReadableText *qmp_x_query_opcount(Error **errp) return NULL; } - dump_opcount_info(buf); + tcg_dump_op_count(buf); return human_readable_text_from_str(buf); } diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 291034cb09..8fd23a9d05 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -2124,11 +2124,6 @@ void dump_exec_info(GString *buf) tcg_dump_info(buf); } -void dump_opcount_info(GString *buf) -{ - tcg_dump_op_count(buf); -} - #else /* CONFIG_USER_ONLY */ void cpu_interrupt(CPUState *cpu, int mask) diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index 9a716be80d..f5bda2c3ca 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -421,7 +421,6 @@ static inline bool tlb_hit(target_ulong tlb_addr, target_ulong addr) #ifdef CONFIG_TCG /* accel/tcg/translate-all.c */ void dump_exec_info(GString *buf); -void dump_opcount_info(GString *buf); #endif /* CONFIG_TCG */ #endif /* !CONFIG_USER_ONLY */ From patchwork Thu May 5 16:18:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1627032 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=H1N+6wy7; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvKFv4mVXz9sBF for ; Fri, 6 May 2022 02:41:07 +1000 (AEST) Received: from localhost ([::1]:37344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmeXJ-0002LL-3q for incoming@patchwork.ozlabs.org; Thu, 05 May 2022 12:41:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmeBV-00028E-LP; Thu, 05 May 2022 12:18:38 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:34412) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmeBT-0005lW-Vl; Thu, 05 May 2022 12:18:33 -0400 Received: by mail-ej1-x633.google.com with SMTP id g6so9714365ejw.1; Thu, 05 May 2022 09:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G1Ct2U+bQ3kGVUW9fsOA/lzpDAuaaKB4V0L6OSmysTo=; b=H1N+6wy7JPNGBxie9cnUCOtEstg0WknQv82ajmxWT+PTlRdtqB5ckykmKU9cEGs/sh /fWpAIvfPcXrp9g8Ftzw3oZhaRbh2UIbORe57nhGco1YNiLG2D7OXBIZOE9cTuzS0Le4 396Dj0zVu3AlSf+SBFyoAytDHYKcEYigl9Y/kQdxcNXYdG2UEj0l1tHfNelffKkRaM7L ZHzzmBXtKOltIyaruir1EOIkABk1aFNQsuYoCxCrSeD+2zvSpmmyta1g42sgYjiX5d63 FrKYG3J0e9NpwW7Op3HiBbKJ0UXrkIrYjPKW6OmEGltnbY/gvl70V0KzAQBvuzFEUwhQ gUtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G1Ct2U+bQ3kGVUW9fsOA/lzpDAuaaKB4V0L6OSmysTo=; b=Xm/a3Zq/5PhUbjpOl+hZvNTzvDj7RG7ruBfku9bRka5X8eAf8eVd44NXekQKm/YMS3 NoSdW7zY3Q7UKbx/UNL/Q6yTE7q22xFidUuJy/ZxFTsOUyV6UgUNML5BI8bw76cmYb8C sz96b1y7txA702ljA/ved2gC+7tIrOOBAXXuq+hbrCGcZraO6lXQGX5BcxG/AZdATTzn QNUgQlkS0tJkAMq/yd2ROGHwiLHiH8jFzv1pt5nMC13TKt1r5Yxk0JewGlBbINshsobB JlYe04NzZghW4MSIWu1ZkkuIK4NzY3yhWSrzHupRceuBb2HaDVVuNFqxz5Tzw+bu/jcv SnYQ== X-Gm-Message-State: AOAM533lAcFb6kqTYRK1REF3MWRDP0fYcdC5S357NQz0vl7pV1EYoHBL Avp9cCX8l7lNA6LGJhaTlHJ0SKgu+ko= X-Google-Smtp-Source: ABdhPJx8ON40EToetEO9Ws02IJUvTEPAtH10gYn/Qqm55eTLv/YNfSfsppNJihbXL2WR8tnPLuchpA== X-Received: by 2002:a17:906:2991:b0:6cf:6b24:e92f with SMTP id x17-20020a170906299100b006cf6b24e92fmr27141434eje.748.1651767509913; Thu, 05 May 2022 09:18:29 -0700 (PDT) Received: from Provence.localdomain (dynamic-078-054-123-159.78.54.pool.telefonica.de. [78.54.123.159]) by smtp.gmail.com with ESMTPSA id i6-20020a17090685c600b006f3ef214dcfsm868542ejy.53.2022.05.05.09.18.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 09:18:29 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , qemu-stable@nongnu.org Subject: [PATCH 11/11] docs/devel: Fix link to developer mailing lists Date: Thu, 5 May 2022 18:18:05 +0200 Message-Id: <20220505161805.11116-12-shentey@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220505161805.11116-1-shentey@gmail.com> References: <20220505161805.11116-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=shentey@gmail.com; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Ammends commit 9f73de8df0335c9387f4ee39e207a65a1615676f 'docs: rSTify the "SubmitAPatch" wiki'. Cc: qemu-stable@nongnu.org Signed-off-by: Bernhard Beschow --- docs/devel/submitting-a-patch.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst index e51259eb9c..21ed52bd82 100644 --- a/docs/devel/submitting-a-patch.rst +++ b/docs/devel/submitting-a-patch.rst @@ -18,9 +18,9 @@ one-shot fix, the bare minimum we ask is that: `__ policy.) ``git commit -s`` or ``git format-patch -s`` will add one. - All contributions to QEMU must be **sent as patches** to the - qemu-devel `mailing list `__. Patch contributions - should not be posted on the bug tracker, posted on forums, or - externally hosted and linked to. (We have other mailing lists too, + qemu-devel `mailing list `__. + Patch contributions should not be posted on the bug tracker, posted on + forums, or externally hosted and linked to. (We have other mailing lists too, but all patches must go to qemu-devel, possibly with a Cc: to another list.) ``git send-email`` (`step-by-step setup guide `__ and `hints and