From patchwork Wed Sep 22 08:44:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 1531231 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=CXkHPD76; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org; receiver=) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4HDypy06xlz9sCD for ; Wed, 22 Sep 2021 22:51:38 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HDypx5nVqz3bjP for ; Wed, 22 Sep 2021 22:51:37 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=CXkHPD76; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=canonical.com (client-ip=185.125.188.123; helo=smtp-relay-internal-1.canonical.com; envelope-from=krzysztof.kozlowski@canonical.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=CXkHPD76; dkim-atps=neutral Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HDsLM1TcFz2yPx for ; Wed, 22 Sep 2021 18:44:57 +1000 (AEST) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 75C433F226 for ; Wed, 22 Sep 2021 08:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632300291; bh=uiMxeL0gXr2dTqfDCAVU08QHmTYD3WPNowiXOrxuH3E=; h=From:To:Subject:Date:Message-Id:MIME-Version:Content-Type; b=CXkHPD764IYmuAL2vO4sv/f7MV8ZmfEaRpKD9SZFid0nmfO16vrFxeTJvEF/U3MHn t1IdXNCDmFk7oQX0NREXTwXGmKccQUg/qVoW8rHim1mrVosTxfPmLyOrqvbiISK1y4 EGtLUF7o5oxd5QkwIAy1R1IRmfFyul2BKR7qRpP9/Sz/P//6G9gKS+IIg6MbgDw3Pm k8FupMp7JZ/17DWL8c6kN75XXKrFaQEH9l52mZqMDQhUcm7w0fVCFyVLgX+JymGx69 /S4sfjug/DIazjK6beKGG8YflHkhgK1+V3DyXn68APY/mNU1zLye3am/aWTvyrURKT dJUPPVJR7HwvQ== Received: by mail-wr1-f69.google.com with SMTP id r7-20020a5d6947000000b0015e0f68a63bso1438344wrw.22 for ; Wed, 22 Sep 2021 01:44:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=uiMxeL0gXr2dTqfDCAVU08QHmTYD3WPNowiXOrxuH3E=; b=Ky/wy891BMh8GxOnKXaLd27HIyDLQXbtfGbDOfscIcerby59H2fkqvAgP+ROKVc6HS Es6/oElpAeBsRla2VzwtmYpUeDSR54QkVrZ7ivD6+03ZjnnQl3gg3x+YUI2uKKDEY9kl r5hjQvvokbCcxU0GfKU1REwasvQbhQat7o29G7MiRIy9+tfqRzNkRUN2EwaE3rbYgTd4 EZKAxFE1Qt79xOmmNa0KN129VB1B3N6g+/JNvB3LvAmGXa0utotnEdcMMKKyWgTNzpN5 CmfiDKWKky0IDxPJqKUH1or43krokZQPEN9h/q4CU3YMTvNuYFJvq/eAFEH8QthZuZx3 87KQ== X-Gm-Message-State: AOAM533qaD9gzuKQUEuHNTQvVTpbUPJvAXw3LxN7BFA8Z7eOcJp52uFP dgzefvYxj5J/w5vFHDE76AjyVb/za7lUZXCQHSeqLdXdCcbnKCxnoqUlJ9/kbxIsEOoiox5BJXh 4hacJWAQe5A4j9mKphkf+4xLxdcG1J4pC2zQinQIXlwI= X-Received: by 2002:a05:600c:35d0:: with SMTP id r16mr9039080wmq.26.1632300290701; Wed, 22 Sep 2021 01:44:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyC680U0RwyaOjK1SOsZp30UKUvzdNakgqk61+QjWsbjiDhpXDKy1rZwHZZ9P4p0zlY3hcaFA== X-Received: by 2002:a05:600c:35d0:: with SMTP id r16mr9039063wmq.26.1632300290511; Wed, 22 Sep 2021 01:44:50 -0700 (PDT) Received: from localhost.localdomain (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id o7sm1851490wro.45.2021.09.22.01.44.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Sep 2021 01:44:50 -0700 (PDT) From: Krzysztof Kozlowski To: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Rob Herring , Frank Rowand , Krzysztof Kozlowski , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [RESEND PATCH 1/2] powerpc/powermac: add missing g5_phy_disable_cpu1() declaration Date: Wed, 22 Sep 2021 10:44:14 +0200 Message-Id: <20210922084415.18269-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 22 Sep 2021 22:50:26 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" g5_phy_disable_cpu1() is used outside of platforms/powermac/feature.c, so it should have a declaration to fix W=1 warning: arch/powerpc/platforms/powermac/feature.c:1533:6: error: no previous prototype for ‘g5_phy_disable_cpu1’ [-Werror=missing-prototypes] Signed-off-by: Krzysztof Kozlowski --- arch/powerpc/include/asm/pmac_feature.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/powerpc/include/asm/pmac_feature.h b/arch/powerpc/include/asm/pmac_feature.h index e08e829261b6..7703e5bf1203 100644 --- a/arch/powerpc/include/asm/pmac_feature.h +++ b/arch/powerpc/include/asm/pmac_feature.h @@ -143,6 +143,10 @@ */ struct device_node; +#ifdef CONFIG_PPC64 +void g5_phy_disable_cpu1(void); +#endif /* CONFIG_PPC64 */ + static inline long pmac_call_feature(int selector, struct device_node* node, long param, long value) { From patchwork Wed Sep 22 08:44:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 1531230 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=Yv+TYoT/; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org; receiver=) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4HDypC38HXz9sCD for ; Wed, 22 Sep 2021 22:50:59 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HDypC23xVz305f for ; Wed, 22 Sep 2021 22:50:59 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=Yv+TYoT/; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=canonical.com (client-ip=185.125.188.123; helo=smtp-relay-internal-1.canonical.com; envelope-from=krzysztof.kozlowski@canonical.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=Yv+TYoT/; dkim-atps=neutral Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HDsLM1QXRz2yHS for ; Wed, 22 Sep 2021 18:44:58 +1000 (AEST) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 370FA4025C for ; Wed, 22 Sep 2021 08:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632300292; bh=z8fZpvZ//AsliWlBk6ZI/8MtJW2aVmSD5QrohcqQ3Yg=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Yv+TYoT/vfF6FFIa9Wd6PsSFGharJyKvrM22BnVqpFtZ9zqZVglPMuY9zEE3tvDcI 5z9hMpu0i+cB8nfDUotXlba9kgOtX1tPEdcw067fJy2W2QQoMH56I1o7N4lfHVqb7Y TiRF+55OT1Ju4EDdiGeaa8S4vdLtJdgFuxI1v7a7Qm4+ZIANAcGuQxYCFeYsrEtcgO p2vilOLY/BjLJB3F1MKhgsxkbxryq6EzAgGzwWdhutEunhJp4AHL2cf9CDzmE8VWe4 02vb531iodh4Yay2b5fFfHPRsgxV+9ryC0A9XfKbwJgK3f8Ip0uoDZRAaLXJTXHC4c 27WxRQm/v2tEQ== Received: by mail-wr1-f72.google.com with SMTP id s13-20020a5d69cd000000b00159d49442cbso1464173wrw.13 for ; Wed, 22 Sep 2021 01:44:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z8fZpvZ//AsliWlBk6ZI/8MtJW2aVmSD5QrohcqQ3Yg=; b=NNiVaHaRooZeqCD9OL7nbS9Abq3rWwyxR0j+v6r/WD9aBoQUzOvToJz/f59S9fNThm PmECNI7qUCv/zKTPpNtrpZufJy4eBtzMxvNKDL0ZviqL4DO3rv+S6Uws9hMVN5/YVN99 cOvscGWh4s50ka3Fy2/cb5S53MLGyYTkGSXWZo0r3x+s77+aS+ZlrvwSM7zrp/Nnrf8x 49E506Jlg/snDRzdZy3PwDrKO4EMIStMHilhPf6BiPD0vuCwy0A00gHzdEX7qwvsJTIi jhsPgkG98n5MZyYiSP8bNQAOQ+odEDXikkH69e1pFvAgITlwW3c4QXb0iXFPMmAH/VCU zgsw== X-Gm-Message-State: AOAM531r37sxuckAtspaKHa0DPcDMda+DLre6fVG6wVIXUWNEWwcqKLC s/eLsQtixxdDLVJwWtmxz5LQDHAfezuY5WYlY4SSfFbR9wGHI8KSl+3duk0Rdo2gGSxEgcSDEP6 msyWPB5BC4kLuPm0A04O9wKch6bEaLyg3Gvs0fuCczOk= X-Received: by 2002:adf:8b19:: with SMTP id n25mr43049486wra.216.1632300291867; Wed, 22 Sep 2021 01:44:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOzt5CWBoWaHmRLpJDmTWsqixtsWYMLhwi8nFJSalUAu/s/IlJpD6Al6BX4ejH9Ir7BxkZGA== X-Received: by 2002:adf:8b19:: with SMTP id n25mr43049468wra.216.1632300291674; Wed, 22 Sep 2021 01:44:51 -0700 (PDT) Received: from localhost.localdomain (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id o7sm1851490wro.45.2021.09.22.01.44.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Sep 2021 01:44:51 -0700 (PDT) From: Krzysztof Kozlowski To: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Rob Herring , Frank Rowand , Krzysztof Kozlowski , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [RESEND PATCH 2/2] powerpc/powermac: constify device_node in of_irq_parse_oldworld() Date: Wed, 22 Sep 2021 10:44:15 +0200 Message-Id: <20210922084415.18269-2-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210922084415.18269-1-krzysztof.kozlowski@canonical.com> References: <20210922084415.18269-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 22 Sep 2021 22:50:26 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" The of_irq_parse_oldworld() does not modify passed device_node so make it a pointer to const for safety. Signed-off-by: Krzysztof Kozlowski --- arch/powerpc/platforms/powermac/pic.c | 2 +- include/linux/of_irq.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/powermac/pic.c b/arch/powerpc/platforms/powermac/pic.c index 4921bccf0376..af5ca1f41bb1 100644 --- a/arch/powerpc/platforms/powermac/pic.c +++ b/arch/powerpc/platforms/powermac/pic.c @@ -384,7 +384,7 @@ static void __init pmac_pic_probe_oldstyle(void) #endif } -int of_irq_parse_oldworld(struct device_node *device, int index, +int of_irq_parse_oldworld(const struct device_node *device, int index, struct of_phandle_args *out_irq) { const u32 *ints = NULL; diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h index aaf219bd0354..6074fdf51f0c 100644 --- a/include/linux/of_irq.h +++ b/include/linux/of_irq.h @@ -20,12 +20,12 @@ typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *); #if defined(CONFIG_PPC32) && defined(CONFIG_PPC_PMAC) extern unsigned int of_irq_workarounds; extern struct device_node *of_irq_dflt_pic; -extern int of_irq_parse_oldworld(struct device_node *device, int index, +extern int of_irq_parse_oldworld(const struct device_node *device, int index, struct of_phandle_args *out_irq); #else /* CONFIG_PPC32 && CONFIG_PPC_PMAC */ #define of_irq_workarounds (0) #define of_irq_dflt_pic (NULL) -static inline int of_irq_parse_oldworld(struct device_node *device, int index, +static inline int of_irq_parse_oldworld(const struct device_node *device, int index, struct of_phandle_args *out_irq) { return -EINVAL;