From patchwork Thu Sep 16 14:10:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1528871 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4H9Jzv6rkVz9t0J for ; Fri, 17 Sep 2021 00:16:43 +1000 (AEST) Received: from localhost ([::1]:36612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQsBt-0008JK-Oh for incoming@patchwork.ozlabs.org; Thu, 16 Sep 2021 10:16:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs6B-0000bU-LU; Thu, 16 Sep 2021 10:10:47 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:49827) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs69-0005wQ-6H; Thu, 16 Sep 2021 10:10:47 -0400 Received: from quad ([82.142.27.6]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mnqfc-1nF5I43YcM-00pNzv; Thu, 16 Sep 2021 16:10:31 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 01/10] util: Remove redundant checks in the openpty() Date: Thu, 16 Sep 2021 16:10:17 +0200 Message-Id: <20210916141026.1174822-2-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210916141026.1174822-1-laurent@vivier.eu> References: <20210916141026.1174822-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:qoiRJHOUX7QGvRdFzYCsWoV5JSgbkFmd1uvlhYZ4uobbg8F61AC wT/fqPpp7eQHf0LdVAJzfZ2s8WlM0+kmCuOQFpTBLE6IjutgrtPVpICawEbX5KGbsPzERSj 7x8aapFGuLzyU1OVvA52gP+72NNCo6U1IWrAOnnm+4k5q7NEg57u5p6RwlgLxdBYT6wtzAd e4yJLxl58RZXmZqHAGj0Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:ij9S7WU/4ks=:Y1REnu62Ht9HBlwJ2+Q8SK iUu5qg7GmPzPUrKWKVuV5U5nw/W9+TUAZv3f1ck29Hhc/SjLSuUIJCh2fpRtUxRMF1CEiWAu2 /PtcqryapPHcWdOpCxZ5FXGLnZWQEzU6yRDFFyF/CS5x//hPlAdxkzu/B20dVFVZuHHICWopm yx3YO+NvVCGkbtvjR0ldDBat8Kfv+VhHMuyXFoBIDw+80prJkwXpULifogfuwbOPuduYblKtR LHmsyrhDeu3iOdaJDzvhOt2D61UnzmGehA01X6NB00LO0UCyA/ydalpZ/ImbGm2wxJh9awtIK fTjaSVCao/3Z7a4RxhDWkM15+3yfmk/vAzrS5vztoCS/gkHEMmkbGpAc6NAY9Elf3EbuTv7tS RMLivOq8kdNIA6n3tsCaHMEzkWt9bAHY9qXd+RabDBwhxUGpiGNad1hPxZsu3xIcf8Dj8dbsn wFrRWzosuW53rQ3DBX2/s9JSAK1lkAjrUrLxUOHZI1iHyK+O/3YMfcYvy86t4fSbwnGRyPVXW VqtiScncoC3SNJm7xtldUmI4Afk1cRMTnsqdYPRhjdNqYs++VCPEr5DwzMljf2+RdEuRhcI4o DkIxTN8tdPkCxG1RiMuw7B2wZV5ORF5VfErme0Y0NWkHE+rR1jitP1WMucOKHAXRtsG+XRx3q K9YWqDtdE9rctTeYajzElyVLfR11uq3Bgg2ycc2NXt7UfO0U3Zrzq8aiyHabsS5o/hTHWg+sa Q1VvYK64JIBYmov7kE1GiHTcIS7QCPWDaqeFKg== Received-SPF: none client-ip=217.72.192.75; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , AlexChen , Euler Robot Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: AlexChen As we can see from the following function call stack, amaster and aslave can not be NULL: char_pty_open() -> qemu_openpty_raw() -> openpty(). In addition, according to the API specification for openpty(): https://www.gnu.org/software/libc/manual/html_node/Pseudo_002dTerminal-Pairs.html, the arguments name, termp and winp can all be NULL, but arguments amaster or aslave can not be NULL. Finally, amaster and aslave has been dereferenced at the beginning of the openpty(). So the checks on amaster and aslave in the openpty() are redundant. Remove them. Reported-by: Euler Robot Signed-off-by: Alex Chen Reviewed-by: Peter Maydell Message-Id: <5F9FE5B8.1030803@huawei.com> Signed-off-by: Laurent Vivier --- util/qemu-openpty.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/util/qemu-openpty.c b/util/qemu-openpty.c index eb17f5b0bcec..427f43a76973 100644 --- a/util/qemu-openpty.c +++ b/util/qemu-openpty.c @@ -80,10 +80,9 @@ static int openpty(int *amaster, int *aslave, char *name, (termp != NULL && tcgetattr(sfd, termp) < 0)) goto err; - if (amaster) - *amaster = mfd; - if (aslave) - *aslave = sfd; + *amaster = mfd; + *aslave = sfd; + if (winp) ioctl(sfd, TIOCSWINSZ, winp); From patchwork Thu Sep 16 14:10:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1528865 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4H9JvR1pyMz9svs for ; Fri, 17 Sep 2021 00:12:49 +1000 (AEST) Received: from localhost ([::1]:55066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQs86-0001VH-Dh for incoming@patchwork.ozlabs.org; Thu, 16 Sep 2021 10:12:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs6A-0000ao-7Y; Thu, 16 Sep 2021 10:10:47 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:46855) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs62-0005rH-8t; Thu, 16 Sep 2021 10:10:45 -0400 Received: from quad ([82.142.27.6]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MV5KC-1mIasz2PCg-00S3CB; Thu, 16 Sep 2021 16:10:31 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 02/10] hw/i386/acpi-build: Fix a typo Date: Thu, 16 Sep 2021 16:10:18 +0200 Message-Id: <20210916141026.1174822-3-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210916141026.1174822-1-laurent@vivier.eu> References: <20210916141026.1174822-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:KNx/rCS/bZzp7BV07Drg8AKK9aroGsX2XEkkDn6TWGoYkGSPYp3 y0KWXdta+otkAgdmRdU66W0FqbpZJ61rXbLSBICAswHg2sO53g1ZoN6h1YaJFiCDKx9Gz0H XPQY45bxvaumx+ambmEZvMf45ZqshuXQSvLgMKk/d3lZnkP6CSx7+LrGQbzuFR/QOOZakQi iDYzk4TmYP9x9P3zMUPcg== X-UI-Out-Filterresults: notjunk:1;V03:K0:r2MjFjCFOa4=:kKduPJFLL0Fxclhgdef1fi +Joa8gkeZH3ah3uUJQblralX8qaJ1aQDHpvLIw9hk48n59KFDD7Qsc57/fuv+AJPZzv9YIhY0 mW3hZtJn2BeFW03Xrpqa0dMpf5HejZXe67kc/YRLUgJgViz/MSBALxbrxjiE8QoUQ8LSXA5jf +wqNuRG3Jklv9KNmwzX5gKfi9OMGQhPeas/XYg8Q7q68DQOVr7ouFA3aLLNKshL2NnY7KnN6Z 03mMrtWzKLlixk/DLGEg4JsPXWru4dAK+9xFKvpW4yP0P0M3nBE6w7Q7Y+MaQ9Ib/jPgdBb5O dXEPcwFOtWC6q7ldiOE7XcttLrg3nRhhRlGllny1BxN4w5dmBBApc9RKD+w1HTSIX83P0eCOz Vbb3MiyBCcIHv78ei4Blnf6s33HtSQqLca/HQfuZFu0epf7OUIjUuH8l2N91w4g7OGtogzEiL 35pt/2lPHTfD5H6JdL1oDHMkrm+XDw63RyTibpKqfsc2Nsu7mxsEPszTKhJTrz5xRBmQs5LsF 3Lcul0/I5QtYWBBT3B0o0gn85SkB/KaWue8IBs34kv2ZxP7uJw+GrRwOZ+RWQ+dmPmyASLac8 c7Aw0HpEg/QYa4lxcNlZfuyesEYG/ieF4xPIPutfk0SFsmlRAay74c463SrU5g3kkAi/rgRvq fdkAmxWDV7Bwdj3aD9+AxkLjgWi1/LxKzAHW/u+Oa6iTpAMx3mroa/0oMy2CnOjC3HwXl42ZD PK2Y55YQa4zDe/Dn5CKzJiAt1LQrHHODKlT1yw== Received-SPF: none client-ip=212.227.17.10; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Ani Sinha , Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Fix 'hotplugabble' -> 'hotpluggable' typo. Reviewed-by: Ani Sinha Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210911082036.436139-1-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/i386/acpi-build.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index d1f5fa3b5a51..dfaa47cdc20b 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -1916,7 +1916,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine) PCMachineState *pcms = PC_MACHINE(machine); int nb_numa_nodes = machine->numa_state->num_nodes; NodeInfo *numa_info = machine->numa_state->nodes; - ram_addr_t hotplugabble_address_space_size = + ram_addr_t hotpluggable_address_space_size = object_property_get_int(OBJECT(pcms), PC_MACHINE_DEVMEM_REGION_SIZE, NULL); @@ -2022,10 +2022,10 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine) * Memory devices may override proximity set by this entry, * providing _PXM method if necessary. */ - if (hotplugabble_address_space_size) { + if (hotpluggable_address_space_size) { numamem = acpi_data_push(table_data, sizeof *numamem); build_srat_memory(numamem, machine->device_memory->base, - hotplugabble_address_space_size, nb_numa_nodes - 1, + hotpluggable_address_space_size, nb_numa_nodes - 1, MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED); } From patchwork Thu Sep 16 14:10:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1528875 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4H9K49388cz9t1C for ; Fri, 17 Sep 2021 00:20:25 +1000 (AEST) Received: from localhost ([::1]:45006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQsFT-0005XV-72 for incoming@patchwork.ozlabs.org; Thu, 16 Sep 2021 10:20:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs63-0000Y9-4w; Thu, 16 Sep 2021 10:10:39 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:52565) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs60-0005qg-Oz; Thu, 16 Sep 2021 10:10:38 -0400 Received: from quad ([82.142.27.6]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mgf8s-1n7u0i0kG4-00hAGr; Thu, 16 Sep 2021 16:10:32 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 03/10] qdev: Complete qdev_init_gpio_out() documentation Date: Thu, 16 Sep 2021 16:10:19 +0200 Message-Id: <20210916141026.1174822-4-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210916141026.1174822-1-laurent@vivier.eu> References: <20210916141026.1174822-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:GZJrsP6kufVP8PIjyrUuEN9PI3SUddyaiHpfN8gf4VU8RSDOQCF JFwJv3f9Fco6k69+imjAlLKMglpvqtN6mLd3XSvloCB2D7xRfxqVtp7shNy9YmCDw4avlfe n4rHB/l/58nxJSsN353PhjOtYcykplmcABqI6ND7GUcC9Os3Rgo9anYZlGPiyEcZFhwzdmc EhV+Po+Ro6Issdgsb6MyQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:EuZUTzNfUmU=:Y53JEfeYe1xxAC5NUkJUIL K/ZycGEs/gegRUWEykNaYgWx90ByDDKmENcep835sD6aPBojnZ9pD4KQuJvon7mXjGxzQ36qP FV39thpHMxSzlsVqYGrQaAn9vohJdON4FdamKC5/uQzRhWn9q5g4GAF+pHj7YUkgfrEoy5QLK oj6hV/Kx9WQ9OXoxIkteUUENeQKK8tfNDV3pChBKwOwlmSo1r3CbvqPVXA44ct/h9Lw56QPep mKIQeVAKlfuv0rvieEOJ1JbrYn+9BnYpxyrjcYqEMVYNIcPQ8SZN/2SojiCUZ7lIPRrplymUM xzP1nuVFbX4iq3sMzBjiZKAJe1yxxZF37mKoO+mUJHTvk5qn7qEw/ahhX8SUzPPG/oJtW8PK7 MHJmZYf6GQT5wySNr/IufkY9T8EKoZm78wN8WNI3JI6Y8zsrvmXROfS7QegkWWPphmhoobrFZ 4SYDl4UeMRxlV+WsCN5gTBYJJawnrOcRqYtiizdHL4X7H6uIaI4S7bg81n3bEOkVJLdwmStNW oRS2unrzQFwhFkUjWQzEj0MOSGgAuqPzIdr0sQV4GQhOXD0fwI4uZBQXjfjeTQloM23+fCajW qoFDduKranRVxSFBfIBL1l9Pwr5NSx20nCuocW8vR3CSStgtTCcah4NkR58erEgu5gYpaMpFf D4hgAIXl7jdaNjQZXRBN0sHjsOGoGQXF+xOG3a5ffbZOdqZ3bAY8UMeFhMbZHFtpe6BEy8/yh CxYLQT+liy/Rnm24Avu9Wzm3kyI749ccG/PezA== Received-SPF: none client-ip=217.72.192.74; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Michael Tokarev , Laurent Vivier , Peter Maydell Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé qdev_init_gpio_out() states it "creates an array of anonymous output GPIO lines" but doesn't document how this array is released. Add a note that it is automatically free'd in qdev instance_finalize(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Message-Id: <20210819142731.2827912-1-philmd@redhat.com> Signed-off-by: Laurent Vivier --- include/hw/qdev-core.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index 762f9584dde1..34c8a7506a1b 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -598,6 +598,10 @@ void qdev_init_gpio_in(DeviceState *dev, qemu_irq_handler handler, int n); * * See qdev_connect_gpio_out() for how code that uses such a device * can connect to one of its output GPIO lines. + * + * There is no need to release the @pins allocated array because it + * will be automatically released when @dev calls its instance_finalize() + * handler. */ void qdev_init_gpio_out(DeviceState *dev, qemu_irq *pins, int n); /** From patchwork Thu Sep 16 14:10:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1528866 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4H9Jvr3KzYz9svs for ; Fri, 17 Sep 2021 00:13:12 +1000 (AEST) Received: from localhost ([::1]:55964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQs8U-0002Ci-50 for incoming@patchwork.ozlabs.org; Thu, 16 Sep 2021 10:13:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs66-0000ZI-KR; Thu, 16 Sep 2021 10:10:42 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:39605) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs62-0005r0-UA; Thu, 16 Sep 2021 10:10:41 -0400 Received: from quad ([82.142.27.6]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MFslN-1mgZx130kp-00HQ5m; Thu, 16 Sep 2021 16:10:32 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 04/10] spelling: sytem => system Date: Thu, 16 Sep 2021 16:10:20 +0200 Message-Id: <20210916141026.1174822-5-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210916141026.1174822-1-laurent@vivier.eu> References: <20210916141026.1174822-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:S7/+crBdyyQ5u09XJHisvfHvINmoXiWVNXe/yYDWLyPTA7Y0SSC FJlQLXjMHiyOHSejBUhTDGS9IemReB+cnMIAzBePwhErU6wabU/T1Zm5Hx5SYP1IrcHgeMT RdLgSk5jL8xJY50B5WKM9jr5ynhUzjd6RRH2zfxJJCU7l3bde3KaYbSaRkNhpEv6k6xEoj/ gJHV8yruLI1g5HqN6GuvA== X-UI-Out-Filterresults: notjunk:1;V03:K0:xiB6yxkWzIg=:hwyKdnYzFl7Zdw9aJ7m8Ul 6aOQrPLw/4ZKqUTUJbvWKcIkg3lhwD7ARlKA+O6tNrLh6r0ENszZ8bZo30GSbMfL1o5c5k77z n8rpMjOFa8ROuktLSTQsD53zFCaGnamIfhuhHjIv92a9x7w6kBSF6d5strLH73aHYekRgHtvd 7c/Nip74mJbicJEsV6m/uM66UmnHT/2WbtJKmVL6R8zEb8t0jt6cP8sdSdH0jD34+0bsIgUzy Cwtqe9rpUiiOLpso9hKIWucGvq8LZLl43HkbYELg50EaPdGTPd+j2uafNXzmZE5mDUEuIzt6z XIBbvYJCGpRJNpDB739v6UhAgpghGhhAWl705XvgUNiruMpWC8/TphDl5dNKluIXxdJAzA7C6 rvCaNC9aoN73m4WkjMd9JKKVnmX9tcQ6xB/8CpzsXmmLCzADBT9Wu4e5bBeb6WWwyGYMBkU89 /eVvB8VR1zpK06Z3s/MkdeF3m+rbD+3KvXPqgHOD2d310aqkUOPkPhNdUBVpfmAbYejXwRlKd zIRkBJuHCuLK8UieuY8tv7j+KBS+i4zQFBxr3KIo7uiV+ci7DAhI6W9bsh//QnbMjwi4wmEIR +KRgNZ5mxBn55aliV9MOD8Yn8zXguxNwxL9uZE81CK81I5UXYI6bjk16iD6dw4zV6x++s8HYG oijDDw1pfntcx6fYPkF73M2FhHyyuXabuQV0xmXXCV4nfLC2juCzMkyIyiaBeaDhpqV739nDU S6X1MY+eGXmjbc60Q9lsXtRvHtm4DOz/dt4D6A== Received-SPF: none client-ip=212.227.17.10; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Michael Tokarev Signed-off-By: Michael Tokarev Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-Id: Signed-off-by: Laurent Vivier --- block/file-posix.c | 2 +- tools/virtiofsd/fuse_lowlevel.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index cb9bffe0471c..1854bfa397b6 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -1705,7 +1705,7 @@ static int handle_aiocb_write_zeroes(void *opaque) */ warn_report_once("Your file system is misbehaving: " "fallocate(FALLOC_FL_PUNCH_HOLE) returned EINVAL. " - "Please report this bug to your file sytem " + "Please report this bug to your file system " "vendor."); } else if (ret != -ENOTSUP) { return ret; diff --git a/tools/virtiofsd/fuse_lowlevel.h b/tools/virtiofsd/fuse_lowlevel.h index 4b4e8c9724fe..c55c0ca2fc1c 100644 --- a/tools/virtiofsd/fuse_lowlevel.h +++ b/tools/virtiofsd/fuse_lowlevel.h @@ -1603,7 +1603,7 @@ int fuse_lowlevel_notify_inval_inode(struct fuse_session *se, fuse_ino_t ino, * parent/name * * To avoid a deadlock this function must not be called in the - * execution path of a related filesytem operation or within any code + * execution path of a related filesystem operation or within any code * that could hold a lock that could be needed to execute such an * operation. As of kernel 4.18, a "related operation" is a lookup(), * symlink(), mknod(), mkdir(), unlink(), rename(), link() or create() @@ -1636,7 +1636,7 @@ int fuse_lowlevel_notify_inval_entry(struct fuse_session *se, fuse_ino_t parent, * that the dentry has been deleted. * * To avoid a deadlock this function must not be called while - * executing a related filesytem operation or while holding a lock + * executing a related filesystem operation or while holding a lock * that could be needed to execute such an operation (see the * description of fuse_lowlevel_notify_inval_entry() for more * details). From patchwork Thu Sep 16 14:10:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1528869 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4H9Jyc2P8vz9svs for ; Fri, 17 Sep 2021 00:15:36 +1000 (AEST) Received: from localhost ([::1]:34062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQsAo-0006Yv-5d for incoming@patchwork.ozlabs.org; Thu, 16 Sep 2021 10:15:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs63-0000YB-6m; Thu, 16 Sep 2021 10:10:39 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:40843) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs60-0005qL-Sa; Thu, 16 Sep 2021 10:10:38 -0400 Received: from quad ([82.142.27.6]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MGA0o-1mhOth1TFk-00GasX; Thu, 16 Sep 2021 16:10:33 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 05/10] configure: add missing pc-bios/qemu_vga.ndrv symlink in build tree Date: Thu, 16 Sep 2021 16:10:21 +0200 Message-Id: <20210916141026.1174822-6-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210916141026.1174822-1-laurent@vivier.eu> References: <20210916141026.1174822-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:9BA2pgzc5u9CNywlhK+tSwD/iueJ87rLuGvMtGZqFFfA4xELrih vlsz2ZosEiLehJq9TOhnBrYvizYfH3v4vRii1FC/L7FjnXBMaeq/FYDXiJkD2BDmBJ6T+B4 xmI+cf+5/sLXvJQewp9Bwn+etorA01ixbEEzv0O8/6TKwbzueSfKndEvA0NtMQagpI1U7AQ 0tSt30IF05y5V+M447ZdA== X-UI-Out-Filterresults: notjunk:1;V03:K0:roFIoukUcnM=:Iz40SEJt8KqJTE0WCNTRgj nMupeU3WBoB2l+KKBumKtCH5HG5YcFmQGg+pn+eI20nSN9L6+vcznAXFdT6GNnAkN5SC6jgoZ 6YuEaGW3PQepOWfTB4m/RLBRUXjTxR25S5IT/p9jn2lEciLTnWzOKBRu+a0Pp2VE0938UZwWQ iJNztyBc4oOTqtPRdog9BG67wzlt7ajOk0GLgPztaOMOO/OQauNQ2iHv6SJE2j+rcHf2cvHLX x+Usn/40JOxs30LxZg7bhvjY7p7F8tqksN3vulVmqx0q2xzUQAnAbPAzw8IzCkdRn4u5PpEAl gUnHYpHjToLqHpuD3/uFOdCPZR/M1ULdJkYuluRqSV7lGRafe0cMCD/8ZwHxvIcqPKvrTgfPX 0OAKj/zE5QPxRCBdZodYuwzA/I3gRqlhkRey/ZUzz9wrs+gNVBhqI3lLh4OTB9yd//RA3u9HC fJ8wv8M/paGCkw/H+Jn4etn4cp6LoUXfyL7VGJbY5rCgLgfewLhW1tkfwzBX8JkgGYDfPkD/c Vp24YZlMUusGCAS2CYfLEU5CP0/RhIVt21wEITazL/8HEcFBGv/vtZYcAAvCVvCoYDRDw6wLl ek/Nt+jeK0hJCaaMTbYKIJcwXMgLn9Swvcg4/p65PJg4HN17yHYc4Q0ptSbQ17J86X/IbGATN HnTf/gFydeKnu0EMaxNkB9n2Gp6c4lOG02xc5bAEgWjHgOYYCfnJ0/xQmEQlsyzrSMYUwIoTu HSCc2TYxkIs1ogpynb7SKkFdYFXkBMNhM9VWgg== Received-SPF: none client-ip=212.227.17.10; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, John Arbuckle , Michael Tokarev , Laurent Vivier , Peter Maydell Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: John Arbuckle Ensure that a link to pc-bios/qemu_vga.ndrv is added to the build tree, otherwise the optional MacOS client driver will not be loaded by OpenBIOS when launching QEMU directly from the build directory. Signed-off-by: John Arbuckle Reviewed-by: Peter Maydell Message-Id: <20210831165020.84855-1-programmingkidx@gmail.com> [lv: commit message rewording as suggested by Mark] Signed-off-by: Laurent Vivier --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index da2501489f34..1043ccce4f99 100755 --- a/configure +++ b/configure @@ -5052,7 +5052,9 @@ for bios_file in \ $source_path/pc-bios/openbios-* \ $source_path/pc-bios/u-boot.* \ $source_path/pc-bios/edk2-*.fd.bz2 \ - $source_path/pc-bios/palcode-* + $source_path/pc-bios/palcode-* \ + $source_path/pc-bios/qemu_vga.ndrv + do LINKS="$LINKS pc-bios/$(basename $bios_file)" done From patchwork Thu Sep 16 14:10:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1528864 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4H9Jtg5TdFz9t0k for ; Fri, 17 Sep 2021 00:12:11 +1000 (AEST) Received: from localhost ([::1]:53922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQs7V-0000dh-H0 for incoming@patchwork.ozlabs.org; Thu, 16 Sep 2021 10:12:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs6A-0000ap-Rg; Thu, 16 Sep 2021 10:10:47 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:57871) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs63-0005rK-5Y; Thu, 16 Sep 2021 10:10:46 -0400 Received: from quad ([82.142.27.6]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MMnru-1mAJ9J3WvE-00IjXR; Thu, 16 Sep 2021 16:10:34 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 06/10] target/i386: spelling: occured=>occurred, mininum=>minimum Date: Thu, 16 Sep 2021 16:10:22 +0200 Message-Id: <20210916141026.1174822-7-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210916141026.1174822-1-laurent@vivier.eu> References: <20210916141026.1174822-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:q12Zwxsk4WKAO2JqcRHb4/GkOO6guq2y7RSOyzvkjkwwwEMYvcz Wjv28Y7OC8knmySCPX3xPARMU9yY5bKhEg9ToGuSmx5jXy8hAKo5UKLrtgXDOQbmQCWTvNQ 9rbbGTKFI6rhLc1ocEtcQ3RJc5HyzRhsUR1I4SWymQlpQ6v23q/7fAjorC8QpTwQV39whPR wjYO8QUKRSEcjLAZigqJA== X-UI-Out-Filterresults: notjunk:1;V03:K0:8j424mu0bLI=:qxdyNdmkDKkdhQJqKHZKXG MZULPecokB3XT+nS4DpPTv5YBs71lN64uVNj78Evv71t9cU33AwOkwnxmgE7D6xnPF7AXVYss f9tNeFwPFq47Sr5czp55njyWLB4/ABw1VYn0GrZrSW1wBz6oaq81fc2TaGGhzSVBDSz0KCHHR R+pE8uQ0ir7kpGecWZ10G18zgLQgOWb8m03TUN7ZmMgAM+FlRcLcMUa++iQHlF6znhpKL2lAl /Ta21jM+EhCKem4kfmhPDnvXJbi9iZS742C61X2XCyqLkSompVB1puL9GbdlfLvTYONgfYj6d IYThtHBM3HZjLgPli53HZRJxZMOvT6RhXC7E6ojU20pAJNUbJtHHAnchK8TF+/uyzCtLYJjgp 7zB66yG2Yje9+upZDAytqNpnZHaO+VFGZQoBMBqeatkAS22BkBC+4fCHJOsg8gxR/jkqsO545 hZ2wBV7tK/nY5t6bcsUSBReWsxw4DdGAFfpQRpr02QTcWqRB5hAPoLQSmf9NxAjyn0497mwEb 507mbWLEgHoH1Bpr2Sx7PPu8LeqHGcXElobIkcx3tjb6AXu+QB6V5F3PTEYUTl6+0SL4NMKOJ GWbInDOE+LHv9oNkkbJPD+NRw2qIPcwF+fyWwSPhJqwulXNOFsNqQEsePpbQLRssoXw7npMJO lLqG7QVDpnHe8JD0gGV9Y725qBCnp4mGvPK3YAGUdRQ/lgc39K1+10P0GAgdWdk2L3oZlNrjC KqKamiWdXYI8UwgT8EQ0+9ZjynpJTNHpiBdP0g== Received-SPF: none client-ip=212.227.17.24; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Michael Tokarev Signed-off-by: Michael Tokarev Message-Id: <20210818141352.417716-1-mjt@msgid.tls.msk.ru> [lv: add mininum=>minimum in subject] Signed-off-by: Laurent Vivier --- accel/kvm/kvm-all.c | 2 +- target/i386/cpu-sysemu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 0125c17edb8d..cace5ffe6442 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -2469,7 +2469,7 @@ static int kvm_init(MachineState *ms) ret = kvm_vm_enable_cap(s, KVM_CAP_DIRTY_LOG_RING, 0, ring_bytes); if (ret) { error_report("Enabling of KVM dirty ring failed: %s. " - "Suggested mininum value is 1024.", strerror(-ret)); + "Suggested minimum value is 1024.", strerror(-ret)); goto err; } diff --git a/target/i386/cpu-sysemu.c b/target/i386/cpu-sysemu.c index 1078e3d157f0..37b7c562f53c 100644 --- a/target/i386/cpu-sysemu.c +++ b/target/i386/cpu-sysemu.c @@ -335,7 +335,7 @@ void x86_cpu_get_crash_info_qom(Object *obj, Visitor *v, GuestPanicInformation *panic_info; if (!cs->crash_occurred) { - error_setg(errp, "No crash occured"); + error_setg(errp, "No crash occurred"); return; } From patchwork Thu Sep 16 14:10:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1528877 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4H9K7Z6HSrz9t0J for ; Fri, 17 Sep 2021 00:23:21 +1000 (AEST) Received: from localhost ([::1]:52236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQsIH-0001zG-Sc for incoming@patchwork.ozlabs.org; Thu, 16 Sep 2021 10:23:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs6C-0000cI-91; Thu, 16 Sep 2021 10:10:49 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:51941) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs6A-0005x9-K8; Thu, 16 Sep 2021 10:10:48 -0400 Received: from quad ([82.142.27.6]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mo7eX-1nEoJ51E6N-00peyo; Thu, 16 Sep 2021 16:10:36 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 07/10] intel_iommu: Fix typo in comments Date: Thu, 16 Sep 2021 16:10:23 +0200 Message-Id: <20210916141026.1174822-8-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210916141026.1174822-1-laurent@vivier.eu> References: <20210916141026.1174822-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:fge7NnsPwy4wPoYMEH7X7ClNoNQN3q4Ti7Y4aAVKGLNy6luk9xq KYoA2RhbBcf3EqCvI4rFR5tQDVqKCQlaGJ2W8dTCRvCjLRDi+v+mKTRbFgd5r7S+UlxXasp ACjg4yTq/wgX+37lzErQOssMFOGtiDqExHk+4R2/1nZo+TrEQBmGTqJUDkkcWU55bMSw4pF ko0jExGHuuWOoPNsSIJ0Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:G8ZfQXADvHg=:Lap+TpbbdpWlkX9/nlAJs+ 8ymAtpA1aW1aNY2+3bWKDn8ssnGHN3YPGn3fnsF3rTDVQlPCVuAIXaeRpHocLSEWSDBddsw6o xL3W7jyFgpGyazTGf0NQYH/FSOf2tdnRAnJKM9to2amO2HrUTzqGJhsmjeav4gmxr6pQiDYmL l7H4Wla1kD+zP+grFmNZjzOgqUQ8PwNOpjEdOKXI18hEKn9FE7G0F2eWBa01Hs9v84S6OzH4d 80pkBfm8e0RvW+Auq/kHfseOZMjtRbUO4e29Vu0jR6SuJGtRBDLmQzTzd+EyhTFuaocj5pOsS joSFPM8TN99rau9uL5fgCka6Vnp9Exbo1/d5MYZZB2QluBIIZn9d7ajhNcUe8d8sa85sWd6J0 9/VFNJ/WgEqCNOCVCZZuxpUlSpuA29JtqolSkwowB2CtxMzb1QnSjVcB3DlRg/KnX/unAUEik wwZKaX7s4P4jbRqEi8jHa5YtLMZcgT55waVhDQ/WuhMiRYw+UmsE1rOK2wNM10NsZp4gUvkIn S9q3LyNZVfeUFpmIlMvZLaprNaX3JHXoMSzllRqUqsfvBjyJWs6xSXIBQ3TDvUMRsyhxVHDPK 4i61H++0pOflgTGrfe7bJ61HQu0eL1RIBGTwSeD4/xn5o6mxzBQFYArWc8UMLniclrfQNTsnY zUkGB4qfc/ftr9IxvKhF23SGyLgrn4ycK4krtMsI3sC97g225TeugnQAORGYnmGoHSWj6A8gF oaHBk8gZJsfd/31aHmlbFrvSOiyyYazkJU09Kw== Received-SPF: none client-ip=212.227.17.24; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Peter Xu , Cai Huoqing , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Cai Huoqing Fix typo: *Unknwon ==> Unknown *futher ==> further *configed ==> configured Signed-off-by: Cai Huoqing Reviewed-by: Philippe Mathieu-Daudé Acked-by: Peter Xu Message-Id: <20210730014942.2311-1-caihuoqing@baidu.com> Signed-off-by: Laurent Vivier --- hw/i386/intel_iommu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 209b3f55530e..75f075547f65 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -679,7 +679,7 @@ static inline bool vtd_pe_type_check(X86IOMMUState *x86_iommu, } break; default: - /* Unknwon type */ + /* Unknown type */ return false; } return true; @@ -692,7 +692,7 @@ static inline bool vtd_pdire_present(VTDPASIDDirEntry *pdire) /** * Caller of this function should check present bit if wants - * to use pdir entry for futher usage except for fpd bit check. + * to use pdir entry for further usage except for fpd bit check. */ static int vtd_get_pdire_from_pdir_table(dma_addr_t pasid_dir_base, uint32_t pasid, @@ -746,7 +746,7 @@ static int vtd_get_pe_in_pasid_leaf_table(IntelIOMMUState *s, /** * Caller of this function should check present bit if wants - * to use pasid entry for futher usage except for fpd bit check. + * to use pasid entry for further usage except for fpd bit check. */ static int vtd_get_pe_from_pdire(IntelIOMMUState *s, uint32_t pasid, @@ -1507,7 +1507,7 @@ static int vtd_sync_shadow_page_table(VTDAddressSpace *vtd_as) } /* - * Check if specific device is configed to bypass address + * Check if specific device is configured to bypass address * translation for DMA requests. In Scalable Mode, bypass * 1st-level translation or 2nd-level translation, it depends * on PGTT setting. From patchwork Thu Sep 16 14:10:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1528878 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4H9KC02sL0z9t0J for ; Fri, 17 Sep 2021 00:26:20 +1000 (AEST) Received: from localhost ([::1]:59418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQsLC-0006jf-4Q for incoming@patchwork.ozlabs.org; Thu, 16 Sep 2021 10:26:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs6J-0000dq-4j; Thu, 16 Sep 2021 10:10:56 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:43627) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs6B-0005yB-J1; Thu, 16 Sep 2021 10:10:50 -0400 Received: from quad ([82.142.27.6]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MTAS1-1mKWpP3yN5-00UX6E; Thu, 16 Sep 2021 16:10:37 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 08/10] hw/vfio: Fix typo in comments Date: Thu, 16 Sep 2021 16:10:24 +0200 Message-Id: <20210916141026.1174822-9-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210916141026.1174822-1-laurent@vivier.eu> References: <20210916141026.1174822-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:VrWB5X7IyoMPnuYSfOUDEgSPmRtCoP5n95ohMEC14Cmz643FWiC fVujIF/+EW/r9icIr3O7HMwnIbAb1LMd4HEEE1xf9jc6hMb/1t+5OvSrSWLNBg39PStnFhp 2MhpQOZiTebBGisOHbrcuHWzVf8ro4QFhRNZTV1GPWXZxPpo3xczFbG3YoJ7ZiT+Wd0w1jk Cxp91P85leEuYcSfW4z4w== X-UI-Out-Filterresults: notjunk:1;V03:K0:Y4O4kfLDwa4=:g+ClptadPlm7ptw0DrhXv4 Bczhkv8N6De8X8sswmuJpbYNG9mjDKlaEfOAhn8OUomFMJ9AcB/UTCB7ALAjNktB1BCd3fGxR N5t3wJSWQe2B1h6QS/6wlek+NU6BCU3J0oEYaN2leetwchuGyf9zlFm+vaeDaVuwVU+u6G9Ea zcSH6ldyDF+cRaEKCxTKDky3FC2doEu0BQUrF1ELEk4BbdbObI5LCCfNpN+DoA+npm55KwIpI FgthAloWlcWefQXGkJ4hd6QZmScRxTlQVxZgXHPlcQ1fMj86h0D27QwOqVei/WWCxKTZL6nZZ Y7ybqLjYFyhjEGvtuJkEpllhpOtswLah/2cSmHhrdiKlZpk5OdXRd6Qm5Xv2fGpLhPdLbdFPk nPF78vnrRpTuS5k1bm2L2rVUtTEvNy8Dt87Ypb9NRRwSctnlWhylyyXpsxGuZDEKkJD0FxIFc jCg5CPCzX3X0P8Y7E/ibw+jW19AtxisYaMAtwKkH4+Bd2ii76tODmAbouBz1g6EruJ3vbdxf/ kiiuvd45FuLW6Ct2eJGMLcq9RTpu/R2Ud6mQG1zSHz1egVNhVh7PLVe9ROxf53yZGlz0zyHqT LomPe2zO/JU2ee2u5Opae0oDinihjzb1JTGikCBE1/BGzDPEEZhR9zpVCg4WdR88z3AjtKwlE FrGrBC7lPFvBVFJUs3D4StlU0tEaoivJ3HImt0o0WfF+X/tMJODCp2spAvSjmktmwMMtbewmb aij6aKPj1L6kxngBWxzd5jytWRbEIpE5wbN0xw== Received-SPF: none client-ip=217.72.192.73; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Cai Huoqing , Michael Tokarev , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Cai Huoqing Fix typo in comments: *programatically ==> programmatically *disconecting ==> disconnecting *mulitple ==> multiple *timout ==> timeout *regsiter ==> register *forumula ==> formula Signed-off-by: Cai Huoqing Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210730012613.2198-1-caihuoqing@baidu.com> Signed-off-by: Laurent Vivier --- hw/vfio/igd.c | 2 +- hw/vfio/pci-quirks.c | 2 +- hw/vfio/pci.c | 6 +++--- hw/vfio/platform.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c index 470205f487eb..d4685709a3b0 100644 --- a/hw/vfio/igd.c +++ b/hw/vfio/igd.c @@ -557,7 +557,7 @@ void vfio_probe_igd_bar4_quirk(VFIOPCIDevice *vdev, int nr) * must allocate a 1MB aligned reserved memory region below 4GB with * the requested size (in bytes) for use by the Intel PCI class VGA * device at VM address 00:02.0. The base address of this reserved - * memory region must be written to the device BDSM regsiter at PCI + * memory region must be written to the device BDSM register at PCI * config offset 0x5C. */ bdsm_size = g_malloc(sizeof(*bdsm_size)); diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index e21a6ede1140..0cf69a8c6d6f 100644 --- a/hw/vfio/pci-quirks.c +++ b/hw/vfio/pci-quirks.c @@ -1356,7 +1356,7 @@ static bool vfio_radeon_smc_is_running(VFIOPCIDevice *vdev) /* * The scope of a config reset is controlled by a mode bit in the misc register * and a fuse, exposed as a bit in another register. The fuse is the default - * (0 = GFX, 1 = whole GPU), the misc bit is a toggle, with the forumula + * (0 = GFX, 1 = whole GPU), the misc bit is a toggle, with the formula * scope = !(misc ^ fuse), where the resulting scope is defined the same as * the fuse. A truth table therefore tells us that if misc == fuse, we need * to flip the value of the bit in the misc register. diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index e1ea1d8a23b5..4feaa1cb6888 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -1364,7 +1364,7 @@ static void vfio_pci_relocate_msix(VFIOPCIDevice *vdev, Error **errp) * TODO: Lookup table for known devices. * * Logically we might use an algorithm here to select the BAR adding - * the least additional MMIO space, but we cannot programatically + * the least additional MMIO space, but we cannot programmatically * predict the driver dependency on BAR ordering or sizing, therefore * 'auto' becomes a lookup for combinations reported to work. */ @@ -2158,7 +2158,7 @@ static void vfio_pci_pre_reset(VFIOPCIDevice *vdev) } /* - * Stop any ongoing DMA by disconecting I/O, MMIO, and bus master. + * Stop any ongoing DMA by disconnecting I/O, MMIO, and bus master. * Also put INTx Disable in known state. */ cmd = vfio_pci_read_config(pdev, PCI_COMMAND, 2); @@ -2384,7 +2384,7 @@ out_single: } /* - * We want to differentiate hot reset of mulitple in-use devices vs hot reset + * We want to differentiate hot reset of multiple in-use devices vs hot reset * of a single in-use device. VFIO_DEVICE_RESET will already handle the case * of doing hot resets when there is only a single device per bus. The in-use * here refers to how many VFIODevices are affected. A hot reset that affects diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c index cc3f66f7e44c..f8f08a0f362d 100644 --- a/hw/vfio/platform.c +++ b/hw/vfio/platform.c @@ -156,7 +156,7 @@ static void vfio_mmap_set_enabled(VFIOPlatformDevice *vdev, bool enabled) * if there is no more active IRQ * @opaque: actually points to the VFIO platform device * - * Called on mmap timer timout, this function checks whether the + * Called on mmap timer timeout, this function checks whether the * IRQ is still active and if not, restores the fast path. * by construction a single eventfd is handled at a time. * if the IRQ is still active, the timer is re-programmed. From patchwork Thu Sep 16 14:10:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1528873 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4H9K320YH0z9t0J for ; Fri, 17 Sep 2021 00:19:26 +1000 (AEST) Received: from localhost ([::1]:41792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQsEV-0003Q0-Rx for incoming@patchwork.ozlabs.org; Thu, 16 Sep 2021 10:19:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs6A-0000aq-T1; Thu, 16 Sep 2021 10:10:47 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:43165) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs65-0005tB-4z; Thu, 16 Sep 2021 10:10:46 -0400 Received: from quad ([82.142.27.6]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Msqty-1mkkQX38mW-00tBLd; Thu, 16 Sep 2021 16:10:37 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 09/10] target/avr: Fix compiler errors (-Werror=enum-conversion) Date: Thu, 16 Sep 2021 16:10:25 +0200 Message-Id: <20210916141026.1174822-10-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210916141026.1174822-1-laurent@vivier.eu> References: <20210916141026.1174822-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:LyOkoG+asRnw83iBmSDISuopuy0rKxuaVsygE66lfD1NbRoAt7O CK5uqsqfN+hpVzCnellWtW3VkF8cuo9Zldr40InIuHj3mIMgTJTr88cE2lhqjvwi6flgTWR S1BF6xENsfcsHt8iS4N5xzWGksTbmojp49YcUBoJvPRukJbfNdUJdQCma7hSHUOxMcu7LLb 7LSZ+nfTmEoINjQxjzACw== X-UI-Out-Filterresults: notjunk:1;V03:K0:/5MQYTTCwJ4=:cyrC/6kKcQuB1wqvCkZXYI l/jKElGlWYgs7OzKTWQAawLXTxCMkDIwzvl2OZ51GFg57DDM0NOWO0yZ/BAm00qDArSiM3u6u NWbesw8e0YUMb7WbkJxmqRzW/a0N8gHyfE1DK5BtYQJ/SkBYgyVEdfRd5q9+G+DFwz/lCu/T5 QquZ7eXiBe48wQ79026AAW1HmvzSWQkfr7+hUl8C/sxzYCQx1rPRqFfxw5FrAe+NybhGTbSXL FzzcI8qR0rmw8Uh+lcxoljxazAB9JTQpyyoJNMSfZnsk7ry33Y15mPOXszSKmNR8JoJzuwp2u xtoiNFBUjScZm1gUEZ3EnqLvUglNua0BrDamkTM/ti7CZIqFjHJsvrnYhHo87cxckMu8WVLzH 7gwWNRAQ6O3PiSFD/ObVC7KnEKxJUduHXN+o79Ipc5/hdyZoa6XYxkh7ABwrhhj7vvxH1J6bP iPPXe4GIzau72qg7QARR29+nYwEpOL9qM7YTpns9foVWAN1j4q0Rzxny/3HgaRaOR7XLmrkxx z2rTMs7hYYyU2ADDEdojzxuDs7hBdVtRKPLezkMMoCStSAKX2eyr5jZ36DdDYyhv20Iw90vNE sOjSjzbaJjp8xMfUkg31LOLFibzzvvpWiM8NfncslW19kWbt1vfmsVYh3wqtYU2BHXMAPzdq+ OjXReoakBT1ylI/RmVZEJR7eHywKfuJ29A/vccgo0AQNyoiHZ873ExTZbv5ZCpeWsiSFHhQCW UE2CLZWqAUWhNL8+edCfuJRcDBqbF0F8VXPzOg== Received-SPF: none client-ip=212.227.17.24; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Stefan Weil , Michael Tokarev , Laurent Vivier , Michael Rolnik Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Stefan Weil ../target/avr/translate.c: In function ‘gen_jmp_ez’: ../target/avr/translate.c:1012:22: error: implicit conversion from ‘enum ’ to ‘DisasJumpType’ [-Werror=enum-conversion] 1012 | ctx->base.is_jmp = DISAS_LOOKUP; | ^ Signed-off-by: Stefan Weil Reviewed-by: Michael Rolnik Message-Id: <20210706180936.249912-1-sw@weilnetz.de> Signed-off-by: Laurent Vivier --- target/avr/translate.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/target/avr/translate.c b/target/avr/translate.c index 1111e08b83f3..438e7b13c18d 100644 --- a/target/avr/translate.c +++ b/target/avr/translate.c @@ -70,11 +70,9 @@ static const char reg_names[NUMBER_OF_CPU_REGISTERS][8] = { }; #define REG(x) (cpu_r[x]) -enum { - DISAS_EXIT = DISAS_TARGET_0, /* We want return to the cpu main loop. */ - DISAS_LOOKUP = DISAS_TARGET_1, /* We have a variable condition exit. */ - DISAS_CHAIN = DISAS_TARGET_2, /* We have a single condition exit. */ -}; +#define DISAS_EXIT DISAS_TARGET_0 /* We want return to the cpu main loop. */ +#define DISAS_LOOKUP DISAS_TARGET_1 /* We have a variable condition exit. */ +#define DISAS_CHAIN DISAS_TARGET_2 /* We have a single condition exit. */ typedef struct DisasContext DisasContext; From patchwork Thu Sep 16 14:10:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1528874 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4H9K3r5TJyz9t0J for ; Fri, 17 Sep 2021 00:20:08 +1000 (AEST) Received: from localhost ([::1]:44386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQsFA-00058e-5h for incoming@patchwork.ozlabs.org; Thu, 16 Sep 2021 10:20:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs6J-0000dp-4b; Thu, 16 Sep 2021 10:10:56 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:32837) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQs6D-0005zb-HX; Thu, 16 Sep 2021 10:10:52 -0400 Received: from quad ([82.142.27.6]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MysFQ-1mmNFk1wzi-00vwV9; Thu, 16 Sep 2021 16:10:38 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 10/10] target/sparc: Make sparc_cpu_dump_state() static Date: Thu, 16 Sep 2021 16:10:26 +0200 Message-Id: <20210916141026.1174822-11-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210916141026.1174822-1-laurent@vivier.eu> References: <20210916141026.1174822-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:diivNTPMv+cTN/boy9Azc/F6yegMMnjFXsXplk8BROYlbdbFjjA ACv7HHVcpod8PLJqT3eQ9XUc0MCbvjLpvZHF7JzIU92JfY9eO3qVFItj7EsN3RWdjSTZII6 f7N+k4auXGn670tGK7YGnG4472RzgLHc0WLWTqaKbSTdrwoJdUoX07yLzipb1NuKHzKLVwe p+HVGLEP2I/P9XWjgWS6g== X-UI-Out-Filterresults: notjunk:1;V03:K0:oXNzOEwwRMI=:y08SQ7tVQ+dqdP0fob/Mlf G+iUBCa/RF6OAF+LOJkQbegunE05qzGNQgVRrtbZEz2nv5OtIsHNC/1XkDTaMkAMvVCLnNyk3 rurOoOQKfYR7EdUA+aQYflECkRQbWT+p6qwLg74F5DIAtg9mGAPXz60hYYRyzfPLhR0CK/j5y qW+n8LMJYVIuAxCRhDGRkwD+TOj0KYJeGgZQ6x9BwPpEiFmY5mccAvpiAyzU4NFf+puKL45bv Ez4aX93fEPCA5EImqw75v/lKg0uwLZgo5/GbEHL1sFMjhKXjg04LhDfVsWOUDTA3gdBD8Ok5f 3KUMRU7O5w8fWRk0u9n4H4neTfzp+efg3Qaw0cKPrCniT+S81aXaTu6Hz6VZMLjwDoUTW/1Om vkdVkUTcA/wBg3d/6tUSTbhWLXWj3BT69iewUWn1uZqRDpHy3wkVjYzy941xfoTpD2hhx+CxY bG+2tuVhKCffVAjeRMH3jBS8VnOKS9w6t36ECx+zvhlzmN4UN5Z0D3E/lRFnq80hkHmm1xIE8 zwTnpR5B+wOa1sypQnSwayctxfecBWGj8y9LNl67bSbGsJOtSoSScjoGVnHjcQjpbMzFNmMVO CDyBrHlfSvv/v4L9to6VK2cECGlPzJR0dqQVgqnceFyRMwpugxb2CtWpFGaYJIQ67WkgMxRaF AOwKF48yjA8rpRYpTyQxVvjT7VK5yeoX6hEmGtn9pzFBM3swl/dvYNjBO7O8pKIGjZOkYLbbg CXgOSBn5iIgOz7d8MTfbNcicFuEk7ZvAup+iqg== Received-SPF: none client-ip=217.72.192.74; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Mark Cave-Ayland , Michael Tokarev , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé The sparc_cpu_dump_state() function is only called within the same file. Make it static. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Reviewed-by: Mark Cave-Ayland Message-Id: <20210916084002.1918445-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- target/sparc/cpu.c | 2 +- target/sparc/cpu.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c index da6b30ec747a..2bf67fb99d60 100644 --- a/target/sparc/cpu.c +++ b/target/sparc/cpu.c @@ -610,7 +610,7 @@ static void cpu_print_cc(FILE *f, uint32_t cc) #define REGS_PER_LINE 8 #endif -void sparc_cpu_dump_state(CPUState *cs, FILE *f, int flags) +static void sparc_cpu_dump_state(CPUState *cs, FILE *f, int flags) { SPARCCPU *cpu = SPARC_CPU(cs); CPUSPARCState *env = &cpu->env; diff --git a/target/sparc/cpu.h b/target/sparc/cpu.h index ff8ae73002a3..1f40d768d8b5 100644 --- a/target/sparc/cpu.h +++ b/target/sparc/cpu.h @@ -571,7 +571,6 @@ extern const VMStateDescription vmstate_sparc_cpu; #endif void sparc_cpu_do_interrupt(CPUState *cpu); -void sparc_cpu_dump_state(CPUState *cpu, FILE *f, int flags); hwaddr sparc_cpu_get_phys_page_debug(CPUState *cpu, vaddr addr); int sparc_cpu_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg); int sparc_cpu_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg);