From patchwork Fri Jul 9 07:29:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ivanhu X-Patchwork-Id: 1502952 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=lqT4pl35; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GLlCz396mz9sRN for ; Fri, 9 Jul 2021 17:29:34 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1m1kx0-0006Qt-Pm; Fri, 09 Jul 2021 07:29:30 +0000 Received: from smtp-relay-canonical-0.internal ([10.131.114.83] helo=smtp-relay-canonical-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1m1kwy-0006Qh-U6 for fwts-devel@lists.ubuntu.com; Fri, 09 Jul 2021 07:29:28 +0000 Received: from canonical.com (unknown [175.182.110.56]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id DA2EE404A0 for ; Fri, 9 Jul 2021 07:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1625815768; bh=45sinJ1eZzBmDgyeNssroLvL05PrfNGDO64rIhdYxns=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=lqT4pl35NZhPZQEdAObzVHFX5+6U/a9KUzIeiseIdi4RtKVy9iHXtrEiNLK5HRF6L 5Ubi7XdrLgKuB9t3FmWPLg/+QmCcspn7YiCRE7yxc2/P4SgykTRcQiSsPlLlC8XqJx cYGHjnqIB71SSD6LGwmxfWlB6JA0A8iATz3QXauBX19yqQ1JOseaU7x6xf2IT7HXHl 5Vu5WoMDOTJVfK8k6S6CqRwabNMaVxzEOOe8hft/HEBuSWpy7jbmJ1iFDjGR4GjN8+ zNVmeQO+BRcz1+7jE35/3tn4StmAhU/rvDIrbA0tdTMKqx6gZc4RrVIsJ2c9OlKCs5 lWCcEtCJ3Surw== From: Ivan Hu To: fwts-devel@lists.ubuntu.com Subject: [PATCH] uefirttime: add advice for the timezone 2047 failure (LP: #1933503) Date: Fri, 9 Jul 2021 15:29:19 +0800 Message-Id: <20210709072919.25978-1-ivan.hu@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" Some system firmwares do not support the timezone value EFI_UNSPECIFIED_TIMEZONE(2047) and set the value 0 directly instead of returning status EFI_INVALID_PARAMETER error. Add the advice information for the failure. Signed-off-by: Ivan Hu --- src/uefi/uefirttime/uefirttime.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/uefi/uefirttime/uefirttime.c b/src/uefi/uefirttime/uefirttime.c index 9c3d6a19..e4c7af51 100644 --- a/src/uefi/uefirttime/uefirttime.c +++ b/src/uefi/uefirttime/uefirttime.c @@ -417,6 +417,11 @@ static int uefirttime_test4(fwts_framework *fw) !((oldtime.TimeZone != 0) && (newtime.TimeZone == 0))) { fwts_failed(fw, LOG_LEVEL_HIGH, "UEFIRuntimeSetTimeTimezone", "Failed to set timezone with UEFI runtime service."); + fwts_advice(fw, + "Some system firmwares may not support the timezone " + "value EFI_UNSPECIFIED_TIMEZONE(2047) and set the " + "value 0 directly instead of returning an error which " + "causes the failure."); return FWTS_ERROR; }