From patchwork Tue Jan 16 20:39:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 861883 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zLhx648Ltz9sP9 for ; Wed, 17 Jan 2018 07:42:34 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3zLhx62QmFzF0fv for ; Wed, 17 Jan 2018 07:42:34 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.17.11; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zLhtJ4B3CzF0ff for ; Wed, 17 Jan 2018 07:40:08 +1100 (AEDT) Received: from [192.168.1.3] ([92.228.15.72]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0Lrryk-1ey8sQ0RMk-013hGS; Tue, 16 Jan 2018 21:40:00 +0100 Subject: [PATCH 1/2] macintosh/rack-meter: Delete an error message for a failed memory allocation in rackmeter_probe() From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt References: Message-ID: Date: Tue, 16 Jan 2018 21:39:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Provags-ID: V03:K0:/PLvv7PEvLzq615KvhyAkMGyFeC1dNBnLRszOT7Yytvy7W1pJz1 k7gl43DJSR72ISWfVVGmhdjjIXc/6UyqtwuCoQOMCqbBawAr2uK0MSh6dUrDy3nnv7q79eM f7TEoMAN2E1Nf/MQOsYMNcesf3kriBdSheqNvZ70SkSjjzRBI6J9yIZggZbEk90Ed6anCeY sAIlmUUaBqJXjyTUifueA== X-UI-Out-Filterresults: notjunk:1; V01:K0:dw1CKBakO6o=:S7b3gTXsivQNSrzdl8iUsO VRkl2uiP1U3WpFEqHJy2mqlokGaYs3hXgBpLm54wfrc5oU6l7hAGIrCyex33KulzJVGC+kuaA 0hmdiRzq+DKCvl9OGeBBxL0uL+2c75S+dNZPqreYFdzIoIC1jdY+ucv5hNXm6E1sk9Gp8Ylg4 j/GK60pVzkxgLR5X7fp/wv9EZmHfus/qon1yWcjiXir7xSVcJOj5aAoIKWxtx03wFHnTHj5OJ JO1cYt0xJ++ggYTQS7FtqSkwwc0i8nvIlTnTpeLFUtPYZOvOQqySfzjsj88FZBOE9Ti/mNWa4 /NWB++SkTzJVTGnbwm1yXp3V7TaoRnVij7wU5QtggbtrXjnuKjKEwI2oqAFJFy0GaICntsn2+ BNMK4EglN8KnD5mF3mQVO/YnUdNsdeYEvEMbBNYsK/U4HBdQ9A+Dk7+1DqJpvvgq+lPN4hEEZ D2QTwUE2cYAO9v+EAUBaQ9fvDc1cIA5W7g7+IvJS6MYUK3hhYnX/K5YdwIOx9DxWCkcv63xHK veQx7echzHEsaG2CU29VLVOH61PqI52iLqJh8t72GVmhe/I6igFd79NpgBGcZztUwu66dlZ2t yM1DdTCAKi/d8y8Vn9Atns3sZ2y41yZWZTqVTJ2YspjyYRdaGvteQF0U1SygCaqxeyQ7vd0ki xgGy+J6iPD3tN928/X+v8YGIMweMCacZ4TRoQ0GMaI58d7q7KngVKmJ6gMzC9OGBK16vr7tUw aowP2dgrycT1ZO7J3enAikKdswSdujA3eD5DSAKLcwsm97Fa+EiRZ5HBqlrvW8GOsx+wHE9we hULrM9XkIRqrqY8D71Tjm3JHjxogSr1cG6gjnp6km7kimDazQ8= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Tue, 16 Jan 2018 21:23:36 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/macintosh/rack-meter.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/macintosh/rack-meter.c b/drivers/macintosh/rack-meter.c index 910b5b6f96b1..0796b74174d4 100644 --- a/drivers/macintosh/rack-meter.c +++ b/drivers/macintosh/rack-meter.c @@ -399,7 +399,6 @@ static int rackmeter_probe(struct macio_dev* mdev, /* Create and initialize our instance data */ rm = kzalloc(sizeof(struct rackmeter), GFP_KERNEL); if (rm == NULL) { - printk(KERN_ERR "rackmeter: failed to allocate memory !\n"); rc = -ENOMEM; goto bail_release; } From patchwork Tue Jan 16 20:40:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 861884 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zLhys4syrz9sP9 for ; Wed, 17 Jan 2018 07:44:05 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3zLhys3tLjzF0fN for ; Wed, 17 Jan 2018 07:44:05 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.17.12; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zLhvR1mRlzF0g2 for ; Wed, 17 Jan 2018 07:41:06 +1100 (AEDT) Received: from [192.168.1.3] ([92.228.15.72]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MZDTE-1eGaqE201U-00Kyr3; Tue, 16 Jan 2018 21:40:58 +0100 Subject: [PATCH 2/2] macintosh/rack-meter: Improve a size determination in rackmeter_probe() From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt References: Message-ID: <862e3609-1010-95d8-0d64-0493f5759f78@users.sourceforge.net> Date: Tue, 16 Jan 2018 21:40:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Provags-ID: V03:K0:sZZEW/D1awxVThn1rBNlC5l45mhkrDcyT/kqqbslsRPsLss+wbz Mk1s3NdzzFzTMdc1tWXWj7u2GruD7mzEgr16obU5h9dgwo3ylM3Afvn4N7HWLWTZlyyjNy8 eyPWkWS8/L4XfDDGVQXOQ/RB/dfc3SMlIKlUvanFF0g1prgRL3wdfQ+Hlxp1DUROLFL8OOD 7tdEhVW4WLx4cOGxHCazw== X-UI-Out-Filterresults: notjunk:1; V01:K0:yPtU8BUIA7U=:njoo/M2C8R0TAX0HGfSp9H l8BiUfAExFK9bZ3KFB0TV1RoQq+A11fPZD1npPYjj/MaQzvW3jxWbUvFOODC5Fou2MqlNhMWI yXiUvnPJ8Ygmc1BK6INhUWidSVt9FPpV57fRD7BBKVgkykfmMfryS9xfuh82MIWNExoJErhsm 2rCeJk7yR3EHEsCk0501QGM1cbMOmKIlUOJbV1IlxVxchICWs11x0bpvUCaV8cwPQtfa6fR3A dpSsw8NdB9+zknJHCz0ZDdga5WEPHWwu426bThcWv9dnEUPBhX5K+DH/yQFOZV0lBNrID3TJq KlQgDMevKsOMtT1jbk7hUp2g22Rlo2zIHDJ51oVGr0TRTwg8ElLREtZpbTRZPZ77T/u1U9qvO 8nP+Ikzj96cYtQsk3xkodpvonjwoY/kK0IxYIwqVbSE08ngrnVlpFDxgPSU+o4DVa33pETb2j SwVCr9lAYr9RjVrXODGblUvJhczNTmD594f3Y4X4k4Lh1EhVNyqu364PHQkAlJbSJM/l9s85i Id6JmzQj+ZCPHCX0HRjw/ReJRBhTWxMA1SW2L5tPhJhIsYaq6XfQVK/1lPV/FMikHnneRjnh/ qUCmEPXHDOclF92ZKe0SohtFD2K7MvUhTBrRkvUkxflOaPJ1NrUHwOhxcJbi3DMemfrRSejel 7wMiO470/4XaGoOnbdym6LlNPGwZr+m5VozJIR5Qky8r4rUPnNbw0MdjidStYcATzb3pvQ/f0 lgvWI6d/BYPHbfYCp8Ds17WsoqV50EF0V0RV20oGo5vLydaltZmFUKSHTc7kFhK51Jlm7gr3A Rhobsr1szueASRAB0CtFqtg80mriyEvOfYF6DqW1xu81qeKN4U= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Tue, 16 Jan 2018 21:26:52 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/macintosh/rack-meter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/macintosh/rack-meter.c b/drivers/macintosh/rack-meter.c index 0796b74174d4..800fc6822ad8 100644 --- a/drivers/macintosh/rack-meter.c +++ b/drivers/macintosh/rack-meter.c @@ -397,7 +397,7 @@ static int rackmeter_probe(struct macio_dev* mdev, } /* Create and initialize our instance data */ - rm = kzalloc(sizeof(struct rackmeter), GFP_KERNEL); + rm = kzalloc(sizeof(*rm), GFP_KERNEL); if (rm == NULL) { rc = -ENOMEM; goto bail_release;