From patchwork Fri Jan 29 08:32:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1433145 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DRrG55V98z9sVF for ; Fri, 29 Jan 2021 19:33:33 +1100 (AEDT) Received: from localhost ([::1]:34696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5PDf-00054H-Ky for incoming@patchwork.ozlabs.org; Fri, 29 Jan 2021 03:33:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5PCz-00051H-O2; Fri, 29 Jan 2021 03:32:51 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:54223) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5PCv-0002RP-Us; Fri, 29 Jan 2021 03:32:49 -0500 Received: from localhost.localdomain ([82.252.149.54]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MxHLs-1lto0H1vzs-00xXyr; Fri, 29 Jan 2021 09:32:41 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 1/4] MAINTAINERS: Update 9pfs tree URL Date: Fri, 29 Jan 2021 09:32:33 +0100 Message-Id: <20210129083236.584238-2-laurent@vivier.eu> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210129083236.584238-1-laurent@vivier.eu> References: <20210129083236.584238-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:yvhI0fkZHNwhSXS/JG97y/oAuAg34XOkmIN7KWFkOGgUZ8A+smP P/UvUWm1rkr4Xxn7G4jkwMSpUl61N9+YIrFm6F1nlZMNZo3wuav8EL1EYU7OZsPbkGOWKJ+ tu0YGgR8EOCeKvro8kERa2IYatJKy8bxNGx0AtCUBxtcoJ3aFHpz2ZVh1LOscNIjXFNBFRD +RDYm3g6RbtVYpBL3uGgw== X-UI-Out-Filterresults: notjunk:1;V03:K0:xAhx/aSGbk8=:E4A6xbHwd7GdkCFul46dS+ /e/N80SOFzgXvTra+pPhNkjEU1gv8tLs2qbrkqVQ90SAkSRkBAIaXZGYBFxprntK80MQ8r59K 4MmNhNW7koWLmqdu3WfYjo1GXbVXwMFu+oU4QksYYWgHACXvcD0MXsa4XQmObv+VgbAsjJloI qUHrRmvMADXy4XiJrhBvf+Aa/sN+4w0GYHoV/SvKi4W3SFtwoIWUNvCDXqXkMY6/MyXo1Ilng ta9tSKCjRaqssf1Oik83EMUMtG2sLobNSIdfvqBJ9C5Qf1oMOA3Cv6LC+CnLT9dw0tHxJg0O0 tWTz1U/4Bj94eJPxZmXyjz6ZZSxrFFOXxfpMBOxG5ARqmDZeUfns96U4eT/8NXR/bOILDSMij omPhLHF3k9a70pFqJXUZsO6YH1DrpO182XZHTmT9n6TWLECd/4z7Q9tZO4VgC Received-SPF: none client-ip=212.227.126.134; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Christian Schoenebeck , Michael Tokarev , Greg Kurz , Laurent Vivier Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Greg Kurz I've already moved my repositories to gitlab for extra CI coverage, and I won't use the ones at github anymore. Signed-off-by: Greg Kurz Reviewed-by: Christian Schoenebeck Message-Id: <161071814430.152031.14540382419012818908.stgit@bahia.lan> Signed-off-by: Laurent Vivier --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 34359a99b8e7..fbb228ef2b34 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1828,7 +1828,7 @@ X: hw/9pfs/xen-9p* F: fsdev/ F: docs/interop/virtfs-proxy-helper.rst F: tests/qtest/virtio-9p-test.c -T: git https://github.com/gkurz/qemu.git 9p-next +T: git https://gitlab.com/gkurz/qemu.git 9p-next virtio-blk M: Stefan Hajnoczi From patchwork Fri Jan 29 08:32:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1433146 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DRrG75Q0Gz9sVF for ; Fri, 29 Jan 2021 19:33:35 +1100 (AEDT) Received: from localhost ([::1]:34858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5PDh-00059f-MT for incoming@patchwork.ozlabs.org; Fri, 29 Jan 2021 03:33:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5PD5-00054a-CH; Fri, 29 Jan 2021 03:32:55 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:40271) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5PD3-0002UM-B7; Fri, 29 Jan 2021 03:32:55 -0500 Received: from localhost.localdomain ([82.252.149.54]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MXGSU-1lU8Q80aOU-00Yh4x; Fri, 29 Jan 2021 09:32:42 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 2/4] tcg/tci: Restrict tci_write_reg16() to 64-bit hosts Date: Fri, 29 Jan 2021 09:32:34 +0100 Message-Id: <20210129083236.584238-3-laurent@vivier.eu> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210129083236.584238-1-laurent@vivier.eu> References: <20210129083236.584238-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:f5G6Sd3S5lkNKACmVqO4C1GfHyqj7/tVUjhGmX1jtTIu0/pCGx1 267zMTLOB12O3MLSBfTSThllSIKjlHWTY4HiMOGjCVFxPWDYU15ey4OCMWxt62Xvzi8VtuK urj+e37WilOlf+BM5mnDhpQQEqW+w6aIDNy476+DaNcoMt+q1kXDzVTK22X/HwYyxcif4m8 eIjZP8mBnajybTmWwZaHg== X-UI-Out-Filterresults: notjunk:1;V03:K0:A40ekwuV+VQ=:DoSzneYg0PMg4Z/xxtjkBA Zy0I9NHT6ieNiWyJtCb9iAFIOcEQ3w/1NM0ccTvqnA3HSX1KJnMF23A6N/nzP3XbpXVrNuhSM 2BLINZSPL0Cyck0Kj01tSlMaNsPQBUI01+6mTjM+2pV8QMBah7uRERxeb9ZkRl1KP7zzSuN7u C3cwYxR9ep7etgupWu71s3YOauSvKde0SWaiOLBELFZsFGGhWUAOu0OeT7piiFJXp2f5d1i9R vQSm1e/wr8InNCMkRwTCnwbUmapl/mD1me9Dl967IP04cc5mCGV2GTZPO+surl7zd51rD8r3r +digl+aEQjyBqNLPw7Co7djWVkGXkYhmnjNFk4ho/s/8lSzrRcCsBmLnEexeALAQWFYSxfMoa am3nx6yNKMaZNdhQdfmRhA/YqF58DvFULT/Lf2bT1Chx3M/CxxnKhycEFlQXde4hNCMSX/9mu C+zUtURQGA== Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Stefan Weil , Michael Tokarev , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Laurent Vivier Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Restrict tci_write_reg16() to 64-bit hosts to fix on 32-bit ones: [520/1115] Compiling C object libqemu-arm-linux-user.fa.p/tcg_tci.c.o FAILED: libqemu-arm-linux-user.fa.p/tcg_tci.c.o tcg/tci.c:132:1: error: 'tci_write_reg16' defined but not used [-Werror=unused-function] tci_write_reg16(tcg_target_ulong *regs, TCGReg index, uint16_t value) ^~~~~~~~~~~~~~~ Fixes: 2f160e0f979 ("tci: Add implementation for INDEX_op_ld16u_i64") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Weil Message-Id: <20210123094107.2340222-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- tcg/tci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tcg/tci.c b/tcg/tci.c index 2311aa7d3ab6..3fc82d3c79d7 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -128,11 +128,13 @@ static void tci_write_reg8(tcg_target_ulong *regs, TCGReg index, uint8_t value) tci_write_reg(regs, index, value); } +#if TCG_TARGET_REG_BITS == 64 static void tci_write_reg16(tcg_target_ulong *regs, TCGReg index, uint16_t value) { tci_write_reg(regs, index, value); } +#endif static void tci_write_reg32(tcg_target_ulong *regs, TCGReg index, uint32_t value) From patchwork Fri Jan 29 08:32:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1433147 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DRrJb1Pxhz9sVt for ; Fri, 29 Jan 2021 19:35:43 +1100 (AEDT) Received: from localhost ([::1]:43618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5PFl-0000Gt-3Z for incoming@patchwork.ozlabs.org; Fri, 29 Jan 2021 03:35:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5PD3-000529-4N; Fri, 29 Jan 2021 03:32:53 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:34577) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5PD1-0002Sz-0m; Fri, 29 Jan 2021 03:32:52 -0500 Received: from localhost.localdomain ([82.252.149.54]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mf3yk-1lbj9c3WHK-00gZKN; Fri, 29 Jan 2021 09:32:43 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 3/4] net/slirp.c: Fix spelling error in error message Date: Fri, 29 Jan 2021 09:32:35 +0100 Message-Id: <20210129083236.584238-4-laurent@vivier.eu> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210129083236.584238-1-laurent@vivier.eu> References: <20210129083236.584238-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:PsrHh8FtWYObSHkcd8w+gUGuZHc8OibAGF6YNLrX0/x5LY8CAi7 TpEJwjoXnVmK0YCG/WRUERwwnWFTqUgZ8YtOWE4pxXmepTYqA4ThCjpcGwY9lQ8bDGegznE jL0e43f80Ho/uiWGeSbX4hsxuYWmumbN7J3jndKbItAHBp6qUkkmCJxCoJGvBuSYPW/In10 AYerTtrUrrd1WPEes2L+Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:hmKZVSv3PS0=:QoBSNK+e9YbdDKjqMa+nMV Bx0277auU8VrYVIf0FyFZNY0a6qFI+eiY8CvDXUHGor4COaxh4QCsFm2NKbuWrEaxTOm91jLN VFY+H73s60o79Vz9feR00uCSoNTLdklMXMPdJa9/I61PFOOQJ4naZuiPXUdG9ME3Czc1yU8Wl j98pjOWCUnYPaFUNaDfJzuFGAA4AjX6Na9WUmZZMqXonz8w1mZ5klZywE4H8+qEtbuklB0FVF t+NPgN52y+EX8MKbohO8T102uQHOtx0sRORfje8ZgzzkGmmOos3rELU/QEkQJjUdBtbPO5B4+ RW6UYoeueHV5XgFs5o63BH+S/HPglV9G7+e7BV0Slj7wstWv4Oew9v/Xh/5POz09x+ju8i5LL KuraWc7cmexlrX2z+cMh5ooM/qHb03cpatBmMZdD0TTUdW1M1WyAgcoSD9jIOL4iVb5e+gLS6 ZdYbcikE7A== Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Doug Evans , Samuel Thibault , =?utf-8?q?Philippe_Mathieu-?= =?utf-8?q?Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Doug Evans DNS should be DHCP Signed-off-by: Doug Evans Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Samuel Thibault Message-Id: <20210122004251.843837-1-dje@google.com> Signed-off-by: Laurent Vivier --- net/slirp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/slirp.c b/net/slirp.c index 8350c6d45f70..be914c0be058 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -473,7 +473,7 @@ static int net_slirp_init(NetClientState *peer, const char *model, return -1; } if (dhcp.s_addr == host.s_addr || dhcp.s_addr == dns.s_addr) { - error_setg(errp, "DNS must be different from host and DNS"); + error_setg(errp, "DHCP must be different from host and DNS"); return -1; } From patchwork Fri Jan 29 08:32:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1433149 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DRrN20qK2z9sWC for ; Fri, 29 Jan 2021 19:38:41 +1100 (AEDT) Received: from localhost ([::1]:48216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5PIb-0002Gj-Vt for incoming@patchwork.ozlabs.org; Fri, 29 Jan 2021 03:38:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5PD7-00056k-OL; Fri, 29 Jan 2021 03:32:57 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:55899) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5PD5-0002Uo-K5; Fri, 29 Jan 2021 03:32:57 -0500 Received: from localhost.localdomain ([82.252.149.54]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MavF5-1lfpsu1tNb-00cSb4; Fri, 29 Jan 2021 09:32:43 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 4/4] target/rx: Fix compiler errors for build with sanitizers Date: Fri, 29 Jan 2021 09:32:36 +0100 Message-Id: <20210129083236.584238-5-laurent@vivier.eu> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210129083236.584238-1-laurent@vivier.eu> References: <20210129083236.584238-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:BaYDGEebk0Ib9T0dj5uodmqiGbdl9jH8EHL4EwWBwwXZyKzxuRA +nZsdSrhKjt92nft9HurvGIQqVEvxpe6ZOiJqWAAfs5BQTqFyMqiHWrdfTC6VG+KT5evcwD cjtI46wRiLwIVmioQiJYuyzrQocmuY/l/Wh6CAwAnVIHMYVq9UrWVkDtNBMXlrS/fS2h38Y 3RgMhOZiSnOBq5FRSbXDw== X-UI-Out-Filterresults: notjunk:1;V03:K0:oBVT3JliVDs=:11x6MepuolRwEqMxtP0sXE w7lDhGdb+Qnp9CMTWc6FWZXs13X80ax9odc/qT5pTyYrX3vnEbRq6kLBNHw/6oIFtQ/+V1eCe PNhZdpP8+XuJ+1wu3qqUH+5hZk/fS6CxFf6DAH5X/RmhaMrGM410+6vvccx6qHliVXACqd2Ik 7BD295U8YuJjFlzenZnYRr1C8oHPIXZJ8i5azsVw2RuXvevqn6qOAKr324EZ+AZ27xtO2ioVr zJzKlxCR7D8rHbiIjoZ4bnaV96Ymjsk1XnrMULylXed3NsTlHsC+n0JTDbuW8ml6y2S6oX8HU 8Srxb0u5ClxQnBvJrglLOt2hc1+afcA0C4pwdfAV8C9YtvHjcZwSZf+arfzj9ChcSwi4Kurxb 4CQ1Cicme5I0PE8nUFT2a6jT0tqYpNB8cGZtgn4vdrR4WQHHuGfSGhExBqGZR Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , qemu-trivial@nongnu.org, Stefan Weil , Michael Tokarev , =?utf-8?q?P?= =?utf-8?q?hilippe_Mathieu-Daud=C3=A9?= , Laurent Vivier Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Stefan Weil gcc (Debian 10.2.1-6) 10.2.1 20210110 aborts builds with enabled sanitizers: ../../../target/rx/op_helper.c: In function ‘helper_scmpu’: ../../../target/rx/op_helper.c:213:24: error: ‘tmp1’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 213 | env->psw_c = (tmp0 >= tmp1); | ~~~~~~^~~~~~~~ ../../../target/rx/op_helper.c:213:24: error: ‘tmp0’ may be used uninitialized in this function [-Werror=maybe-uninitialized] ../../../target/rx/op_helper.c: In function ‘helper_suntil’: ../../../target/rx/op_helper.c:299:23: error: ‘tmp’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 299 | env->psw_c = (tmp <= env->regs[2]); | ~~~~~^~~~~~~~~~~~~~~~ ../../../target/rx/op_helper.c: In function ‘helper_swhile’: ../../../target/rx/op_helper.c:318:23: error: ‘tmp’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 318 | env->psw_c = (tmp <= env->regs[2]); | ~~~~~^~~~~~~~~~~~~~~~ Rewriting the code fixes those errors. Signed-off-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20210128172127.46041-1-sw@weilnetz.de> Signed-off-by: Laurent Vivier --- target/rx/op_helper.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c index 59389f49921f..4d315b44492f 100644 --- a/target/rx/op_helper.c +++ b/target/rx/op_helper.c @@ -201,14 +201,14 @@ void helper_scmpu(CPURXState *env) if (env->regs[3] == 0) { return; } - while (env->regs[3] != 0) { + do { tmp0 = cpu_ldub_data_ra(env, env->regs[1]++, GETPC()); tmp1 = cpu_ldub_data_ra(env, env->regs[2]++, GETPC()); env->regs[3]--; if (tmp0 != tmp1 || tmp0 == '\0') { break; } - } + } while (env->regs[3] != 0); env->psw_z = tmp0 - tmp1; env->psw_c = (tmp0 >= tmp1); } @@ -287,14 +287,14 @@ void helper_suntil(CPURXState *env, uint32_t sz) if (env->regs[3] == 0) { return ; } - while (env->regs[3] != 0) { + do { tmp = cpu_ldufn[sz](env, env->regs[1], GETPC()); env->regs[1] += 1 << sz; env->regs[3]--; if (tmp == env->regs[2]) { break; } - } + } while (env->regs[3] != 0); env->psw_z = tmp - env->regs[2]; env->psw_c = (tmp <= env->regs[2]); } @@ -306,14 +306,14 @@ void helper_swhile(CPURXState *env, uint32_t sz) if (env->regs[3] == 0) { return ; } - while (env->regs[3] != 0) { + do { tmp = cpu_ldufn[sz](env, env->regs[1], GETPC()); env->regs[1] += 1 << sz; env->regs[3]--; if (tmp != env->regs[2]) { break; } - } + } while (env->regs[3] != 0); env->psw_z = env->regs[3]; env->psw_c = (tmp <= env->regs[2]); }