From patchwork Tue Dec 12 18:54:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 847599 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="BYfuy45W"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yx8Hz3zlfz9t3F for ; Wed, 13 Dec 2017 05:59:11 +1100 (AEDT) Received: from localhost ([::1]:60017 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOpll-0002QL-6Y for incoming@patchwork.ozlabs.org; Tue, 12 Dec 2017 13:59:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOplB-0002OL-IX for qemu-devel@nongnu.org; Tue, 12 Dec 2017 13:58:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOpl7-0008Bt-Iz for qemu-devel@nongnu.org; Tue, 12 Dec 2017 13:58:33 -0500 Received: from mail-co1nam03on0078.outbound.protection.outlook.com ([104.47.40.78]:51456 helo=NAM03-CO1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eOpl7-00088W-4Q for qemu-devel@nongnu.org; Tue, 12 Dec 2017 13:58:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vX9BUUcObfFfljT+DRnS5AQq6I5rgR4RfPvF5n4ZJDI=; b=BYfuy45WqchBYUVVlKzPcbzN9X+WamR2DxTeVrZDCjZ6hHcMNRmFmpAV7JXDO9+L073aWZ+xVloI2qD0Ezb8NW7SCCXFgkB/AJhY8k0xqkUvYTPB9n/9mMgLN7l9Kr9v40+DiMovWrKOGfaEcVTsMhbGJDMfVV/w4okrbaC/HPk= Received: from MWHPR0201CA0099.namprd02.prod.outlook.com (10.167.161.40) by MWHPR02MB3391.namprd02.prod.outlook.com (10.164.192.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Tue, 12 Dec 2017 18:58:25 +0000 Received: from BL2NAM02FT026.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::205) by MWHPR0201CA0099.outlook.office365.com (2603:10b6:301:75::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.302.9 via Frontend Transport; Tue, 12 Dec 2017 18:58:25 +0000 Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BL2NAM02FT026.mail.protection.outlook.com (10.152.77.156) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.302.6 via Frontend Transport; Tue, 12 Dec 2017 18:58:25 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1eOpl2-0003Ey-FN; Tue, 12 Dec 2017 10:58:24 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1eOpl2-0007gX-Cp; Tue, 12 Dec 2017 10:58:24 -0800 Received: from xsj-pvapsmtp01 (xsj-smtp1.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id vBCIwNpn032214; Tue, 12 Dec 2017 10:58:23 -0800 Received: from [172.19.2.220] (helo=xsjalistai50.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1eOpl1-0007fr-3j; Tue, 12 Dec 2017 10:58:23 -0800 From: Alistair Francis To: , , Date: Tue, 12 Dec 2017 10:54:13 -0800 Message-ID: X-Mailer: git-send-email 2.14.1 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23524.006 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(376002)(346002)(2980300002)(438002)(189003)(199004)(2906002)(5660300001)(36756003)(2950100002)(6666003)(39060400002)(63266004)(15650500001)(4326008)(81156014)(478600001)(8676002)(47776003)(81166006)(106002)(50226002)(118296001)(316002)(16586007)(8936002)(356003)(305945005)(106466001)(54906003)(110136005)(9786002)(50466002)(36386004)(76176011)(7696005)(51416003)(59450400001)(48376002)(2201001)(77096006)(107986001)(2101003); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR02MB3391; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2NAM02FT026; 1:izkh9Yk9Afamw2hBek/y5wnk34Os7vuZIrcTJji1yXzZNUnzs5ZeLBav40PO8MqaQyaYhfjEYcUt6xkHdLfBZ9EX5g+XY1aq87RrNEpEuxPLAtqZfNUOLlaVkfXwZr2J MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cc3abc1e-47ee-4ffa-2add-08d5419252d0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(4608076)(2017052603307); SRVR:MWHPR02MB3391; X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB3391; 3:U+stXtAZ2DLzkGDly8uCTUCUqwmU+liQ3TSEwXH04t7SddcyX2b6CnWzYPX60L3xfx+0u+ayJzNE1+D6p+AvZacJbkprObzThee0vP+Z3GiE91OXYl2C+xAYQdAP5eEi/D1h69LuG//7TP6z/29rzKU1A4BzTZ4SmsHqZpwdOhtSTJXDs9kobP2OjxXSLXmAV1xy0/SOg3QOwtziwSu7I2ABKK26nzXBYr7W7t4u/IVsOm7/AFQOK+bHMd4FkV0j9gxs8ACQK66iS4971XGNWXupNv4FynoAxZ2z+ulv26FF3sIE2s8GIXhQTDweBKkLqcMmIQM86Kfm3DRsogFsj6pM7e+qsyEesgqwIyLfnsg=; 25:K7Wx/HslGHywhPKV5aPhJJc57v/0194A9M/znr/RZJhNjckRjmshq/KNMfwsuLx4DO9x3sc7WZwZQFivxk4i83hWbDCkRV5A19yNM56Ti76MdrT8m+l58WkzUU/2l5gg+9FcaQNKtA9wVopeiYfOPdqbTDgm/Addh13yuDa+3OWpXosVqpN+Af3myfNmgcfI/wdNlXMfNfHj5+v4uGQdqrE5fMFbyIUMFgezplAaCWBZhYy0FHGwhEc8Lw4IXnJwk4YJWgiYvxO8ktlwXFPThpMkJ+cdxcOMmj2SekWA0CqgyrX4Xi0ss/5zggi2U9VbLqBYywSSHJmeK9JSBE4s5w== X-MS-TrafficTypeDiagnostic: MWHPR02MB3391: X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB3391; 31:J3J7g5zcjfUBBSp/1J7Db+3HUHUmM1zcEHzxpETqRsqQHdlwxW+1gQKTEF66DI0Lqo5fSQz7A1yBwwPtVCG7WcLdaFVB+djt6DqL0oWmoG0UgmszKqwNnjwYMtwHOgFvDcff54lwJFB1iRxp3OoDKYG5pMhsz9ImQeCDQDIHWB/LuNYExQJ0sb1UkfxUNoMIH4cmG7WRT0Az+ZEUDrj1lMLd3rloPr67EJ+pnvQzKpM=; 20:7qTl3sEo+UA3k3L2KtVwwwZrrh8rzN/DaHgj5kqS2JNR7tmAABZlb+BvAfgF9yCA9/DRiiwKlou2Mqe9BNNPYvKc/aNUu2jqqnoshxqOeQ1xvJzVDbh8tf5UH9qXgdD+4WJCkp9NGfBFm1+cxjYoILl5QpBmyOK9HmyNisuTA88hZ5eSHT1Lu4wdEj96t0VHlLpb0doW2YWwLOaZ7Sh03SsMB615DByxo0fhFZAEFdNqf5bs3jJkv5qsD8ntpsM4pHmb5zsVA4SuHKWpJJ6Syv1nGIjkPZnyMeJFwFKZeYeuAavaa48NItlZbr72rsXGtmhKRgwfvj+oj7iiHdNHoFzDG1WFZw6GqtUz2TyUbcK8EaWJVv9dZcZt9UrWYDHfHSuYjGDcYhdZf/cgCybrXjDJHRKRrNsaA0X3lQVcxUwIaaSyRyDtXzk9rHGW3VQNrAI2Tf4oTFD6rerpHfs8L/jo2dOsNEoHwOXB/asge//XUvQnrBSqTtvFfNto3l4T X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93004095)(3231023)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(6072148)(201708071742011); SRVR:MWHPR02MB3391; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:MWHPR02MB3391; X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB3391; 4:UDH8ZT1eo4MFEYiW/8sx43NvVI6xCriMXrnTkLuiazyyxxYgV9sr7mRccG8js7Ra3T9QLhxFXGt+uzFHDfC0Y3GmK8I1QQuGROjQQ53ns5LXrgC7UwKKyCcik4Eu57NWgnyXrNFpKs9ADvrBMwrueJrcUMAItnNLy13Tbu4/B5xPGEnx6J41xNIx9zZIUuO/VW4aEQCF8IUZRThg6tppRD3mUJKZNklo5lATrPJIbmdnmw8zgKM2LN8uYXz96M0g/Jl1EstHLl/wlQ5B14fe4wGKtE+1eXGKOGk+R3GKTQ7XpMWb/oA2gmSzExOsS18G X-Forefront-PRVS: 051900244E X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR02MB3391; 23:elG0rrE78OGHZOu6ETHr9gGfO+RbsQLUTuOJPMq5E?= l1tJWwM9gfGEz2STubvYiUQBeCvyRRKFCU2cOSx+gbNqzfhwSQmabHRMOIHtP/nmdwYMStuyk+WsMi1//gPcmPjgWvK45YsbaPvT65zSPo2kRhwYUil5/WjPV+mnFKzA38VCaUwPnrwSYFclN07aRDdheCPpUwiRSGsumJOIqbETfNXh8LoIAg0rA6Ym+PoiEdd6RWAwA5PpWOflGkzePHdMYycuyJe3Q7o7eoLhQxiFTBPXWleGLETpdiOnF6YQOSPjiFP9rKlDnia6gvyU9B6CIaULQQfHrddigLCMT4sXNIeoDaNH0hI65PQamYTGia3QuiljKeZeyTZ6IFmSguKXXqfKShk5iGOk7Hu5/fas9IQ80/91dCfSJyf4fALJ/8wp791bmpBLAzqYhkKQbt0rWmPmCnsWcOkQMQpLNhOPA/rPZ9Ji2z+xViXl8ZjY7/MQqv+AY3TOfolZSVFCpzabsLlmj9PFqwvA08cjkXv+CvdNofn47+mwa+hO1JaS8E2GzDq9eG7uHLjh6oExH1rKwHZFfXvwlFEHZSf9tOpBWYx39iEJ/dGcAGRPHY9lbY6lh4Kwj5MdZRW5lqH+HApPXKpLjO+wEXCr+v5axqxanxAOJh8IyF5P5D5RwSgZ9eu9b6PISU56pmNdcfDhkm72ptmxaIqrOeCVx2lDquim9k8Hajtfp059Br3ZP0r/JYejtoNZt9RuJbQF+SMHHYKMjFD5bOG4H0b7FpdyJqDY8uJHuq79C0k0DWZ7vx5/P8vR+n7OUYqpOHF6tVwkzTxoPp29XB/5cgtIlGkz43ur1dIEMKgsXPVnlOPefuTZu6nyhtKH+7GnGnNv34Oeoi01mSGBaOToCW4CmMkx0MZiOzCEcu0DWd4sKYo/8iBVFJqmQ1QEMNftdoBFP3O7YFpHAvT86mLbcKQRkwW/xPXjdM1MzHQoWDBgiIYRkKk+gJNW9tDq+6RotCKrN8ajcPEQR0oEVQ4R+iWs83nDxByvslP2K7g0YpFGqTFcP40Fzc= X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB3391; 6:BcgVdJK6t5X08zqN1QSfKuXzyfquKQALhHkiiWITcI1v63wlL3aDHv6vDnos78S7AKwViizecUQ9qige02mHH3kWoR1Z2n+ufLpoGMQ5QyZ5+FF5t3JdBzxNmMXF6mFZt2+RSpEf3K+Gr4wD3kJtCUVP3kbUFdVbKPhflsmnYrpgmbRPOJQA4ptzHfKzUm27/viq1gFVHbnqzCDG4YDLEkT4+76kT09OtNCVPwBzyBQGvDEE4xnrjzhazna5R1RPpBvpL2VpLdjpNLQSuGaAyCqocnvjILISC/zHKnEwMGtz+cUfeUCBg7xRKqC6aC9nI27njBQVNyJsg7mPKar83/5vFRJvFWm/vapFvwAbDJg=; 5:ghFEDnGu7F3pgIz/q52w0/7Yztz8QV6bCXP4P37LGAY7ipgKH0OVG8/SgP/HL7X5UudJzEdeGufOaZiVEoNLarBySjq19A+lJ0yVeB6aVofwYbC/Jn4aGkKEOAAVUcTlj0uI2GXfyKRvAX/7ouA4OUkwh8Ju2PcEo5FQILGdIxo=; 24:AGeKCqeQ+pm67zq/NjlqffDgjDiJOBNy1VDPtnbUNSKJq2TRRpXZvFYnK91VF5bGTWTsikXGbQPhl0X7EWLP640A+IlrsCg2J8MOOc3JlMs=; 7:27cIp3fAT5/plx9+K9DLorSlA+zxf24x5IYJuEMEffhnA/Jb35E/klc5FWSByL/6LRz6YWj+FrguMf9ANPYQ9AKN4Yu+tYIKZLQcX9fXTCl4Gebn+bBcG5NX0SJsa545eZTX4qLRHmb+10tkrxgTozVTSN8fRlIP35e+7pH2MazWhPaqp/3AqaOfoEz8FKFyIXNAooa6Ypj/jTWZ+grzQUDVPjLiVWiOWHzFmUIJdKRbL9r0E/iwP+hn/gwSQxXV SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2017 18:58:25.1322 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cc3abc1e-47ee-4ffa-2add-08d5419252d0 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB3391 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.40.78 Subject: [Qemu-devel] [PATCH-2.12 v3 1/3] xilinx_spips: Update the QSPI Mod ID reset value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, frederic.konrad@adacore.com, frasse.iglesias@gmail.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Update the reset value to match the latest ZynqMP register spec. Signed-off-by: Alistair Francis Reviewed-by: KONRAD Frederic Reviewed-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index ad1b2ba79f..899db814ee 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -355,6 +355,7 @@ static void xlnx_zynqmp_qspips_reset(DeviceState *d) s->regs[R_GQSPI_RX_THRESH] = 1; s->regs[R_GQSPI_GFIFO_THRESH] = 1; s->regs[R_GQSPI_IMR] = GQSPI_IXR_MASK; + s->regs[R_MOD_ID] = 0x01090101; s->man_start_com_g = false; s->gqspi_irqline = 0; xlnx_zynqmp_qspips_update_ixr(s); From patchwork Tue Dec 12 18:54:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 847600 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="VWvMCOTu"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yx8JC0J2pz9t39 for ; Wed, 13 Dec 2017 05:59:23 +1100 (AEDT) Received: from localhost ([::1]:60018 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOplx-0002XY-4N for incoming@patchwork.ozlabs.org; Tue, 12 Dec 2017 13:59:21 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOplM-0002VP-9c for qemu-devel@nongnu.org; Tue, 12 Dec 2017 13:58:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOplI-0008T0-9G for qemu-devel@nongnu.org; Tue, 12 Dec 2017 13:58:44 -0500 Received: from mail-sn1nam01on0070.outbound.protection.outlook.com ([104.47.32.70]:64240 helo=NAM01-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eOplH-0008Qt-Vd for qemu-devel@nongnu.org; Tue, 12 Dec 2017 13:58:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=opZdV0o44e/py8XZBiKF3AP0sKjULsCEx+vb8g8/sDY=; b=VWvMCOTum+4WeYlROsIyGh6sk5KFwXMuypHlGpSo+RcHEr4rAUHrhvS6odV9+okSJTdvSIH8lRu0wCF2phR7cIMBt8odyxOYjbFMANHxs/jBEpJh/MONaQZcmg/PDNVJ7H0BL3iRbfqM1MWPxZmFonFrQo28Tb1U9u3e9B0VfWM= Received: from BN6PR02CA0101.namprd02.prod.outlook.com (10.161.158.42) by SN1PR02MB1343.namprd02.prod.outlook.com (10.162.0.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Tue, 12 Dec 2017 18:58:36 +0000 Received: from BL2NAM02FT035.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::209) by BN6PR02CA0101.outlook.office365.com (2603:10b6:405:60::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.302.9 via Frontend Transport; Tue, 12 Dec 2017 18:58:35 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; adacore.com; dkim=none (message not signed) header.d=none;adacore.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by BL2NAM02FT035.mail.protection.outlook.com (10.152.77.157) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.302.6 via Frontend Transport; Tue, 12 Dec 2017 18:58:35 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:42885 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1eOplC-0006A6-On; Tue, 12 Dec 2017 10:58:34 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1eOplC-0007hl-MB; Tue, 12 Dec 2017 10:58:34 -0800 Received: from xsj-pvapsmtp01 (maildrop.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id vBCIwPUn026257; Tue, 12 Dec 2017 10:58:25 -0800 Received: from [172.19.2.220] (helo=xsjalistai50.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1eOpl3-0007gm-GQ; Tue, 12 Dec 2017 10:58:25 -0800 From: Alistair Francis To: , , Date: Tue, 12 Dec 2017 10:54:16 -0800 Message-ID: <19836f3e0a298b13343c5a59c87425355e7fd8bd.1513104804.git.alistair.francis@xilinx.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23524.006 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(39860400002)(346002)(2980300002)(438002)(189003)(199004)(51416003)(48376002)(478600001)(63266004)(4326008)(76176011)(7696005)(106002)(2906002)(16586007)(2950100002)(110136005)(54906003)(575784001)(9786002)(36756003)(316002)(305945005)(356003)(118296001)(59450400001)(77096006)(2201001)(36386004)(39060400002)(6666003)(47776003)(106466001)(8676002)(81166006)(8936002)(81156014)(50226002)(50466002)(5660300001)(107986001)(5001870100001)(2101003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR02MB1343; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2NAM02FT035; 1:R0QtEHeHEH0x4nMOsMoN+34jwSsW6rZ1Y4lkVVlOBUbBMzMI6TPP53KDPiKjkzyE5QJjz+xiIM5BVFU9bvAnlpOlXDLdpCQcatfsrmDf/3RtWYjSikBAFLqxGn3zTDgr MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a69de956-13aa-4c44-a69c-08d54192590e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(4608076)(2017052603307); SRVR:SN1PR02MB1343; X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1343; 3:/Lv8S+hVdYEtZ+kcAxiKbKI42NR5OomjKKI4L3i6vfvd94rSbhGbStozvy9fMTa+HrPLalBTELk5B4BgdPyuDZG/nm0QDk8eVe5830Ois8uOTwLxD9w6YhQ1owPopP7YeRLj2tuy/8QHk5ioRaWnOI8wtg9cssKUOieDl1BBWWFa9mNCjEZlDpa9x5XwdBYF4cgmLVXc9yvNQwLs5iIZUzTYyK9+frxLNCXe+TbhPvXCMU5gzDZiHrts3xZpsxao8o17vfhAAGgkiZyiNLuzaWAIw3eXFvSllGLSgzorbaKGvswN5tKd3Au5NHIKz3trruX9r8kUIFw1lZMU6GFgbAR/g3rDjh+C7xLbdg3vGqA=; 25:ucDmrzJdcnLUwzk106bufuy500W83ZpHfSdB8jd3fVyoevAyWRfwoWTeOkXwZZjUPGsKvQWB6SkepHKMR++akCCAsfi28/VlpbmX0w5F2p970eAYqCdXkgfKrXGONor4wxn6UK3x56/LFe3SuFtEJR1hgjMhcB62gZq3CBBgjcZGV6/v5zjLH53B/phZiB0DHO4ezoOvvtqQwHFJpjW/ZwIMv7BC17zZCv6tK6n2RqZYIneT2ItkUuXlEO6OrK8yU6fTJN4bI+OZIgd2KXzZzVBSOnwEV481hb1YEaYLnDzTUZiHatQGpsJdV7VDOJ5zj/+m6ZG4MMZSO+4twnamtMEh2+ooJszToAM39vHbcHk= X-MS-TrafficTypeDiagnostic: SN1PR02MB1343: X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1343; 31:NV++Rp2+jTdE0R8NGUvjVxsPTPHIzDaqYHHv04c/vhdo775byRKcvbf6dFCkqG49kZSt6dUqK5GbGF1B6WQO4pzee88ATQu3UAlEBDIW8OhqxxQWqKpNyONSWbOhnhtq7xHtUDq9hTye6jc5HHZLWAMgVrsxTgq0MLRcgwR8MwuEeZkpiryR58m2kcSlUeswL9LFqAKXQsUACD/IB5eht7p61OPGa6cK/jG47ixMmc8=; 20:bDjSFAeZVSNFjaDF0xwkpd+uQ8d06Izc94y/ae2gfqng5R9bEE3CB+3I44taiwgJlUHD4PWEb2JwJ4pct1XSmIKHkGmiiwK+6csqOhVhFRWPv3pUJQyWTjaiGCDhVFR683JkOymMe4MuowxuxPOwRcc1RCP893bQL2B9LzNa+V0gQGoABBvz383jzb0JU/u2dgoihhDUHgKRmFCpLavDbgWElIxfkDaqWcnM8wAO4onbuQCpjJZxsmVBnHnaZeNPElWCdFFgr/5ZigFKa3ZVzPMWnEHZs8tjES0m+9AtI1Gu1XkqjrGWqYC+1TqSUw5uhYlXlnglL45kkpnpObEJSbmU2PdIcW3a4NXzLcwjPRVpVvL1OCeAMwfatXOtPX8ofar+AvMXNHLd92X7uS2eizbGonr2Neero2Bb7UMymVSBQAyeQa/ktlCVdV3TE90LXL+K4U8YvY8xkAxLDNupd4LzWy1+4x6iN5018shsh/C8bzRWdj+JkBMfhIdl09Cb X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(93006095)(93004095)(3002001)(3231023)(10201501046)(6055026)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123564025)(6072148)(201708071742011); SRVR:SN1PR02MB1343; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:SN1PR02MB1343; X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1343; 4:UKQNrnETB88jH7zvaoLphzPymNwou62NoW3eMDqIdbpW+kj+zcem6NgV1omfkSI9/idN0egikbxrGbRVaj0ka1uHs9SaXBBNptx3FKs9XfV0grfFxCV1q/bUmWSQcqAnbHnymwzVC4+QGVUcjhYRX5NlAfflGwW8nv48/n2+uLmozG5E6PYAog+8Ipl/zSljgxChSKPmbUcDnZr+mEBJQQaZm4L85+sjUAP3tikehz3ogeLz+RVNt4mClmGwW/LjGCFsu8sEA5tSopoQ2Im0y6aSYWRV8eg5prMRHMaP9Vtu2X4Qn23OU+1RTXRozf2q X-Forefront-PRVS: 051900244E X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR02MB1343; 23:aLnAcfQ5FwOL8TmWxf6vHYFIkd5CZmiBThjs/0EN9?= WkwBlcNTmG0OJWa2BKhM1a+LBThygdeTPaoE24Ma+SM+/3l2qbClPrIv3lBWcFjp3OnfQPwVKkAsZ8vZCTDVZ6KfyelWnm8csRLqWEgZaQS18Fpr7e5Kc8ebPzh6ISjR9VRh+jfqGCwydT4tzBFAmQO8F9vivb6jxzdoxfhf5uTJpipL4iS1mzwIuSpicEyVo9HA3tFcW3hZVOMQgm3ysDH8jV2HAZyIhzSQ6+HvQS4yovNRSFoHV1KTTAAlztEgxS+r+D1jb7Uxq0dquTVLT3WFBceY8TEupud0VljURa6F4NwbAZYD/L66Zr9kTzqkso58q+t8tlC4ddCUJ2etreb0AmCz5Amxt4BNpR34i5ZCnlrs761+5JmW2hQ681GgQZCUbOBBtp5aLgxRkMnwEoEXKfjQwksT8sdzK9gRNRsClqMbB3mNn0oY5ow5QFxH/QGV3UI8z5IQzlDh5jOPx8cnMIzUdZrvQcn1xMWOPvkc44PEHUHPp8RMCx3QJrvW4EET0BbWIIb4le7QtQy8NEp4yga7fMDbNYYKY57tkXHGUx7vhqtC4zMUiUSUSVV2TLPe51HVhctSjoWWlwGyPC+eD0SvjtdTcc/+6C0xkr5Z4BZi4TA45yh6oYdAYjzKCmM70+QnR4UMuNpLLvrYXQLkljj2bWn9KWDVJ6f/NeMm4CP7RlQaj5YvhnjCYMdqpn0gNFifJvCEC24CYR9DKiXnQzG/zsZfyzSdg1yMgtJUd60kHScbIYxVHC7QkGOvmLQbh+MSHwcYPUXZJVZnT27vPeaquqC522V/L1As8DBRmHIXr6CNsxu2S9PtpnnrrVae5yWr/PqjojYcEq2RmDmzlW4AHEUKOj/VoEAL6Pz2CoeS2Aqg9fBviDtXz2OK+0dkmMsgtO1Zxr6Fp75f2GhbywZ3CMHE/CNbpukQ4pRDVwlmo5Mb2qvENYV/RZGLP+0j5Me5ApiErYMujethdy+SmNQW+68F/VQn5ch7HqCQbwExQHDYtAd0PQ0m1aUyB2iz8ccbXSA5tV+rEWzNBxn X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1343; 6:yFUPqsL+eTsN4fUe7fRArbwvkq1iiIceLz5lDK2lSGKpPE6nGqzYbk8fAIMYY/mqBV5AdDfzQKIw5yjevIxY6BMYAIEqxWzN8+MKJ8sFle+SMn36sBSDssA2JxagMPgh29NLyF/BSS0b7gRQByCjdl6qACl8MT4qtmJv+nFuvWZx242d52v0/GB6PZIODFWsJFeQ0ijor27DHZIRxts46o1MU67KhawnHZHOhWJ35+pOTKnR+dGWnf5dpD3hkAZLUDmLP3w3jEClsy/LYEKWPVPw3hrUd2zE0R4BAK2Yj/NikYnYP6VUk7tnrmszSg1tcZaCkFd5tUHF/W9xvA8XrTqGpENZnR85P3lUyd2wwVM=; 5:hDOl+4E78z7lE1IkK5r89IEpOpQJi41mYkgnZxbbMzZVDfifOCMKw2U+el98d207gp2qSpII8y2BD0Ie4jz1JxUrzYfDZPtJXJKHgVvLPKpmyCql6Q+5EFCYslV0usln0tnoSJQ0nkyQB0Rr+/HCrGrvaxLyZu1LvsH/1ApbWhQ=; 24:C/DCZQJJ9yl7PtSs1ZPzggl1hoH2bTqnvO1gS0vbP9vPKnpofnAoAH84jtMmDbf6K41vIwX2f5Zg+HfX4nFh0SsRTHWsET+DX4H/PBX0RjE=; 7:+iSweGh2+XbjJoakdBoL9Z8YOxaS6/CKhWGV5aW9fpbvXEMrGPsf+i484NxCILuoFCjEah3p2KcOqNQ+dWjFEI7u7dpEjCf7HQjS3omHSPCWacSfYWykFno4Zy1QjajXbcxNulUQ+WhqggLlAI4svoHzfTs1O3+EVnokESHeBuMuX1rZ1Dzd6/ARIHCM+p12wDRHjoJuBhHsiG5RIdMDP8479DMeOI1yPydQFdEvfWAiN8YhoxOv/mCrOGIEuYJ/ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2017 18:58:35.5456 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a69de956-13aa-4c44-a69c-08d54192590e X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB1343 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.32.70 Subject: [Qemu-devel] [PATCH-2.12 v3 2/3] xilinx_spips: Set all of the reset values X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, frederic.konrad@adacore.com, frasse.iglesias@gmail.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Following the ZynqMP register spec let's ensure that all reset values are set. Signed-off-by: Alistair Francis Reviewed-by: Francisco Iglesias --- V3: - Match documented name V2: - Don't bother double setting registers hw/ssi/xilinx_spips.c | 35 ++++++++++++++++++++++++++++++----- include/hw/ssi/xilinx_spips.h | 2 +- 2 files changed, 31 insertions(+), 6 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 899db814ee..42d9b04bd3 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -66,6 +66,7 @@ /* interrupt mechanism */ #define R_INTR_STATUS (0x04 / 4) +#define R_INTR_STATUS_RESET (0x104) #define R_INTR_EN (0x08 / 4) #define R_INTR_DIS (0x0C / 4) #define R_INTR_MASK (0x10 / 4) @@ -102,6 +103,9 @@ #define R_SLAVE_IDLE_COUNT (0x24 / 4) #define R_TX_THRES (0x28 / 4) #define R_RX_THRES (0x2C / 4) +#define R_GPIO (0x30 / 4) +#define R_LPBK_DLY_ADJ (0x38 / 4) +#define R_LPBK_DLY_ADJ_RESET (0x33) #define R_TXD1 (0x80 / 4) #define R_TXD2 (0x84 / 4) #define R_TXD3 (0x88 / 4) @@ -140,8 +144,12 @@ #define R_GQSPI_IER (0x108 / 4) #define R_GQSPI_IDR (0x10c / 4) #define R_GQSPI_IMR (0x110 / 4) +#define R_GQSPI_IMR_RESET (0xfbe) #define R_GQSPI_TX_THRESH (0x128 / 4) #define R_GQSPI_RX_THRESH (0x12c / 4) +#define R_GQSPI_GPIO (0x130 / 4) +#define R_GQSPI_LPBK_DLY_ADJ (0x138 / 4) +#define R_GQSPI_LPBK_DLY_ADJ_RESET (0x33) #define R_GQSPI_CNFG (0x100 / 4) FIELD(GQSPI_CNFG, MODE_EN, 30, 2) FIELD(GQSPI_CNFG, GEN_FIFO_START_MODE, 29, 1) @@ -177,8 +185,16 @@ FIELD(GQSPI_GF_SNAPSHOT, EXPONENT, 9, 1) FIELD(GQSPI_GF_SNAPSHOT, DATA_XFER, 8, 1) FIELD(GQSPI_GF_SNAPSHOT, IMMEDIATE_DATA, 0, 8) -#define R_GQSPI_MOD_ID (0x168 / 4) -#define R_GQSPI_MOD_ID_VALUE 0x010A0000 +#define R_GQSPI_MOD_ID (0x1fc / 4) +#define R_GQSPI_MOD_ID_RESET (0x10a0000) + +#define R_QSPIDMA_DST_CTRL (0x80c / 4) +#define R_QSPIDMA_DST_CTRL_RESET (0x803ffa00) +#define R_QSPIDMA_DST_I_MASK (0x820 / 4) +#define R_QSPIDMA_DST_I_MASK_RESET (0xfe) +#define R_QSPIDMA_DST_CTRL2 (0x824 / 4) +#define R_QSPIDMA_DST_CTRL2_RESET (0x081bfff8) + /* size of TXRX FIFOs */ #define RXFF_A (128) #define TXFF_A (128) @@ -351,11 +367,20 @@ static void xlnx_zynqmp_qspips_reset(DeviceState *d) fifo8_reset(&s->rx_fifo_g); fifo8_reset(&s->rx_fifo_g); fifo32_reset(&s->fifo_g); + s->regs[R_INTR_STATUS] = R_INTR_STATUS_RESET; + s->regs[R_GPIO] = 1; + s->regs[R_LPBK_DLY_ADJ] = R_LPBK_DLY_ADJ_RESET; + s->regs[R_GQSPI_GFIFO_THRESH] = 0x10; + s->regs[R_MOD_ID] = 0x01090101; + s->regs[R_GQSPI_IMR] = R_GQSPI_IMR_RESET; s->regs[R_GQSPI_TX_THRESH] = 1; s->regs[R_GQSPI_RX_THRESH] = 1; - s->regs[R_GQSPI_GFIFO_THRESH] = 1; - s->regs[R_GQSPI_IMR] = GQSPI_IXR_MASK; - s->regs[R_MOD_ID] = 0x01090101; + s->regs[R_GQSPI_GPIO] = 1; + s->regs[R_GQSPI_LPBK_DLY_ADJ] = R_GQSPI_LPBK_DLY_ADJ_RESET; + s->regs[R_GQSPI_MOD_ID] = R_GQSPI_MOD_ID_RESET; + s->regs[R_QSPIDMA_DST_CTRL] = R_QSPIDMA_DST_CTRL_RESET; + s->regs[R_QSPIDMA_DST_I_MASK] = R_QSPIDMA_DST_I_MASK_RESET; + s->regs[R_QSPIDMA_DST_CTRL2] = R_QSPIDMA_DST_CTRL2_RESET; s->man_start_com_g = false; s->gqspi_irqline = 0; xlnx_zynqmp_qspips_update_ixr(s); diff --git a/include/hw/ssi/xilinx_spips.h b/include/hw/ssi/xilinx_spips.h index 75fc94ce5d..d398a4e81c 100644 --- a/include/hw/ssi/xilinx_spips.h +++ b/include/hw/ssi/xilinx_spips.h @@ -32,7 +32,7 @@ typedef struct XilinxSPIPS XilinxSPIPS; #define XLNX_SPIPS_R_MAX (0x100 / 4) -#define XLNX_ZYNQMP_SPIPS_R_MAX (0x200 / 4) +#define XLNX_ZYNQMP_SPIPS_R_MAX (0x830 / 4) /* Bite off 4k chunks at a time */ #define LQSPI_CACHE_SIZE 1024 From patchwork Tue Dec 12 18:54:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 847603 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="VW8aZPjm"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yx8Mp6Csnz9t3F for ; Wed, 13 Dec 2017 06:02:30 +1100 (AEDT) Received: from localhost ([::1]:60038 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOpoz-0004kr-1k for incoming@patchwork.ozlabs.org; Tue, 12 Dec 2017 14:02:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOplK-0002UH-LO for qemu-devel@nongnu.org; Tue, 12 Dec 2017 13:58:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOplG-0008Q4-RO for qemu-devel@nongnu.org; Tue, 12 Dec 2017 13:58:42 -0500 Received: from mail-dm3nam03on0063.outbound.protection.outlook.com ([104.47.41.63]:61155 helo=NAM03-DM3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eOplG-0008P0-JD for qemu-devel@nongnu.org; Tue, 12 Dec 2017 13:58:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UL47o2+CIP2+8fiiwdRAJNhk6FCxEx4hmCAhpdlfEAI=; b=VW8aZPjmyv9pDmoVXNKVDE+8jtheLOkPG4NuzQn+hFCtuRioIGXC+fTObLaDJq9JTM0nI8cifV7QS4TMKDcADBHS1hZjIKzT9uYJ37EAeG2tnC7/GT1AC81S9rN1N4SZaSbDTd+zKn99ZmK5xim0i3gFKDNj4vAVDeBeW9OLGEI= Received: from SN4PR0201CA0016.namprd02.prod.outlook.com (10.161.238.154) by SN1PR02MB1344.namprd02.prod.outlook.com (10.162.0.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Tue, 12 Dec 2017 18:58:35 +0000 Received: from SN1NAM02FT010.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::203) by SN4PR0201CA0016.outlook.office365.com (2603:10b6:803:2b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.302.9 via Frontend Transport; Tue, 12 Dec 2017 18:58:35 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; adacore.com; dkim=none (message not signed) header.d=none;adacore.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by SN1NAM02FT010.mail.protection.outlook.com (10.152.72.86) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.302.6 via Frontend Transport; Tue, 12 Dec 2017 18:58:35 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1eOplC-0003FH-QK; Tue, 12 Dec 2017 10:58:34 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1eOplC-0007hl-Nk; Tue, 12 Dec 2017 10:58:34 -0800 Received: from xsj-pvapsmtp01 (smtp2.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id vBCIwSHi032227; Tue, 12 Dec 2017 10:58:28 -0800 Received: from [172.19.2.220] (helo=xsjalistai50.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1eOpl5-0007h0-TD; Tue, 12 Dec 2017 10:58:27 -0800 From: Alistair Francis To: , , Date: Tue, 12 Dec 2017 10:54:18 -0800 Message-ID: X-Mailer: git-send-email 2.14.1 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23524.006 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(376002)(346002)(2980300002)(438002)(199004)(189003)(9786002)(63266004)(77096006)(39060400002)(4326008)(36756003)(54906003)(106466001)(110136005)(356003)(81166006)(16586007)(7696005)(2906002)(305945005)(81156014)(6666003)(50226002)(2950100002)(51416003)(47776003)(8676002)(76176011)(8936002)(5660300001)(106002)(478600001)(36386004)(2201001)(50466002)(48376002)(316002)(118296001)(107986001)(2101003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR02MB1344; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT010; 1:EoP0viZ6t9Gjgbl33F+rVN2gBxMxC336OyLgjKwDje296p4zEwBsVKhJ5JwZFWsipnLIBkwm4v+UxicZqRMB5h59wACfKrwJrZO67hQ11syAITaMnOKhPp3/dChkjjBy MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 55f22089-b4f7-4844-cc16-08d5419258cd X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(4608076)(2017052603307); SRVR:SN1PR02MB1344; X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1344; 3:zJ1jELdKO5qhxPK2lf4kQNPhgBPRaZAOvOEE4SOCBXUwlII+ANCqKvKfK61X4YY4Dn5JceHE4qezOeKqF2feIz/CxVMYY6m+fsuXkRE0mGeCPXSmBBp4HAtmqeDj+hIQ8nA/AlDndEeLBkz0k5ezCxFb6L01VKfSzWMloo0Mia73TrVtNd/bSVedBg19m64gESmhJeUKA58XI26WTIzyUVx4tTbKnFOgqtUiMLA03Va01MHrqQSxsKi7gEPQcrax4bwrAhN4bQPZ/xVaDnVnSzI8SOE6u9igxOuYt1xLw8wAhb8EEF/ZgqWnV8O6YzhoMFNFFEKhnWPLL9gBq+0L9YLa0isatlkMI9dZxiB1qvQ=; 25:mOXvd0LAGC7wcfAa4aKL5xrnpsIh0FZMKqwsvzTqi1pD7h7SI6AQF30406oMK9Kit9kunPnq+fTSzUzmz2EreM5eS58EgPSN192eIi4MtDFTEZgWni6LsCY0ZWqEoxzGk9aaCgXKKGDOiJ4hCfuvN+eknZYEEhcPGQerv0Khd9YsD+ynd3XQKHFdEAlYhPG0Q5p1Z905MyiIPM05cpJXJuPgzU5R5QwzCXQY0FXEhXNeLqnYa14vR63CowvVSBUpg8PI4VYdyARhiI/QAa8AMqgUvSId0+5uZhb+xPasWAhSK44DW3Gy+qHA9LGjnDcgdTMdKrtyAWEvCUtS+OTr1w== X-MS-TrafficTypeDiagnostic: SN1PR02MB1344: X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1344; 31:pUXyA7z6CsKJnFeG2E3MzLSZA8+aAfCI/lIVYbzjqkl2+qNR6uk8nKTJpZWZSS6vhLO1Pewm2h4QOSRZeNUvEOlc6ie9gH2eOR8ojXwPeVoAK4Mr1cA4hOax8+kU7MechhVyaTesGOwoeMfUFvWhJro6yws+r4oviCIOvZkbwCgQpsiGveezkXXAFu9jDLv+crk+lf3r+QjIf9wwDsMD/JNByUFTQTkQsgjbGINtLN8=; 20:fll73IjkE/QjO8YYe0/jr+6X6yam1SiOc0WWouU5RrC7yilwUs++0p6c9swvAMs4ywPS3fIeZ+ecXSmbPWH1pNoxzgQwfejo0d9njwcWN/V1KniChlqwLjbw3kdEt0X/onPkNe49rGFauyrWbmP74VPWnw/lGr3q6O+snu59ImbcMPEU9UlooT6Xw25lxl5NfRfZIbq2lc/bMFui31/C2qyIYHqM8PclN+6AD1bxY5nq08Ki5uxymkUzJAqsOalC0ZoMUof8KCtWTkzjponNz0PJRw4NgkRZTcPat9/Qhjb9WEt9e628j1381e/oI3AQRNUWme+htkzMAcNSb+C90XqXOiVjN5UtPFWsRxZWkfbcSLvi13yi5O5Yw7OemZxR8X0r6V/kWgox6Mr2sLW0L8/4jTM+HVNMmkwIzXqh8S6ULq8IDJSmqaf1rsJndwWAS9I++O6qYa6i6bOPjuQce6QH6cTze3eibqgfN/iV5uqcxOM2/+qmb9ru+agHMcOY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93004095)(3002001)(3231023)(10201501046)(6055026)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123564025)(6072148)(201708071742011); SRVR:SN1PR02MB1344; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:SN1PR02MB1344; X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1344; 4:p2uJnztlEU7l8nBO3uwlOIJsTPb+9OxkrpOWNMgc/X8ofemYQMh2RI/FDp0a0xh06JEZx1Osz6WFBuqm0vffY2J0b1x6XZ6Mnq3YoNSRddqDGDeDNFP5liEYX4Ng3yXyH/7Cu5EGzJrmqEaJc3ud/BJIsnKctgufWaqnJkSZpyVjgpaTew6Qz/kTMITZNSaKFmEOCjjzj3YS+p9XhIv0ixFFL8QFz1UytbBlPxiYxHSU9EI7Jp/8w8IaEcDs2OjoPKZa1caSqUuoU13nyxYcRIL0AV/v7dWHCFMxGYLTSOXBCnjOzL0of8JChtp4kXtL X-Forefront-PRVS: 051900244E X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR02MB1344; 23:G1dejsxJ1IrUFHbkVEsCEAYSeyroQJrDYZyBJjxYD?= xXFm85PzaqIU4tW4/bALxkO1SgQzFhwK3fAEWObguT9gRF6AZjbjkI7U63K5fO3ahutZLH2m3ASXzgFpFJAYMumjpEucXOBE+nh8pHXc01Kqd6c+FTT8xzT0QvIZ/3iuXr9ADtNXloBAi8XyrsuI2mZZ33dhFKWdrhiTpw9iNVXU56lEUImcDrBrYn7NapqJtLOmy7EDzpE6uUBSiB/bAmUBX4Ce737oOyNVz3ZU+zZDL6XHgoYEEVy2wzc6Mm+vwbRny1DqZ+Kqj9A+QGMCyNOyqqCyLZZXMINKzo8dxzSSIbf6ObYc9cvHmXycMJyheQKU+zeiohU2+57OJnIAOPbDR6IdFs7I/YH/uxztIJ5bezrnEG44bJV4gVcrwejdvGkpGS54ZDbIda55BYhi2+McrqQVcUpP5cJUt5muuk0W7yb8vN10UZXEG4RaaPGqpMs+VXOYADucgQVFMkeHYX+TgPc881c0UEV+6mPo+bNPvU/9L/OUW8pdn6+5/631/fyrMEN3XvA8guSGh3MKtqh30qsCKD7+Uio9mEllHkg2ra7v8pon2Wbyy3QR3u82++ICDgdtpt1Xke0hkhZwnlePmji+NzLVv/WEr3EcKAexXVMOCIdxk3WsDzBo0RFXr3Ifb2lRMEuprfSDtceI4JKVskc7u3jtPEKXkq9pdB6cRvI3x6ZU9q0v2450jr3KHaIZ1rpOioMTV+oWQqxKwqscngLphYyz8Mv11CeO6KLh59+6XRU3sJiDSHucUiv+XAWPK1XkxLVQ4uEHQ/4iMNSmlDSdzfW2fZxm021RE0ol1U8VXyIssIge17cVKeiJyiSIFy/yyod/NvEe6ZGkRZ3erByhWM/pAMjvzOk/VR9EbUcO01Mr9IMc+W+lnttop0+ckjRugME+5fO4JSt9GiDfnq1pacS79+B6u8+l1w2+j97AKur//VhiLQRMRf3umQ= X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1344; 6:KYPvOvgaZNZBLLddUP9HqnOC8DfZKsqWDxefCpcdG9/bei/HsBR/qF/iTQGPjvRgeqxrhJzIM4ITlDBg60IZx/2xOl3PjbtorcoO86ghPkdAby8yLNWRWN3zDUkj7oOrufuLWB2AsHNk9M+fdJaEDpzRk+0JT9LryHhAhBeYEZBN3xBNDAG0MM9eKWni826a+8jca3UBrSpFM9G/QNefnBI6helpHABJF7RwxVD96otThI2CU/I+A8BBaZl/WscCbky5OmPLgDt928kqytZ3+/LSCnWQRXtDPqCxaUBmZNvM7O1+Yj4NNLrLFMjruq1BJNqWhURCRwCEwaIU7YO/MKKip9IxlWY6e2x4u/qmXR8=; 5:GMoL3ZlGXkh5/J4q2xA1uPxl2vcCkrZyrpJT5HjiDPFARyKMdCKYCdyCPAapRLxqDelIca+F/C5NnpPgJTIl9+arz8OZIdHc1PRC/cGf73abA4VtwHpYvFTzstrDwvWvZMy9Bda0MUvhBJlxGIb/oIzAPgWpsv3C7Y6FhWJSDRw=; 24:htqW2cFQN6KiHBBnQjyTyBYGgMgRiNSdpKQl+3aCv974xGHzF27ECP4yvvh6tWAsr8/Z7YPKIG5r3yfFCKlNPYQoI6w2eESoPpoQl9s6pBw=; 7:W8Fe38kgyKwyg4w1+Uc2GHSSJ+pgH8UH8LFAi926EXRx7LA/qFevwPNItNM2u3G/zHap6Dbk71sItw/0Aam6Hj3dbAOcnjLj6Bu1IEzwElDpSeYQHsPD2rNPxPrhu2O4rnwZFI3Ea5Dhb3VUM+Omt3MjVeKHAqEQ/+LcIy1oBuZeAzV7QvnRBGMDw6nwvofBvwtGI8QEGV76wcyvvMlHD4ZJwKos21WO7xEcrG85iRPMlysKfsIlEBvLPo57wUaN SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2017 18:58:35.1674 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55f22089-b4f7-4844-cc16-08d5419258cd X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB1344 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.41.63 Subject: [Qemu-devel] [PATCH-2.12 v3 3/3] xilinx_spips: Use memset instead of a for loop to zero registers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, frederic.konrad@adacore.com, frasse.iglesias@gmail.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Use memset() instead of a for loop to zero all of the registers. Signed-off-by: Alistair Francis Reviewed-by: KONRAD Frederic Reviewed-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 42d9b04bd3..d8187fadd1 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -329,10 +329,7 @@ static void xilinx_spips_reset(DeviceState *d) { XilinxSPIPS *s = XILINX_SPIPS(d); - int i; - for (i = 0; i < XLNX_SPIPS_R_MAX; i++) { - s->regs[i] = 0; - } + memset(s->regs, 0, sizeof(s->regs)); fifo8_reset(&s->rx_fifo); fifo8_reset(&s->rx_fifo); @@ -357,13 +354,11 @@ static void xilinx_spips_reset(DeviceState *d) static void xlnx_zynqmp_qspips_reset(DeviceState *d) { XlnxZynqMPQSPIPS *s = XLNX_ZYNQMP_QSPIPS(d); - int i; xilinx_spips_reset(d); - for (i = 0; i < XLNX_ZYNQMP_SPIPS_R_MAX; i++) { - s->regs[i] = 0; - } + memset(s->regs, 0, sizeof(s->regs)); + fifo8_reset(&s->rx_fifo_g); fifo8_reset(&s->rx_fifo_g); fifo32_reset(&s->fifo_g);