From patchwork Wed Dec 6 21:11:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 845357 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ysWhZ6DFvz9s74 for ; Thu, 7 Dec 2017 08:19:26 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3ysWhZ53vVzF0Gy for ; Thu, 7 Dec 2017 08:19:26 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.15.3; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3ysWf52g5FzDrbq for ; Thu, 7 Dec 2017 08:17:16 +1100 (AEDT) Received: from [192.168.1.3] ([77.182.86.166]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MHGJ1-1eJ8Ts1KvT-00E5YU; Wed, 06 Dec 2017 22:11:51 +0100 Subject: [PATCH 1/3] tty/serial/ucc_uart: Delete an error message for a failed memory allocation in ucc_uart_probe() From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Timur Tabi References: <5c6d363d-398b-4695-78c3-33b9e8dbffa3@users.sourceforge.net> Message-ID: Date: Wed, 6 Dec 2017 22:11:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <5c6d363d-398b-4695-78c3-33b9e8dbffa3@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:2RSq5Or7dlejv7tHyaxIPj5KZDmYjU71nahW2N9q/fPMEubu6yw f3p7RobvY76tgEgbkp9tRN+kSZQrFNWsObcSW+ABKk7urG48aXpk7/UME842ZfTWuzaWqrJ JY32dv6S66MfUry9fI8Kku7os0fQB6bYpS+fpxUdBe4eJuyjKayUChFs+JJ70zB8lVhKjBb /KaHErokrQdZyzZGls6Uw== X-UI-Out-Filterresults: notjunk:1; V01:K0:WbjG8SDkgGI=:doTEQNJd20t2HgTMjJVQ6J 08N6nQoyJwwRnqrePsqyywOFV6a/e07A9fMuHTklNZH8BD4wu4UhVDA0YgkH7uvIvT6f8rme4 C0n8PesTu7XYoFbLm0ui60PPzingp5q/ZnQMsCqb85ub2r9LUgWZ7p9HM92vgzGHR0ARNFwP7 9VrJY9qXad/GtTG1g+jcQHvpPZ3ZorooqsKwWR6hqi4y3WfNaiQRDrdST/hFZF85yxEjTuczQ d/VpRmpGobhONY9aTKndYpXzu+HG8YY8yBGZnU0BQkd2I/w2hF45/0p//VAyGiW2J8EKCdUSM 38DXmvO8Sl/o7oX5Ot47QJlKnLeszM9Cwh0oyTar/vnDzBRhHfRjdAUgpTRpjadwntXELdI9O 8E0py6A6FRX4ZhC4LwoZ8Vn/77IT4W7qnBHpS9aNraWxRlDMgiii488dH4jzvxnlTzRpiMZz/ +VcgAw9t6O4H/BPYb5Yj/dxRGScyCO36p+X0AUNpQCWTW2Twrb1B7eO6aClYOq7sCILHAWdXA oSIfB/RRQXSvWM3JzwnCp1Y+A0x1nRajEXjBzgXfrKyoykgfXmtvZlH1aORg+IVqd1OCTi4GL AnU+l7NPR4Pff2O9umsJhpXB6Fr6qXaNVxP5aGhDeE4js5VLCsYmdAwWElla8y8m3dj9BGHZf kCkq50wxH0yPxU6dDEK/OnI8Zi2IjppfQ1xHSP1FkzINc2rytafqLHfghdZQQJKEpbX5vcxwk 5J1buEPFytHx+ySnWfvm7OM+Yt44QqVCCWrP4YXJ8ztjwUUyG1tvZU7IIZPQFvvVut/gDtl6q B9BUKQ8Gl41tx8jPilAA2LxFBQZbbh2l2kzFmZCFTtWRsvs0Mvt6sB7uZUBJhwoK7jtJuU7 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Wed, 6 Dec 2017 21:41:14 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/ucc_uart.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c index 2b6376e6e5ad..48364f0eba72 100644 --- a/drivers/tty/serial/ucc_uart.c +++ b/drivers/tty/serial/ucc_uart.c @@ -1254,10 +1254,8 @@ static int ucc_uart_probe(struct platform_device *ofdev) } qe_port = kzalloc(sizeof(struct uart_qe_port), GFP_KERNEL); - if (!qe_port) { - dev_err(&ofdev->dev, "can't allocate QE port structure\n"); + if (!qe_port) return -ENOMEM; - } /* Search for IRQ and mapbase */ ret = of_address_to_resource(np, 0, &res); From patchwork Wed Dec 6 21:12:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 845358 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ysWkp6PJ7z9s74 for ; Thu, 7 Dec 2017 08:21:22 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3ysWkp5JSCzF0Gr for ; Thu, 7 Dec 2017 08:21:22 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.15.4; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3ysWgh6GKdzF06C for ; Thu, 7 Dec 2017 08:18:40 +1100 (AEDT) Received: from [192.168.1.3] ([77.182.86.166]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LnSOM-1ezqm73eCk-00hbPi; Wed, 06 Dec 2017 22:13:22 +0100 Subject: [PATCH 2/3] tty/serial/ucc_uart: Improve a size determination in ucc_uart_probe() From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Timur Tabi References: <5c6d363d-398b-4695-78c3-33b9e8dbffa3@users.sourceforge.net> Message-ID: <38dd53cc-f7e8-57b9-bd0f-0946c787ac2e@users.sourceforge.net> Date: Wed, 6 Dec 2017 22:12:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <5c6d363d-398b-4695-78c3-33b9e8dbffa3@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:NCNzkvvHHx8nJskUWjGDBxV79mC1P1iIcKBRFlxye25z4GLQPMn cBsmCRKSIXvTRo7YT6KhzIcemL8j/x1uprkRuyaDPkxDOiReXJZtoW9F4xLd1/uXfnZ8uJ5 bknOF6rYEXlUpSM5aMkgOrncKg2coYdxY9ht+G+pMdQkDUr9JovmtqMQNRBl6p78ADWCuix 5979hBWfoF114Yd/mqB1g== X-UI-Out-Filterresults: notjunk:1; V01:K0:pphOAcwKPYA=:WewVIfi1KdvhZDwO+K+oO/ vRlSwoW43Mu56XATbOSfi4mfAno52YErP8BvM7Dkl7N9n12ZwkNiJPb4O7WVUk/OINhScB9x4 /DaCX5265znuaKU06zd9IXvE2ECR/r2gF4onBrQmNKmeul3SsgyG1SNEeiMoln84ukGwjlpRL bhI4RMsgJFvPLz1utG3I4yWINW4uXBU8qnTD9C2OzwOZWsxfLnElK/ZJ8GaEf/3Cx93KhRslT x0jCUMEXS5okR9Du1jqGcx3FZkyastkzzhe2zIO5FNAEhjFZiJpJH3pMrfSFirY3AT7xJRlOR VWXgBMlkUM/KQ9HIAMxRlNomGYbi6qt+51nIMtmuD1CwR8HCFomNtDCAsIG2WoH+OYCzunSwg adUws3JeIcGArHewnX4ctBnbvedYsHkfHxyjFGw8jxl8U414Y5BasvwCxBT30Rtz06jHOHW95 oqC0cfzeVo6Dt1csOWVvg5fz4+0dCpAY1B96mIr3yJSeEcd/uFcb48aJVHNbA5laRvDRnpO/g mK2AT4mWeZEwUqq/+PttlHpUnl2jSc+plQAe8rtc8Jj0vb/cEmv/e+U/peNnu0fvtRtEA2IQv v3tJQU00Q+T/Ad4osP/RvXPZRjGzEIfTftwW2S2kKYXnFt2KYOliaW/ENoV92RqLDmt1iAHk5 t/qtYBupwMqA6FjDISlBK5mRtgeR9no/eeDrcBr1BW8ihBVKaid1MUv3SieJG3tGUELRG/iEv iiDC0NJAbq1WFQXi756p/8YOBscRKtI+/Cn4SZVaelUznFgxDIy7qEgxjvFfn3r3+rVdgZ7Ea /ielcPrEUbpbrTtN66vJnUKHWSXzkVt+eQt8UZsGEIpWCReFUobFyk8VkjQI+9rQ/zJ2Hdi X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Wed, 6 Dec 2017 21:45:32 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/ucc_uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c index 48364f0eba72..a9ce652899aa 100644 --- a/drivers/tty/serial/ucc_uart.c +++ b/drivers/tty/serial/ucc_uart.c @@ -1253,7 +1253,7 @@ static int ucc_uart_probe(struct platform_device *ofdev) } } - qe_port = kzalloc(sizeof(struct uart_qe_port), GFP_KERNEL); + qe_port = kzalloc(sizeof(*qe_port), GFP_KERNEL); if (!qe_port) return -ENOMEM; From patchwork Wed Dec 6 21:14:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 845359 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ysWmx6jGlz9s74 for ; Thu, 7 Dec 2017 08:23:13 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3ysWmx5MwbzF0H6 for ; Thu, 7 Dec 2017 08:23:13 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.15.3; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3ysWkp1PnLzF0H3 for ; Thu, 7 Dec 2017 08:21:21 +1100 (AEDT) Received: from [192.168.1.3] ([77.182.86.166]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MN47k-1eOrop1DSa-006cjB; Wed, 06 Dec 2017 22:15:07 +0100 Subject: [PATCH 3/3] tty/serial/ucc_uart: Fix a typo in a comment line From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Timur Tabi References: <5c6d363d-398b-4695-78c3-33b9e8dbffa3@users.sourceforge.net> Message-ID: Date: Wed, 6 Dec 2017 22:14:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <5c6d363d-398b-4695-78c3-33b9e8dbffa3@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:ENrEaRPAnPhZw5C59dBd4VgwNqKGZQfzDhM5LQcgqKYQKUqJ8WH VZ+X+ZJ8YZj1fQl5WqXKeBdPCcmXe371JFstPWHfNoc2TKP9WYvXDBC1n1716S+6o5dNUHD J/oagtgg7xLS0w7c/KPvW1WHoQFsnTAISlpq7dMdZPdOIxbi083rOqB9NY/2Ecp2f1+dudv fPhyHj/TJVKEINrS8Ujkg== X-UI-Out-Filterresults: notjunk:1; V01:K0:66yLc8QrWbY=:SA4UF+5YuMenxo+9dxECqa ZNDhsWvj5Fbh4Gi6R0tiEEZr0fz8itI5d1Z8Jtnyp4yBn80lH2OSh19BJ2gNjPVLikG16/NoA PEjAr3iywBY4254aos56HHRF/+R7TlfcXDq5wMCb7GDZAtQnS21zYupZ/Is2WKEisxNYFQZjY SDXhAentq1z+oWxTeIu2sZ7Zen1/m5oZM+J8FkZYeoy7iZfB3pSB3rIOFz+A7KcROCfCmUa1d DanJIW96rY5578HaoXkSt1HcagRL43fcThyli2TtMERPEzSiX5qOIVp/wmW3Xd5IKyfqklhWh zZD/l/g3CKWmMrDJAdrEMe94q2pSKNAMmNJQHZiUNSUsTmcjoCgc4zTpP9r7ERPoDbPAiADTp FN3134/Wgu6/k1EoZ56VaR/Jn/DXQgzXCpK5YK2RsCQyDrm6iopKSqLNvczYhMk2pUEavgv9e rin5Vdh6ZFvi6aQ63l6SJS9tjWUFJxVh9qZIMdEjGaA6Xhu6sfRpFrQWNQzxk8mgAsaRtKESZ hCSGzzxUfjIozUdLhy/UU1xSSfvJZLbgywzufm+4WCc/ryiplToHSoVTbJv3/hMhbD4u6cdQl TzPlPdcboliS0S44qVYsnIOBZMuVHl3vzsdssCApMDWtz7kRGagaoLpQN6Jj5XAs0vv5IzfKf 0wcqIVk3EAKMrQKRkfPMQg3q/Iu0n3InclgMKm3hB+bOFG2aXr5jXHm3iILEkFa/f5b8FmOeo If0EV3YXxVrE0kUTfg6jUY2j/f8BQNJ9jL2hf0Zuw4XUKECOtKLGIXwcFwavfH9XtoDUeBrKd B5CaSU8L1bz+V6Mb6NlwLLOzl5Z0hoPBYzkSM4fs3Ne7hROJyyfyixNeeL+AXO0gsHmDjGL X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: trivial@kernel.org, kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Wed, 6 Dec 2017 21:56:28 +0100 Add a missing character in a function name of this description. Signed-off-by: Markus Elfring --- drivers/tty/serial/ucc_uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c index a9ce652899aa..d0f139d897a2 100644 --- a/drivers/tty/serial/ucc_uart.c +++ b/drivers/tty/serial/ucc_uart.c @@ -1154,7 +1154,7 @@ static unsigned int soc_info(unsigned int *rev_h, unsigned int *rev_l) } /* - * requst_firmware_nowait() callback function + * request_firmware_nowait() callback function * * This function is called by the kernel when a firmware is made available, * or if it times out waiting for the firmware.