From patchwork Wed Jan 8 16:02:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1219765 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47tDbB20xfz9sNx for ; Thu, 9 Jan 2020 03:04:38 +1100 (AEDT) Received: from localhost ([::1]:46026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipDox-0006wV-EQ for incoming@patchwork.ozlabs.org; Wed, 08 Jan 2020 11:04:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36366) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipDnH-0005e2-Tg for qemu-devel@nongnu.org; Wed, 08 Jan 2020 11:02:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipDnG-0001q7-QQ for qemu-devel@nongnu.org; Wed, 08 Jan 2020 11:02:51 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:56181) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ipDnC-0001l3-9a; Wed, 08 Jan 2020 11:02:46 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MuDHR-1jgcim0EdZ-00uddu; Wed, 08 Jan 2020 17:02:37 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 1/5] MAINTAINERS: Update Yuval Shaia's email address Date: Wed, 8 Jan 2020 17:02:29 +0100 Message-Id: <20200108160233.991134-2-laurent@vivier.eu> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200108160233.991134-1-laurent@vivier.eu> References: <20200108160233.991134-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:etpxR2CQD/P8Mx74yZqxCD10NlNlT1WxkMSCMaddz7551USEPww JdezFtWmzZj7ETLfTm8o7qVnCFImN4PnMpPFSxqsz11/AN8GkGKQwFbYG42Mp3PafEDluI5 Z4Co8PtSG1JA6264e9ZeYjYwd7NwDRj66+g0P7n2J0S+3gyEfU9TgdNEYVq79+DKrY+bWTn rCS6ARUf+jxjsw5Ku5aKw== X-UI-Out-Filterresults: notjunk:1; V03:K0:spc/qM3I/Cw=:DF/no3hmC0l74czZf9S96B aRY7ZFUhvkSprunFk356cmbXDclEOjkdkTBekbdQcH4I4GBGDKHNcTNkFVqhvnh813xtLpn0G hvANNHFalnIOFjPGomGhVJ0fY4WCC/6MdRWwTzQxIOQ39niJ2vlPAPCtAQAHyu90Hq+6klNK4 BNpKXlcuiS3HY29WAKmtaaQgUsHk/lDYLCGoVJpdgAw3/Xg3bj85sDcwEOO8x73VWKXPSU7SI zgCUCc8s9UUOQu/RgkQuM0F6Nfmw8L2bpciyUGzJRiAH1N82gUP+XT7FqDHFrZQtJdrqCqI4X 6lnU1bQl28er20h836YWjmh3FbPNS1K4ALaDA3TzWml8km6mNln5HGa7pNbM9jobnmjAemuaD 4nxHHqpVMxLmQd9w/N/h812oyodORg+GBDPEKKejeuYZJ0m94/QzLKGScOmPtrHoXdbVG6POa PiATL2ogNnx4Y+L3BBUO0yebNjBLOsZpXX4QH+/+Gp1MbxK2QHmVBTRvUU9By4Ki1eHCF9CfT NjbNGwLPPtT6iWcvamcaJ3X/3StqaPbBBIFSWleUSZk6abLjoM4S4SrgB2JMeSNaR3gt0lGhy XGeLqTiuuTbIJauVKkVxLKnUdbeGsrWerBSv8SKXWv7vOSadYnBzhg+H3xKC4H3hMcGqooabH ObAKKouRnuG5aaWdicwaBjipsU3IPz/hfyKJes57b64/aY1t8qYtc+twfc1QJQcA2L0RZV20L 2S4+koinZLYbycTph3xtEohGIaoe+7Yep3uZhUqLzdAj83232Pb1R62wTUv1Rg/nuUm5xKI6D UuLpgzdzIUOgaseQX43iAo8zR3rFRkNQ1RC9Zlk2P7AW0YLwo+EsCPgzeldlynOdXJghrusdm Oxs3Ozn3lKFiy6VclLYw== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.131 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Yuval Shaia , qemu-arm@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Yuval Shaia Use gmail account for maintainer tasks. Signed-off-by: Yuval Shaia Acked-by: Marcel Apfelbaum Message-Id: <20191126102637.2038-1-yuval.shaia@oracle.com> Signed-off-by: Laurent Vivier --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cd2dc137a3a9..df0893cd4cfe 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2659,7 +2659,7 @@ F: tests/test-replication.c F: docs/block-replication.txt PVRDMA -M: Yuval Shaia +M: Yuval Shaia M: Marcel Apfelbaum S: Maintained F: hw/rdma/* From patchwork Wed Jan 8 16:02:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1219771 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47tDgf29cRz9sRf for ; Thu, 9 Jan 2020 03:08:30 +1100 (AEDT) Received: from localhost ([::1]:46090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipDsh-0004Sk-NC for incoming@patchwork.ozlabs.org; Wed, 08 Jan 2020 11:08:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36646) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipDnX-0005y3-6j for qemu-devel@nongnu.org; Wed, 08 Jan 2020 11:03:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipDnS-00020s-9M for qemu-devel@nongnu.org; Wed, 08 Jan 2020 11:03:07 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:39255) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ipDnJ-0001sA-EB; Wed, 08 Jan 2020 11:02:53 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N8GhM-1jkA294BG4-014Cq3; Wed, 08 Jan 2020 17:02:38 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 2/5] util/module: fix a memory leak Date: Wed, 8 Jan 2020 17:02:30 +0100 Message-Id: <20200108160233.991134-3-laurent@vivier.eu> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200108160233.991134-1-laurent@vivier.eu> References: <20200108160233.991134-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:hS/W2JMW7nZSLC0eATbtBj6PivLfM45GzikAafYooWqOMTH/Eae 7iyfqSvy+QZsEMwCgFBCGdCN2lO3755qEwf2A5s5iXi/c55NekWtqO0o0nj+XgneyWcm9hR zOIYvWOmuyGgG52AKn+Zmz3+lbmUtietPv2AGLu2vrEzB4Aslp1mK0Fi4HTEmmgoboGYb6S RLjOe5BZ9BPh5XSKddV9A== X-UI-Out-Filterresults: notjunk:1; V03:K0:V2H1zfct0lA=:qw+R8WMdzOZiTSvJHc7vHG 0SbNg+CnBwgIfzQ6uICPhUe1nt5EiS5WbesfBq40iXKc8RsxsfKdNnS3XazU6XXDoeXve6/gx VFaQWVkz8ZXDCCIUNaTgKmbMb8Ma2UPnNB6LxbwulJ4BJP+L/nhHw7/VAgha1PqxLs053MEUV RUE0YjMChw21AODNGbTDHmXrIdHKnS1o/Jp8RE/3vrexJ44V4LQCH+7RjHBNF89uIpVhRWnaP aG3tbu9LrfivyxRCimlQQ6BpGbI3ZXZKiNFwqelxWzPjeOmRQtBZwHPjOa4JKhAu4N1qtDUeM XozihjDBOMx7JNagAyVH5/lMwz7wJpKnLWkcK4oJvu96xGr0qcg08Ksq9PieDqZmK+0XHOvQb WWHlR8BqKMxuOCwz4RXh+IoUSfLyOTNIyFPi9/cEhmPGSPUltFQmwOD//uAF1wZ+FenhXa8p4 xcZg/Pc3XgKabGyeYEF+2VjE0X++MXlgB3ZEkds3d0EVXMB3D5HkI16KWdcDsZWRGNwH59Oav C1xkKXwzafLAEEvP7BPKKA5QDt5Z2kFOjlPU2dOHyxfFlGqbvXu0zss0NF5scM1sKB+KFXUg3 dX2HB9Gtx2DOxkotJV5j8gICaqMLtM0f/kj58Rl3CfSqm2gw8cZDTY+MYt/PklueajohPfVJa 82UWDJYPF872CWXvVlC9F/RqK1L9gQLzGoq11TQNsiMSggwSYHVXZSqUgCqsLiRllc/0Ow/ne TEpK6sBtSI3LZ6i9MGy8EgXkXEpz8eiYySjWWe8MGegy3tnJGz1cPoqex/7oG21fbP/delnX1 tyzMjoLJuhFVIkzWrviw9ckMoKF4mQPOzBvHMbmaH8RovYW4RiweZ9X6S2u1hy4AmUDvBXnse sx6i+5LUo6PLNg5iivWg== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.187 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Pan Nengyuan , Michael Tokarev , Laurent Vivier , Markus Armbruster , qemu-arm@nongnu.org, Euler Robot , Paolo Bonzini Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Pan Nengyuan spotted by ASAN Fixes: 81d8ccb1bea4fb9eaaf4c8e30bd4021180a9a39f Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Markus Armbruster Message-Id: <1576805650-16380-1-git-send-email-pannengyuan@huawei.com> Signed-off-by: Laurent Vivier --- util/module.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/module.c b/util/module.c index e9fe3e5422ad..8c5315a7a307 100644 --- a/util/module.c +++ b/util/module.c @@ -214,6 +214,7 @@ bool module_load_one(const char *prefix, const char *lib_name) if (!success) { g_hash_table_remove(loaded_modules, module_name); + g_free(module_name); } for (i = 0; i < n_dirs; i++) { From patchwork Wed Jan 8 16:02:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1219766 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47tDbF2KxXz9sNx for ; Thu, 9 Jan 2020 03:04:41 +1100 (AEDT) Received: from localhost ([::1]:46028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipDp0-0007Az-Nh for incoming@patchwork.ozlabs.org; Wed, 08 Jan 2020 11:04:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36637) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipDnW-0005xa-RX for qemu-devel@nongnu.org; Wed, 08 Jan 2020 11:03:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipDnV-00023v-KP for qemu-devel@nongnu.org; Wed, 08 Jan 2020 11:03:06 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:37357) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ipDnJ-0001sl-TQ; Wed, 08 Jan 2020 11:02:54 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MSswA-1jH9k041Ms-00ULNl; Wed, 08 Jan 2020 17:02:39 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 3/5] nbd: fix uninitialized variable warning Date: Wed, 8 Jan 2020 17:02:31 +0100 Message-Id: <20200108160233.991134-4-laurent@vivier.eu> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200108160233.991134-1-laurent@vivier.eu> References: <20200108160233.991134-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:/EYbbloMlE/mMInqy/wdNfBC3RP04ti36AzGOyWwDHvqGvzbFHS v208escUAmxXixQMpRzprBjxVZjUoGNrRCODviDRVNYwEugYcBQieTDNwHOOD/6ZIIlIaYw KA+Be91bIDGmuZ0G/UBFArstWuyyb2NLijwwhX6UPa+txMmfD9lRrMyQY5cjXKCQW9iu26V iF8KcNVXo2nNpXAzErDhQ== X-UI-Out-Filterresults: notjunk:1; V03:K0:iOjUjdSmKnQ=:6tycorvo7+rtQ6XdOUOAUt H+pbOWqu7gT3UNfWGYuxNfdl6c2ZUoBAoErARBoEQU72X49+mIsnESZ0U7/bB4nvctT/LOOuv B3t5mpG7hmAxMXWw4vTM3y9S+kAToNaKwHRW3Az8rnEX7iDQy9ONUCHT5YJVDAC6waMnsoJiG NgEqnYDMfGq9IKDtd1Tr3Ga0FVO8FnoSEvb9RYjg2j1WeKHSfLWCCovmONA8pImZB4q0uU7rG x5LfCWSBIPmAkAA78x+7NUPWkIgrlE0Vy+PCJIbWNGZuZmzdUsKKa2xUmKFAY0Rj2/EwC7MUZ Evb1vtFiJspXYnYPmiXIlcwKT0OlvgS6mVPJyTQKA8FoGjZqDC05AG9xp/TBn24DtgnNx94oZ TSHXX8xuZNBrmKP7tqhEz3xc4LLQN5IMHB55125TZZQ+FPCDZfCRhzLZBOVaZgtoAsT5s+VV5 cE5DSjvWk0sMLo8FtfS79ZVMQaSmRX56H+/YiHN7mgl1mV3RGkuglaPmGr+zq+Y+PTPKbQ8oB Usdkw70/6UqQqARMiLbrZMp17tVyuWlA9anI/HDiJUGmvw3Tfg09GpYWANiUsiA7/KYgjDMsd mboQq8U4UzTSXSjBtm8ByH8I/WSJjDIjFkGpUsSjhCJnlm386Xg7sq0DIxZt8vgmfa6Xy9cob TQV+lDvuhgwu1ntcEmoBcpl7yhzVyjYHM9xc4YQt6SEJHjsxKfHrswa7GPOOejC3egv4pRIR+ sxnylE6ZOMNmqZFaKxx/yuLmAxZOef///mCsX36rK35jvrZSirGgkh46ckbqXKnF05ACGgGZd TLLWSonKCtqnm7JaZ+gBsY2Nse5odRhUAa/ZHlQ9Y7CVjd8/r3b94O9ithaZrZdTBUYqOKy0d ZHuvl/3lstAYoyDKpsjA== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.187 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Pan Nengyuan , Michael Tokarev , Laurent Vivier , qemu-arm@nongnu.org, Euler Robot , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Pan Nengyuan Fixes: /mnt/sdb/qemu/nbd/server.c: In function 'nbd_handle_request': /mnt/sdb/qemu/nbd/server.c:2313:9: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] int ret; Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id: <20200108025132.46956-1-pannengyuan@huawei.com> Signed-off-by: Laurent Vivier --- nbd/server.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index 24ebc1a80571..87fcd2e7bfac 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -2384,20 +2384,12 @@ static coroutine_fn int nbd_handle_request(NBDClient *client, !client->export_meta.bitmap, NBD_META_ID_BASE_ALLOCATION, errp); - if (ret < 0) { - return ret; - } - } - - if (client->export_meta.bitmap) { + } else { /* client->export_meta.bitmap */ ret = nbd_co_send_bitmap(client, request->handle, client->exp->export_bitmap, request->from, request->len, dont_fragment, true, NBD_META_ID_DIRTY_BITMAP, errp); - if (ret < 0) { - return ret; - } } return ret; From patchwork Wed Jan 8 16:02:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1219769 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47tDfC4B8dz9sRf for ; Thu, 9 Jan 2020 03:07:15 +1100 (AEDT) Received: from localhost ([::1]:46071 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipDrV-0002nd-15 for incoming@patchwork.ozlabs.org; Wed, 08 Jan 2020 11:07:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36680) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipDnY-0005zj-AW for qemu-devel@nongnu.org; Wed, 08 Jan 2020 11:03:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipDnX-00025A-2M for qemu-devel@nongnu.org; Wed, 08 Jan 2020 11:03:08 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:46689) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ipDnK-0001tl-Lk; Wed, 08 Jan 2020 11:02:54 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N5mWp-1jmd0O4C7v-017F6e; Wed, 08 Jan 2020 17:02:40 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 4/5] arm/translate-a64: fix uninitialized variable warning Date: Wed, 8 Jan 2020 17:02:32 +0100 Message-Id: <20200108160233.991134-5-laurent@vivier.eu> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200108160233.991134-1-laurent@vivier.eu> References: <20200108160233.991134-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:EHnKO7J//24FrZUg1j5EIhq7KWvRVTiEIll+WUa35nyi5IL7Tzh ePKu/lTxyjEGo2CJgXrXlBESFDb4nLEwOexjcPUoLntfZ65SYP/HxOsb3KOu92ZrSUlkPiA h/G+s05PwjTZjcDlVxEffhkdpwxYipDYsQ9a0ECbdAEQyXAY/R78dTx/qog3VB3u7n+2ovH 3FvNgcWftBwkIAsAFRcFw== X-UI-Out-Filterresults: notjunk:1; V03:K0:kp8Eg0YxKM4=:Ez7+Vo4nmSWoZpQ1sfoR1j TlLb05P6sWZj1pWDrDa8ZoMsiWLK2QlImCTTpgmhcZE4924VP1DfouXPx0YGMYoJhmZB/NZO8 XqEhHNLHB9J+tcB+KO/SwRu9YaF2u94o61/HuhhZgSnSyH3NtVrz1zXGiH6Km/tJOdO6U9NjU OwMWx+RhF0L+itcsPbeRp/+HjnNwFXtOIOyH79VyaJJawDmC2ivHrDzQmYqFp1HcM6L4Y4pbQ +wQftz0gT0xXcmvjQO1BOwxcrOMmbkF6Vn4H//1vYJdPq1dliHFEyxSTSeyitZZvRMXp3eA1O EWm12TFCI8TloyA4jdTLlbSYS0LUn3DpzlmOkOWP9dtIiL2Z6SkxPXcDefvCCiNAsj5kMW6dG 9SeAJWYyJqgNX5iNoC0V01mJjW4AmzDLLdVPrZwHJQCLf0dPWuzafzJMh7N9tTvNvMVdp8+2C cAkczGi8eTaGc+f2+hdlheaU8WKfYhPNMID1lBKyFQvnaKjwdrh2zilJbqk19CvJrhhpHRMeW rqWfuigEIv+5PFLIuPsB3Tfi+9++mkWgdfC4QeMNchlABu4x+ZKnsRZiBlhViNVWs5YXweH7G IqFX2NQO8nEQjRuF74zh+8TNey+YPGVw4O5BpxfGuiA9YPiZphfrwcd0r6uQBs4waJcZ1hDnI rSKHQpkSyQa/qZ5jFOgl3ijCxt4il2mspnhVXE4MwlHQ3S+7tLsVvkOv5e/e8Ohsi7wtV7sky iyK2gMG7K7Q9cmp5+NW+4A7I/a2hiO2TC3qhctSIHG4/Gngmcr4+Pf7rlSITF+lnuMt1/tF1K vY6dfgOR9C8YjQFCcZp/85JhrrAgFNH3gZv3CM/HtRA3EI/gqVeXpHtWS4Q1jtDehrSo7AycH 5ykwqdja1wAGXaQtpn/5IskW0HuvHtgqBRFegV0Pw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.187 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Pan Nengyuan , Michael Tokarev , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Euler Robot , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Pan Nengyuan Fixes: target/arm/translate-a64.c: In function 'disas_crypto_three_reg_sha512': target/arm/translate-a64.c:13625:9: error: 'genfn' may be used uninitialized in this function [-Werror=maybe-uninitialized] genfn(tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ qemu/target/arm/translate-a64.c:13609:8: error: 'feature' may be used uninitialized in this function [-Werror=maybe-uninitialized] if (!feature) { Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200108023915.52288-1-pannengyuan@huawei.com> Signed-off-by: Laurent Vivier --- target/arm/translate-a64.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index d4bebbe62958..63a3d2668710 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -13585,6 +13585,8 @@ static void disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn) feature = dc_isar_feature(aa64_sha3, s); genfn = NULL; break; + default: + g_assert_not_reached(); } } else { switch (opcode) { From patchwork Wed Jan 8 16:02:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1219768 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47tDdw2wYGz9sRh for ; Thu, 9 Jan 2020 03:07:00 +1100 (AEDT) Received: from localhost ([::1]:46064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipDrF-0002Ll-Q4 for incoming@patchwork.ozlabs.org; Wed, 08 Jan 2020 11:06:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36445) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipDnL-0005hq-9r for qemu-devel@nongnu.org; Wed, 08 Jan 2020 11:02:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipDnK-0001u2-01 for qemu-devel@nongnu.org; Wed, 08 Jan 2020 11:02:55 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:58733) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ipDnJ-0001sQ-MV; Wed, 08 Jan 2020 11:02:53 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MTzve-1jG4Kg3vVK-00R2Wv; Wed, 08 Jan 2020 17:02:41 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 5/5] vl: fix memory leak in configure_accelerators Date: Wed, 8 Jan 2020 17:02:33 +0100 Message-Id: <20200108160233.991134-6-laurent@vivier.eu> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200108160233.991134-1-laurent@vivier.eu> References: <20200108160233.991134-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:dBVTSiGT6cFvz6yTeBe4zQ3GS80X+iAEX9u3kOCQRLeS3Yx6qyC Z7Jc8NEZzFMS9OZL2SVwwtgcFeUk1liIDSGHcUEgQYhV+cPkoiVAfYZuc9QT+fvRL1rBuZM Pc1y4aBeBiCG3rJ1DBPL0A3OQBgnoZ/dZ7eFHwcpEPBXGEYEN5jT0YrXlAkTrxmsqtMhuYX 3w7AyKz6hhJFi5zT4A6Ww== X-UI-Out-Filterresults: notjunk:1; V03:K0:RrWxFiTocSE=:WugAK7Vv6c9O8V7GZ+xfjJ vz140dfW2NBp/RynMhp1c1FrKrHWMWw3JCge/tdA4qRmRD0RKekaDP5Be1ghGzIUtYmfXz7nq lUclvc31IZGoOLviiXBJKTFxCd11D+8dkkFWWya1LQljBAy/i2nsenzc2GaW5FJiIkeode2Nc Y01FwKTtHXHIHbD1EubX7aQx/A+l3d+S/Xsk1CrTr2nmSBJYL/rCIKK7sMoM+q7Va9fTMmP2O UFpTCxgXqFINQlKuGsQyMlv95RFAvPRaNTjRTlbRrBNFV3uPZBA3rcFm7E5E1YLdOVf5f0RbR DDHjdVLvYOwnetDHdvMscEOkdAKd7do6XPT993MMO8bghGxHBVNi1nrcu02JrmIv2BiJiUE97 D5rwH+ouQf72B5w2WfiGizGCgxBGTX/b4g9tt0d3fdWrVVwOyUYyvTNjTiP9d3+DR2aywIYPF DnypHqEkApWtmxcVNzhTa1EhPTxVtKDH33XcyK0ebtoqEcBAPDEcuL1LPtg4TTMaPLJ2DWISA 6kiguTSS/zkDkujZWL9p7Hw/LQHlxelqzHA+lYefLxW5jExC2y0DHpVMPSFQLinwjkq8MIxYT PXmgOHb2VM3/cOdkyLWk7PqDgp3N+s0vDTT3v8Cv3KN5nK0sEc4vzFesB5SlpwqMWuv/E1vTt ZeFr4pgjsYbZhg6bFjBrjvyfwgemmvGbFhRvgCF9u4w+w8qKpR8/GgkLj/inX9zFJMTLPxZ/S 2glPheRbEVZokjWzerT87Qs38RP+JezwIOQvMLWSUzCCujIACkgBv0J5eI2IM4I7url9+amBx WqOEhXscm6Sem5yjs4Hfyw+EFAHUQ+rLfqCuol9Gozr+3CMqWIxJBOIU13UW/g8mvueeN773O +dIcVd3TwuNSFAaJcta742DtrErp9BBV4Vhtzp8Ag= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.133 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-block@nongnu.org, qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Euler Robot , Michael Tokarev , Laurent Vivier , qemu-arm@nongnu.org, Chen Qun , Paolo Bonzini Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Chen Qun The accel_list forgot to free, the asan output: Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0xffff919331cb in __interceptor_malloc (/lib64/libasan.so.4+0xd31cb) #1 0xffff913f7163 in g_malloc (/lib64/libglib-2.0.so.0+0x57163) #2 0xffff91413d9b in g_strsplit (/lib64/libglib-2.0.so.0+0x73d9b) #3 0xaaab42fb58e7 in configure_accelerators /qemu/vl.c:2777 #4 0xaaab42fb58e7 in main /qemu/vl.c:4121 #5 0xffff8f9b0b9f in __libc_start_main (/lib64/libc.so.6+0x20b9f) #6 0xaaab42fc1dab (/qemu/build/aarch64-softmmu/qemu-system-aarch64+0x8b1dab) Indirect leak of 4 byte(s) in 1 object(s) allocated from: #0 0xffff919331cb in __interceptor_malloc (/lib64/libasan.so.4+0xd31cb) #1 0xffff913f7163 in g_malloc (/lib64/libglib-2.0.so.0+0x57163) #2 0xffff9141243b in g_strdup (/lib64/libglib-2.0.so.0+0x7243b) #3 0xffff91413e6f in g_strsplit (/lib64/libglib-2.0.so.0+0x73e6f) #4 0xaaab42fb58e7 in configure_accelerators /qemu/vl.c:2777 #5 0xaaab42fb58e7 in main /qemu/vl.c:4121 #6 0xffff8f9b0b9f in __libc_start_main (/lib64/libc.so.6+0x20b9f) #7 0xaaab42fc1dab (/qemu/build/aarch64-softmmu/qemu-system-aarch64+0x8b1dab) Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200108114207.58084-1-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/vl.c b/vl.c index 86474a55c9ef..035a24e52b24 100644 --- a/vl.c +++ b/vl.c @@ -2788,6 +2788,7 @@ static void configure_accelerators(const char *progname) error_report("invalid accelerator %s", *tmp); } } + g_strfreev(accel_list); } else { if (accel != NULL) { error_report("The -accel and \"-machine accel=\" options are incompatible");